From: kernel test robot <lkp@intel.com>
To: jeffxu@chromium.org, skhan@linuxfoundation.org, keescook@chromium.org
Cc: oe-kbuild-all@lists.linux.dev, akpm@linux-foundation.org,
dmitry.torokhov@gmail.com, dverkamp@chromium.org,
asmadeus@codewreck.org, hughd@google.com, jeffxu@google.com,
jorgelo@chromium.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-mm@kvack.org,
jannh@google.com, linux-hardening@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH v1 1/2] mm/memfd: sysctl: fix MEMFD_NOEXEC_SCOPE_NOEXEC_ENFORCED
Date: Fri, 30 Jun 2023 13:32:17 +0800 [thread overview]
Message-ID: <202306301351.kkbSegQW-lkp@intel.com> (raw)
In-Reply-To: <20230630031721.623955-2-jeffxu@google.com>
Hi,
kernel test robot noticed the following build errors:
[auto build test ERROR on akpm-mm/mm-everything]
url: https://github.com/intel-lab-lkp/linux/commits/jeffxu-chromium-org/mm-memfd-sysctl-fix-MEMFD_NOEXEC_SCOPE_NOEXEC_ENFORCED/20230630-111827
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20230630031721.623955-2-jeffxu%40google.com
patch subject: [PATCH v1 1/2] mm/memfd: sysctl: fix MEMFD_NOEXEC_SCOPE_NOEXEC_ENFORCED
config: microblaze-randconfig-r003-20230630 (https://download.01.org/0day-ci/archive/20230630/202306301351.kkbSegQW-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230630/202306301351.kkbSegQW-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306301351.kkbSegQW-lkp@intel.com/
All errors (new ones prefixed by >>):
mm/memfd.c: In function 'sysctl_memfd_noexec':
>> mm/memfd.c:273:22: error: 'MEMFD_NOEXEC_SCOPE_EXEC' undeclared (first use in this function)
273 | int sysctl = MEMFD_NOEXEC_SCOPE_EXEC;
| ^~~~~~~~~~~~~~~~~~~~~~~
mm/memfd.c:273:22: note: each undeclared identifier is reported only once for each function it appears in
mm/memfd.c: In function '__do_sys_memfd_create':
>> mm/memfd.c:311:31: error: 'MEMFD_NOEXEC_SCOPE_NOEXEC_SEAL' undeclared (first use in this function)
311 | if (sysctl == MEMFD_NOEXEC_SCOPE_NOEXEC_SEAL)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> mm/memfd.c:321:43: error: 'MEMFD_NOEXEC_SCOPE_NOEXEC_ENFORCED' undeclared (first use in this function)
321 | if (flags & MFD_EXEC && sysctl >= MEMFD_NOEXEC_SCOPE_NOEXEC_ENFORCED) {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/MEMFD_NOEXEC_SCOPE_EXEC +273 mm/memfd.c
270
271 static int sysctl_memfd_noexec(void)
272 {
> 273 int sysctl = MEMFD_NOEXEC_SCOPE_EXEC;
274 #ifdef CONFIG_SYSCTL
275 struct pid_namespace *ns;
276
277 ns = task_active_pid_ns(current);
278 if (ns)
279 sysctl = ns->memfd_noexec_scope;
280 #endif
281 return sysctl;
282 }
283
284 SYSCALL_DEFINE2(memfd_create,
285 const char __user *, uname,
286 unsigned int, flags)
287 {
288 char comm[TASK_COMM_LEN];
289 unsigned int *file_seals;
290 struct file *file;
291 int fd, error;
292 char *name;
293 long len;
294 int sysctl = sysctl_memfd_noexec();
295
296 if (!(flags & MFD_HUGETLB)) {
297 if (flags & ~(unsigned int)MFD_ALL_FLAGS)
298 return -EINVAL;
299 } else {
300 /* Allow huge page size encoding in flags. */
301 if (flags & ~(unsigned int)(MFD_ALL_FLAGS |
302 (MFD_HUGE_MASK << MFD_HUGE_SHIFT)))
303 return -EINVAL;
304 }
305
306 /* Invalid if both EXEC and NOEXEC_SEAL are set.*/
307 if ((flags & MFD_EXEC) && (flags & MFD_NOEXEC_SEAL))
308 return -EINVAL;
309
310 if (!(flags & (MFD_EXEC | MFD_NOEXEC_SEAL))) {
> 311 if (sysctl == MEMFD_NOEXEC_SCOPE_NOEXEC_SEAL)
312 flags |= MFD_NOEXEC_SEAL;
313 else
314 flags |= MFD_EXEC;
315
316 pr_warn_once(
317 "memfd_create() without MFD_EXEC nor MFD_NOEXEC_SEAL, pid=%d '%s'\n",
318 task_pid_nr(current), get_task_comm(comm, current));
319 }
320
> 321 if (flags & MFD_EXEC && sysctl >= MEMFD_NOEXEC_SCOPE_NOEXEC_ENFORCED) {
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-06-30 5:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 3:17 [PATCH v1 0/2] mm/memfd: fix sysctl MEMFD_NOEXEC_SCOPE_NOEXEC_ENFORCED jeffxu
2023-06-30 3:17 ` [PATCH v1 1/2] mm/memfd: sysctl: fix MEMFD_NOEXEC_SCOPE_NOEXEC_ENFORCED jeffxu
2023-06-30 5:32 ` kernel test robot [this message]
2023-06-30 6:33 ` kernel test robot
2023-06-30 6:44 ` kernel test robot
2023-06-30 3:17 ` [PATCH v1 2/2] selftests/memfd: " jeffxu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202306301351.kkbSegQW-lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=asmadeus@codewreck.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dverkamp@chromium.org \
--cc=hughd@google.com \
--cc=jannh@google.com \
--cc=jeffxu@chromium.org \
--cc=jeffxu@google.com \
--cc=jorgelo@chromium.org \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-security-module@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.