From: Rob Herring <robh@kernel.org>
To: Astrid Rost <astrid.rost@axis.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
kernel@axis.com, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: leds: Read max-brightness from devicetree
Date: Fri, 30 Jun 2023 10:49:28 -0600 [thread overview]
Message-ID: <20230630164928.GA1884613-robh@kernel.org> (raw)
In-Reply-To: <20230630092248.4146169-3-astrid.rost@axis.com>
On Fri, Jun 30, 2023 at 11:22:47AM +0200, Astrid Rost wrote:
> Add max-brightness in order to reduce the current on the connected LEDs.
> Normally, the maximum brightness is determined by the hardware, and this
> property is not required. This property is used to set a software limit.
> It could happen that an LED is made so bright that it gets damaged or
> causes damage due to restrictions in a specific system, such as mounting
> conditions. Note that led-max-microamp should be preferably used, if it
> is supported by the controller.
>
> Signed-off-by: Astrid Rost <astrid.rost@axis.com>
> ---
> Documentation/devicetree/bindings/leds/common.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
The patch order is wrong. You have to define a property before you can
use it. Otherwise,
Reviewed-by: Rob Herring <robh@kernel.org>
prev parent reply other threads:[~2023-06-30 16:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230630092248.4146169-1-astrid.rost@axis.com>
2023-06-30 9:22 ` [PATCH v2 1/2] led: led-class: Read max-brightness from devicetree Astrid Rost
2023-06-30 17:59 ` Andy Shevchenko
2023-07-01 11:09 ` Jacek Anaszewski
2023-07-03 7:53 ` Astrid Rost
2023-07-03 9:32 ` Jacek Anaszewski
2023-06-30 9:22 ` [PATCH v2 2/2] dt-bindings: leds: " Astrid Rost
2023-06-30 16:49 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230630164928.GA1884613-robh@kernel.org \
--to=robh@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=astrid.rost@axis.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=kernel@axis.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.