From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0AE90EB64DD for ; Fri, 30 Jun 2023 21:30:28 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qFLgD-0005j5-5u; Fri, 30 Jun 2023 17:29:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFLg3-0005ik-Ub for qemu-devel@nongnu.org; Fri, 30 Jun 2023 17:29:17 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qFLfx-0002gD-79 for qemu-devel@nongnu.org; Fri, 30 Jun 2023 17:29:10 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2F3EB1F88D; Fri, 30 Jun 2023 21:29:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1688160547; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=kLBSNHDYBW8LdY5QM264/5GExux6FF4huRtxjK7NpcI=; b=bxTfjAqNbEIJURH4LKJfJ7LrjJnaIAlYLcVpLOvv4tA4Izl48MuYm/JbdkRQQXHlTlmG5N LZBSLZy4Sybc5WwXAanxX8zZ6NOKpdFFD1QNrvyLios4zJSvTzXUhI3Kz8860T4E4npwZ9 wQXssPA8zjgpq1IWdx2eahZdnlIoi68= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1688160547; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=kLBSNHDYBW8LdY5QM264/5GExux6FF4huRtxjK7NpcI=; b=GX8/EDx6LZn9OH3p+kY3QNdlLlkzfdaP7XmbIwl2Zahre2Lo3Kas6u4ngTQOh7y2DXY5i5 GYvhuouCltg6HZCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 868E613915; Fri, 30 Jun 2023 21:29:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2UowFCFJn2TRKAAAMHmgww (envelope-from ); Fri, 30 Jun 2023 21:29:05 +0000 From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Juan Quintela , Peter Xu , Steve Sistare , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= Subject: [PATCH v3 0/6] migration: Test the new "file:" migration Date: Fri, 30 Jun 2023 18:28:56 -0300 Message-Id: <20230630212902.19925-1-farosas@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=195.135.220.29; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Based-on: [PATCH V4 0/2] migration file URI https://lore.kernel.org/r/1688135108-316997-1-git-send-email-steven.sistare@oracle.com Since v2: - removed the extra setup event. Libvirt has been enabling events for a long time, it should be safe - fixed small issues pointed out by Peter (leaking memory, mmap args) - stopped looking at the error string in the QMP error test - skipped the check for zeroes on non-linux platforms CI run: https://gitlab.com/farosas/qemu/-/pipelines/917665246 v2: https://lore.kernel.org/r/20230628165542.17214-1-farosas@suse.de - added the force-emit-setup-event property - added verification that the skipped region is empty CI run: https://gitlab.com/farosas/qemu/-/pipelines/914915941 v1: https://lore.kernel.org/r/20230626182210.8792-1-farosas@suse.de Here's the test for the file: migration. I hit an issue with the setting of migration status. If we call query-migrate too soon after migrate-incoming, the query returns an empty response because we're not setting the MIGRATION_STATUS_SETUP in the incoming path. We just send the event, but never actually change state. Aside from the fix, there's some tidying up to avoid duplicating too much code in the tests. Thanks CI run: https://gitlab.com/farosas/qemu/-/pipelines/912226554 Fabiano Rosas (6): tests/qtest: migration: Expose migrate_set_capability tests/qtest: migration: Add migrate_incoming_qmp helper tests/qtest: migration: Use migrate_incoming_qmp where appropriate migration: Set migration status early in incoming side tests/qtest: migration: Add support for negative testing of qmp_migrate tests/qtest: migration-test: Add tests for file-based migration migration/migration.c | 7 +- tests/qtest/libqtest.c | 33 +++++++ tests/qtest/libqtest.h | 28 ++++++ tests/qtest/meson.build | 1 + tests/qtest/migration-helpers.c | 60 +++++++++++++ tests/qtest/migration-helpers.h | 10 +++ tests/qtest/migration-test.c | 138 +++++++++++++++++++++++++----- tests/qtest/virtio-net-failover.c | 77 ++--------------- 8 files changed, 261 insertions(+), 93 deletions(-) -- 2.35.3