From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH net-next 1/6] net: dsa: vsc73xx: convert to PHYLINK
Date: Fri, 30 Jun 2023 22:19:04 +0800 [thread overview]
Message-ID: <202306302257.DWKHSgvF-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20230621191302.1405623-1-paweldembicki@gmail.com>
References: <20230621191302.1405623-1-paweldembicki@gmail.com>
TO: Pawel Dembicki <paweldembicki@gmail.com>
TO: netdev@vger.kernel.org
CC: linus.walleij@linaro.org
CC: Pawel Dembicki <paweldembicki@gmail.com>
CC: Andrew Lunn <andrew@lunn.ch>
CC: Florian Fainelli <f.fainelli@gmail.com>
CC: Vladimir Oltean <olteanv@gmail.com>
CC: Eric Dumazet <edumazet@google.com>
CC: Jakub Kicinski <kuba@kernel.org>
CC: Paolo Abeni <pabeni@redhat.com>
CC: Russell King <linux@armlinux.org.uk>
CC: linux-kernel@vger.kernel.org
Hi Pawel,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Pawel-Dembicki/net-dsa-vsc73xx-add-port_stp_state_set-function/20230622-031529
base: net-next/main
patch link: https://lore.kernel.org/r/20230621191302.1405623-1-paweldembicki%40gmail.com
patch subject: [PATCH net-next 1/6] net: dsa: vsc73xx: convert to PHYLINK
:::::: branch date: 9 days ago
:::::: commit date: 9 days ago
config: parisc-randconfig-m041-20230629 (https://download.01.org/0day-ci/archive/20230630/202306302257.DWKHSgvF-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230630/202306302257.DWKHSgvF-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202306302257.DWKHSgvF-lkp@intel.com/
smatch warnings:
drivers/net/dsa/vitesse-vsc73xx-core.c:891 vsc73xx_phylink_mac_link_up() error: uninitialized symbol 'val'.
vim +/val +891 drivers/net/dsa/vitesse-vsc73xx-core.c
05bd97fc559df4 drivers/net/dsa/vitesse-vsc73xx.c Linus Walleij 2018-06-30 860
33f498e941bbd8 drivers/net/dsa/vitesse-vsc73xx-core.c Pawel Dembicki 2023-06-21 861 static void vsc73xx_phylink_mac_link_up(struct dsa_switch *ds, int port,
33f498e941bbd8 drivers/net/dsa/vitesse-vsc73xx-core.c Pawel Dembicki 2023-06-21 862 unsigned int mode,
33f498e941bbd8 drivers/net/dsa/vitesse-vsc73xx-core.c Pawel Dembicki 2023-06-21 863 phy_interface_t interface,
33f498e941bbd8 drivers/net/dsa/vitesse-vsc73xx-core.c Pawel Dembicki 2023-06-21 864 struct phy_device *phydev,
33f498e941bbd8 drivers/net/dsa/vitesse-vsc73xx-core.c Pawel Dembicki 2023-06-21 865 int speed, int duplex,
33f498e941bbd8 drivers/net/dsa/vitesse-vsc73xx-core.c Pawel Dembicki 2023-06-21 866 bool tx_pause, bool rx_pause)
33f498e941bbd8 drivers/net/dsa/vitesse-vsc73xx-core.c Pawel Dembicki 2023-06-21 867 {
33f498e941bbd8 drivers/net/dsa/vitesse-vsc73xx-core.c Pawel Dembicki 2023-06-21 868 struct vsc73xx *vsc = ds->priv;
33f498e941bbd8 drivers/net/dsa/vitesse-vsc73xx-core.c Pawel Dembicki 2023-06-21 869 u32 val;
05bd97fc559df4 drivers/net/dsa/vitesse-vsc73xx.c Linus Walleij 2018-06-30 870
33f498e941bbd8 drivers/net/dsa/vitesse-vsc73xx-core.c Pawel Dembicki 2023-06-21 871 switch (speed) {
33f498e941bbd8 drivers/net/dsa/vitesse-vsc73xx-core.c Pawel Dembicki 2023-06-21 872 case SPEED_1000:
05bd97fc559df4 drivers/net/dsa/vitesse-vsc73xx.c Linus Walleij 2018-06-30 873 /* Set up default for internal port or external RGMII */
33f498e941bbd8 drivers/net/dsa/vitesse-vsc73xx-core.c Pawel Dembicki 2023-06-21 874 if (interface == PHY_INTERFACE_MODE_RGMII)
05bd97fc559df4 drivers/net/dsa/vitesse-vsc73xx.c Linus Walleij 2018-06-30 875 val = VSC73XX_MAC_CFG_1000M_F_RGMII;
05bd97fc559df4 drivers/net/dsa/vitesse-vsc73xx.c Linus Walleij 2018-06-30 876 else
05bd97fc559df4 drivers/net/dsa/vitesse-vsc73xx.c Linus Walleij 2018-06-30 877 val = VSC73XX_MAC_CFG_1000M_F_PHY;
33f498e941bbd8 drivers/net/dsa/vitesse-vsc73xx-core.c Pawel Dembicki 2023-06-21 878 break;
33f498e941bbd8 drivers/net/dsa/vitesse-vsc73xx-core.c Pawel Dembicki 2023-06-21 879 case SPEED_100:
33f498e941bbd8 drivers/net/dsa/vitesse-vsc73xx-core.c Pawel Dembicki 2023-06-21 880 case SPEED_10:
33f498e941bbd8 drivers/net/dsa/vitesse-vsc73xx-core.c Pawel Dembicki 2023-06-21 881 if (duplex == DUPLEX_FULL)
05bd97fc559df4 drivers/net/dsa/vitesse-vsc73xx.c Linus Walleij 2018-06-30 882 val = VSC73XX_MAC_CFG_100_10M_F_PHY;
33f498e941bbd8 drivers/net/dsa/vitesse-vsc73xx-core.c Pawel Dembicki 2023-06-21 883 else
05bd97fc559df4 drivers/net/dsa/vitesse-vsc73xx.c Linus Walleij 2018-06-30 884 val = VSC73XX_MAC_CFG_100_10M_H_PHY;
33f498e941bbd8 drivers/net/dsa/vitesse-vsc73xx-core.c Pawel Dembicki 2023-06-21 885 break;
05bd97fc559df4 drivers/net/dsa/vitesse-vsc73xx.c Linus Walleij 2018-06-30 886 }
05bd97fc559df4 drivers/net/dsa/vitesse-vsc73xx.c Linus Walleij 2018-06-30 887
05bd97fc559df4 drivers/net/dsa/vitesse-vsc73xx.c Linus Walleij 2018-06-30 888 /* Enable port (forwarding) in the receieve mask */
05bd97fc559df4 drivers/net/dsa/vitesse-vsc73xx.c Linus Walleij 2018-06-30 889 vsc73xx_update_bits(vsc, VSC73XX_BLOCK_ANALYZER, 0,
05bd97fc559df4 drivers/net/dsa/vitesse-vsc73xx.c Linus Walleij 2018-06-30 890 VSC73XX_RECVMASK, BIT(port), BIT(port));
33f498e941bbd8 drivers/net/dsa/vitesse-vsc73xx-core.c Pawel Dembicki 2023-06-21 @891 vsc73xx_adjust_enable_port(vsc, port, val);
05bd97fc559df4 drivers/net/dsa/vitesse-vsc73xx.c Linus Walleij 2018-06-30 892 }
05bd97fc559df4 drivers/net/dsa/vitesse-vsc73xx.c Linus Walleij 2018-06-30 893
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2023-06-30 14:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 14:19 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-06-21 19:12 [PATCH net-next 1/6] net: dsa: vsc73xx: convert to PHYLINK Pawel Dembicki
2023-06-21 21:21 ` Linus Walleij
2023-06-22 7:34 ` Simon Horman
2023-06-22 11:55 ` Russell King (Oracle)
2023-06-24 4:02 ` Paweł Dembicki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202306302257.DWKHSgvF-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.