All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Konstantin Menyaev via buildroot <buildroot@buildroot.org>
Cc: KAMenyaev@sberdevices.ru, sdfw_system_team@sberdevices.ru
Subject: Re: [Buildroot] [PATCH 1/1] package/dnsmasq: provide pidfile along with -x flag
Date: Sat, 1 Jul 2023 22:44:15 +0200	[thread overview]
Message-ID: <20230701224415.31c0c417@windsurf> (raw)
In-Reply-To: <20230616012324.75426-1-KAMenyaev@sberdevices.ru>

Hello Konstantin,

Thanks for your contribution. See below for some feedback.

On Fri, 16 Jun 2023 04:23:24 +0300
Konstantin Menyaev via buildroot <buildroot@buildroot.org> wrote:

> From: Konstantin Menyaev <KAMenyaev@sberdevices.ru>
> 
> Use pidfile for more accurate process match.
> Useful in multiple process instances.
> 
> Signed-off-by: Konstantin Menyaev <KAMenyaev@sberdevices.ru>
> ---
>  package/dnsmasq/S80dnsmasq | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/package/dnsmasq/S80dnsmasq b/package/dnsmasq/S80dnsmasq
> index b052259e87..b2cd56adef 100644
> --- a/package/dnsmasq/S80dnsmasq
> +++ b/package/dnsmasq/S80dnsmasq
> @@ -1,16 +1,21 @@
>  #!/bin/sh
>  
> +NAME="dnsmasq"
> +DAEMON="/usr/sbin/$NAME"
> +PIDFILE="/var/run/$NAME.pid"

This is not correct, as it doesn't match the coding style documented at
https://nightly.buildroot.org/#adding-packages-start-script. I've
therefore changed this to match the expected coding style, which
allowed to drop the ignored check-package warning from
.checkpackageignore about "Variables".

See the final commit at:

  https://gitlab.com/buildroot.org/buildroot/-/commit/0c4c7da2f33cd701f614709e85a097a8751d81a4

I hope I didn't mess up the script while doing this.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2023-07-01 20:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-16  1:23 [Buildroot] [PATCH 1/1] package/dnsmasq: provide pidfile along with -x flag Konstantin Menyaev via buildroot
2023-07-01 20:44 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230701224415.31c0c417@windsurf \
    --to=buildroot@buildroot.org \
    --cc=KAMenyaev@sberdevices.ru \
    --cc=sdfw_system_team@sberdevices.ru \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.