All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: stable@vger.kernel.org
Subject: Re: Fix regression on Stoney
Date: Sun, 2 Jul 2023 15:41:57 +0200	[thread overview]
Message-ID: <2023070229-slinky-explore-187e@gregkh> (raw)
In-Reply-To: <9ef5921a-2382-b006-75fe-1613ac727dc7@amd.com>

On Sun, Jul 02, 2023 at 08:12:15AM -0500, Mario Limonciello wrote:
> Hi,
> 
> A regression [1] was reported on suspend for AMD Stoney on 6.3.10.
> It bisected down to:
> 
> 1ca399f127e0 ("drm/amd/display: Add wrapper to call planes and stream
> update")
> 
> This was requested by me to fix a PSR problem [2], which isn't used on
> Stoney.
> 
> This was also backported into 6.1.36 (as e538342002cb) and 5.15.119 (as
> 3c1aa91b37f9).
> 
> It's fixed on 6.3.y by cherry-picking:
> 
> 32953485c558 ("drm/amd/display: Do not update DRR while BW optimizations
> pending")
> 
> It's fixed in 6.1.y by cherry-picking:
> 
> 3442f4e0e555 ("drm/amd/display: Remove optimization for VRR updates")
> 32953485c558 ("drm/amd/display: Do not update DRR while BW optimizations
> pending")

All now queued up, thanks.

> On 5.15.y it's not a reasonable backport to take the fix to stable because
> there is a lot of missing Freesync code.  Instead it's better to revert the
> patch series that introduced it to 5.15.y because PSR-SU isn't even
> introduced until later kernels anyway.
> 
> 5a24be76af79 ("drm/amd/display: fix the system hang while disable PSR")
> 3c1aa91b37f9 ("drm/amd/display: Add wrapper to call planes and stream
> update")
> eea850c025b5 ("drm/amd/display: Use dc_update_planes_and_stream")
> 97ca308925a5 ("drm/amd/display: Add minimal pipe split transition state")

Can you please send these reverts with the discussion as to why they are
requried?

thanks,

greg k-h

      reply	other threads:[~2023-07-02 13:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-02 13:12 Fix regression on Stoney Mario Limonciello
2023-07-02 13:41 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023070229-slinky-explore-187e@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=mario.limonciello@amd.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.