From: Mauro Carvalho Chehab <mchehab@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Hans Verkuil" <hverkuil-cisco@xs4all.nl>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Mark Brown" <broonie@kernel.org>,
"David Lin" <CTLIN0@nuvoton.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org, "Antti Palosaari" <crope@iki.fi>,
"Sergey Kozlov" <serjk@netup.ru>,
"Abylay Ospan" <aospan@netup.ru>,
"Yasunari Takiguchi" <Yasunari.Takiguchi@sony.com>,
"Michael Krufky" <mkrufky@linuxtv.org>,
"Matthias Schwarzott" <zzam@gentoo.org>,
"Akihiro Tsukada" <tskd08@gmail.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>
Subject: Re: [PATCH v1 0/4] ASoC: remove copy of intlog10()
Date: Mon, 3 Jul 2023 08:18:16 +0200 [thread overview]
Message-ID: <20230703081816.37028ab7@sal.lan> (raw)
In-Reply-To: <20230619172019.21457-1-andriy.shevchenko@linux.intel.com>
Em Mon, 19 Jun 2023 20:20:15 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> escreveu:
> The first three patches moves intlog10() to be available in entire
> kernel. The last one removes copy of it in one driver. Besides already
> good Lines of Code (LoC) statistics the upcoming users, if any, can
> utilize the exported functions.
>
> The series can be routed either via ASoC tree or media tree.
>
> Note, int_log.h is separated from math.h due to licensing.
> I dunno if we can mix two in a single header file. In any
> case we may do it later on.
>
> Andy Shevchenko (4):
> lib/math: Move dvb_math.c into lib/math/int_log.c
> lib/math/int_log: Use ARRAY_SIZE(logtable) where makes sense
> lib/math/int_log: Replace LGPL-2.1-or-later boilerplate with SPDX
> identifier
> ASoC: nau8825: Replace copied'n'pasted intlog10()
It probably makes sense to apply it at ASoC tree, as the relevant
change is there.
I have just one small nit on patch 1/4, which should be trivial to
solve. Once done, feel free to merge it with my ack:
Acked-by: Mauro Carvalho Chehab <mchehab@kernel.org>
>
> Documentation/driver-api/media/dtv-common.rst | 2 +-
> drivers/media/dvb-core/Makefile | 2 +-
> drivers/media/dvb-frontends/af9013_priv.h | 2 +-
> drivers/media/dvb-frontends/af9033_priv.h | 2 +-
> drivers/media/dvb-frontends/cxd2820r_priv.h | 2 +-
> drivers/media/dvb-frontends/cxd2841er.c | 2 +-
> .../cxd2880/cxd2880_tnrdmd_dvbt2_mon.c | 2 +-
> .../cxd2880/cxd2880_tnrdmd_dvbt_mon.c | 2 +-
> .../media/dvb-frontends/cxd2880/cxd2880_top.c | 2 +-
> drivers/media/dvb-frontends/dib7000p.c | 2 +-
> drivers/media/dvb-frontends/dib8000.c | 2 +-
> drivers/media/dvb-frontends/dib9000.c | 2 +-
> drivers/media/dvb-frontends/drxk_hard.c | 2 +-
> drivers/media/dvb-frontends/lgdt3305.c | 2 +-
> drivers/media/dvb-frontends/lgdt3306a.c | 2 +-
> drivers/media/dvb-frontends/lgdt330x.c | 2 +-
> drivers/media/dvb-frontends/m88ds3103_priv.h | 2 +-
> drivers/media/dvb-frontends/mn88443x.c | 2 +-
> drivers/media/dvb-frontends/mn88472_priv.h | 2 +-
> drivers/media/dvb-frontends/mn88473_priv.h | 2 +-
> drivers/media/dvb-frontends/or51132.c | 2 +-
> drivers/media/dvb-frontends/or51211.c | 2 +-
> drivers/media/dvb-frontends/rtl2830_priv.h | 2 +-
> drivers/media/dvb-frontends/rtl2832_priv.h | 2 +-
> drivers/media/dvb-frontends/si2165.c | 2 +-
> drivers/media/dvb-frontends/stv0367.c | 2 +-
> drivers/media/dvb-frontends/tc90522.c | 2 +-
> drivers/media/dvb-frontends/tda10048.c | 2 +-
> include/{media/dvb_math.h => linux/int_log.h} | 18 +---
> lib/math/Makefile | 2 +-
> .../dvb-core/dvb_math.c => lib/math/int_log.c | 26 ++----
> sound/soc/codecs/nau8825.c | 93 +------------------
> 32 files changed, 45 insertions(+), 150 deletions(-)
> rename include/{media/dvb_math.h => linux/int_log.h} (63%)
> rename drivers/media/dvb-core/dvb_math.c => lib/math/int_log.c (84%)
>
prev parent reply other threads:[~2023-07-03 6:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 17:20 [PATCH v1 0/4] ASoC: remove copy of intlog10() Andy Shevchenko
2023-06-19 17:20 ` [PATCH v1 1/4] lib/math: Move dvb_math.c into lib/math/int_log.c Andy Shevchenko
2023-07-03 6:14 ` Mauro Carvalho Chehab
2023-06-19 17:20 ` [PATCH v1 2/4] lib/math/int_log: Use ARRAY_SIZE(logtable) where makes sense Andy Shevchenko
2023-07-03 6:15 ` Mauro Carvalho Chehab
2023-06-19 17:20 ` [PATCH v1 3/4] lib/math/int_log: Replace LGPL-2.1-or-later boilerplate with SPDX identifier Andy Shevchenko
2023-07-03 6:16 ` Mauro Carvalho Chehab
2023-06-19 17:20 ` [PATCH v1 4/4] ASoC: nau8825: Replace copied'n'pasted intlog10() Andy Shevchenko
2023-06-19 17:43 ` Mark Brown
2023-07-03 6:18 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230703081816.37028ab7@sal.lan \
--to=mchehab@kernel.org \
--cc=CTLIN0@nuvoton.com \
--cc=Yasunari.Takiguchi@sony.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=aospan@netup.ru \
--cc=broonie@kernel.org \
--cc=crope@iki.fi \
--cc=hverkuil-cisco@xs4all.nl \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mkrufky@linuxtv.org \
--cc=perex@perex.cz \
--cc=serjk@netup.ru \
--cc=tiwai@suse.com \
--cc=tskd08@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=zzam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.