From: Jakub Kicinski <kuba@kernel.org>
To: Liang Chen <liangchen.linux@gmail.com>
Cc: ilias.apalodimas@linaro.org, hawk@kernel.org,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
linyunsheng@huawei.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] skbuff: Optimize SKB coalescing for page pool case
Date: Mon, 3 Jul 2023 11:53:26 -0700 [thread overview]
Message-ID: <20230703115326.69f8953b@kernel.org> (raw)
In-Reply-To: <CAKhg4t+hoOiVWMbBiD7HCu_Z5pSdCsZrev2FMEKhbWvzgHCarw@mail.gmail.com>
On Mon, 3 Jul 2023 17:12:46 +0800 Liang Chen wrote:
> As for the "pp" reference, it has the test
> page_pool_is_pp_page_frag(head_page) there. So for a non-frag pp page,
> it will be a get_page call.
You don't understand - you can't put a page from a page pool in two
skbs with pp_recycle set, unless the page is frag'ed.
next prev parent reply other threads:[~2023-07-03 18:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 12:11 [PATCH net-next] skbuff: Optimize SKB coalescing for page pool case Liang Chen
2023-06-29 6:53 ` Yunsheng Lin
2023-06-29 12:17 ` Liang Chen
2023-06-29 12:19 ` Liang Chen
2023-06-30 11:52 ` Yunsheng Lin
2023-07-03 9:09 ` Liang Chen
2023-06-30 23:07 ` Jakub Kicinski
2023-07-03 9:12 ` Liang Chen
2023-07-03 18:53 ` Jakub Kicinski [this message]
2023-07-04 0:50 ` Yunsheng Lin
2023-07-04 4:54 ` Liang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230703115326.69f8953b@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=liangchen.linux@gmail.com \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.