From: Leon Romanovsky <leon@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org,
Selvin Xavier <selvin.xavier@broadcom.com>,
Jason Gunthorpe <jgg@nvidia.com>,
linux-rdma@vger.kernel.org,
Devesh Sharma <devesh.sharma@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>,
Doug Ledford <dledford@redhat.com>
Subject: Re: [PATCH] RDMA/bnxt_re: fix verbs undefined build errors
Date: Mon, 3 Jul 2023 16:28:14 +0300 [thread overview]
Message-ID: <20230703132814.GA32152@unreal> (raw)
In-Reply-To: <20230701003059.23064-1-rdunlap@infradead.org>
On Fri, Jun 30, 2023 at 05:30:59PM -0700, Randy Dunlap wrote:
> When INFINIBAND_USER_ACCESS is not set, the bnxt_re driver has
> build errors:
>
> ERROR: modpost: "uverbs_idr_class" [drivers/infiniband/hw/bnxt_re/bnxt_re.ko] undefined!
> ERROR: modpost: "ib_uverbs_get_ucontext_file" [drivers/infiniband/hw/bnxt_re/bnxt_re.ko] undefined!
> ERROR: modpost: "uverbs_destroy_def_handler" [drivers/infiniband/hw/bnxt_re/bnxt_re.ko] undefined!
>
> Handle this case by making the driver depend on INFINIBAND_USER_ACCESS.
>
> Fixes: 592e8b3226a2 ("RDMA/bnxt_re: Add bnxt_re driver build support")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Selvin Xavier <selvin.xavier@broadcom.com>
> Cc: Jason Gunthorpe <jgg@nvidia.com>
> Cc: Leon Romanovsky <leonro@nvidia.com>
> Cc: linux-rdma@vger.kernel.org
> Cc: Devesh Sharma <devesh.sharma@broadcom.com>
> Cc: Somnath Kotur <somnath.kotur@broadcom.com>
> Cc: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
> Cc: Doug Ledford <dledford@redhat.com>
> ---
> drivers/infiniband/hw/bnxt_re/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
I liked this variant [1] more as bnxt_re driver can theoretically work
without INFINIBAND_USER_ACCESS too.
[1] https://lore.kernel.org/all/20230703113025.356682-1-arnd@kernel.org
Thanks
prev parent reply other threads:[~2023-07-03 13:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-01 0:30 [PATCH] RDMA/bnxt_re: fix verbs undefined build errors Randy Dunlap
2023-07-03 13:28 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230703132814.GA32152@unreal \
--to=leon@kernel.org \
--cc=devesh.sharma@broadcom.com \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=selvin.xavier@broadcom.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.