From: Juerg Haefliger <juerg.haefliger@canonical.com>
To: Josh Boyer <jwboyer@kernel.org>
Cc: hildawu@realtek.com, linux-firmware@kernel.org,
Larry.Finger@lwfinger.net, max.chou@realtek.com,
alex_lu@realsil.com.cn, mu_hua_chen@realtek.com,
hsinyu_chang@realtek.com, kidman@realtek.com
Subject: Re: [PATCH] rtl_bt: Update RTL8852C BT USB firmware to 0x040D_7225
Date: Mon, 3 Jul 2023 13:48:24 +0200 [thread overview]
Message-ID: <20230703134824.7795b277@smeagol> (raw)
In-Reply-To: <CA+5PVA7k+NHHb9LqEw04nfBA4mJ5O=XrNqh86cHbDSeUzW87NA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1295 bytes --]
Josh,
> Applied and pushed out.
>
> josh
>
> On Wed, Jun 7, 2023 at 4:28 AM <hildawu@realtek.com> wrote:
> >
> > From: Hilda Wu <hildawu@realtek.com>
> >
> > This firmware patch update for Realtek RTL8852C BT USB controller
> >
> > Note: This firmware patch needs to be used with driver
> > "btrtl: Firmware format v2 support". Please update the
> > driver with this commit: 9a24ce5e29b15c4c6b0c89c04f9df6ce14addefa
Do I understand this correctly that kernels that don't have this patch (any
kernel < 6.4) can no longer load this v2 BT firmware because it's not
compatible with old drivers? That's a regression, no? The incompatible new
firmware should be named differently so that we don't break old kernels.
The v2 driver [1] seems to support both the old and new firmware binary so IMO
should try to load the new firmware first and fall back to the old one if not
found.
Unless I'm misreading this.
...Juerg
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9a24ce5e29b15c4c6b0c89c04f9df6ce14addefa
> > Release Version: 0x040D_7225
> >
> > Signed-off-by: Hilda Wu <hildawu@realtek.com>
> > ---
> > rtl_bt/rtl8852cu_fw.bin | Bin 113336 -> 112953 bytes
> > 1 file changed, 0 insertions(+), 0 deletions(-)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-07-03 11:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 8:27 [PATCH] rtl_bt: Update RTL8852C BT USB firmware to 0x040D_7225 hildawu
2023-06-12 11:08 ` Josh Boyer
2023-07-03 11:48 ` Juerg Haefliger [this message]
2023-08-03 4:49 ` Juerg Haefliger
2023-08-04 6:03 ` Max Chou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230703134824.7795b277@smeagol \
--to=juerg.haefliger@canonical.com \
--cc=Larry.Finger@lwfinger.net \
--cc=alex_lu@realsil.com.cn \
--cc=hildawu@realtek.com \
--cc=hsinyu_chang@realtek.com \
--cc=jwboyer@kernel.org \
--cc=kidman@realtek.com \
--cc=linux-firmware@kernel.org \
--cc=max.chou@realtek.com \
--cc=mu_hua_chen@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.