From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Arnout Vandecappelle <arnout@mind.be>
Cc: Romain Naour <romain.naour@smile.fr>,
James Hilliard <james.hilliard1@gmail.com>,
Arnout Vandecappelle via buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [git commit] package/python-setuptools: add missing dependency on host-python-wheel
Date: Mon, 3 Jul 2023 20:56:31 +0200 [thread overview]
Message-ID: <20230703205631.4dd121b0@windsurf> (raw)
In-Reply-To: <20230703182930.B08CA863E5@busybox.osuosl.org>
On Mon, 3 Jul 2023 20:20:31 +0200
Arnout Vandecappelle via buildroot <buildroot@buildroot.org> wrote:
> commit: https://git.buildroot.net/buildroot/commit/?id=3b2913552ee4e304d4d86e577b237652a8f0a99f
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>
> While migrating to pep517 build backend the host-python-wheel
> dependency has been added to host-python-setuptools but
> not to python-setuptools. Note that host-python-wheel is not really
> needed during the build of (target) setuptools, but the setup.py script
> checks if the dependency is present in the host directory.
>
> To make everything consistent, add host-python-wheel as a build
> dependency, and BR2_PACKAGE_PYTHON_WHEEL as a runtime dependency.
Hu, this was not in the patch from Romain I believe.
> + select BR2_PACKAGE_PYTHON_WHEEL # runtime
This is not correct, there is no such symbol in Buildroot, and it
causes a check-symbol error:
https://gitlab.com/buildroot.org/buildroot/-/jobs/4586144848
What was the motivation behind this additional select?
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-07-03 18:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 18:20 [Buildroot] [git commit] package/python-setuptools: add missing dependency on host-python-wheel Arnout Vandecappelle via buildroot
2023-07-03 18:56 ` Thomas Petazzoni via buildroot [this message]
2023-07-03 19:36 ` Yann E. MORIN
2023-07-04 20:28 ` Arnout Vandecappelle via buildroot
2023-07-04 20:59 ` James Hilliard
2023-07-06 20:28 ` Yann E. MORIN
2023-07-06 21:05 ` James Hilliard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230703205631.4dd121b0@windsurf \
--to=buildroot@buildroot.org \
--cc=arnout@mind.be \
--cc=james.hilliard1@gmail.com \
--cc=romain.naour@smile.fr \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.