Re: [Buildroot] [PATCH 1/3] arch: add support for mcf54418 Colfdire

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Jean-Michel Hautbois <jeanmichel.hautbois@yoseli.org>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Romain Naour <romain.naour@gmail.com>,
	Giulio Benetti <giulio.benetti@benettiengineering.com>,
	Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/3] arch: add support for mcf54418 Colfdire
Date: Tue, 4 Jul 2023 07:24:49 +0200	[thread overview]
Message-ID: <20230704052449.GM2510@scaer> (raw)
In-Reply-To: <34f2156d-2f2e-c77f-b002-ec0c01bbc6ae@yoseli.org>

Jean-Michel, All,

On 2023-07-03 22:37 +0200, Jean-Michel Hautbois spake thusly:
> On 03/07/2023 20:55, Yann E. MORIN wrote:
> >On 2023-06-29 07:31 +0200, Jean-Michel Hautbois spake thusly:
> >>The m68k family ony has one Coldfire variant, namely the 5208. Add the
> >>support for the MCF54418 CPU in the configuration file.
> >As your cover-letter said, eda11417beaf (m68k: remove
> >BR2_GCC_TARGET_ARCH), setting it breaks use of external toolchains.
[--SNIP--]
> >So, your commit log should explain how/why it is safe to re-introduce
> >BR2_GCC_TARGET_ARCH. I see you only set ig for this new CPU variant, so
> >maybe that's enough of a reason.
> >
> >Still, it'd be nice to have it explained in plain letters.
> 
> OK, so get the content from the plain letter and have it in this commit
> message too ;-).

Yes, the reference to commit eda11417beaf is very important to have in
the nez commit mess is very important to have in the nez commit messagee

> >Also, it'd be nice if you could try with an external toolchain, and
> >explain that in the commit log. If you do not have an external toolchain
> >available, you can generate one with Buildroot, and re-use it as an
> >external toolchain.
> Sadly, the only external toolchain I tried is the one from bootlin, and it
> is not compatible with a CPU which has a MMU. Considering I might miss some
> things !

If there is no other pre-built toolchain, then build one with Buildroot
(with this change!), and re-user it as an external toolchain, just to be
sure that this case at least still works; see the manual [0] on how to
do that.

[0] https://buildroot.org/downloads/manual/manual.html#_advanced_usage

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot