From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D29DCEB64DA for ; Tue, 4 Jul 2023 09:57:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oJBHKLuVyjEeCflCaSyeRUunOilNDChJryWH5Iru0K8=; b=AFdPUHx1YQqkE7 UxF89n1SIaCDXoLGESiD8ewNd+x+0U9G/8cGUtF7rD+Pow+CsOysEZu9Hf4m6WRH42h8/DA3YSGFy rvQaMMa6Dhem5jI9NUyMeQUIRkXS2+URrX8HIsTh5kcksOaj8Fx3+Pb7nt4djItSjcP4BPM+KD//5 5RKLvVR30MNNu7Hl80L4RyGoAr2Fcpr8lIJLgITEaUrvgc2msTcWydBWX4HVcPK+EB3NZ+x2cj8+t BT3YDIfL0bKpsjwxhM4nKbbK94mDXzUjf/jcHpZfDIP4JU1Chh7fa1zX0OoqikY2RftGEn9k9i98k QthsFB1oWA9CiX0xUoBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGcly-00CoSf-1Z; Tue, 04 Jul 2023 09:56:38 +0000 Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGclv-00CoQy-0p; Tue, 04 Jul 2023 09:56:37 +0000 X-GND-Sasl: miquel.raynal@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1688464592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mMapt+1v6arSkASxO8Vo/k1eb4URuf8TQG4qlhn8MnA=; b=MqsYEmANYbQeHQzDbkLhMUahxnUMbuzqWizhWc2AjfbV/tbNF8tsEpgVAK0lHnZt7SADVD pj9s56P5VDsQkjoDpoN4gz4JDh35m0ZolCz6wDDkrfZ6jqETug28jcpXZf9j6iAtbe1zxO UveLyrixfCgqolvN/xfNUfyIA/4tJsx3Rnm1Xu/gtIgrXW9vPY3t1vZP0cIgnXSWJfd/v4 DlPL6/xCmg++MDDhsv0w1zlQCG4DKii69CLqch37HeqTjxwLgOboN9ph6LGjG4DTxVoVcm Zag5KVmebxeQKwJ8ap/rMOiC40SKCt98ZFZBN1AlRFKQBk/FwPwVAtCWINO2Aw== X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id D4F882000C; Tue, 4 Jul 2023 09:56:29 +0000 (UTC) Date: Tue, 4 Jul 2023 11:56:28 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , , , , , , , Subject: Re: [RFC PATCH v1 2/2] mtd: rawnand: meson: support for 512B ECC step size Message-ID: <20230704115628.55320428@xps-13> In-Reply-To: References: <20230628092937.538683-1-AVKrasnov@sberdevices.ru> <20230628092937.538683-3-AVKrasnov@sberdevices.ru> <20230704103617.4affae8a@xps-13> <9e6eaa87-887c-f955-113a-43860c8ea00c@sberdevices.ru> <20230704114110.25ca9de4@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230704_025635_590806_ACE23026 X-CRM114-Status: GOOD ( 30.76 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org SGkgQXJzZW5peSwKCmF2a3Jhc25vdkBzYmVyZGV2aWNlcy5ydSB3cm90ZSBvbiBUdWUsIDQgSnVs IDIwMjMgMTI6NDY6NTEgKzAzMDA6Cgo+IE9uIDA0LjA3LjIwMjMgMTI6NDEsIE1pcXVlbCBSYXlu YWwgd3JvdGU6Cj4gPiBIaSBBcnNlbml5LAo+ID4gCj4gPiBhdmtyYXNub3ZAc2JlcmRldmljZXMu cnUgd3JvdGUgb24gVHVlLCA0IEp1bCAyMDIzIDEyOjIzOjAzICswMzAwOgo+ID4gICAKPiA+PiBP biAwNC4wNy4yMDIzIDExOjM2LCBNaXF1ZWwgUmF5bmFsIHdyb3RlOiAgCj4gPj4+IEhpIEFyc2Vu aXksCj4gPj4+Cj4gPj4+IEFWS3Jhc25vdkBzYmVyZGV2aWNlcy5ydSB3cm90ZSBvbiBXZWQsIDI4 IEp1biAyMDIzIDEyOjI5OjM2ICswMzAwOgo+ID4+PiAgICAgCj4gPj4+PiBNZXNvbiBOQU5EIHN1 cHBvcnRzIGJvdGggNTEyQiBhbmQgMTAyNEIgRUNDIHN0ZXAgc2l6ZS4KPiA+Pj4+Cj4gPj4+PiBT aWduZWQtb2ZmLWJ5OiBBcnNlbml5IEtyYXNub3YgPEFWS3Jhc25vdkBzYmVyZGV2aWNlcy5ydT4K PiA+Pj4+IC0tLQo+ID4+Pj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYyB8IDQ3 ICsrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0KPiA+Pj4+ICAxIGZpbGUgY2hhbmdlZCwg MzUgaW5zZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0pCj4gPj4+Pgo+ID4+Pj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYyBiL2RyaXZlcnMvbXRkL25hbmQv cmF3L21lc29uX25hbmQuYwo+ID4+Pj4gaW5kZXggMzQ1MjEyZThjNjkxLi42Y2M0ZjYzYjg2Yzgg MTAwNjQ0Cj4gPj4+PiAtLS0gYS9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMKPiA+ Pj4+ICsrKyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYwo+ID4+Pj4gQEAgLTEz NSw2ICsxMzUsNyBAQCBzdHJ1Y3QgbWVzb25fbmZjX25hbmRfY2hpcCB7Cj4gPj4+PiAgc3RydWN0 IG1lc29uX25hbmRfZWNjIHsKPiA+Pj4+ICAJdTMyIGJjaDsKPiA+Pj4+ICAJdTMyIHN0cmVuZ3Ro Owo+ID4+Pj4gKwl1MzIgc2l6ZTsKPiA+Pj4+ICB9Owo+ID4+Pj4gIAo+ID4+Pj4gIHN0cnVjdCBt ZXNvbl9uZmNfZGF0YSB7Cj4gPj4+PiBAQCAtMTkwLDcgKzE5MSw4IEBAIHN0cnVjdCBtZXNvbl9u ZmMgewo+ID4+Pj4gIH07Cj4gPj4+PiAgCj4gPj4+PiAgZW51bSB7Cj4gPj4+PiAtCU5GQ19FQ0Nf QkNIOF8xSwkJPSAyLAo+ID4+Pj4gKwlORkNfRUNDX0JDSDhfNTEyCT0gMSwKPiA+Pj4+ICsJTkZD X0VDQ19CQ0g4XzFLLAo+ID4+Pj4gIAlORkNfRUNDX0JDSDI0XzFLLAo+ID4+Pj4gIAlORkNfRUND X0JDSDMwXzFLLAo+ID4+Pj4gIAlORkNfRUNDX0JDSDQwXzFLLAo+ID4+Pj4gQEAgLTE5OCwxNSAr MjAwLDE2IEBAIGVudW0gewo+ID4+Pj4gIAlORkNfRUNDX0JDSDYwXzFLLAo+ID4+Pj4gIH07Cj4g Pj4+PiAgCj4gPj4+PiAtI2RlZmluZSBNRVNPTl9FQ0NfREFUQShiLCBzKQl7IC5iY2ggPSAoYiks CS5zdHJlbmd0aCA9IChzKX0KPiA+Pj4+ICsjZGVmaW5lIE1FU09OX0VDQ19EQVRBKGIsIHMsIHN6 KQl7IC5iY2ggPSAoYiksIC5zdHJlbmd0aCA9IChzKSwgLnNpemUgPSAoc3opIH0KPiA+Pj4+ICAK PiA+Pj4+ICBzdGF0aWMgc3RydWN0IG1lc29uX25hbmRfZWNjIG1lc29uX2VjY1tdID0gewo+ID4+ Pj4gLQlNRVNPTl9FQ0NfREFUQShORkNfRUNDX0JDSDhfMUssIDgpLAo+ID4+Pj4gLQlNRVNPTl9F Q0NfREFUQShORkNfRUNDX0JDSDI0XzFLLCAyNCksCj4gPj4+PiAtCU1FU09OX0VDQ19EQVRBKE5G Q19FQ0NfQkNIMzBfMUssIDMwKSwKPiA+Pj4+IC0JTUVTT05fRUNDX0RBVEEoTkZDX0VDQ19CQ0g0 MF8xSywgNDApLAo+ID4+Pj4gLQlNRVNPTl9FQ0NfREFUQShORkNfRUNDX0JDSDUwXzFLLCA1MCks Cj4gPj4+PiAtCU1FU09OX0VDQ19EQVRBKE5GQ19FQ0NfQkNINjBfMUssIDYwKSwKPiA+Pj4+ICsJ TUVTT05fRUNDX0RBVEEoTkZDX0VDQ19CQ0g4XzUxMiwgOCwgIDUxMiksCj4gPj4+PiArCU1FU09O X0VDQ19EQVRBKE5GQ19FQ0NfQkNIOF8xSywgIDgsICAxMDI0KSwKPiA+Pj4+ICsJTUVTT05fRUND X0RBVEEoTkZDX0VDQ19CQ0gyNF8xSywgMjQsIDEwMjQpLAo+ID4+Pj4gKwlNRVNPTl9FQ0NfREFU QShORkNfRUNDX0JDSDMwXzFLLCAzMCwgMTAyNCksCj4gPj4+PiArCU1FU09OX0VDQ19EQVRBKE5G Q19FQ0NfQkNINDBfMUssIDQwLCAxMDI0KSwKPiA+Pj4+ICsJTUVTT05fRUNDX0RBVEEoTkZDX0VD Q19CQ0g1MF8xSywgNTAsIDEwMjQpLAo+ID4+Pj4gKwlNRVNPTl9FQ0NfREFUQShORkNfRUNDX0JD SDYwXzFLLCA2MCwgMTAyNCksCj4gPj4+PiAgfTsKPiA+Pj4+ICAKPiA+Pj4+ICBzdGF0aWMgaW50 IG1lc29uX25hbmRfY2FsY19lY2NfYnl0ZXMoaW50IHN0ZXBfc2l6ZSwgaW50IHN0cmVuZ3RoKQo+ ID4+Pj4gQEAgLTIyNCw4ICsyMjcsMjcgQEAgc3RhdGljIGludCBtZXNvbl9uYW5kX2NhbGNfZWNj X2J5dGVzKGludCBzdGVwX3NpemUsIGludCBzdHJlbmd0aCkKPiA+Pj4+ICAKPiA+Pj4+ICBOQU5E X0VDQ19DQVBTX1NJTkdMRShtZXNvbl9neGxfZWNjX2NhcHMsCj4gPj4+PiAgCQkgICAgIG1lc29u X25hbmRfY2FsY19lY2NfYnl0ZXMsIDEwMjQsIDgsIDI0LCAzMCwgNDAsIDUwLCA2MCk7Cj4gPj4+ PiAtTkFORF9FQ0NfQ0FQU19TSU5HTEUobWVzb25fYXhnX2VjY19jYXBzLAo+ID4+Pj4gLQkJICAg ICBtZXNvbl9uYW5kX2NhbGNfZWNjX2J5dGVzLCAxMDI0LCA4KTsKPiA+Pj4+ICsKPiA+Pj4+ICtz dGF0aWMgY29uc3QgaW50IGF4Z19zdGVwaW5mb19zdHJlbmd0aHNbXSA9IHsgOCB9Owo+ID4+Pj4g K3N0YXRpYyBjb25zdCBzdHJ1Y3QgbmFuZF9lY2Nfc3RlcF9pbmZvIGF4Z19zdGVwaW5mb18xMDI0 ID0gewo+ID4+Pj4gKwkuc3RlcHNpemUgPSAxMDI0LAo+ID4+Pj4gKwkuc3RyZW5ndGhzID0gYXhn X3N0ZXBpbmZvX3N0cmVuZ3RocywKPiA+Pj4+ICsJLm5zdHJlbmd0aHMgPSBBUlJBWV9TSVpFKGF4 Z19zdGVwaW5mb19zdHJlbmd0aHMpCj4gPj4+PiArfTsKPiA+Pj4+ICsKPiA+Pj4+ICtzdGF0aWMg Y29uc3Qgc3RydWN0IG5hbmRfZWNjX3N0ZXBfaW5mbyBheGdfc3RlcGluZm9fNTEyID0gewo+ID4+ Pj4gKwkuc3RlcHNpemUgPSA1MTIsCj4gPj4+PiArCS5zdHJlbmd0aHMgPSBheGdfc3RlcGluZm9f c3RyZW5ndGhzLAo+ID4+Pj4gKwkubnN0cmVuZ3RocyA9IEFSUkFZX1NJWkUoYXhnX3N0ZXBpbmZv X3N0cmVuZ3RocykKPiA+Pj4+ICt9Owo+ID4+Pj4gKwo+ID4+Pj4gK3N0YXRpYyBjb25zdCBzdHJ1 Y3QgbmFuZF9lY2Nfc3RlcF9pbmZvIGF4Z19zdGVwaW5mb1tdID0geyBheGdfc3RlcGluZm9fMTAy NCwgYXhnX3N0ZXBpbmZvXzUxMiB9Owo+ID4+Pj4gKwo+ID4+Pj4gK3N0YXRpYyBjb25zdCBzdHJ1 Y3QgbmFuZF9lY2NfY2FwcyBtZXNvbl9heGdfZWNjX2NhcHMgPSB7Cj4gPj4+PiArCS5zdGVwaW5m b3MgPSBheGdfc3RlcGluZm8sCj4gPj4+PiArCS5uc3RlcGluZm9zID0gQVJSQVlfU0laRShheGdf c3RlcGluZm8pLAo+ID4+Pj4gKwkuY2FsY19lY2NfYnl0ZXMgPSBtZXNvbl9uYW5kX2NhbGNfZWNj X2J5dGVzLAo+ID4+Pj4gK307Cj4gPj4+PiAgCj4gPj4+PiAgc3RhdGljIHN0cnVjdCBtZXNvbl9u ZmNfbmFuZF9jaGlwICp0b19tZXNvbl9uYW5kKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQpCj4gPj4+ PiAgewo+ID4+Pj4gQEAgLTEyNTksNyArMTI4MSw4IEBAIHN0YXRpYyBpbnQgbWVzb25fbmFuZF9i Y2hfbW9kZShzdHJ1Y3QgbmFuZF9jaGlwICpuYW5kKQo+ID4+Pj4gIAkJcmV0dXJuIC1FSU5WQUw7 Cj4gPj4+PiAgCj4gPj4+PiAgCWZvciAoaSA9IDA7IGkgPCBBUlJBWV9TSVpFKG1lc29uX2VjYyk7 IGkrKykgewo+ID4+Pj4gLQkJaWYgKG1lc29uX2VjY1tpXS5zdHJlbmd0aCA9PSBuYW5kLT5lY2Mu c3RyZW5ndGgpIHsKPiA+Pj4+ICsJCWlmIChtZXNvbl9lY2NbaV0uc3RyZW5ndGggPT0gbmFuZC0+ ZWNjLnN0cmVuZ3RoICYmCj4gPj4+PiArCQkgICAgbWVzb25fZWNjW2ldLnNpemUgPT0gbmFuZC0+ ZWNjLnNpemUpIHsKPiA+Pj4+ICAJCQltZXNvbl9jaGlwLT5iY2hfbW9kZSA9IG1lc29uX2VjY1tp XS5iY2g7Cj4gPj4+PiAgCQkJcmV0dXJuIDA7Cj4gPj4+PiAgCQl9Cj4gPj4+PiBAQCAtMTI3OCw3 ICsxMzAxLDcgQEAgc3RhdGljIGludCBtZXNvbl9uYW5kX2F0dGFjaF9jaGlwKHN0cnVjdCBuYW5k X2NoaXAgKm5hbmQpCj4gPj4+PiAgCXN0cnVjdCBtZXNvbl9uZmMgKm5mYyA9IG5hbmRfZ2V0X2Nv bnRyb2xsZXJfZGF0YShuYW5kKTsKPiA+Pj4+ICAJc3RydWN0IG1lc29uX25mY19uYW5kX2NoaXAg Km1lc29uX2NoaXAgPSB0b19tZXNvbl9uYW5kKG5hbmQpOwo+ID4+Pj4gIAlzdHJ1Y3QgbXRkX2lu Zm8gKm10ZCA9IG5hbmRfdG9fbXRkKG5hbmQpOwo+ID4+Pj4gLQlpbnQgbnNlY3RvcnMgPSBtdGQt PndyaXRlc2l6ZSAvIDEwMjQ7Cj4gPj4+PiArCWludCBuc2VjdG9ycyA9IG10ZC0+d3JpdGVzaXpl IC8gNTEyOyAgICAKPiA+Pj4KPiA+Pj4gVGhpcyBjYW5ub3QgYmUgdW5jb25kaXRpb25hbCwgcmln aHQ/ICAgIAo+ID4+Cj4gPj4gSGVsbG8gTWlxdWVsIQo+ID4+Cj4gPj4gWWVzLCB0aGlzIGNvZGUg bG9va3Mgc3RyYW5nZS4gJ25zZWN0b3JzJyBpcyB1c2VkIHRvIGNhbGN1bGF0ZSBzcGFjZSBpbiBP T0IKPiA+PiB0aGF0IGNvdWxkIGJlIHVzZWQgYnkgRUNDIGVuZ2luZSAodGhpcyB2YWx1ZSB3aWxs IGJlIHBhc3NlZCBhcyAnb29iYXZhaWwnCj4gPj4gdG8gJ25hbmRfZWNjX2Nob29zZV9jb25mKCkn KS4gSWRlYSBvZiA1MTIgaXMgdG8gY29uc2lkZXIgIndvcnN0IiBjYXNlCj4gPj4gZm9yIEVDQywg ZS5nLiBtaW5pbWFsIG51bWJlciBvZiBieXRlcyBmb3IgRUNDIGVuZ2luZSAoYW5kIGF0IHRoZSBz YW1lIHRpbWUKPiA+PiBtYXhpbXVtIG51bWJlciBvZiBmcmVlIGJ5dGVzKS4gRm9yIE1lc29uLCBp ZiBFQ0Mgc3RlcCBzaXplIGlzIDUxMiwgdGhlbiB3ZQo+ID4+IGhhdmUgNCB4IDIgZnJlZSBieXRl cyBpbiBPT0IgKGlmIHN0ZXAgc2l6ZSBpZiAxMDI0IHRoZW4gd2UgaGF2ZSAyIHggMiBmcmVlCj4g Pj4gYnl0ZXMgaW4gT09CKS4KPiA+Pgo+ID4+IEkgdGhpbmsgdGhpcyBjb2RlIGNvdWxkIGJlIHJl d29ya2VkIGluIHRoZSBmb2xsb3dpbmcgd2F5Ogo+ID4+Cj4gPj4gaWYgRUNDIHN0ZXAgc2l6ZSBp cyBhbHJlYWR5IGtub3duIGhlcmUgKGZyb20gRFRTKSwgY2FsY3VsYXRlICduc2VjdG9ycycgdXNp bmcKPiA+PiBnaXZlbiB2YWx1ZSAoZGl2IGJ5IDUxMiBmb3IgZXhhbXBsZSkuIE90aGVyd2lzZSBj YWxjdWxhdGUgJ25zZWN0b3JzJyBpbiB0aGUKPiA+PiBjdXJyZW50IG1hbm5lcjogIAo+ID4gCj4g PiBJdCB3aWxsIGFsd2F5cyBiZSBrbm93biB3aGVuIHRoZXNlIGZ1bmN0aW9uIGFyZSBydW4uIFRo ZXJlIGlzIG5vCj4gPiBndWVzc2luZyBoZXJlLiAgCj4gCj4gSG0gSSBjaGVja2VkLCB0aGF0IGJ1 dCBpZiBzdGVwIHNpemUgaXMgbm90IHNldCBpbiBEVFMsIGhlcmUgaXQgd2lsbCBiZSAwLCAKPiB0 aGVuIGl0IHdpbGwgYmUgc2VsZWN0ZWQgaW4gJ25hbmRfZWNjX2Nob29zZV9jb25mKCknIGFjY29y ZGluZyBwcm92aWRlZCAnZWNjX2NhcHMnCj4gYW5kICdvb2JhdmFpbCcuLi4KPiAKPiBBbnl3YXks IEknbGwgZG8gdGhlIGZvbGxvd2luZyB0aGluZzoKPiAKPiBpbnQgbnNlY3RvcnM7Cj4gCj4gaWYg KG5hbmQtPmVjYy5zaXplKQo+ICAgICBuc2VjdG9ycyA9IG10ZC0+d3JpdGVzaXplIC8gbmFuZC0+ ZWNjLnNpemU7IDwtLS0gdGhpcyBpcyBmb3IgNTEyIEVDQwoKWW91IHNob3VsZCBzZXQgbmFuZC0+ ZWNjLnNpemUgaW4gLT5hdHRhY2hfY2hpcCgpIGluc3RlYWQuCgo+IGVsc2UKPiAgICAgbnNlY3Rv cnMgPSBtdGQtPndyaXRlc2l6ZSAvIDEwMjQ7IDwtLS0gdGhpcyBpcyBmb3IgZGVmYXVsdCAxMDI0 IEVDQwo+IAo+IFRoYW5rcywgQXJzZW5peQo+IAo+ID4gICAKPiA+Pgo+ID4+IGludCBuc2VjdG9y cyA9IG10ZC0+d3JpdGVzaXplIC8gMTAyNDsKPiA+Pgo+ID4+IE1vcmVvdmVyIDEwMjQgaXMgZGVm YXVsdCBFQ0Mgc3RlcCBzaXplIGZvciB0aGlzIGRyaXZlciwgc28gZGVmYXVsdCBiZWhhdmlvdXIK PiA+PiB3aWxsIGJlIHByZXNlcnZlZC4gIAo+ID4gCj4gPiBZZXMsIG90aGVyd2lzZSB5b3Ugd291 bGQgYnJlYWsgZXhpc3RpbmcgdXNlcnMuCj4gPiAgIAo+ID4+Cj4gPj4gVGhhbmtzLCBBcnNlbml5 Cj4gPj4gIAo+ID4+PiAgICAgCj4gPj4+PiAgCWludCByYXdfd3JpdGVzaXplOwo+ID4+Pj4gIAlp bnQgcmV0Owo+ID4+Pj4gICAgICAKPiA+Pj4KPiA+Pj4KPiA+Pj4gVGhhbmtzLAo+ID4+PiBNaXF1 w6hsICAgIAo+ID4gCj4gPiAKPiA+IFRoYW5rcywKPiA+IE1pcXXDqGwgIAoKClRoYW5rcywKTWlx dcOobAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtYW1sb2dpYyBtYWlsaW5nIGxpc3QKbGludXgtYW1sb2dpY0BsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYW1sb2dp Ywo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5205EB64D9 for ; Tue, 4 Jul 2023 09:56:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I3JH/DjCpm4qcQVEGJIKyw1w0fiEpJnRLFxQHa1gEWY=; b=YUhkqYmXpoWVGj 3TkDHchgMPHUKLj2BwYuYCwF6W8g+qItxfJ2VFFQoYXTI4PPq+RIwZlgbjfkFNRcFMGYmWUR/uEhd weEgG66Cr4Ty1HvVvu5pcPkp1tZdrbnMJpZFn2GUiKO9mRwzkTXa4bHAPYlulQQxFI4NM42WjfOnc nqoPF+4Ez4BLmuEwNGc5b07Em+U4iSY9dzjp9NLkFNrzMGo1Jo/ICxLX1wPNH/e1W3ZwEDZGUVJc3 lbI2b3YOujkyIH0+5Vp0jr30QKx16nElluSwVfmNiFbnHtdSrz4P/yFB34IogtK5eQLj98CZgwY8l rRit8jUk1iI+Wg4qKbpQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGclz-00CoTA-1Q; Tue, 04 Jul 2023 09:56:39 +0000 Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGclv-00CoQy-0p; Tue, 04 Jul 2023 09:56:37 +0000 X-GND-Sasl: miquel.raynal@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1688464592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mMapt+1v6arSkASxO8Vo/k1eb4URuf8TQG4qlhn8MnA=; b=MqsYEmANYbQeHQzDbkLhMUahxnUMbuzqWizhWc2AjfbV/tbNF8tsEpgVAK0lHnZt7SADVD pj9s56P5VDsQkjoDpoN4gz4JDh35m0ZolCz6wDDkrfZ6jqETug28jcpXZf9j6iAtbe1zxO UveLyrixfCgqolvN/xfNUfyIA/4tJsx3Rnm1Xu/gtIgrXW9vPY3t1vZP0cIgnXSWJfd/v4 DlPL6/xCmg++MDDhsv0w1zlQCG4DKii69CLqch37HeqTjxwLgOboN9ph6LGjG4DTxVoVcm Zag5KVmebxeQKwJ8ap/rMOiC40SKCt98ZFZBN1AlRFKQBk/FwPwVAtCWINO2Aw== X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id D4F882000C; Tue, 4 Jul 2023 09:56:29 +0000 (UTC) Date: Tue, 4 Jul 2023 11:56:28 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , , , , , , , Subject: Re: [RFC PATCH v1 2/2] mtd: rawnand: meson: support for 512B ECC step size Message-ID: <20230704115628.55320428@xps-13> In-Reply-To: References: <20230628092937.538683-1-AVKrasnov@sberdevices.ru> <20230628092937.538683-3-AVKrasnov@sberdevices.ru> <20230704103617.4affae8a@xps-13> <9e6eaa87-887c-f955-113a-43860c8ea00c@sberdevices.ru> <20230704114110.25ca9de4@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230704_025635_590806_ACE23026 X-CRM114-Status: GOOD ( 30.76 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgQXJzZW5peSwKCmF2a3Jhc25vdkBzYmVyZGV2aWNlcy5ydSB3cm90ZSBvbiBUdWUsIDQgSnVs IDIwMjMgMTI6NDY6NTEgKzAzMDA6Cgo+IE9uIDA0LjA3LjIwMjMgMTI6NDEsIE1pcXVlbCBSYXlu YWwgd3JvdGU6Cj4gPiBIaSBBcnNlbml5LAo+ID4gCj4gPiBhdmtyYXNub3ZAc2JlcmRldmljZXMu cnUgd3JvdGUgb24gVHVlLCA0IEp1bCAyMDIzIDEyOjIzOjAzICswMzAwOgo+ID4gICAKPiA+PiBP biAwNC4wNy4yMDIzIDExOjM2LCBNaXF1ZWwgUmF5bmFsIHdyb3RlOiAgCj4gPj4+IEhpIEFyc2Vu aXksCj4gPj4+Cj4gPj4+IEFWS3Jhc25vdkBzYmVyZGV2aWNlcy5ydSB3cm90ZSBvbiBXZWQsIDI4 IEp1biAyMDIzIDEyOjI5OjM2ICswMzAwOgo+ID4+PiAgICAgCj4gPj4+PiBNZXNvbiBOQU5EIHN1 cHBvcnRzIGJvdGggNTEyQiBhbmQgMTAyNEIgRUNDIHN0ZXAgc2l6ZS4KPiA+Pj4+Cj4gPj4+PiBT aWduZWQtb2ZmLWJ5OiBBcnNlbml5IEtyYXNub3YgPEFWS3Jhc25vdkBzYmVyZGV2aWNlcy5ydT4K PiA+Pj4+IC0tLQo+ID4+Pj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYyB8IDQ3 ICsrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0KPiA+Pj4+ICAxIGZpbGUgY2hhbmdlZCwg MzUgaW5zZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0pCj4gPj4+Pgo+ID4+Pj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYyBiL2RyaXZlcnMvbXRkL25hbmQv cmF3L21lc29uX25hbmQuYwo+ID4+Pj4gaW5kZXggMzQ1MjEyZThjNjkxLi42Y2M0ZjYzYjg2Yzgg MTAwNjQ0Cj4gPj4+PiAtLS0gYS9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMKPiA+ Pj4+ICsrKyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYwo+ID4+Pj4gQEAgLTEz NSw2ICsxMzUsNyBAQCBzdHJ1Y3QgbWVzb25fbmZjX25hbmRfY2hpcCB7Cj4gPj4+PiAgc3RydWN0 IG1lc29uX25hbmRfZWNjIHsKPiA+Pj4+ICAJdTMyIGJjaDsKPiA+Pj4+ICAJdTMyIHN0cmVuZ3Ro Owo+ID4+Pj4gKwl1MzIgc2l6ZTsKPiA+Pj4+ICB9Owo+ID4+Pj4gIAo+ID4+Pj4gIHN0cnVjdCBt ZXNvbl9uZmNfZGF0YSB7Cj4gPj4+PiBAQCAtMTkwLDcgKzE5MSw4IEBAIHN0cnVjdCBtZXNvbl9u ZmMgewo+ID4+Pj4gIH07Cj4gPj4+PiAgCj4gPj4+PiAgZW51bSB7Cj4gPj4+PiAtCU5GQ19FQ0Nf QkNIOF8xSwkJPSAyLAo+ID4+Pj4gKwlORkNfRUNDX0JDSDhfNTEyCT0gMSwKPiA+Pj4+ICsJTkZD X0VDQ19CQ0g4XzFLLAo+ID4+Pj4gIAlORkNfRUNDX0JDSDI0XzFLLAo+ID4+Pj4gIAlORkNfRUND X0JDSDMwXzFLLAo+ID4+Pj4gIAlORkNfRUNDX0JDSDQwXzFLLAo+ID4+Pj4gQEAgLTE5OCwxNSAr MjAwLDE2IEBAIGVudW0gewo+ID4+Pj4gIAlORkNfRUNDX0JDSDYwXzFLLAo+ID4+Pj4gIH07Cj4g Pj4+PiAgCj4gPj4+PiAtI2RlZmluZSBNRVNPTl9FQ0NfREFUQShiLCBzKQl7IC5iY2ggPSAoYiks CS5zdHJlbmd0aCA9IChzKX0KPiA+Pj4+ICsjZGVmaW5lIE1FU09OX0VDQ19EQVRBKGIsIHMsIHN6 KQl7IC5iY2ggPSAoYiksIC5zdHJlbmd0aCA9IChzKSwgLnNpemUgPSAoc3opIH0KPiA+Pj4+ICAK PiA+Pj4+ICBzdGF0aWMgc3RydWN0IG1lc29uX25hbmRfZWNjIG1lc29uX2VjY1tdID0gewo+ID4+ Pj4gLQlNRVNPTl9FQ0NfREFUQShORkNfRUNDX0JDSDhfMUssIDgpLAo+ID4+Pj4gLQlNRVNPTl9F Q0NfREFUQShORkNfRUNDX0JDSDI0XzFLLCAyNCksCj4gPj4+PiAtCU1FU09OX0VDQ19EQVRBKE5G Q19FQ0NfQkNIMzBfMUssIDMwKSwKPiA+Pj4+IC0JTUVTT05fRUNDX0RBVEEoTkZDX0VDQ19CQ0g0 MF8xSywgNDApLAo+ID4+Pj4gLQlNRVNPTl9FQ0NfREFUQShORkNfRUNDX0JDSDUwXzFLLCA1MCks Cj4gPj4+PiAtCU1FU09OX0VDQ19EQVRBKE5GQ19FQ0NfQkNINjBfMUssIDYwKSwKPiA+Pj4+ICsJ TUVTT05fRUNDX0RBVEEoTkZDX0VDQ19CQ0g4XzUxMiwgOCwgIDUxMiksCj4gPj4+PiArCU1FU09O X0VDQ19EQVRBKE5GQ19FQ0NfQkNIOF8xSywgIDgsICAxMDI0KSwKPiA+Pj4+ICsJTUVTT05fRUND X0RBVEEoTkZDX0VDQ19CQ0gyNF8xSywgMjQsIDEwMjQpLAo+ID4+Pj4gKwlNRVNPTl9FQ0NfREFU QShORkNfRUNDX0JDSDMwXzFLLCAzMCwgMTAyNCksCj4gPj4+PiArCU1FU09OX0VDQ19EQVRBKE5G Q19FQ0NfQkNINDBfMUssIDQwLCAxMDI0KSwKPiA+Pj4+ICsJTUVTT05fRUNDX0RBVEEoTkZDX0VD Q19CQ0g1MF8xSywgNTAsIDEwMjQpLAo+ID4+Pj4gKwlNRVNPTl9FQ0NfREFUQShORkNfRUNDX0JD SDYwXzFLLCA2MCwgMTAyNCksCj4gPj4+PiAgfTsKPiA+Pj4+ICAKPiA+Pj4+ICBzdGF0aWMgaW50 IG1lc29uX25hbmRfY2FsY19lY2NfYnl0ZXMoaW50IHN0ZXBfc2l6ZSwgaW50IHN0cmVuZ3RoKQo+ ID4+Pj4gQEAgLTIyNCw4ICsyMjcsMjcgQEAgc3RhdGljIGludCBtZXNvbl9uYW5kX2NhbGNfZWNj X2J5dGVzKGludCBzdGVwX3NpemUsIGludCBzdHJlbmd0aCkKPiA+Pj4+ICAKPiA+Pj4+ICBOQU5E X0VDQ19DQVBTX1NJTkdMRShtZXNvbl9neGxfZWNjX2NhcHMsCj4gPj4+PiAgCQkgICAgIG1lc29u X25hbmRfY2FsY19lY2NfYnl0ZXMsIDEwMjQsIDgsIDI0LCAzMCwgNDAsIDUwLCA2MCk7Cj4gPj4+ PiAtTkFORF9FQ0NfQ0FQU19TSU5HTEUobWVzb25fYXhnX2VjY19jYXBzLAo+ID4+Pj4gLQkJICAg ICBtZXNvbl9uYW5kX2NhbGNfZWNjX2J5dGVzLCAxMDI0LCA4KTsKPiA+Pj4+ICsKPiA+Pj4+ICtz dGF0aWMgY29uc3QgaW50IGF4Z19zdGVwaW5mb19zdHJlbmd0aHNbXSA9IHsgOCB9Owo+ID4+Pj4g K3N0YXRpYyBjb25zdCBzdHJ1Y3QgbmFuZF9lY2Nfc3RlcF9pbmZvIGF4Z19zdGVwaW5mb18xMDI0 ID0gewo+ID4+Pj4gKwkuc3RlcHNpemUgPSAxMDI0LAo+ID4+Pj4gKwkuc3RyZW5ndGhzID0gYXhn X3N0ZXBpbmZvX3N0cmVuZ3RocywKPiA+Pj4+ICsJLm5zdHJlbmd0aHMgPSBBUlJBWV9TSVpFKGF4 Z19zdGVwaW5mb19zdHJlbmd0aHMpCj4gPj4+PiArfTsKPiA+Pj4+ICsKPiA+Pj4+ICtzdGF0aWMg Y29uc3Qgc3RydWN0IG5hbmRfZWNjX3N0ZXBfaW5mbyBheGdfc3RlcGluZm9fNTEyID0gewo+ID4+ Pj4gKwkuc3RlcHNpemUgPSA1MTIsCj4gPj4+PiArCS5zdHJlbmd0aHMgPSBheGdfc3RlcGluZm9f c3RyZW5ndGhzLAo+ID4+Pj4gKwkubnN0cmVuZ3RocyA9IEFSUkFZX1NJWkUoYXhnX3N0ZXBpbmZv X3N0cmVuZ3RocykKPiA+Pj4+ICt9Owo+ID4+Pj4gKwo+ID4+Pj4gK3N0YXRpYyBjb25zdCBzdHJ1 Y3QgbmFuZF9lY2Nfc3RlcF9pbmZvIGF4Z19zdGVwaW5mb1tdID0geyBheGdfc3RlcGluZm9fMTAy NCwgYXhnX3N0ZXBpbmZvXzUxMiB9Owo+ID4+Pj4gKwo+ID4+Pj4gK3N0YXRpYyBjb25zdCBzdHJ1 Y3QgbmFuZF9lY2NfY2FwcyBtZXNvbl9heGdfZWNjX2NhcHMgPSB7Cj4gPj4+PiArCS5zdGVwaW5m b3MgPSBheGdfc3RlcGluZm8sCj4gPj4+PiArCS5uc3RlcGluZm9zID0gQVJSQVlfU0laRShheGdf c3RlcGluZm8pLAo+ID4+Pj4gKwkuY2FsY19lY2NfYnl0ZXMgPSBtZXNvbl9uYW5kX2NhbGNfZWNj X2J5dGVzLAo+ID4+Pj4gK307Cj4gPj4+PiAgCj4gPj4+PiAgc3RhdGljIHN0cnVjdCBtZXNvbl9u ZmNfbmFuZF9jaGlwICp0b19tZXNvbl9uYW5kKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQpCj4gPj4+ PiAgewo+ID4+Pj4gQEAgLTEyNTksNyArMTI4MSw4IEBAIHN0YXRpYyBpbnQgbWVzb25fbmFuZF9i Y2hfbW9kZShzdHJ1Y3QgbmFuZF9jaGlwICpuYW5kKQo+ID4+Pj4gIAkJcmV0dXJuIC1FSU5WQUw7 Cj4gPj4+PiAgCj4gPj4+PiAgCWZvciAoaSA9IDA7IGkgPCBBUlJBWV9TSVpFKG1lc29uX2VjYyk7 IGkrKykgewo+ID4+Pj4gLQkJaWYgKG1lc29uX2VjY1tpXS5zdHJlbmd0aCA9PSBuYW5kLT5lY2Mu c3RyZW5ndGgpIHsKPiA+Pj4+ICsJCWlmIChtZXNvbl9lY2NbaV0uc3RyZW5ndGggPT0gbmFuZC0+ ZWNjLnN0cmVuZ3RoICYmCj4gPj4+PiArCQkgICAgbWVzb25fZWNjW2ldLnNpemUgPT0gbmFuZC0+ ZWNjLnNpemUpIHsKPiA+Pj4+ICAJCQltZXNvbl9jaGlwLT5iY2hfbW9kZSA9IG1lc29uX2VjY1tp XS5iY2g7Cj4gPj4+PiAgCQkJcmV0dXJuIDA7Cj4gPj4+PiAgCQl9Cj4gPj4+PiBAQCAtMTI3OCw3 ICsxMzAxLDcgQEAgc3RhdGljIGludCBtZXNvbl9uYW5kX2F0dGFjaF9jaGlwKHN0cnVjdCBuYW5k X2NoaXAgKm5hbmQpCj4gPj4+PiAgCXN0cnVjdCBtZXNvbl9uZmMgKm5mYyA9IG5hbmRfZ2V0X2Nv bnRyb2xsZXJfZGF0YShuYW5kKTsKPiA+Pj4+ICAJc3RydWN0IG1lc29uX25mY19uYW5kX2NoaXAg Km1lc29uX2NoaXAgPSB0b19tZXNvbl9uYW5kKG5hbmQpOwo+ID4+Pj4gIAlzdHJ1Y3QgbXRkX2lu Zm8gKm10ZCA9IG5hbmRfdG9fbXRkKG5hbmQpOwo+ID4+Pj4gLQlpbnQgbnNlY3RvcnMgPSBtdGQt PndyaXRlc2l6ZSAvIDEwMjQ7Cj4gPj4+PiArCWludCBuc2VjdG9ycyA9IG10ZC0+d3JpdGVzaXpl IC8gNTEyOyAgICAKPiA+Pj4KPiA+Pj4gVGhpcyBjYW5ub3QgYmUgdW5jb25kaXRpb25hbCwgcmln aHQ/ICAgIAo+ID4+Cj4gPj4gSGVsbG8gTWlxdWVsIQo+ID4+Cj4gPj4gWWVzLCB0aGlzIGNvZGUg bG9va3Mgc3RyYW5nZS4gJ25zZWN0b3JzJyBpcyB1c2VkIHRvIGNhbGN1bGF0ZSBzcGFjZSBpbiBP T0IKPiA+PiB0aGF0IGNvdWxkIGJlIHVzZWQgYnkgRUNDIGVuZ2luZSAodGhpcyB2YWx1ZSB3aWxs IGJlIHBhc3NlZCBhcyAnb29iYXZhaWwnCj4gPj4gdG8gJ25hbmRfZWNjX2Nob29zZV9jb25mKCkn KS4gSWRlYSBvZiA1MTIgaXMgdG8gY29uc2lkZXIgIndvcnN0IiBjYXNlCj4gPj4gZm9yIEVDQywg ZS5nLiBtaW5pbWFsIG51bWJlciBvZiBieXRlcyBmb3IgRUNDIGVuZ2luZSAoYW5kIGF0IHRoZSBz YW1lIHRpbWUKPiA+PiBtYXhpbXVtIG51bWJlciBvZiBmcmVlIGJ5dGVzKS4gRm9yIE1lc29uLCBp ZiBFQ0Mgc3RlcCBzaXplIGlzIDUxMiwgdGhlbiB3ZQo+ID4+IGhhdmUgNCB4IDIgZnJlZSBieXRl cyBpbiBPT0IgKGlmIHN0ZXAgc2l6ZSBpZiAxMDI0IHRoZW4gd2UgaGF2ZSAyIHggMiBmcmVlCj4g Pj4gYnl0ZXMgaW4gT09CKS4KPiA+Pgo+ID4+IEkgdGhpbmsgdGhpcyBjb2RlIGNvdWxkIGJlIHJl d29ya2VkIGluIHRoZSBmb2xsb3dpbmcgd2F5Ogo+ID4+Cj4gPj4gaWYgRUNDIHN0ZXAgc2l6ZSBp cyBhbHJlYWR5IGtub3duIGhlcmUgKGZyb20gRFRTKSwgY2FsY3VsYXRlICduc2VjdG9ycycgdXNp bmcKPiA+PiBnaXZlbiB2YWx1ZSAoZGl2IGJ5IDUxMiBmb3IgZXhhbXBsZSkuIE90aGVyd2lzZSBj YWxjdWxhdGUgJ25zZWN0b3JzJyBpbiB0aGUKPiA+PiBjdXJyZW50IG1hbm5lcjogIAo+ID4gCj4g PiBJdCB3aWxsIGFsd2F5cyBiZSBrbm93biB3aGVuIHRoZXNlIGZ1bmN0aW9uIGFyZSBydW4uIFRo ZXJlIGlzIG5vCj4gPiBndWVzc2luZyBoZXJlLiAgCj4gCj4gSG0gSSBjaGVja2VkLCB0aGF0IGJ1 dCBpZiBzdGVwIHNpemUgaXMgbm90IHNldCBpbiBEVFMsIGhlcmUgaXQgd2lsbCBiZSAwLCAKPiB0 aGVuIGl0IHdpbGwgYmUgc2VsZWN0ZWQgaW4gJ25hbmRfZWNjX2Nob29zZV9jb25mKCknIGFjY29y ZGluZyBwcm92aWRlZCAnZWNjX2NhcHMnCj4gYW5kICdvb2JhdmFpbCcuLi4KPiAKPiBBbnl3YXks IEknbGwgZG8gdGhlIGZvbGxvd2luZyB0aGluZzoKPiAKPiBpbnQgbnNlY3RvcnM7Cj4gCj4gaWYg KG5hbmQtPmVjYy5zaXplKQo+ICAgICBuc2VjdG9ycyA9IG10ZC0+d3JpdGVzaXplIC8gbmFuZC0+ ZWNjLnNpemU7IDwtLS0gdGhpcyBpcyBmb3IgNTEyIEVDQwoKWW91IHNob3VsZCBzZXQgbmFuZC0+ ZWNjLnNpemUgaW4gLT5hdHRhY2hfY2hpcCgpIGluc3RlYWQuCgo+IGVsc2UKPiAgICAgbnNlY3Rv cnMgPSBtdGQtPndyaXRlc2l6ZSAvIDEwMjQ7IDwtLS0gdGhpcyBpcyBmb3IgZGVmYXVsdCAxMDI0 IEVDQwo+IAo+IFRoYW5rcywgQXJzZW5peQo+IAo+ID4gICAKPiA+Pgo+ID4+IGludCBuc2VjdG9y cyA9IG10ZC0+d3JpdGVzaXplIC8gMTAyNDsKPiA+Pgo+ID4+IE1vcmVvdmVyIDEwMjQgaXMgZGVm YXVsdCBFQ0Mgc3RlcCBzaXplIGZvciB0aGlzIGRyaXZlciwgc28gZGVmYXVsdCBiZWhhdmlvdXIK PiA+PiB3aWxsIGJlIHByZXNlcnZlZC4gIAo+ID4gCj4gPiBZZXMsIG90aGVyd2lzZSB5b3Ugd291 bGQgYnJlYWsgZXhpc3RpbmcgdXNlcnMuCj4gPiAgIAo+ID4+Cj4gPj4gVGhhbmtzLCBBcnNlbml5 Cj4gPj4gIAo+ID4+PiAgICAgCj4gPj4+PiAgCWludCByYXdfd3JpdGVzaXplOwo+ID4+Pj4gIAlp bnQgcmV0Owo+ID4+Pj4gICAgICAKPiA+Pj4KPiA+Pj4KPiA+Pj4gVGhhbmtzLAo+ID4+PiBNaXF1 w6hsICAgIAo+ID4gCj4gPiAKPiA+IFRoYW5rcywKPiA+IE1pcXXDqGwgIAoKClRoYW5rcywKTWlx dcOobAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C246EB64DA for ; Tue, 4 Jul 2023 09:57:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IbPW+KaIHfb2j4XdU/CVdbjh49VAj4EHbcvapMW6h34=; b=JX/2ECPrNmavKE 3rTrhkszcODpWAe09VO3NUl8ekko0nzi/aXZoWM01RuASChrPRrDJGp/tlW/F3emd1osD86Wo/sLM w5ECt3s5jTh7wivnJbS0FtpJYncEYtrX5pGw9VQr/GbNnDyfgagU62dDrWstbpBfS+PLS2MCkecTi bi3AAJa6GMo5+aSRUN2b6bIGLbs7RW0obQNQNzeELw0TUKEwYrZ5G39FMy78jpzfkYe4rK2ZQMNGe Xqnzvyqdf6qGtF47t8mcXwQ6BbgVCTgdYMN6QGXjy/eH2Sk0kQxv1Wlfc2ejpId1Kv4kqG9ffPy6V FIMh0mlsj0FScJ9jY+Wg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGcly-00CoT1-2s; Tue, 04 Jul 2023 09:56:38 +0000 Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGclv-00CoQy-0p; Tue, 04 Jul 2023 09:56:37 +0000 X-GND-Sasl: miquel.raynal@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1688464592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mMapt+1v6arSkASxO8Vo/k1eb4URuf8TQG4qlhn8MnA=; b=MqsYEmANYbQeHQzDbkLhMUahxnUMbuzqWizhWc2AjfbV/tbNF8tsEpgVAK0lHnZt7SADVD pj9s56P5VDsQkjoDpoN4gz4JDh35m0ZolCz6wDDkrfZ6jqETug28jcpXZf9j6iAtbe1zxO UveLyrixfCgqolvN/xfNUfyIA/4tJsx3Rnm1Xu/gtIgrXW9vPY3t1vZP0cIgnXSWJfd/v4 DlPL6/xCmg++MDDhsv0w1zlQCG4DKii69CLqch37HeqTjxwLgOboN9ph6LGjG4DTxVoVcm Zag5KVmebxeQKwJ8ap/rMOiC40SKCt98ZFZBN1AlRFKQBk/FwPwVAtCWINO2Aw== X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id D4F882000C; Tue, 4 Jul 2023 09:56:29 +0000 (UTC) Date: Tue, 4 Jul 2023 11:56:28 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , , , , , , , Subject: Re: [RFC PATCH v1 2/2] mtd: rawnand: meson: support for 512B ECC step size Message-ID: <20230704115628.55320428@xps-13> In-Reply-To: References: <20230628092937.538683-1-AVKrasnov@sberdevices.ru> <20230628092937.538683-3-AVKrasnov@sberdevices.ru> <20230704103617.4affae8a@xps-13> <9e6eaa87-887c-f955-113a-43860c8ea00c@sberdevices.ru> <20230704114110.25ca9de4@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230704_025635_590806_ACE23026 X-CRM114-Status: GOOD ( 30.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgQXJzZW5peSwKCmF2a3Jhc25vdkBzYmVyZGV2aWNlcy5ydSB3cm90ZSBvbiBUdWUsIDQgSnVs IDIwMjMgMTI6NDY6NTEgKzAzMDA6Cgo+IE9uIDA0LjA3LjIwMjMgMTI6NDEsIE1pcXVlbCBSYXlu YWwgd3JvdGU6Cj4gPiBIaSBBcnNlbml5LAo+ID4gCj4gPiBhdmtyYXNub3ZAc2JlcmRldmljZXMu cnUgd3JvdGUgb24gVHVlLCA0IEp1bCAyMDIzIDEyOjIzOjAzICswMzAwOgo+ID4gICAKPiA+PiBP biAwNC4wNy4yMDIzIDExOjM2LCBNaXF1ZWwgUmF5bmFsIHdyb3RlOiAgCj4gPj4+IEhpIEFyc2Vu aXksCj4gPj4+Cj4gPj4+IEFWS3Jhc25vdkBzYmVyZGV2aWNlcy5ydSB3cm90ZSBvbiBXZWQsIDI4 IEp1biAyMDIzIDEyOjI5OjM2ICswMzAwOgo+ID4+PiAgICAgCj4gPj4+PiBNZXNvbiBOQU5EIHN1 cHBvcnRzIGJvdGggNTEyQiBhbmQgMTAyNEIgRUNDIHN0ZXAgc2l6ZS4KPiA+Pj4+Cj4gPj4+PiBT aWduZWQtb2ZmLWJ5OiBBcnNlbml5IEtyYXNub3YgPEFWS3Jhc25vdkBzYmVyZGV2aWNlcy5ydT4K PiA+Pj4+IC0tLQo+ID4+Pj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYyB8IDQ3 ICsrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0KPiA+Pj4+ICAxIGZpbGUgY2hhbmdlZCwg MzUgaW5zZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0pCj4gPj4+Pgo+ID4+Pj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYyBiL2RyaXZlcnMvbXRkL25hbmQv cmF3L21lc29uX25hbmQuYwo+ID4+Pj4gaW5kZXggMzQ1MjEyZThjNjkxLi42Y2M0ZjYzYjg2Yzgg MTAwNjQ0Cj4gPj4+PiAtLS0gYS9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMKPiA+ Pj4+ICsrKyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYwo+ID4+Pj4gQEAgLTEz NSw2ICsxMzUsNyBAQCBzdHJ1Y3QgbWVzb25fbmZjX25hbmRfY2hpcCB7Cj4gPj4+PiAgc3RydWN0 IG1lc29uX25hbmRfZWNjIHsKPiA+Pj4+ICAJdTMyIGJjaDsKPiA+Pj4+ICAJdTMyIHN0cmVuZ3Ro Owo+ID4+Pj4gKwl1MzIgc2l6ZTsKPiA+Pj4+ICB9Owo+ID4+Pj4gIAo+ID4+Pj4gIHN0cnVjdCBt ZXNvbl9uZmNfZGF0YSB7Cj4gPj4+PiBAQCAtMTkwLDcgKzE5MSw4IEBAIHN0cnVjdCBtZXNvbl9u ZmMgewo+ID4+Pj4gIH07Cj4gPj4+PiAgCj4gPj4+PiAgZW51bSB7Cj4gPj4+PiAtCU5GQ19FQ0Nf QkNIOF8xSwkJPSAyLAo+ID4+Pj4gKwlORkNfRUNDX0JDSDhfNTEyCT0gMSwKPiA+Pj4+ICsJTkZD X0VDQ19CQ0g4XzFLLAo+ID4+Pj4gIAlORkNfRUNDX0JDSDI0XzFLLAo+ID4+Pj4gIAlORkNfRUND X0JDSDMwXzFLLAo+ID4+Pj4gIAlORkNfRUNDX0JDSDQwXzFLLAo+ID4+Pj4gQEAgLTE5OCwxNSAr MjAwLDE2IEBAIGVudW0gewo+ID4+Pj4gIAlORkNfRUNDX0JDSDYwXzFLLAo+ID4+Pj4gIH07Cj4g Pj4+PiAgCj4gPj4+PiAtI2RlZmluZSBNRVNPTl9FQ0NfREFUQShiLCBzKQl7IC5iY2ggPSAoYiks CS5zdHJlbmd0aCA9IChzKX0KPiA+Pj4+ICsjZGVmaW5lIE1FU09OX0VDQ19EQVRBKGIsIHMsIHN6 KQl7IC5iY2ggPSAoYiksIC5zdHJlbmd0aCA9IChzKSwgLnNpemUgPSAoc3opIH0KPiA+Pj4+ICAK PiA+Pj4+ICBzdGF0aWMgc3RydWN0IG1lc29uX25hbmRfZWNjIG1lc29uX2VjY1tdID0gewo+ID4+ Pj4gLQlNRVNPTl9FQ0NfREFUQShORkNfRUNDX0JDSDhfMUssIDgpLAo+ID4+Pj4gLQlNRVNPTl9F Q0NfREFUQShORkNfRUNDX0JDSDI0XzFLLCAyNCksCj4gPj4+PiAtCU1FU09OX0VDQ19EQVRBKE5G Q19FQ0NfQkNIMzBfMUssIDMwKSwKPiA+Pj4+IC0JTUVTT05fRUNDX0RBVEEoTkZDX0VDQ19CQ0g0 MF8xSywgNDApLAo+ID4+Pj4gLQlNRVNPTl9FQ0NfREFUQShORkNfRUNDX0JDSDUwXzFLLCA1MCks Cj4gPj4+PiAtCU1FU09OX0VDQ19EQVRBKE5GQ19FQ0NfQkNINjBfMUssIDYwKSwKPiA+Pj4+ICsJ TUVTT05fRUNDX0RBVEEoTkZDX0VDQ19CQ0g4XzUxMiwgOCwgIDUxMiksCj4gPj4+PiArCU1FU09O X0VDQ19EQVRBKE5GQ19FQ0NfQkNIOF8xSywgIDgsICAxMDI0KSwKPiA+Pj4+ICsJTUVTT05fRUND X0RBVEEoTkZDX0VDQ19CQ0gyNF8xSywgMjQsIDEwMjQpLAo+ID4+Pj4gKwlNRVNPTl9FQ0NfREFU QShORkNfRUNDX0JDSDMwXzFLLCAzMCwgMTAyNCksCj4gPj4+PiArCU1FU09OX0VDQ19EQVRBKE5G Q19FQ0NfQkNINDBfMUssIDQwLCAxMDI0KSwKPiA+Pj4+ICsJTUVTT05fRUNDX0RBVEEoTkZDX0VD Q19CQ0g1MF8xSywgNTAsIDEwMjQpLAo+ID4+Pj4gKwlNRVNPTl9FQ0NfREFUQShORkNfRUNDX0JD SDYwXzFLLCA2MCwgMTAyNCksCj4gPj4+PiAgfTsKPiA+Pj4+ICAKPiA+Pj4+ICBzdGF0aWMgaW50 IG1lc29uX25hbmRfY2FsY19lY2NfYnl0ZXMoaW50IHN0ZXBfc2l6ZSwgaW50IHN0cmVuZ3RoKQo+ ID4+Pj4gQEAgLTIyNCw4ICsyMjcsMjcgQEAgc3RhdGljIGludCBtZXNvbl9uYW5kX2NhbGNfZWNj X2J5dGVzKGludCBzdGVwX3NpemUsIGludCBzdHJlbmd0aCkKPiA+Pj4+ICAKPiA+Pj4+ICBOQU5E X0VDQ19DQVBTX1NJTkdMRShtZXNvbl9neGxfZWNjX2NhcHMsCj4gPj4+PiAgCQkgICAgIG1lc29u X25hbmRfY2FsY19lY2NfYnl0ZXMsIDEwMjQsIDgsIDI0LCAzMCwgNDAsIDUwLCA2MCk7Cj4gPj4+ PiAtTkFORF9FQ0NfQ0FQU19TSU5HTEUobWVzb25fYXhnX2VjY19jYXBzLAo+ID4+Pj4gLQkJICAg ICBtZXNvbl9uYW5kX2NhbGNfZWNjX2J5dGVzLCAxMDI0LCA4KTsKPiA+Pj4+ICsKPiA+Pj4+ICtz dGF0aWMgY29uc3QgaW50IGF4Z19zdGVwaW5mb19zdHJlbmd0aHNbXSA9IHsgOCB9Owo+ID4+Pj4g K3N0YXRpYyBjb25zdCBzdHJ1Y3QgbmFuZF9lY2Nfc3RlcF9pbmZvIGF4Z19zdGVwaW5mb18xMDI0 ID0gewo+ID4+Pj4gKwkuc3RlcHNpemUgPSAxMDI0LAo+ID4+Pj4gKwkuc3RyZW5ndGhzID0gYXhn X3N0ZXBpbmZvX3N0cmVuZ3RocywKPiA+Pj4+ICsJLm5zdHJlbmd0aHMgPSBBUlJBWV9TSVpFKGF4 Z19zdGVwaW5mb19zdHJlbmd0aHMpCj4gPj4+PiArfTsKPiA+Pj4+ICsKPiA+Pj4+ICtzdGF0aWMg Y29uc3Qgc3RydWN0IG5hbmRfZWNjX3N0ZXBfaW5mbyBheGdfc3RlcGluZm9fNTEyID0gewo+ID4+ Pj4gKwkuc3RlcHNpemUgPSA1MTIsCj4gPj4+PiArCS5zdHJlbmd0aHMgPSBheGdfc3RlcGluZm9f c3RyZW5ndGhzLAo+ID4+Pj4gKwkubnN0cmVuZ3RocyA9IEFSUkFZX1NJWkUoYXhnX3N0ZXBpbmZv X3N0cmVuZ3RocykKPiA+Pj4+ICt9Owo+ID4+Pj4gKwo+ID4+Pj4gK3N0YXRpYyBjb25zdCBzdHJ1 Y3QgbmFuZF9lY2Nfc3RlcF9pbmZvIGF4Z19zdGVwaW5mb1tdID0geyBheGdfc3RlcGluZm9fMTAy NCwgYXhnX3N0ZXBpbmZvXzUxMiB9Owo+ID4+Pj4gKwo+ID4+Pj4gK3N0YXRpYyBjb25zdCBzdHJ1 Y3QgbmFuZF9lY2NfY2FwcyBtZXNvbl9heGdfZWNjX2NhcHMgPSB7Cj4gPj4+PiArCS5zdGVwaW5m b3MgPSBheGdfc3RlcGluZm8sCj4gPj4+PiArCS5uc3RlcGluZm9zID0gQVJSQVlfU0laRShheGdf c3RlcGluZm8pLAo+ID4+Pj4gKwkuY2FsY19lY2NfYnl0ZXMgPSBtZXNvbl9uYW5kX2NhbGNfZWNj X2J5dGVzLAo+ID4+Pj4gK307Cj4gPj4+PiAgCj4gPj4+PiAgc3RhdGljIHN0cnVjdCBtZXNvbl9u ZmNfbmFuZF9jaGlwICp0b19tZXNvbl9uYW5kKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQpCj4gPj4+ PiAgewo+ID4+Pj4gQEAgLTEyNTksNyArMTI4MSw4IEBAIHN0YXRpYyBpbnQgbWVzb25fbmFuZF9i Y2hfbW9kZShzdHJ1Y3QgbmFuZF9jaGlwICpuYW5kKQo+ID4+Pj4gIAkJcmV0dXJuIC1FSU5WQUw7 Cj4gPj4+PiAgCj4gPj4+PiAgCWZvciAoaSA9IDA7IGkgPCBBUlJBWV9TSVpFKG1lc29uX2VjYyk7 IGkrKykgewo+ID4+Pj4gLQkJaWYgKG1lc29uX2VjY1tpXS5zdHJlbmd0aCA9PSBuYW5kLT5lY2Mu c3RyZW5ndGgpIHsKPiA+Pj4+ICsJCWlmIChtZXNvbl9lY2NbaV0uc3RyZW5ndGggPT0gbmFuZC0+ ZWNjLnN0cmVuZ3RoICYmCj4gPj4+PiArCQkgICAgbWVzb25fZWNjW2ldLnNpemUgPT0gbmFuZC0+ ZWNjLnNpemUpIHsKPiA+Pj4+ICAJCQltZXNvbl9jaGlwLT5iY2hfbW9kZSA9IG1lc29uX2VjY1tp XS5iY2g7Cj4gPj4+PiAgCQkJcmV0dXJuIDA7Cj4gPj4+PiAgCQl9Cj4gPj4+PiBAQCAtMTI3OCw3 ICsxMzAxLDcgQEAgc3RhdGljIGludCBtZXNvbl9uYW5kX2F0dGFjaF9jaGlwKHN0cnVjdCBuYW5k X2NoaXAgKm5hbmQpCj4gPj4+PiAgCXN0cnVjdCBtZXNvbl9uZmMgKm5mYyA9IG5hbmRfZ2V0X2Nv bnRyb2xsZXJfZGF0YShuYW5kKTsKPiA+Pj4+ICAJc3RydWN0IG1lc29uX25mY19uYW5kX2NoaXAg Km1lc29uX2NoaXAgPSB0b19tZXNvbl9uYW5kKG5hbmQpOwo+ID4+Pj4gIAlzdHJ1Y3QgbXRkX2lu Zm8gKm10ZCA9IG5hbmRfdG9fbXRkKG5hbmQpOwo+ID4+Pj4gLQlpbnQgbnNlY3RvcnMgPSBtdGQt PndyaXRlc2l6ZSAvIDEwMjQ7Cj4gPj4+PiArCWludCBuc2VjdG9ycyA9IG10ZC0+d3JpdGVzaXpl IC8gNTEyOyAgICAKPiA+Pj4KPiA+Pj4gVGhpcyBjYW5ub3QgYmUgdW5jb25kaXRpb25hbCwgcmln aHQ/ICAgIAo+ID4+Cj4gPj4gSGVsbG8gTWlxdWVsIQo+ID4+Cj4gPj4gWWVzLCB0aGlzIGNvZGUg bG9va3Mgc3RyYW5nZS4gJ25zZWN0b3JzJyBpcyB1c2VkIHRvIGNhbGN1bGF0ZSBzcGFjZSBpbiBP T0IKPiA+PiB0aGF0IGNvdWxkIGJlIHVzZWQgYnkgRUNDIGVuZ2luZSAodGhpcyB2YWx1ZSB3aWxs IGJlIHBhc3NlZCBhcyAnb29iYXZhaWwnCj4gPj4gdG8gJ25hbmRfZWNjX2Nob29zZV9jb25mKCkn KS4gSWRlYSBvZiA1MTIgaXMgdG8gY29uc2lkZXIgIndvcnN0IiBjYXNlCj4gPj4gZm9yIEVDQywg ZS5nLiBtaW5pbWFsIG51bWJlciBvZiBieXRlcyBmb3IgRUNDIGVuZ2luZSAoYW5kIGF0IHRoZSBz YW1lIHRpbWUKPiA+PiBtYXhpbXVtIG51bWJlciBvZiBmcmVlIGJ5dGVzKS4gRm9yIE1lc29uLCBp ZiBFQ0Mgc3RlcCBzaXplIGlzIDUxMiwgdGhlbiB3ZQo+ID4+IGhhdmUgNCB4IDIgZnJlZSBieXRl cyBpbiBPT0IgKGlmIHN0ZXAgc2l6ZSBpZiAxMDI0IHRoZW4gd2UgaGF2ZSAyIHggMiBmcmVlCj4g Pj4gYnl0ZXMgaW4gT09CKS4KPiA+Pgo+ID4+IEkgdGhpbmsgdGhpcyBjb2RlIGNvdWxkIGJlIHJl d29ya2VkIGluIHRoZSBmb2xsb3dpbmcgd2F5Ogo+ID4+Cj4gPj4gaWYgRUNDIHN0ZXAgc2l6ZSBp cyBhbHJlYWR5IGtub3duIGhlcmUgKGZyb20gRFRTKSwgY2FsY3VsYXRlICduc2VjdG9ycycgdXNp bmcKPiA+PiBnaXZlbiB2YWx1ZSAoZGl2IGJ5IDUxMiBmb3IgZXhhbXBsZSkuIE90aGVyd2lzZSBj YWxjdWxhdGUgJ25zZWN0b3JzJyBpbiB0aGUKPiA+PiBjdXJyZW50IG1hbm5lcjogIAo+ID4gCj4g PiBJdCB3aWxsIGFsd2F5cyBiZSBrbm93biB3aGVuIHRoZXNlIGZ1bmN0aW9uIGFyZSBydW4uIFRo ZXJlIGlzIG5vCj4gPiBndWVzc2luZyBoZXJlLiAgCj4gCj4gSG0gSSBjaGVja2VkLCB0aGF0IGJ1 dCBpZiBzdGVwIHNpemUgaXMgbm90IHNldCBpbiBEVFMsIGhlcmUgaXQgd2lsbCBiZSAwLCAKPiB0 aGVuIGl0IHdpbGwgYmUgc2VsZWN0ZWQgaW4gJ25hbmRfZWNjX2Nob29zZV9jb25mKCknIGFjY29y ZGluZyBwcm92aWRlZCAnZWNjX2NhcHMnCj4gYW5kICdvb2JhdmFpbCcuLi4KPiAKPiBBbnl3YXks IEknbGwgZG8gdGhlIGZvbGxvd2luZyB0aGluZzoKPiAKPiBpbnQgbnNlY3RvcnM7Cj4gCj4gaWYg KG5hbmQtPmVjYy5zaXplKQo+ICAgICBuc2VjdG9ycyA9IG10ZC0+d3JpdGVzaXplIC8gbmFuZC0+ ZWNjLnNpemU7IDwtLS0gdGhpcyBpcyBmb3IgNTEyIEVDQwoKWW91IHNob3VsZCBzZXQgbmFuZC0+ ZWNjLnNpemUgaW4gLT5hdHRhY2hfY2hpcCgpIGluc3RlYWQuCgo+IGVsc2UKPiAgICAgbnNlY3Rv cnMgPSBtdGQtPndyaXRlc2l6ZSAvIDEwMjQ7IDwtLS0gdGhpcyBpcyBmb3IgZGVmYXVsdCAxMDI0 IEVDQwo+IAo+IFRoYW5rcywgQXJzZW5peQo+IAo+ID4gICAKPiA+Pgo+ID4+IGludCBuc2VjdG9y cyA9IG10ZC0+d3JpdGVzaXplIC8gMTAyNDsKPiA+Pgo+ID4+IE1vcmVvdmVyIDEwMjQgaXMgZGVm YXVsdCBFQ0Mgc3RlcCBzaXplIGZvciB0aGlzIGRyaXZlciwgc28gZGVmYXVsdCBiZWhhdmlvdXIK PiA+PiB3aWxsIGJlIHByZXNlcnZlZC4gIAo+ID4gCj4gPiBZZXMsIG90aGVyd2lzZSB5b3Ugd291 bGQgYnJlYWsgZXhpc3RpbmcgdXNlcnMuCj4gPiAgIAo+ID4+Cj4gPj4gVGhhbmtzLCBBcnNlbml5 Cj4gPj4gIAo+ID4+PiAgICAgCj4gPj4+PiAgCWludCByYXdfd3JpdGVzaXplOwo+ID4+Pj4gIAlp bnQgcmV0Owo+ID4+Pj4gICAgICAKPiA+Pj4KPiA+Pj4KPiA+Pj4gVGhhbmtzLAo+ID4+PiBNaXF1 w6hsICAgIAo+ID4gCj4gPiAKPiA+IFRoYW5rcywKPiA+IE1pcXXDqGwgIAoKClRoYW5rcywKTWlx dcOobAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt YXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D26EEB64D9 for ; Tue, 4 Jul 2023 09:56:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231280AbjGDJ4i (ORCPT ); Tue, 4 Jul 2023 05:56:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231255AbjGDJ4g (ORCPT ); Tue, 4 Jul 2023 05:56:36 -0400 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54F2AE5; Tue, 4 Jul 2023 02:56:34 -0700 (PDT) X-GND-Sasl: miquel.raynal@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1688464592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mMapt+1v6arSkASxO8Vo/k1eb4URuf8TQG4qlhn8MnA=; b=MqsYEmANYbQeHQzDbkLhMUahxnUMbuzqWizhWc2AjfbV/tbNF8tsEpgVAK0lHnZt7SADVD pj9s56P5VDsQkjoDpoN4gz4JDh35m0ZolCz6wDDkrfZ6jqETug28jcpXZf9j6iAtbe1zxO UveLyrixfCgqolvN/xfNUfyIA/4tJsx3Rnm1Xu/gtIgrXW9vPY3t1vZP0cIgnXSWJfd/v4 DlPL6/xCmg++MDDhsv0w1zlQCG4DKii69CLqch37HeqTjxwLgOboN9ph6LGjG4DTxVoVcm Zag5KVmebxeQKwJ8ap/rMOiC40SKCt98ZFZBN1AlRFKQBk/FwPwVAtCWINO2Aw== X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id D4F882000C; Tue, 4 Jul 2023 09:56:29 +0000 (UTC) Date: Tue, 4 Jul 2023 11:56:28 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , , , , , , , Subject: Re: [RFC PATCH v1 2/2] mtd: rawnand: meson: support for 512B ECC step size Message-ID: <20230704115628.55320428@xps-13> In-Reply-To: References: <20230628092937.538683-1-AVKrasnov@sberdevices.ru> <20230628092937.538683-3-AVKrasnov@sberdevices.ru> <20230704103617.4affae8a@xps-13> <9e6eaa87-887c-f955-113a-43860c8ea00c@sberdevices.ru> <20230704114110.25ca9de4@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Arseniy, avkrasnov@sberdevices.ru wrote on Tue, 4 Jul 2023 12:46:51 +0300: > On 04.07.2023 12:41, Miquel Raynal wrote: > > Hi Arseniy, > >=20 > > avkrasnov@sberdevices.ru wrote on Tue, 4 Jul 2023 12:23:03 +0300: > > =20 > >> On 04.07.2023 11:36, Miquel Raynal wrote: =20 > >>> Hi Arseniy, > >>> > >>> AVKrasnov@sberdevices.ru wrote on Wed, 28 Jun 2023 12:29:36 +0300: > >>> =20 > >>>> Meson NAND supports both 512B and 1024B ECC step size. > >>>> > >>>> Signed-off-by: Arseniy Krasnov > >>>> --- > >>>> drivers/mtd/nand/raw/meson_nand.c | 47 +++++++++++++++++++++++-----= --- > >>>> 1 file changed, 35 insertions(+), 12 deletions(-) > >>>> > >>>> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/ra= w/meson_nand.c > >>>> index 345212e8c691..6cc4f63b86c8 100644 > >>>> --- a/drivers/mtd/nand/raw/meson_nand.c > >>>> +++ b/drivers/mtd/nand/raw/meson_nand.c > >>>> @@ -135,6 +135,7 @@ struct meson_nfc_nand_chip { > >>>> struct meson_nand_ecc { > >>>> u32 bch; > >>>> u32 strength; > >>>> + u32 size; > >>>> }; > >>>> =20 > >>>> struct meson_nfc_data { > >>>> @@ -190,7 +191,8 @@ struct meson_nfc { > >>>> }; > >>>> =20 > >>>> enum { > >>>> - NFC_ECC_BCH8_1K =3D 2, > >>>> + NFC_ECC_BCH8_512 =3D 1, > >>>> + NFC_ECC_BCH8_1K, > >>>> NFC_ECC_BCH24_1K, > >>>> NFC_ECC_BCH30_1K, > >>>> NFC_ECC_BCH40_1K, > >>>> @@ -198,15 +200,16 @@ enum { > >>>> NFC_ECC_BCH60_1K, > >>>> }; > >>>> =20 > >>>> -#define MESON_ECC_DATA(b, s) { .bch =3D (b), .strength =3D (s)} > >>>> +#define MESON_ECC_DATA(b, s, sz) { .bch =3D (b), .strength =3D (s),= .size =3D (sz) } > >>>> =20 > >>>> static struct meson_nand_ecc meson_ecc[] =3D { > >>>> - MESON_ECC_DATA(NFC_ECC_BCH8_1K, 8), > >>>> - MESON_ECC_DATA(NFC_ECC_BCH24_1K, 24), > >>>> - MESON_ECC_DATA(NFC_ECC_BCH30_1K, 30), > >>>> - MESON_ECC_DATA(NFC_ECC_BCH40_1K, 40), > >>>> - MESON_ECC_DATA(NFC_ECC_BCH50_1K, 50), > >>>> - MESON_ECC_DATA(NFC_ECC_BCH60_1K, 60), > >>>> + MESON_ECC_DATA(NFC_ECC_BCH8_512, 8, 512), > >>>> + MESON_ECC_DATA(NFC_ECC_BCH8_1K, 8, 1024), > >>>> + MESON_ECC_DATA(NFC_ECC_BCH24_1K, 24, 1024), > >>>> + MESON_ECC_DATA(NFC_ECC_BCH30_1K, 30, 1024), > >>>> + MESON_ECC_DATA(NFC_ECC_BCH40_1K, 40, 1024), > >>>> + MESON_ECC_DATA(NFC_ECC_BCH50_1K, 50, 1024), > >>>> + MESON_ECC_DATA(NFC_ECC_BCH60_1K, 60, 1024), > >>>> }; > >>>> =20 > >>>> static int meson_nand_calc_ecc_bytes(int step_size, int strength) > >>>> @@ -224,8 +227,27 @@ static int meson_nand_calc_ecc_bytes(int step_s= ize, int strength) > >>>> =20 > >>>> NAND_ECC_CAPS_SINGLE(meson_gxl_ecc_caps, > >>>> meson_nand_calc_ecc_bytes, 1024, 8, 24, 30, 40, 50, 60); > >>>> -NAND_ECC_CAPS_SINGLE(meson_axg_ecc_caps, > >>>> - meson_nand_calc_ecc_bytes, 1024, 8); > >>>> + > >>>> +static const int axg_stepinfo_strengths[] =3D { 8 }; > >>>> +static const struct nand_ecc_step_info axg_stepinfo_1024 =3D { > >>>> + .stepsize =3D 1024, > >>>> + .strengths =3D axg_stepinfo_strengths, > >>>> + .nstrengths =3D ARRAY_SIZE(axg_stepinfo_strengths) > >>>> +}; > >>>> + > >>>> +static const struct nand_ecc_step_info axg_stepinfo_512 =3D { > >>>> + .stepsize =3D 512, > >>>> + .strengths =3D axg_stepinfo_strengths, > >>>> + .nstrengths =3D ARRAY_SIZE(axg_stepinfo_strengths) > >>>> +}; > >>>> + > >>>> +static const struct nand_ecc_step_info axg_stepinfo[] =3D { axg_ste= pinfo_1024, axg_stepinfo_512 }; > >>>> + > >>>> +static const struct nand_ecc_caps meson_axg_ecc_caps =3D { > >>>> + .stepinfos =3D axg_stepinfo, > >>>> + .nstepinfos =3D ARRAY_SIZE(axg_stepinfo), > >>>> + .calc_ecc_bytes =3D meson_nand_calc_ecc_bytes, > >>>> +}; > >>>> =20 > >>>> static struct meson_nfc_nand_chip *to_meson_nand(struct nand_chip *= nand) > >>>> { > >>>> @@ -1259,7 +1281,8 @@ static int meson_nand_bch_mode(struct nand_chi= p *nand) > >>>> return -EINVAL; > >>>> =20 > >>>> for (i =3D 0; i < ARRAY_SIZE(meson_ecc); i++) { > >>>> - if (meson_ecc[i].strength =3D=3D nand->ecc.strength) { > >>>> + if (meson_ecc[i].strength =3D=3D nand->ecc.strength && > >>>> + meson_ecc[i].size =3D=3D nand->ecc.size) { > >>>> meson_chip->bch_mode =3D meson_ecc[i].bch; > >>>> return 0; > >>>> } > >>>> @@ -1278,7 +1301,7 @@ static int meson_nand_attach_chip(struct nand_= chip *nand) > >>>> struct meson_nfc *nfc =3D nand_get_controller_data(nand); > >>>> struct meson_nfc_nand_chip *meson_chip =3D to_meson_nand(nand); > >>>> struct mtd_info *mtd =3D nand_to_mtd(nand); > >>>> - int nsectors =3D mtd->writesize / 1024; > >>>> + int nsectors =3D mtd->writesize / 512; =20 > >>> > >>> This cannot be unconditional, right? =20 > >> > >> Hello Miquel! > >> > >> Yes, this code looks strange. 'nsectors' is used to calculate space in= OOB > >> that could be used by ECC engine (this value will be passed as 'oobava= il' > >> to 'nand_ecc_choose_conf()'). Idea of 512 is to consider "worst" case > >> for ECC, e.g. minimal number of bytes for ECC engine (and at the same = time > >> maximum number of free bytes). For Meson, if ECC step size is 512, the= n we > >> have 4 x 2 free bytes in OOB (if step size if 1024 then we have 2 x 2 = free > >> bytes in OOB). > >> > >> I think this code could be reworked in the following way: > >> > >> if ECC step size is already known here (from DTS), calculate 'nsectors= ' using > >> given value (div by 512 for example). Otherwise calculate 'nsectors' i= n the > >> current manner: =20 > >=20 > > It will always be known when these function are run. There is no > > guessing here. =20 >=20 > Hm I checked, that but if step size is not set in DTS, here it will be 0,= =20 > then it will be selected in 'nand_ecc_choose_conf()' according provided '= ecc_caps' > and 'oobavail'... >=20 > Anyway, I'll do the following thing: >=20 > int nsectors; >=20 > if (nand->ecc.size) > nsectors =3D mtd->writesize / nand->ecc.size; <--- this is for 512 ECC You should set nand->ecc.size in ->attach_chip() instead. > else > nsectors =3D mtd->writesize / 1024; <--- this is for default 1024 ECC >=20 > Thanks, Arseniy >=20 > > =20 > >> > >> int nsectors =3D mtd->writesize / 1024; > >> > >> Moreover 1024 is default ECC step size for this driver, so default beh= aviour > >> will be preserved. =20 > >=20 > > Yes, otherwise you would break existing users. > > =20 > >> > >> Thanks, Arseniy > >> =20 > >>> =20 > >>>> int raw_writesize; > >>>> int ret; > >>>> =20 > >>> > >>> > >>> Thanks, > >>> Miqu=C3=A8l =20 > >=20 > >=20 > > Thanks, > > Miqu=C3=A8l =20 Thanks, Miqu=C3=A8l