From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBD1AEB64DA for ; Tue, 4 Jul 2023 13:41:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jAPf1FdhdKw0geBRv+4P5u7TUitU7lDwE45lbZn6Xx8=; b=ep1Yjlt81ILtfF ddIb4kjTqxT7mXzsY1xuZ/xKIb89xNuoSk898Wh+EMir/eQK9O9ary42entagiZBCKWsYGWbmO2b2 cypUdokI5CgziUDCTFevg6Kp0UfStiNJ4qmXEhKZs9rfVKB8YqYOar7yO9ADY+nMkDPk6phgy4OKr 1B1EdugxRA7W5RSxHwzeLW/WCTzNRwxP5x2562tDMEJ8SIvTMEsv4bLw2zZcCvU1laAO9viiWKBeA KRB83l2EWBR732IKXY8AXfAj+j35AxE/quX2JpW9xgU4yTDBgdWjSnPlIrLKOduaRl18cr03cTQi1 Tkn3SPUPXdLsmt3F4b/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGgHQ-00DQCE-0R; Tue, 04 Jul 2023 13:41:20 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGgHM-00DQAQ-1v; Tue, 04 Jul 2023 13:41:18 +0000 X-GND-Sasl: miquel.raynal@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1688478072; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QJLhG5xef0Dm9kVxipRfJ1zAKqJpL9r++IajKk5AkNU=; b=pZo+4NrPp2dycBIRoGMvUMInSYsTFLDpojazcKafyNd55aRmC80dmZ1TZdYaeVs3mfgjBE z6ngQq4XpQ7bf5wQ2kp6Wzt7xDHanylnonV7EkM+d+LnLuDobkEPsoLkh+3gpPDbbgwy29 vbjXtpOZPjanZTztmEfCWazX4Lgpl+QXBjT/gdKdhQcq1+x+DdcRUuscmFGFmhgGn/2V6H vCyMqXZ2ZVDsIKLbSwQGOD2dMUUzCWV/hB7/CdX44FztFNvbk5M+8U0Zr2R6dumBq+AmIY 9VbRtRlJnIx8NOokmg9NJjeqGgYG+rmqreo7wsMxVxuXqXZIPGyqvZVsvtM/fQ== X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 6F5DEC000B; Tue, 4 Jul 2023 13:41:08 +0000 (UTC) Date: Tue, 4 Jul 2023 15:41:06 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , , , , , , , Subject: Re: [RFC PATCH v1 2/2] mtd: rawnand: meson: support for 512B ECC step size Message-ID: <20230704154106.5c5aafd8@xps-13> In-Reply-To: References: <20230628092937.538683-1-AVKrasnov@sberdevices.ru> <20230628092937.538683-3-AVKrasnov@sberdevices.ru> <20230704103617.4affae8a@xps-13> <9e6eaa87-887c-f955-113a-43860c8ea00c@sberdevices.ru> <20230704114110.25ca9de4@xps-13> <20230704115628.55320428@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230704_064117_065770_506A6C42 X-CRM114-Status: GOOD ( 21.04 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org SGkgQXJzZW5peSwKCj4gPj4+PiBZZXMsIHRoaXMgY29kZSBsb29rcyBzdHJhbmdlLiAnbnNlY3Rv cnMnIGlzIHVzZWQgdG8gY2FsY3VsYXRlIHNwYWNlIGluIE9PQgo+ID4+Pj4gdGhhdCBjb3VsZCBi ZSB1c2VkIGJ5IEVDQyBlbmdpbmUgKHRoaXMgdmFsdWUgd2lsbCBiZSBwYXNzZWQgYXMgJ29vYmF2 YWlsJwo+ID4+Pj4gdG8gJ25hbmRfZWNjX2Nob29zZV9jb25mKCknKS4gSWRlYSBvZiA1MTIgaXMg dG8gY29uc2lkZXIgIndvcnN0IiBjYXNlCj4gPj4+PiBmb3IgRUNDLCBlLmcuIG1pbmltYWwgbnVt YmVyIG9mIGJ5dGVzIGZvciBFQ0MgZW5naW5lIChhbmQgYXQgdGhlIHNhbWUgdGltZQo+ID4+Pj4g bWF4aW11bSBudW1iZXIgb2YgZnJlZSBieXRlcykuIEZvciBNZXNvbiwgaWYgRUNDIHN0ZXAgc2l6 ZSBpcyA1MTIsIHRoZW4gd2UKPiA+Pj4+IGhhdmUgNCB4IDIgZnJlZSBieXRlcyBpbiBPT0IgKGlm IHN0ZXAgc2l6ZSBpZiAxMDI0IHRoZW4gd2UgaGF2ZSAyIHggMiBmcmVlCj4gPj4+PiBieXRlcyBp biBPT0IpLgo+ID4+Pj4KPiA+Pj4+IEkgdGhpbmsgdGhpcyBjb2RlIGNvdWxkIGJlIHJld29ya2Vk IGluIHRoZSBmb2xsb3dpbmcgd2F5Ogo+ID4+Pj4KPiA+Pj4+IGlmIEVDQyBzdGVwIHNpemUgaXMg YWxyZWFkeSBrbm93biBoZXJlIChmcm9tIERUUyksIGNhbGN1bGF0ZSAnbnNlY3RvcnMnIHVzaW5n Cj4gPj4+PiBnaXZlbiB2YWx1ZSAoZGl2IGJ5IDUxMiBmb3IgZXhhbXBsZSkuIE90aGVyd2lzZSBj YWxjdWxhdGUgJ25zZWN0b3JzJyBpbiB0aGUKPiA+Pj4+IGN1cnJlbnQgbWFubmVyOiAgICAKPiA+ Pj4KPiA+Pj4gSXQgd2lsbCBhbHdheXMgYmUga25vd24gd2hlbiB0aGVzZSBmdW5jdGlvbiBhcmUg cnVuLiBUaGVyZSBpcyBubwo+ID4+PiBndWVzc2luZyBoZXJlLiAgICAKPiA+Pgo+ID4+IEhtIEkg Y2hlY2tlZCwgdGhhdCBidXQgaWYgc3RlcCBzaXplIGlzIG5vdCBzZXQgaW4gRFRTLCBoZXJlIGl0 IHdpbGwgYmUgMCwgCj4gPj4gdGhlbiBpdCB3aWxsIGJlIHNlbGVjdGVkIGluICduYW5kX2VjY19j aG9vc2VfY29uZigpJyBhY2NvcmRpbmcgcHJvdmlkZWQgJ2VjY19jYXBzJwo+ID4+IGFuZCAnb29i YXZhaWwnLi4uCj4gPj4KPiA+PiBBbnl3YXksIEknbGwgZG8gdGhlIGZvbGxvd2luZyB0aGluZzoK PiA+Pgo+ID4+IGludCBuc2VjdG9yczsKPiA+Pgo+ID4+IGlmIChuYW5kLT5lY2Muc2l6ZSkKPiA+ PiAgICAgbnNlY3RvcnMgPSBtdGQtPndyaXRlc2l6ZSAvIG5hbmQtPmVjYy5zaXplOyA8LS0tIHRo aXMgaXMgZm9yIDUxMiBFQ0MgIAo+ID4gCj4gPiBZb3Ugc2hvdWxkIHNldCBuYW5kLT5lY2Muc2l6 ZSBpbiAtPmF0dGFjaF9jaGlwKCkgaW5zdGVhZC4gIAo+IAo+IFNvcnJ5LCBkaWRuJ3QgZ2V0IGl0 Li4uIGlmIEVDQyBzdGVwIHNpemUgaXMgc2V0IGluIERUUywgdGhlbiBoZXJlLCBpbiBjaGlwIGF0 dGFjaAo+IGNhbGxiYWNrIGl0IHdpbGwgYmUgYWxyZWFkeSBrbm93biAoRFQgcGFydCB3YXMgcHJv Y2Vzc2VkIGluICdyYXduYW5kX2R0X2luaXQoKScpLgo+IElmIEVDQyBzdGVwIHNpemUgaXMgdW5r bm93biAoZS5nLiAwIGhlcmUpLCAnbmFuZF9lY2NfY2hvb3NlX2NvbmYoKScgd2lsbCBzZXQgaXQK PiBhY2NvcmRpbmcgcHJvdmlkZWQgZWNjIGNhcHMuIFdoYXQgZG8gWW91IG1lYW4gZm9yICJZb3Ug c2hvdWxkIHNldCAuLi4iID8KClRoZSBjdXJyZW50IGFwcHJvYWNoIGlzIHdyb25nLCBpdCBkZWNp ZGVzIHRoZSBudW1iZXIgb2YgRUNDIGNodW5rcwooY2FsbGVkIG5zZWN0b3JzIGluIHRoZSBkcml2 ZXIpIGFuZCB0aGVuIGFza3MgdGhlIGNvcmUgdG8gZGVjaWRlIHRoZQpudW1iZXIgb2YgRUNDIGNo dW5rcyB0byB1c2UuCgpKdXN0IHByb3ZpZGUgbXRkLT5vb2JzaXplIC0gMiBhcyBsYXN0IHBhcmFt ZXRlciBhbmQgdGhlbiByZWx5IG9uIHRoZQpjb3JlJ3MgbG9naWMgdG8gZmluZCB0aGUgcmlnaHQg RUNDIHN0ZXAtc2l6ZS9zdHJlbmd0aD8KClRoZXJlIGlzIG5vIHBvaW50IGluIHJlcXVlc3Rpbmcg YSBwYXJ0aWN1bGFyIHN0ZXAgc2l6ZSB3aXRob3V0IGEKc3BlY2lmaWMgc3RyZW5ndGgsIG9yPyBT byBJIGJlbGlldmUgeW91IHNob3VsZCBwcm92aWRlIGJvdGggaW4gdGhlIERUUwppZiB5b3Ugd2Fu dCBwYXJ0aWN1bGFyIHBhcmFtZXRlcnMgdG8gYmUgYXBwbGllZCwgb3RoZXJ3aXNlIHlvdSBjYW4g bGV0CnRoZSBjb3JlIGRlY2lkZSB3aGF0IGlzIGJlc3QuCgpUaGFua3MsCk1pcXXDqGwKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFtbG9naWMg bWFpbGluZyBsaXN0CmxpbnV4LWFtbG9naWNAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFtbG9naWMK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7684EEB64DD for ; Tue, 4 Jul 2023 13:41:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H6c+T/5EsZGRioPc08PxrakJmRmV68paqXqP/qUmzMc=; b=M+OJoqal07Kbn5 hzKcw1Sm2Yd87kDsxEsx9Y32qVAXNlNooQ+hbyL23OCtixy0wd0VtEIBAfDkgB3TQVQYvNbj8099u Q62o3knRW+k2Q02gqgs654fuY3eDIFvEAl9lKcJeI8Mub0QqQ56cebVCMsWN6GD47Q/8lVhJPJmfb hGSH9r2dw58Ooy0VVrzy5IGyeWSc9dUfLwdB9r8MdOem1w8GNJzfDwanGIj8bbgK0dl3N41C00hIi BvAm+v2JInRCQqQJuo2555plhQwkLC4U8IJWvLv/B9zMiiia0EuO2DRYIuZrXJBfhzzHLuGKNgd5h TGBg55CTLqeH7M8f5kUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGgHR-00DQCw-0R; Tue, 04 Jul 2023 13:41:21 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGgHM-00DQAQ-1v; Tue, 04 Jul 2023 13:41:18 +0000 X-GND-Sasl: miquel.raynal@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1688478072; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QJLhG5xef0Dm9kVxipRfJ1zAKqJpL9r++IajKk5AkNU=; b=pZo+4NrPp2dycBIRoGMvUMInSYsTFLDpojazcKafyNd55aRmC80dmZ1TZdYaeVs3mfgjBE z6ngQq4XpQ7bf5wQ2kp6Wzt7xDHanylnonV7EkM+d+LnLuDobkEPsoLkh+3gpPDbbgwy29 vbjXtpOZPjanZTztmEfCWazX4Lgpl+QXBjT/gdKdhQcq1+x+DdcRUuscmFGFmhgGn/2V6H vCyMqXZ2ZVDsIKLbSwQGOD2dMUUzCWV/hB7/CdX44FztFNvbk5M+8U0Zr2R6dumBq+AmIY 9VbRtRlJnIx8NOokmg9NJjeqGgYG+rmqreo7wsMxVxuXqXZIPGyqvZVsvtM/fQ== X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 6F5DEC000B; Tue, 4 Jul 2023 13:41:08 +0000 (UTC) Date: Tue, 4 Jul 2023 15:41:06 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , , , , , , , Subject: Re: [RFC PATCH v1 2/2] mtd: rawnand: meson: support for 512B ECC step size Message-ID: <20230704154106.5c5aafd8@xps-13> In-Reply-To: References: <20230628092937.538683-1-AVKrasnov@sberdevices.ru> <20230628092937.538683-3-AVKrasnov@sberdevices.ru> <20230704103617.4affae8a@xps-13> <9e6eaa87-887c-f955-113a-43860c8ea00c@sberdevices.ru> <20230704114110.25ca9de4@xps-13> <20230704115628.55320428@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230704_064117_065770_506A6C42 X-CRM114-Status: GOOD ( 21.04 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgQXJzZW5peSwKCj4gPj4+PiBZZXMsIHRoaXMgY29kZSBsb29rcyBzdHJhbmdlLiAnbnNlY3Rv cnMnIGlzIHVzZWQgdG8gY2FsY3VsYXRlIHNwYWNlIGluIE9PQgo+ID4+Pj4gdGhhdCBjb3VsZCBi ZSB1c2VkIGJ5IEVDQyBlbmdpbmUgKHRoaXMgdmFsdWUgd2lsbCBiZSBwYXNzZWQgYXMgJ29vYmF2 YWlsJwo+ID4+Pj4gdG8gJ25hbmRfZWNjX2Nob29zZV9jb25mKCknKS4gSWRlYSBvZiA1MTIgaXMg dG8gY29uc2lkZXIgIndvcnN0IiBjYXNlCj4gPj4+PiBmb3IgRUNDLCBlLmcuIG1pbmltYWwgbnVt YmVyIG9mIGJ5dGVzIGZvciBFQ0MgZW5naW5lIChhbmQgYXQgdGhlIHNhbWUgdGltZQo+ID4+Pj4g bWF4aW11bSBudW1iZXIgb2YgZnJlZSBieXRlcykuIEZvciBNZXNvbiwgaWYgRUNDIHN0ZXAgc2l6 ZSBpcyA1MTIsIHRoZW4gd2UKPiA+Pj4+IGhhdmUgNCB4IDIgZnJlZSBieXRlcyBpbiBPT0IgKGlm IHN0ZXAgc2l6ZSBpZiAxMDI0IHRoZW4gd2UgaGF2ZSAyIHggMiBmcmVlCj4gPj4+PiBieXRlcyBp biBPT0IpLgo+ID4+Pj4KPiA+Pj4+IEkgdGhpbmsgdGhpcyBjb2RlIGNvdWxkIGJlIHJld29ya2Vk IGluIHRoZSBmb2xsb3dpbmcgd2F5Ogo+ID4+Pj4KPiA+Pj4+IGlmIEVDQyBzdGVwIHNpemUgaXMg YWxyZWFkeSBrbm93biBoZXJlIChmcm9tIERUUyksIGNhbGN1bGF0ZSAnbnNlY3RvcnMnIHVzaW5n Cj4gPj4+PiBnaXZlbiB2YWx1ZSAoZGl2IGJ5IDUxMiBmb3IgZXhhbXBsZSkuIE90aGVyd2lzZSBj YWxjdWxhdGUgJ25zZWN0b3JzJyBpbiB0aGUKPiA+Pj4+IGN1cnJlbnQgbWFubmVyOiAgICAKPiA+ Pj4KPiA+Pj4gSXQgd2lsbCBhbHdheXMgYmUga25vd24gd2hlbiB0aGVzZSBmdW5jdGlvbiBhcmUg cnVuLiBUaGVyZSBpcyBubwo+ID4+PiBndWVzc2luZyBoZXJlLiAgICAKPiA+Pgo+ID4+IEhtIEkg Y2hlY2tlZCwgdGhhdCBidXQgaWYgc3RlcCBzaXplIGlzIG5vdCBzZXQgaW4gRFRTLCBoZXJlIGl0 IHdpbGwgYmUgMCwgCj4gPj4gdGhlbiBpdCB3aWxsIGJlIHNlbGVjdGVkIGluICduYW5kX2VjY19j aG9vc2VfY29uZigpJyBhY2NvcmRpbmcgcHJvdmlkZWQgJ2VjY19jYXBzJwo+ID4+IGFuZCAnb29i YXZhaWwnLi4uCj4gPj4KPiA+PiBBbnl3YXksIEknbGwgZG8gdGhlIGZvbGxvd2luZyB0aGluZzoK PiA+Pgo+ID4+IGludCBuc2VjdG9yczsKPiA+Pgo+ID4+IGlmIChuYW5kLT5lY2Muc2l6ZSkKPiA+ PiAgICAgbnNlY3RvcnMgPSBtdGQtPndyaXRlc2l6ZSAvIG5hbmQtPmVjYy5zaXplOyA8LS0tIHRo aXMgaXMgZm9yIDUxMiBFQ0MgIAo+ID4gCj4gPiBZb3Ugc2hvdWxkIHNldCBuYW5kLT5lY2Muc2l6 ZSBpbiAtPmF0dGFjaF9jaGlwKCkgaW5zdGVhZC4gIAo+IAo+IFNvcnJ5LCBkaWRuJ3QgZ2V0IGl0 Li4uIGlmIEVDQyBzdGVwIHNpemUgaXMgc2V0IGluIERUUywgdGhlbiBoZXJlLCBpbiBjaGlwIGF0 dGFjaAo+IGNhbGxiYWNrIGl0IHdpbGwgYmUgYWxyZWFkeSBrbm93biAoRFQgcGFydCB3YXMgcHJv Y2Vzc2VkIGluICdyYXduYW5kX2R0X2luaXQoKScpLgo+IElmIEVDQyBzdGVwIHNpemUgaXMgdW5r bm93biAoZS5nLiAwIGhlcmUpLCAnbmFuZF9lY2NfY2hvb3NlX2NvbmYoKScgd2lsbCBzZXQgaXQK PiBhY2NvcmRpbmcgcHJvdmlkZWQgZWNjIGNhcHMuIFdoYXQgZG8gWW91IG1lYW4gZm9yICJZb3Ug c2hvdWxkIHNldCAuLi4iID8KClRoZSBjdXJyZW50IGFwcHJvYWNoIGlzIHdyb25nLCBpdCBkZWNp ZGVzIHRoZSBudW1iZXIgb2YgRUNDIGNodW5rcwooY2FsbGVkIG5zZWN0b3JzIGluIHRoZSBkcml2 ZXIpIGFuZCB0aGVuIGFza3MgdGhlIGNvcmUgdG8gZGVjaWRlIHRoZQpudW1iZXIgb2YgRUNDIGNo dW5rcyB0byB1c2UuCgpKdXN0IHByb3ZpZGUgbXRkLT5vb2JzaXplIC0gMiBhcyBsYXN0IHBhcmFt ZXRlciBhbmQgdGhlbiByZWx5IG9uIHRoZQpjb3JlJ3MgbG9naWMgdG8gZmluZCB0aGUgcmlnaHQg RUNDIHN0ZXAtc2l6ZS9zdHJlbmd0aD8KClRoZXJlIGlzIG5vIHBvaW50IGluIHJlcXVlc3Rpbmcg YSBwYXJ0aWN1bGFyIHN0ZXAgc2l6ZSB3aXRob3V0IGEKc3BlY2lmaWMgc3RyZW5ndGgsIG9yPyBT byBJIGJlbGlldmUgeW91IHNob3VsZCBwcm92aWRlIGJvdGggaW4gdGhlIERUUwppZiB5b3Ugd2Fu dCBwYXJ0aWN1bGFyIHBhcmFtZXRlcnMgdG8gYmUgYXBwbGllZCwgb3RoZXJ3aXNlIHlvdSBjYW4g bGV0CnRoZSBjb3JlIGRlY2lkZSB3aGF0IGlzIGJlc3QuCgpUaGFua3MsCk1pcXXDqGwKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eCBN VEQgZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51EF5EB64D9 for ; Tue, 4 Jul 2023 13:41:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DS/BdIag4ly8dlu9Tvl2Ec26g/NFynfISEzs/5t1OEw=; b=xYdIHsqGaLurrC 36OO8GtXM+RWVsk7PMIUgb2eDhT+MbLOQzRGtRZmUCmbHx3V1E8t7qy1fxR/L2giXNMruCpSyxE8M 8G2ZD4ndDgWFhp7mgW1zPnvNHJJehJrhOYZRkrCAbNXgjI6o4cOAaadTg+seMckqYO/bg6pqxghZS 4VB/aZiNNzXvGaSQEfoGXcYdponkrSbMN2glkZ3XP7XlzxdylmbaYT7A0w7jC0gbZH7WfKlEYfhD7 u9dmD6uviR1zB4Z6UTEJHVKsUX0au5vPEEoMOYb2u1hJkwN8aHTG6g0xuQh9mM7bgvP/Qu2bANRr5 zIEf7sP3EJ2o+IoAgVAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGgHQ-00DQCZ-1l; Tue, 04 Jul 2023 13:41:20 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGgHM-00DQAQ-1v; Tue, 04 Jul 2023 13:41:18 +0000 X-GND-Sasl: miquel.raynal@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1688478072; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QJLhG5xef0Dm9kVxipRfJ1zAKqJpL9r++IajKk5AkNU=; b=pZo+4NrPp2dycBIRoGMvUMInSYsTFLDpojazcKafyNd55aRmC80dmZ1TZdYaeVs3mfgjBE z6ngQq4XpQ7bf5wQ2kp6Wzt7xDHanylnonV7EkM+d+LnLuDobkEPsoLkh+3gpPDbbgwy29 vbjXtpOZPjanZTztmEfCWazX4Lgpl+QXBjT/gdKdhQcq1+x+DdcRUuscmFGFmhgGn/2V6H vCyMqXZ2ZVDsIKLbSwQGOD2dMUUzCWV/hB7/CdX44FztFNvbk5M+8U0Zr2R6dumBq+AmIY 9VbRtRlJnIx8NOokmg9NJjeqGgYG+rmqreo7wsMxVxuXqXZIPGyqvZVsvtM/fQ== X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 6F5DEC000B; Tue, 4 Jul 2023 13:41:08 +0000 (UTC) Date: Tue, 4 Jul 2023 15:41:06 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , , , , , , , Subject: Re: [RFC PATCH v1 2/2] mtd: rawnand: meson: support for 512B ECC step size Message-ID: <20230704154106.5c5aafd8@xps-13> In-Reply-To: References: <20230628092937.538683-1-AVKrasnov@sberdevices.ru> <20230628092937.538683-3-AVKrasnov@sberdevices.ru> <20230704103617.4affae8a@xps-13> <9e6eaa87-887c-f955-113a-43860c8ea00c@sberdevices.ru> <20230704114110.25ca9de4@xps-13> <20230704115628.55320428@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230704_064117_065770_506A6C42 X-CRM114-Status: GOOD ( 21.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgQXJzZW5peSwKCj4gPj4+PiBZZXMsIHRoaXMgY29kZSBsb29rcyBzdHJhbmdlLiAnbnNlY3Rv cnMnIGlzIHVzZWQgdG8gY2FsY3VsYXRlIHNwYWNlIGluIE9PQgo+ID4+Pj4gdGhhdCBjb3VsZCBi ZSB1c2VkIGJ5IEVDQyBlbmdpbmUgKHRoaXMgdmFsdWUgd2lsbCBiZSBwYXNzZWQgYXMgJ29vYmF2 YWlsJwo+ID4+Pj4gdG8gJ25hbmRfZWNjX2Nob29zZV9jb25mKCknKS4gSWRlYSBvZiA1MTIgaXMg dG8gY29uc2lkZXIgIndvcnN0IiBjYXNlCj4gPj4+PiBmb3IgRUNDLCBlLmcuIG1pbmltYWwgbnVt YmVyIG9mIGJ5dGVzIGZvciBFQ0MgZW5naW5lIChhbmQgYXQgdGhlIHNhbWUgdGltZQo+ID4+Pj4g bWF4aW11bSBudW1iZXIgb2YgZnJlZSBieXRlcykuIEZvciBNZXNvbiwgaWYgRUNDIHN0ZXAgc2l6 ZSBpcyA1MTIsIHRoZW4gd2UKPiA+Pj4+IGhhdmUgNCB4IDIgZnJlZSBieXRlcyBpbiBPT0IgKGlm IHN0ZXAgc2l6ZSBpZiAxMDI0IHRoZW4gd2UgaGF2ZSAyIHggMiBmcmVlCj4gPj4+PiBieXRlcyBp biBPT0IpLgo+ID4+Pj4KPiA+Pj4+IEkgdGhpbmsgdGhpcyBjb2RlIGNvdWxkIGJlIHJld29ya2Vk IGluIHRoZSBmb2xsb3dpbmcgd2F5Ogo+ID4+Pj4KPiA+Pj4+IGlmIEVDQyBzdGVwIHNpemUgaXMg YWxyZWFkeSBrbm93biBoZXJlIChmcm9tIERUUyksIGNhbGN1bGF0ZSAnbnNlY3RvcnMnIHVzaW5n Cj4gPj4+PiBnaXZlbiB2YWx1ZSAoZGl2IGJ5IDUxMiBmb3IgZXhhbXBsZSkuIE90aGVyd2lzZSBj YWxjdWxhdGUgJ25zZWN0b3JzJyBpbiB0aGUKPiA+Pj4+IGN1cnJlbnQgbWFubmVyOiAgICAKPiA+ Pj4KPiA+Pj4gSXQgd2lsbCBhbHdheXMgYmUga25vd24gd2hlbiB0aGVzZSBmdW5jdGlvbiBhcmUg cnVuLiBUaGVyZSBpcyBubwo+ID4+PiBndWVzc2luZyBoZXJlLiAgICAKPiA+Pgo+ID4+IEhtIEkg Y2hlY2tlZCwgdGhhdCBidXQgaWYgc3RlcCBzaXplIGlzIG5vdCBzZXQgaW4gRFRTLCBoZXJlIGl0 IHdpbGwgYmUgMCwgCj4gPj4gdGhlbiBpdCB3aWxsIGJlIHNlbGVjdGVkIGluICduYW5kX2VjY19j aG9vc2VfY29uZigpJyBhY2NvcmRpbmcgcHJvdmlkZWQgJ2VjY19jYXBzJwo+ID4+IGFuZCAnb29i YXZhaWwnLi4uCj4gPj4KPiA+PiBBbnl3YXksIEknbGwgZG8gdGhlIGZvbGxvd2luZyB0aGluZzoK PiA+Pgo+ID4+IGludCBuc2VjdG9yczsKPiA+Pgo+ID4+IGlmIChuYW5kLT5lY2Muc2l6ZSkKPiA+ PiAgICAgbnNlY3RvcnMgPSBtdGQtPndyaXRlc2l6ZSAvIG5hbmQtPmVjYy5zaXplOyA8LS0tIHRo aXMgaXMgZm9yIDUxMiBFQ0MgIAo+ID4gCj4gPiBZb3Ugc2hvdWxkIHNldCBuYW5kLT5lY2Muc2l6 ZSBpbiAtPmF0dGFjaF9jaGlwKCkgaW5zdGVhZC4gIAo+IAo+IFNvcnJ5LCBkaWRuJ3QgZ2V0IGl0 Li4uIGlmIEVDQyBzdGVwIHNpemUgaXMgc2V0IGluIERUUywgdGhlbiBoZXJlLCBpbiBjaGlwIGF0 dGFjaAo+IGNhbGxiYWNrIGl0IHdpbGwgYmUgYWxyZWFkeSBrbm93biAoRFQgcGFydCB3YXMgcHJv Y2Vzc2VkIGluICdyYXduYW5kX2R0X2luaXQoKScpLgo+IElmIEVDQyBzdGVwIHNpemUgaXMgdW5r bm93biAoZS5nLiAwIGhlcmUpLCAnbmFuZF9lY2NfY2hvb3NlX2NvbmYoKScgd2lsbCBzZXQgaXQK PiBhY2NvcmRpbmcgcHJvdmlkZWQgZWNjIGNhcHMuIFdoYXQgZG8gWW91IG1lYW4gZm9yICJZb3Ug c2hvdWxkIHNldCAuLi4iID8KClRoZSBjdXJyZW50IGFwcHJvYWNoIGlzIHdyb25nLCBpdCBkZWNp ZGVzIHRoZSBudW1iZXIgb2YgRUNDIGNodW5rcwooY2FsbGVkIG5zZWN0b3JzIGluIHRoZSBkcml2 ZXIpIGFuZCB0aGVuIGFza3MgdGhlIGNvcmUgdG8gZGVjaWRlIHRoZQpudW1iZXIgb2YgRUNDIGNo dW5rcyB0byB1c2UuCgpKdXN0IHByb3ZpZGUgbXRkLT5vb2JzaXplIC0gMiBhcyBsYXN0IHBhcmFt ZXRlciBhbmQgdGhlbiByZWx5IG9uIHRoZQpjb3JlJ3MgbG9naWMgdG8gZmluZCB0aGUgcmlnaHQg RUNDIHN0ZXAtc2l6ZS9zdHJlbmd0aD8KClRoZXJlIGlzIG5vIHBvaW50IGluIHJlcXVlc3Rpbmcg YSBwYXJ0aWN1bGFyIHN0ZXAgc2l6ZSB3aXRob3V0IGEKc3BlY2lmaWMgc3RyZW5ndGgsIG9yPyBT byBJIGJlbGlldmUgeW91IHNob3VsZCBwcm92aWRlIGJvdGggaW4gdGhlIERUUwppZiB5b3Ugd2Fu dCBwYXJ0aWN1bGFyIHBhcmFtZXRlcnMgdG8gYmUgYXBwbGllZCwgb3RoZXJ3aXNlIHlvdSBjYW4g bGV0CnRoZSBjb3JlIGRlY2lkZSB3aGF0IGlzIGJlc3QuCgpUaGFua3MsCk1pcXXDqGwKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26D1DEB64D9 for ; Tue, 4 Jul 2023 13:41:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229994AbjGDNlQ (ORCPT ); Tue, 4 Jul 2023 09:41:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230256AbjGDNlP (ORCPT ); Tue, 4 Jul 2023 09:41:15 -0400 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 954F2E6D; Tue, 4 Jul 2023 06:41:13 -0700 (PDT) X-GND-Sasl: miquel.raynal@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1688478072; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QJLhG5xef0Dm9kVxipRfJ1zAKqJpL9r++IajKk5AkNU=; b=pZo+4NrPp2dycBIRoGMvUMInSYsTFLDpojazcKafyNd55aRmC80dmZ1TZdYaeVs3mfgjBE z6ngQq4XpQ7bf5wQ2kp6Wzt7xDHanylnonV7EkM+d+LnLuDobkEPsoLkh+3gpPDbbgwy29 vbjXtpOZPjanZTztmEfCWazX4Lgpl+QXBjT/gdKdhQcq1+x+DdcRUuscmFGFmhgGn/2V6H vCyMqXZ2ZVDsIKLbSwQGOD2dMUUzCWV/hB7/CdX44FztFNvbk5M+8U0Zr2R6dumBq+AmIY 9VbRtRlJnIx8NOokmg9NJjeqGgYG+rmqreo7wsMxVxuXqXZIPGyqvZVsvtM/fQ== X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 6F5DEC000B; Tue, 4 Jul 2023 13:41:08 +0000 (UTC) Date: Tue, 4 Jul 2023 15:41:06 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , , , , , , , Subject: Re: [RFC PATCH v1 2/2] mtd: rawnand: meson: support for 512B ECC step size Message-ID: <20230704154106.5c5aafd8@xps-13> In-Reply-To: References: <20230628092937.538683-1-AVKrasnov@sberdevices.ru> <20230628092937.538683-3-AVKrasnov@sberdevices.ru> <20230704103617.4affae8a@xps-13> <9e6eaa87-887c-f955-113a-43860c8ea00c@sberdevices.ru> <20230704114110.25ca9de4@xps-13> <20230704115628.55320428@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Arseniy, > >>>> Yes, this code looks strange. 'nsectors' is used to calculate space = in OOB > >>>> that could be used by ECC engine (this value will be passed as 'ooba= vail' > >>>> to 'nand_ecc_choose_conf()'). Idea of 512 is to consider "worst" case > >>>> for ECC, e.g. minimal number of bytes for ECC engine (and at the sam= e time > >>>> maximum number of free bytes). For Meson, if ECC step size is 512, t= hen we > >>>> have 4 x 2 free bytes in OOB (if step size if 1024 then we have 2 x = 2 free > >>>> bytes in OOB). > >>>> > >>>> I think this code could be reworked in the following way: > >>>> > >>>> if ECC step size is already known here (from DTS), calculate 'nsecto= rs' using > >>>> given value (div by 512 for example). Otherwise calculate 'nsectors'= in the > >>>> current manner: =20 > >>> > >>> It will always be known when these function are run. There is no > >>> guessing here. =20 > >> > >> Hm I checked, that but if step size is not set in DTS, here it will be= 0,=20 > >> then it will be selected in 'nand_ecc_choose_conf()' according provide= d 'ecc_caps' > >> and 'oobavail'... > >> > >> Anyway, I'll do the following thing: > >> > >> int nsectors; > >> > >> if (nand->ecc.size) > >> nsectors =3D mtd->writesize / nand->ecc.size; <--- this is for 512= ECC =20 > >=20 > > You should set nand->ecc.size in ->attach_chip() instead. =20 >=20 > Sorry, didn't get it... if ECC step size is set in DTS, then here, in chi= p attach > callback it will be already known (DT part was processed in 'rawnand_dt_i= nit()'). > If ECC step size is unknown (e.g. 0 here), 'nand_ecc_choose_conf()' will = set it > according provided ecc caps. What do You mean for "You should set ..." ? The current approach is wrong, it decides the number of ECC chunks (called nsectors in the driver) and then asks the core to decide the number of ECC chunks to use. Just provide mtd->oobsize - 2 as last parameter and then rely on the core's logic to find the right ECC step-size/strength? There is no point in requesting a particular step size without a specific strength, or? So I believe you should provide both in the DTS if you want particular parameters to be applied, otherwise you can let the core decide what is best. Thanks, Miqu=C3=A8l