Re: [RFC PATCH] mm: memory-failure: add missing set_mce_nospec() for memory_failure()

[kernel test robot <lkp@intel.com>]

Hi Miaohe,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on akpm-mm/mm-everything]

url:    https://github.com/intel-lab-lkp/linux/commits/Miaohe-Lin/mm-memory-failure-add-missing-set_mce_nospec-for-memory_failure/20230704-202035
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20230704121948.1331846-1-linmiaohe%40huawei.com
patch subject: [RFC PATCH] mm: memory-failure: add missing set_mce_nospec() for memory_failure()
config: arm64-randconfig-r021-20230704 (https://download.01.org/0day-ci/archive/20230705/202307050025.piXqvNt6-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230705/202307050025.piXqvNt6-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307050025.piXqvNt6-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from include/linux/export.h:5,
                    from include/linux/linkage.h:7,
                    from include/linux/kernel.h:17,
                    from mm/memory-failure.c:39:
   mm/memory-failure.c: In function 'memory_failure_work_func':
>> mm/memory-failure.c:2406:37: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~' [-Wparentheses]
    2406 |                                 if (!entry.flags & MF_SW_SIMULATED)
         |                                     ^~~~~~~~~~~~
   include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
      57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
         |                                                    ^~~~
   mm/memory-failure.c:2406:33: note: in expansion of macro 'if'
    2406 |                                 if (!entry.flags & MF_SW_SIMULATED)
         |                                 ^~
>> mm/memory-failure.c:2406:37: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~' [-Wparentheses]
    2406 |                                 if (!entry.flags & MF_SW_SIMULATED)
         |                                     ^~~~~~~~~~~~
   include/linux/compiler.h:57:61: note: in definition of macro '__trace_if_var'
      57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
         |                                                             ^~~~
   mm/memory-failure.c:2406:33: note: in expansion of macro 'if'
    2406 |                                 if (!entry.flags & MF_SW_SIMULATED)
         |                                 ^~
>> mm/memory-failure.c:2406:37: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~' [-Wparentheses]
    2406 |                                 if (!entry.flags & MF_SW_SIMULATED)
         |                                     ^~~~~~~~~~~~
   include/linux/compiler.h:68:10: note: in definition of macro '__trace_if_value'
      68 |         (cond) ?                                        \
         |          ^~~~
   include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
      55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
         |                            ^~~~~~~~~~~~~~
   mm/memory-failure.c:2406:33: note: in expansion of macro 'if'
    2406 |                                 if (!entry.flags & MF_SW_SIMULATED)
         |                                 ^~


vim +2406 mm/memory-failure.c

  2387	
  2388	static void memory_failure_work_func(struct work_struct *work)
  2389	{
  2390		struct memory_failure_cpu *mf_cpu;
  2391		struct memory_failure_entry entry = { 0, };
  2392		unsigned long proc_flags;
  2393		int gotten;
  2394	
  2395		mf_cpu = container_of(work, struct memory_failure_cpu, work);
  2396		for (;;) {
  2397			spin_lock_irqsave(&mf_cpu->lock, proc_flags);
  2398			gotten = kfifo_get(&mf_cpu->fifo, &entry);
  2399			spin_unlock_irqrestore(&mf_cpu->lock, proc_flags);
  2400			if (!gotten)
  2401				break;
  2402			if (entry.flags & MF_SOFT_OFFLINE)
  2403				soft_offline_page(entry.pfn, entry.flags);
  2404			else
  2405				if (!memory_failure(entry.pfn, entry.flags))
> 2406					if (!entry.flags & MF_SW_SIMULATED)
  2407						set_mce_nospec(entry.pfn);
  2408		}
  2409	}
  2410	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki