From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B880C0015E for ; Wed, 5 Jul 2023 06:16:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id E1A928176E; Wed, 5 Jul 2023 06:16:11 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org E1A928176E Authentication-Results: smtp1.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=f9GAZaYR X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JO-nYUuYWXlC; Wed, 5 Jul 2023 06:16:10 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id 42CF98175C; Wed, 5 Jul 2023 06:16:10 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 42CF98175C Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id F354FC0072; Wed, 5 Jul 2023 06:16:09 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id CA238C0032 for ; Wed, 5 Jul 2023 06:16:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 36E8A8176E for ; Wed, 5 Jul 2023 06:16:08 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 36E8A8176E X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gCgvmNEI4AgQ for ; Wed, 5 Jul 2023 06:16:07 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 4EF8681756 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp1.osuosl.org (Postfix) with ESMTPS id 4EF8681756 for ; Wed, 5 Jul 2023 06:16:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688537766; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TBBB6lG9AFcGbGAzMsUXWxOnjBOVl3P6MUCcvBHbSmw=; b=f9GAZaYRg2hN3xc6SoKc1590mARchDSX1dB2ESJfIY2vPMt1TfBBq9Lstf13GFqgAqyGAa AC2xoeuZHzoIvnvQJI4dBZrlGqaP8jb8ftLhQzLJPan0k+AhbgYJKZzZkEHbugx92+eabn wheWcpJBh8arIJpfrlw4UptGkdqHmnM= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-37--Y9y3Fu_N82LkRaoTpajkg-1; Wed, 05 Jul 2023 02:16:04 -0400 X-MC-Unique: -Y9y3Fu_N82LkRaoTpajkg-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3fb40d0623bso1694705e9.1 for ; Tue, 04 Jul 2023 23:16:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688537763; x=1691129763; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TBBB6lG9AFcGbGAzMsUXWxOnjBOVl3P6MUCcvBHbSmw=; b=EPkp9zhsCAvvk5SzJneMDhXH35Wi5v+xhs/YOCPllCQ5NS4a0ZESTZwKLG67WALa90 JHALFd+jViJSZZgrePdkGmbCiYpW6+mNHSbZlcUw0PAHDQB8YFXUXgDW6xsVOPNCB1K6 fII1s/pCtsG7ivXsrEfF2FuyuFIyeNBZhlZiq0moCWHwuTHN1ns2RcvL8FsI8aREtrRC GPSn+urm5ZhZl4KvBFJrVGq7o4nEEutbvuRnYtcXE/y5UgrYe5Wz2iygLRjcs2+9R1Pb kompIxW3c7qlifaeQjX4mBU1Cu1hC2htfta4HS4fWUsf3sg4IvUtk1BFrWD4xJM+MhVk FkqA== X-Gm-Message-State: ABy/qLYG6sX2zyTyAw602BliOC/TA66KhDUpioqjUTSHYzaPYDRcDXf1 M+xfEAqi09SAWiNdo9F52pUCYnEDbM2HYoN4JEuXO3vSHdO3AD+5qHuiMOraDsnavM/LD7SIqUs tbXBtFz/oupN21cEdyDB1D91oCDQQ3FSv3AKi6ktKRw== X-Received: by 2002:a05:600c:519a:b0:3fb:b18a:f32d with SMTP id fa26-20020a05600c519a00b003fbb18af32dmr1182554wmb.17.1688537763304; Tue, 04 Jul 2023 23:16:03 -0700 (PDT) X-Google-Smtp-Source: APBJJlGRjW7JSmJKn22ARTG8gQSc74SDVkixROnuT/Q+4llMdAdfakRodtDTA7BfzPqsBd3zTp3PHg== X-Received: by 2002:a05:600c:519a:b0:3fb:b18a:f32d with SMTP id fa26-20020a05600c519a00b003fbb18af32dmr1182532wmb.17.1688537763037; Tue, 04 Jul 2023 23:16:03 -0700 (PDT) Received: from redhat.com ([2a02:14f:1f8:91bf:2a8a:e512:df36:67d3]) by smtp.gmail.com with ESMTPSA id d18-20020a05600c251200b003fbcf032c55sm1123833wma.7.2023.07.04.23.16.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jul 2023 23:16:02 -0700 (PDT) Date: Wed, 5 Jul 2023 02:15:58 -0400 From: "Michael S. Tsirkin" To: Jason Wang Subject: Re: [PATCH] mlx5_vdpa: offer VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK Message-ID: <20230705021447-mutt-send-email-mst@kernel.org> References: <20230703142514.363256-1-eperezma@redhat.com> <20230703110241-mutt-send-email-mst@kernel.org> <20230704061356-mutt-send-email-mst@kernel.org> <20230705012917-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: Xuan Zhuo , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Eugenio =?iso-8859-1?Q?P=E9rez?= , leiyang@redhat.com X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" T24gV2VkLCBKdWwgMDUsIDIwMjMgYXQgMDE6NDc6NDRQTSArMDgwMCwgSmFzb24gV2FuZyB3cm90 ZToKPiBPbiBXZWQsIEp1bCA1LCAyMDIzIGF0IDE6MzHigK9QTSBNaWNoYWVsIFMuIFRzaXJraW4g PG1zdEByZWRoYXQuY29tPiB3cm90ZToKPiA+Cj4gPiBPbiBXZWQsIEp1bCAwNSwgMjAyMyBhdCAw MToxMTozN1BNICswODAwLCBKYXNvbiBXYW5nIHdyb3RlOgo+ID4gPiBPbiBUdWUsIEp1bCA0LCAy MDIzIGF0IDY6MTbigK9QTSBNaWNoYWVsIFMuIFRzaXJraW4gPG1zdEByZWRoYXQuY29tPiB3cm90 ZToKPiA+ID4gPgo+ID4gPiA+IE9uIE1vbiwgSnVsIDAzLCAyMDIzIGF0IDA1OjI2OjAyUE0gLTA3 MDAsIFNpLVdlaSBMaXUgd3JvdGU6Cj4gPiA+ID4gPgo+ID4gPiA+ID4KPiA+ID4gPiA+IE9uIDcv My8yMDIzIDg6NDYgQU0sIE1pY2hhZWwgUy4gVHNpcmtpbiB3cm90ZToKPiA+ID4gPiA+ID4gT24g TW9uLCBKdWwgMDMsIDIwMjMgYXQgMDQ6MjU6MTRQTSArMDIwMCwgRXVnZW5pbyBQw6lyZXogd3Jv dGU6Cj4gPiA+ID4gPiA+ID4gT2ZmZXIgdGhpcyBiYWNrZW5kIGZlYXR1cmUgYXMgbWx4NSBpcyBj b21wYXRpYmxlIHdpdGggaXQuIEl0IGFsbG93cyBpdAo+ID4gPiA+ID4gPiA+IHRvIGRvIGxpdmUg bWlncmF0aW9uIHdpdGggQ1ZRLCBkeW5hbWljYWxseSBzd2l0Y2hpbmcgYmV0d2VlbiBwYXNzdGhy b3VnaAo+ID4gPiA+ID4gPiA+IGFuZCBzaGFkb3cgdmlydHF1ZXVlLgo+ID4gPiA+ID4gPiA+Cj4g PiA+ID4gPiA+ID4gU2lnbmVkLW9mZi1ieTogRXVnZW5pbyBQw6lyZXogPGVwZXJlem1hQHJlZGhh dC5jb20+Cj4gPiA+ID4gPiA+IFNhbWUgY29tbWVudC4KPiA+ID4gPiA+IHRvIHdoaWNoPwo+ID4g PiA+ID4KPiA+ID4gPiA+IC1TaXdlaQo+ID4gPiA+Cj4gPiA+ID4gVkhPU1RfQkFDS0VORF9GX0VO QUJMRV9BRlRFUl9EUklWRVJfT0sgaXMgdG9vIG5hcnJvdyBhIHVzZS1jYXNlIHRvIGNvbW1pdCB0 byBpdAo+ID4gPiA+IGFzIGEga2VybmVsL3VzZXJzcGFjZSBBQkk6IHdoYXQgaWYgb25lIHdhbnRz IHRvIHN0YXJ0IHJpbmdzIGluIHNvbWUKPiA+ID4gPiBvdGhlciBzcGVjaWZpYyBvcmRlcj8KPiA+ ID4KPiA+ID4gSnVzdCBlbmFibGUgYSBxdWV1ZSBieSB3cml0aW5nIGUuZyAxIHRvIHF1ZXVlX2Vu YWJsZSBpbiBhIHNwZWNpZmljIG9yZGVyPwo+ID4KPiA+Cj4gPiBCdXQgdGhlbiBhdCBkcml2ZXIg b2sgdGltZSB3ZSBkb24ndCBrbm93IGhvdyBtYW55IHF1ZXVlcyBhcmUgdGhlcmUuCj4gCj4gVGhl cmUgc2hvdWxkIGJlIGEgZGV2aWNlIHNwZWNpZmljIGludGVyZmFjZSBmb3IgdGhpcywgZm9yIGV4 YW1wbGUsCj4gbnVtX3F1ZXVlX3BhcmlzLiBTbyB0aGUgZGV2aWNlIGtub3dzIGF0IG1vc3QgaG93 IG1hbnkgcXVldWVzIHRoZXJlCj4gYXJlLiBPciBhbnl0aGluZyBJIG1pc3M/CgpUaGF0J3MgYSBk ZXZpY2UgbGltaXRhdGlvbnMuIERvZXMgbm90IHRlbGwgdGhlIGRldmljZSBob3cgbXVjaCBpcyB1 c2VkLgoKPiA+Cj4gPiA+ID4gQXMgd2FzIGRpc2N1c3NlZCBvbiBsaXN0LCBhIGJldHRlciBwcm9t aXNlIGlzIG5vdCB0byBhY2Nlc3MgcmluZwo+ID4gPiA+IHVudGlsIHRoZSAxc3Qga2ljay4gdmRw YSBjYW4gdGhlbiBkbyBhIGtpY2sgd2hlbiBpdCB3YW50cwo+ID4gPiA+IHRoZSBkZXZpY2UgdG8g c3RhcnQgYWNjZXNzaW5nIHJpbmdzLgo+ID4gPgo+ID4gPiBSZXRoaW5rIGFib3V0IHRoZSBBQ0NF U1NfQUZURVJfS0lDSywgaXQgc291bmRzIGZ1bmN0aW9uYWwgZXF1aXZhbGVudAo+ID4gPiB0byBh bGxvdyBxdWV1ZV9lbmFibGUgYWZ0ZXIgRFJJVkVSX09LLCBidXQgaXQgc2VlbXMgdG8gaGF2ZQo+ ID4gPiBkaXN0YW52YWdlczoKPiA+ID4KPiA+ID4gQSBidXN5IHBvbGxpbmcgc29mdHdhcmUgZGV2 aWNlIG1heSBkaXNhYmxlIG5vdGlmaWNhdGlvbnMgYW5kIG5ldmVyCj4gPiA+IHJlc3BvbmQgdG8g cmVnaXN0ZXIgdG8gYW55IGtpY2sgbm90aWZpZXJzLiBBQ0NFU1NfQUZURVJfS0lDSyB3aWxsCj4g PiA+IGludHJvZHVjZSBvdmVyaGVhZCB0byB0aG9zZSBpbXBsZW1lbnRhdGlvbnMuCj4gPiA+Cj4g PiA+IFRoYW5rcwo+ID4KPiA+IEl0J3MganVzdCB0aGUgMXN0IGtpY2ssIHRoZW4geW91IGNhbiBk aXNhYmxlLiBObz8KPiAKPiBZZXMsIGJ1dDoKPiAKPiAxKSBhZGRpbmcgaG9va3MgZm9yIHF1ZXVl X2VuYWJsZQo+IDIpIGFkZGluZyBuZXcgY29kZXMgdG8gcmVnaXN0ZXIgZXZlbnQgbm90aWZpZXIg YW5kIHRvZ2dsZSB0aGUgbm90aWZpZXIKPiAKPiAxKSBzZWVtcyBtdWNoIGVhc2llcj8gT3IgZm9y IG1vc3QgZGV2aWNlcywgaXQgYWxyZWFkeSBiZWhhdmVzIGxpa2UgdGhpcy4KPiAKPiBUaGFua3MK CldlbGwgbGlidmhvc3R1c2VyIGNoZWNrcyBlbmFibGVkIHF1ZXVlcyBhdCBEUklWRVJfT0ssIGRv ZXMgaXQgbm90PwoKPiA+Cj4gPiA+ID4KPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiAtLS0KPiA+ ID4gPiA+ID4gPiAgIGRyaXZlcnMvdmRwYS9tbHg1L25ldC9tbHg1X3ZuZXQuYyB8IDcgKysrKysr Kwo+ID4gPiA+ID4gPiA+ICAgMSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKQo+ID4gPiA+ ID4gPiA+Cj4gPiA+ID4gPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdmRwYS9tbHg1L25ldC9t bHg1X3ZuZXQuYyBiL2RyaXZlcnMvdmRwYS9tbHg1L25ldC9tbHg1X3ZuZXQuYwo+ID4gPiA+ID4g PiA+IGluZGV4IDkxMzhlZjJmYjJjOC4uNWYzMDlhMTZiOWRjIDEwMDY0NAo+ID4gPiA+ID4gPiA+ IC0tLSBhL2RyaXZlcnMvdmRwYS9tbHg1L25ldC9tbHg1X3ZuZXQuYwo+ID4gPiA+ID4gPiA+ICsr KyBiL2RyaXZlcnMvdmRwYS9tbHg1L25ldC9tbHg1X3ZuZXQuYwo+ID4gPiA+ID4gPiA+IEBAIC03 LDYgKzcsNyBAQAo+ID4gPiA+ID4gPiA+ICAgI2luY2x1ZGUgPHVhcGkvbGludXgvdmlydGlvX25l dC5oPgo+ID4gPiA+ID4gPiA+ICAgI2luY2x1ZGUgPHVhcGkvbGludXgvdmlydGlvX2lkcy5oPgo+ ID4gPiA+ID4gPiA+ICAgI2luY2x1ZGUgPHVhcGkvbGludXgvdmRwYS5oPgo+ID4gPiA+ID4gPiA+ ICsjaW5jbHVkZSA8dWFwaS9saW51eC92aG9zdF90eXBlcy5oPgo+ID4gPiA+ID4gPiA+ICAgI2lu Y2x1ZGUgPGxpbnV4L3ZpcnRpb19jb25maWcuaD4KPiA+ID4gPiA+ID4gPiAgICNpbmNsdWRlIDxs aW51eC9hdXhpbGlhcnlfYnVzLmg+Cj4gPiA+ID4gPiA+ID4gICAjaW5jbHVkZSA8bGludXgvbWx4 NS9jcS5oPgo+ID4gPiA+ID4gPiA+IEBAIC0yNDk5LDYgKzI1MDAsMTEgQEAgc3RhdGljIHZvaWQg dW5yZWdpc3Rlcl9saW5rX25vdGlmaWVyKHN0cnVjdCBtbHg1X3ZkcGFfbmV0ICpuZGV2KQo+ID4g PiA+ID4gPiA+ICAgICAgICAgICAgICAgICAgIGZsdXNoX3dvcmtxdWV1ZShuZGV2LT5tdmRldi53 cSk7Cj4gPiA+ID4gPiA+ID4gICB9Cj4gPiA+ID4gPiA+ID4gK3N0YXRpYyB1NjQgbWx4NV92ZHBh X2dldF9iYWNrZW5kX2ZlYXR1cmVzKGNvbnN0IHN0cnVjdCB2ZHBhX2RldmljZSAqdmRwYSkKPiA+ ID4gPiA+ID4gPiArewo+ID4gPiA+ID4gPiA+ICsgcmV0dXJuIEJJVF9VTEwoVkhPU1RfQkFDS0VO RF9GX0VOQUJMRV9BRlRFUl9EUklWRVJfT0spOwo+ID4gPiA+ID4gPiA+ICt9Cj4gPiA+ID4gPiA+ ID4gKwo+ID4gPiA+ID4gPiA+ICAgc3RhdGljIGludCBtbHg1X3ZkcGFfc2V0X2RyaXZlcl9mZWF0 dXJlcyhzdHJ1Y3QgdmRwYV9kZXZpY2UgKnZkZXYsIHU2NCBmZWF0dXJlcykKPiA+ID4gPiA+ID4g PiAgIHsKPiA+ID4gPiA+ID4gPiAgICAgICAgICAgc3RydWN0IG1seDVfdmRwYV9kZXYgKm12ZGV2 ID0gdG9fbXZkZXYodmRldik7Cj4gPiA+ID4gPiA+ID4gQEAgLTMxNDAsNiArMzE0Niw3IEBAIHN0 YXRpYyBjb25zdCBzdHJ1Y3QgdmRwYV9jb25maWdfb3BzIG1seDVfdmRwYV9vcHMgPSB7Cj4gPiA+ ID4gPiA+ID4gICAgICAgICAgIC5nZXRfdnFfYWxpZ24gPSBtbHg1X3ZkcGFfZ2V0X3ZxX2FsaWdu LAo+ID4gPiA+ID4gPiA+ICAgICAgICAgICAuZ2V0X3ZxX2dyb3VwID0gbWx4NV92ZHBhX2dldF92 cV9ncm91cCwKPiA+ID4gPiA+ID4gPiAgICAgICAgICAgLmdldF9kZXZpY2VfZmVhdHVyZXMgPSBt bHg1X3ZkcGFfZ2V0X2RldmljZV9mZWF0dXJlcywKPiA+ID4gPiA+ID4gPiArIC5nZXRfYmFja2Vu ZF9mZWF0dXJlcyA9IG1seDVfdmRwYV9nZXRfYmFja2VuZF9mZWF0dXJlcywKPiA+ID4gPiA+ID4g PiAgICAgICAgICAgLnNldF9kcml2ZXJfZmVhdHVyZXMgPSBtbHg1X3ZkcGFfc2V0X2RyaXZlcl9m ZWF0dXJlcywKPiA+ID4gPiA+ID4gPiAgICAgICAgICAgLmdldF9kcml2ZXJfZmVhdHVyZXMgPSBt bHg1X3ZkcGFfZ2V0X2RyaXZlcl9mZWF0dXJlcywKPiA+ID4gPiA+ID4gPiAgICAgICAgICAgLnNl dF9jb25maWdfY2IgPSBtbHg1X3ZkcGFfc2V0X2NvbmZpZ19jYiwKPiA+ID4gPiA+ID4gPiAtLQo+ ID4gPiA+ID4gPiA+IDIuMzkuMwo+ID4gPiA+Cj4gPgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KVmlydHVhbGl6YXRpb24gbWFpbGluZyBsaXN0ClZpcnR1 YWxpemF0aW9uQGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhm b3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL3ZpcnR1YWxpemF0aW9u From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B387C001B3 for ; Wed, 5 Jul 2023 06:16:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230255AbjGEGQs (ORCPT ); Wed, 5 Jul 2023 02:16:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229610AbjGEGQp (ORCPT ); Wed, 5 Jul 2023 02:16:45 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C01310E2 for ; Tue, 4 Jul 2023 23:16:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688537765; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TBBB6lG9AFcGbGAzMsUXWxOnjBOVl3P6MUCcvBHbSmw=; b=eTPDQsdQ3Ldug73MVD7pORlE106e1B+XhtPzff6HGehM690z5FaRLa4EYcZOPjgDzkVJKK LLpOl+udWzwDsPvibICb2/7wSx8z8y+rrxvsiiVK7rYPS9qrCB9bUj7KJfu06Q/4/9T//H YgQnx+YxOOLFfhrWmER43Cjv/XPf6cs= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-656-04lf3DjiNY2YfoA4Ma1HdA-1; Wed, 05 Jul 2023 02:16:04 -0400 X-MC-Unique: 04lf3DjiNY2YfoA4Ma1HdA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3fa8d203eccso1503665e9.1 for ; Tue, 04 Jul 2023 23:16:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688537763; x=1691129763; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TBBB6lG9AFcGbGAzMsUXWxOnjBOVl3P6MUCcvBHbSmw=; b=TVOS5A43Ri+l4W58qhHQJ6CO073ag1hQ0Ssq8UfEQhgre+jz2rQqkXaEkvOlEqxdU7 eKWMzz6IXIO7kseUtTKwaTgpd+C1F00eUf9bt6utM/w3zn56oguCP//eHTlEyRlr3Ad9 SxZ3l5lLTwS3eZypGqe9gSNBROOH2x04QwCYFXVuxFoMWTjTx5qASACzYykBIu11Y2JC gsKbMrShrrBGKaX7bqY39iuwH51BjLqWR94vs/LZYwqoROnV0yt375Mx3MSHNqBJk1G5 NBtRHtet4C1ZAdqr6YNzNnBd/3uADG6tHIMk7pV31cX8tX7AhPxJVz+IE7RWNMcbzLBK hgsg== X-Gm-Message-State: ABy/qLaCKE31mw8GetwvnTuhy99tYFwoNz1wu0bCznF+6WS4U/2/bBoQ quQAyk3NSgmY8qoU3uHSY8nd1ORaGMPtZHnn0xZPTmxEcUPaDpqtUXGhhDF/Na516e4uyleckb/ OILPouB2s6wB4tDFXrOu93Jmg X-Received: by 2002:a05:600c:519a:b0:3fb:b18a:f32d with SMTP id fa26-20020a05600c519a00b003fbb18af32dmr1182552wmb.17.1688537763304; Tue, 04 Jul 2023 23:16:03 -0700 (PDT) X-Google-Smtp-Source: APBJJlGRjW7JSmJKn22ARTG8gQSc74SDVkixROnuT/Q+4llMdAdfakRodtDTA7BfzPqsBd3zTp3PHg== X-Received: by 2002:a05:600c:519a:b0:3fb:b18a:f32d with SMTP id fa26-20020a05600c519a00b003fbb18af32dmr1182532wmb.17.1688537763037; Tue, 04 Jul 2023 23:16:03 -0700 (PDT) Received: from redhat.com ([2a02:14f:1f8:91bf:2a8a:e512:df36:67d3]) by smtp.gmail.com with ESMTPSA id d18-20020a05600c251200b003fbcf032c55sm1123833wma.7.2023.07.04.23.16.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jul 2023 23:16:02 -0700 (PDT) Date: Wed, 5 Jul 2023 02:15:58 -0400 From: "Michael S. Tsirkin" To: Jason Wang Cc: Si-Wei Liu , Eugenio =?iso-8859-1?Q?P=E9rez?= , linux-kernel@vger.kernel.org, Dragos Tatulea , virtualization@lists.linux-foundation.org, leiyang@redhat.com, Xuan Zhuo Subject: Re: [PATCH] mlx5_vdpa: offer VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK Message-ID: <20230705021447-mutt-send-email-mst@kernel.org> References: <20230703142514.363256-1-eperezma@redhat.com> <20230703110241-mutt-send-email-mst@kernel.org> <20230704061356-mutt-send-email-mst@kernel.org> <20230705012917-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 05, 2023 at 01:47:44PM +0800, Jason Wang wrote: > On Wed, Jul 5, 2023 at 1:31 PM Michael S. Tsirkin wrote: > > > > On Wed, Jul 05, 2023 at 01:11:37PM +0800, Jason Wang wrote: > > > On Tue, Jul 4, 2023 at 6:16 PM Michael S. Tsirkin wrote: > > > > > > > > On Mon, Jul 03, 2023 at 05:26:02PM -0700, Si-Wei Liu wrote: > > > > > > > > > > > > > > > On 7/3/2023 8:46 AM, Michael S. Tsirkin wrote: > > > > > > On Mon, Jul 03, 2023 at 04:25:14PM +0200, Eugenio Pérez wrote: > > > > > > > Offer this backend feature as mlx5 is compatible with it. It allows it > > > > > > > to do live migration with CVQ, dynamically switching between passthrough > > > > > > > and shadow virtqueue. > > > > > > > > > > > > > > Signed-off-by: Eugenio Pérez > > > > > > Same comment. > > > > > to which? > > > > > > > > > > -Siwei > > > > > > > > VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK is too narrow a use-case to commit to it > > > > as a kernel/userspace ABI: what if one wants to start rings in some > > > > other specific order? > > > > > > Just enable a queue by writing e.g 1 to queue_enable in a specific order? > > > > > > But then at driver ok time we don't know how many queues are there. > > There should be a device specific interface for this, for example, > num_queue_paris. So the device knows at most how many queues there > are. Or anything I miss? That's a device limitations. Does not tell the device how much is used. > > > > > > As was discussed on list, a better promise is not to access ring > > > > until the 1st kick. vdpa can then do a kick when it wants > > > > the device to start accessing rings. > > > > > > Rethink about the ACCESS_AFTER_KICK, it sounds functional equivalent > > > to allow queue_enable after DRIVER_OK, but it seems to have > > > distanvages: > > > > > > A busy polling software device may disable notifications and never > > > respond to register to any kick notifiers. ACCESS_AFTER_KICK will > > > introduce overhead to those implementations. > > > > > > Thanks > > > > It's just the 1st kick, then you can disable. No? > > Yes, but: > > 1) adding hooks for queue_enable > 2) adding new codes to register event notifier and toggle the notifier > > 1) seems much easier? Or for most devices, it already behaves like this. > > Thanks Well libvhostuser checks enabled queues at DRIVER_OK, does it not? > > > > > > > > > > > > > > > > > > > --- > > > > > > > drivers/vdpa/mlx5/net/mlx5_vnet.c | 7 +++++++ > > > > > > > 1 file changed, 7 insertions(+) > > > > > > > > > > > > > > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c > > > > > > > index 9138ef2fb2c8..5f309a16b9dc 100644 > > > > > > > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c > > > > > > > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c > > > > > > > @@ -7,6 +7,7 @@ > > > > > > > #include > > > > > > > #include > > > > > > > #include > > > > > > > +#include > > > > > > > #include > > > > > > > #include > > > > > > > #include > > > > > > > @@ -2499,6 +2500,11 @@ static void unregister_link_notifier(struct mlx5_vdpa_net *ndev) > > > > > > > flush_workqueue(ndev->mvdev.wq); > > > > > > > } > > > > > > > +static u64 mlx5_vdpa_get_backend_features(const struct vdpa_device *vdpa) > > > > > > > +{ > > > > > > > + return BIT_ULL(VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK); > > > > > > > +} > > > > > > > + > > > > > > > static int mlx5_vdpa_set_driver_features(struct vdpa_device *vdev, u64 features) > > > > > > > { > > > > > > > struct mlx5_vdpa_dev *mvdev = to_mvdev(vdev); > > > > > > > @@ -3140,6 +3146,7 @@ static const struct vdpa_config_ops mlx5_vdpa_ops = { > > > > > > > .get_vq_align = mlx5_vdpa_get_vq_align, > > > > > > > .get_vq_group = mlx5_vdpa_get_vq_group, > > > > > > > .get_device_features = mlx5_vdpa_get_device_features, > > > > > > > + .get_backend_features = mlx5_vdpa_get_backend_features, > > > > > > > .set_driver_features = mlx5_vdpa_set_driver_features, > > > > > > > .get_driver_features = mlx5_vdpa_get_driver_features, > > > > > > > .set_config_cb = mlx5_vdpa_set_config_cb, > > > > > > > -- > > > > > > > 2.39.3 > > > > > >