From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A009BEB64D9 for ; Wed, 5 Jul 2023 02:16:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:CC:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oKyzqxdxON6GbdIRujb4Jw2iZivIGRKOrTQODIMi3ho=; b=KBFpT6hiUxxigjs5HU6uvU4aL4 uu8yughJqQDa3cP0jSioyCfWZTPHwy8b9U6bIQtaRs84FPmtQ7Z3z2m9w+TOmtTKpO1VeO1UDwAU/ rnGwvMgSCPFVQ9RLg1wVctRSpk27FwvvB5RRM09Qd5HZsfNM2wPdUBNemGupVUQ1KVQKS9WLCsCZo 3o29wePL8SjPf2XjFnpyPfuyC6Sbc2iEtSo2FAUe9DUQZxIXk1mO4r/f6bRuh2Z3upo3aaWuPBLWP OEZZOBFSEEqKChkK2fWIsNdoJfIAhzcP3qO1zLa3kzFz8HIgzT9RFOszRzTD6bx6pZ1nXg+FwugsN 9OlRx8nQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGs3j-00EbV2-2F; Wed, 05 Jul 2023 02:15:59 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGs3e-00EbTu-38; Wed, 05 Jul 2023 02:15:58 +0000 Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Qwjrl3xPlz6J7Ml; Wed, 5 Jul 2023 10:13:59 +0800 (CST) Received: from localhost (10.34.206.101) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 5 Jul 2023 03:15:41 +0100 Date: Wed, 5 Jul 2023 10:15:37 +0800 From: Jonathan Cameron To: Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= CC: Yangtao Li , Krzysztof Kozlowski , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 1/5] genirq/devres: Add devm_request_threaded_irq_emsg() Message-ID: <20230705101537.000059d2@Huawei.com> In-Reply-To: <20230704141954.fcmol2yswkpbnpaw@pengutronix.de> References: <20230703090455.62101-1-frank.li@vivo.com> <20230703090455.62101-2-frank.li@vivo.com> <20230703174347.4m6hcmify4jwsozv@pengutronix.de> <11052797-b006-11bb-e4eb-987ddd568b24@kernel.org> <20805fef-d6aa-91d8-999e-04b1d6b7a37a@vivo.com> <20230704141954.fcmol2yswkpbnpaw@pengutronix.de> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.34.206.101] X-ClientProxiedBy: lhrpeml100002.china.huawei.com (7.191.160.241) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230704_191555_320922_108BB494 X-CRM114-Status: GOOD ( 27.59 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, 4 Jul 2023 16:19:54 +0200 Uwe Kleine-K=C3=B6nig wrote: > Hello, >=20 > On Tue, Jul 04, 2023 at 05:06:12PM +0800, Yangtao Li wrote: > > On 2023/7/4 16:48, Krzysztof Kozlowski wrote: > > =20 > > > [=E4=BD=A0=E9=80=9A=E5=B8=B8=E4=B8=8D=E4=BC=9A=E6=94=B6=E5=88=B0=E6= =9D=A5=E8=87=AA krzk@kernel.org =E7=9A=84=E7=94=B5=E5=AD=90=E9=82=AE=E4=BB= =B6=E3=80=82=E8=AF=B7=E8=AE=BF=E9=97=AE https://aka.ms/LearnAboutSenderIden= tification=EF=BC=8C=E4=BB=A5=E4=BA=86=E8=A7=A3=E8=BF=99=E4=B8=80=E7=82=B9= =E4=B8=BA=E4=BB=80=E4=B9=88=E5=BE=88=E9=87=8D=E8=A6=81] > > >=20 > > > On 03/07/2023 19:43, Uwe Kleine-K=C3=B6nig wrote: =20 > > > > Hello Krzysztof, > > > >=20 > > > > On Mon, Jul 03, 2023 at 02:31:59PM +0200, Krzysztof Kozlowski wrote= : =20 > > > > > On 03/07/2023 11:04, Yangtao Li wrote: =20 > > > > > > There are more than 700 calls to the devm_request_threaded_irq = method. > > > > > > Most drivers only request one interrupt resource, and these err= or > > > > > > messages are basically the same. If error messages are printed > > > > > > everywhere, more than 1000 lines of code can be saved by removi= ng the > > > > > > msg in the driver. =20 > > > > >=20 > > > > > ... > > > > > =20 > > > > > > +int devm_request_threaded_irq_emsg(struct device *dev, unsigne= d int irq, > > > > > > + irq_handler_t handler, irq_handl= er_t thread_fn, > > > > > > + unsigned long irqflags, const ch= ar *devname, > > > > > > + void *dev_id, const char *emsg) > > > > > > +{ > > > > > > + int rc; > > > > > > + > > > > > > + rc =3D devm_request_threaded_irq(dev, irq, handler, NULL, i= rqflags, > > > > > > + devname, dev_id); > > > > > > + if (rc && rc !=3D -EPROBE_DEFER) { > > > > > > + dev_err(dev, "Failed to request %sinterrupt %u %s %= s: %pe\n", > > > > > > + thread_fn ? "threaded " : "", irq, devname = ? : dev_name(dev), > > > > > > + emsg ? : "", ERR_PTR(rc)); =20 > > > > > It is open-coding dev_err_probe(). Just use dev_err_probe instead= . =20 > > > > dev_err_probe is supposed to be only called in probe functions, whi= le > > > > devm_request_threaded_irq might be called in other contexts (e.g. w= hen a > > > > device is opened). That's why I asked to not use dev_err_probe() in= v2 =20 > > > True, but then all the callers of this function will forget to set > > > deferred probe reason. =20 >=20 > That's another reason for letting the driver issue the error message and > not the request_irq function. > =20 > > So let's use dev_err_probe? > >=20 > > BTW, any suggestions for names here, keep using > > devm_request_threaded_irq_emsg or change to a new name? =20 >=20 > I would have called it devm_request_threaded_irq_verbose() which I > consider easier to understand. But maybe is just my (green) > bikeshed. If going to use dev_err_probe() internally maybe can just use devm_request_threaded_irq_probe() thus reflecting that and making it different to the devm_request_threaded_irq()? I'm not sure we need to call out the fact it prints an error message in the naming. Maybe the fact it should probably only be used in probe() is the more relevant information? Bikesheds should all be red! Jonathan >=20 > Best regards > Uwe >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8BF98EB64D9 for ; Wed, 5 Jul 2023 02:16:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nl9kdvfypSwu7Ih27HY3yTje8hg9CqhZufW/x9KiQaQ=; b=QnUoS7DpjfAwhD Y9eaB5IwwKETr5O42l5BEoitu0SoyoecVMkuuGJ5Ebog/0pTjnUdi3iQTehViMJ+B+peFdu3iUv5y +eKbDMScg2n33N3xd3fHe2om9D3VZao13k3oslHeh1YdrCdxdIjw+HO4Ny2IeeI1Go9I1lH484egK CbwfGu1GCFFcCp1Pcxmnl4vTFJZCngWjKLoLQL7E2qTTgqY3ZgGq/2el/s61mSU66lJjHr1Vpj8tl hVpmsNpsskpoU44Ve5vOXmgTM0Qe9YxSWrQAfFUG0Uli2NtOpVq810zDsxROw3TSpGXn5EIqd4rmG WaptkWQZIbqeecrSoHrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGs3j-00EbUw-0i; Wed, 05 Jul 2023 02:15:59 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGs3e-00EbTu-38; Wed, 05 Jul 2023 02:15:58 +0000 Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Qwjrl3xPlz6J7Ml; Wed, 5 Jul 2023 10:13:59 +0800 (CST) Received: from localhost (10.34.206.101) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 5 Jul 2023 03:15:41 +0100 Date: Wed, 5 Jul 2023 10:15:37 +0800 From: Jonathan Cameron To: Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= CC: Yangtao Li , Krzysztof Kozlowski , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 1/5] genirq/devres: Add devm_request_threaded_irq_emsg() Message-ID: <20230705101537.000059d2@Huawei.com> In-Reply-To: <20230704141954.fcmol2yswkpbnpaw@pengutronix.de> References: <20230703090455.62101-1-frank.li@vivo.com> <20230703090455.62101-2-frank.li@vivo.com> <20230703174347.4m6hcmify4jwsozv@pengutronix.de> <11052797-b006-11bb-e4eb-987ddd568b24@kernel.org> <20805fef-d6aa-91d8-999e-04b1d6b7a37a@vivo.com> <20230704141954.fcmol2yswkpbnpaw@pengutronix.de> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.34.206.101] X-ClientProxiedBy: lhrpeml100002.china.huawei.com (7.191.160.241) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230704_191555_320922_108BB494 X-CRM114-Status: GOOD ( 27.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCA0IEp1bCAyMDIzIDE2OjE5OjU0ICswMjAwClV3ZSBLbGVpbmUtS8O2bmlnIDx1Lmts ZWluZS1rb2VuaWdAcGVuZ3V0cm9uaXguZGU+IHdyb3RlOgoKPiBIZWxsbywKPiAKPiBPbiBUdWUs IEp1bCAwNCwgMjAyMyBhdCAwNTowNjoxMlBNICswODAwLCBZYW5ndGFvIExpIHdyb3RlOgo+ID4g T24gMjAyMy83LzQgMTY6NDgsIEtyenlzenRvZiBLb3psb3dza2kgd3JvdGU6Cj4gPiAgIAo+ID4g PiBb5L2g6YCa5bi45LiN5Lya5pS25Yiw5p2l6IeqIGtyemtAa2VybmVsLm9yZyDnmoTnlLXlrZDp gq7ku7bjgILor7forr/pl64gaHR0cHM6Ly9ha2EubXMvTGVhcm5BYm91dFNlbmRlcklkZW50aWZp Y2F0aW9u77yM5Lul5LqG6Kej6L+Z5LiA54K55Li65LuA5LmI5b6I6YeN6KaBXQo+ID4gPiAKPiA+ ID4gT24gMDMvMDcvMjAyMyAxOTo0MywgVXdlIEtsZWluZS1Lw7ZuaWcgd3JvdGU6ICAKPiA+ID4g PiBIZWxsbyBLcnp5c3p0b2YsCj4gPiA+ID4gCj4gPiA+ID4gT24gTW9uLCBKdWwgMDMsIDIwMjMg YXQgMDI6MzE6NTlQTSArMDIwMCwgS3J6eXN6dG9mIEtvemxvd3NraSB3cm90ZTogIAo+ID4gPiA+ ID4gT24gMDMvMDcvMjAyMyAxMTowNCwgWWFuZ3RhbyBMaSB3cm90ZTogIAo+ID4gPiA+ID4gPiBU aGVyZSBhcmUgbW9yZSB0aGFuIDcwMCBjYWxscyB0byB0aGUgZGV2bV9yZXF1ZXN0X3RocmVhZGVk X2lycSBtZXRob2QuCj4gPiA+ID4gPiA+IE1vc3QgZHJpdmVycyBvbmx5IHJlcXVlc3Qgb25lIGlu dGVycnVwdCByZXNvdXJjZSwgYW5kIHRoZXNlIGVycm9yCj4gPiA+ID4gPiA+IG1lc3NhZ2VzIGFy ZSBiYXNpY2FsbHkgdGhlIHNhbWUuIElmIGVycm9yIG1lc3NhZ2VzIGFyZSBwcmludGVkCj4gPiA+ ID4gPiA+IGV2ZXJ5d2hlcmUsIG1vcmUgdGhhbiAxMDAwIGxpbmVzIG9mIGNvZGUgY2FuIGJlIHNh dmVkIGJ5IHJlbW92aW5nIHRoZQo+ID4gPiA+ID4gPiBtc2cgaW4gdGhlIGRyaXZlci4gIAo+ID4g PiA+ID4gCj4gPiA+ID4gPiAuLi4KPiA+ID4gPiA+ICAgCj4gPiA+ID4gPiA+ICtpbnQgZGV2bV9y ZXF1ZXN0X3RocmVhZGVkX2lycV9lbXNnKHN0cnVjdCBkZXZpY2UgKmRldiwgdW5zaWduZWQgaW50 IGlycSwKPiA+ID4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlycV9oYW5k bGVyX3QgaGFuZGxlciwgaXJxX2hhbmRsZXJfdCB0aHJlYWRfZm4sCj4gPiA+ID4gPiA+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBsb25nIGlycWZsYWdzLCBjb25zdCBj aGFyICpkZXZuYW1lLAo+ID4gPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg dm9pZCAqZGV2X2lkLCBjb25zdCBjaGFyICplbXNnKQo+ID4gPiA+ID4gPiArewo+ID4gPiA+ID4g PiArICAgaW50IHJjOwo+ID4gPiA+ID4gPiArCj4gPiA+ID4gPiA+ICsgICByYyA9IGRldm1fcmVx dWVzdF90aHJlYWRlZF9pcnEoZGV2LCBpcnEsIGhhbmRsZXIsIE5VTEwsIGlycWZsYWdzLAo+ID4g PiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRldm5hbWUsIGRldl9p ZCk7Cj4gPiA+ID4gPiA+ICsgICBpZiAocmMgJiYgcmMgIT0gLUVQUk9CRV9ERUZFUikgewo+ID4g PiA+ID4gPiArICAgICAgICAgICBkZXZfZXJyKGRldiwgIkZhaWxlZCB0byByZXF1ZXN0ICVzaW50 ZXJydXB0ICV1ICVzICVzOiAlcGVcbiIsCj4gPiA+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAg dGhyZWFkX2ZuID8gInRocmVhZGVkICIgOiAiIiwgaXJxLCBkZXZuYW1lID8gOiBkZXZfbmFtZShk ZXYpLAo+ID4gPiA+ID4gPiArICAgICAgICAgICAgICAgICAgIGVtc2cgPyA6ICIiLCBFUlJfUFRS KHJjKSk7ICAKPiA+ID4gPiA+IEl0IGlzIG9wZW4tY29kaW5nIGRldl9lcnJfcHJvYmUoKS4gSnVz dCB1c2UgZGV2X2Vycl9wcm9iZSBpbnN0ZWFkLiAgCj4gPiA+ID4gZGV2X2Vycl9wcm9iZSBpcyBz dXBwb3NlZCB0byBiZSBvbmx5IGNhbGxlZCBpbiBwcm9iZSBmdW5jdGlvbnMsIHdoaWxlCj4gPiA+ ID4gZGV2bV9yZXF1ZXN0X3RocmVhZGVkX2lycSBtaWdodCBiZSBjYWxsZWQgaW4gb3RoZXIgY29u dGV4dHMgKGUuZy4gd2hlbiBhCj4gPiA+ID4gZGV2aWNlIGlzIG9wZW5lZCkuIFRoYXQncyB3aHkg SSBhc2tlZCB0byBub3QgdXNlIGRldl9lcnJfcHJvYmUoKSBpbiB2MiAgCj4gPiA+IFRydWUsIGJ1 dCB0aGVuIGFsbCB0aGUgY2FsbGVycyBvZiB0aGlzIGZ1bmN0aW9uIHdpbGwgZm9yZ2V0IHRvIHNl dAo+ID4gPiBkZWZlcnJlZCBwcm9iZSByZWFzb24uICAKPiAKPiBUaGF0J3MgYW5vdGhlciByZWFz b24gZm9yIGxldHRpbmcgdGhlIGRyaXZlciBpc3N1ZSB0aGUgZXJyb3IgbWVzc2FnZSBhbmQKPiBu b3QgdGhlIHJlcXVlc3RfaXJxIGZ1bmN0aW9uLgo+ICAKPiA+IFNvIGxldCdzIHVzZSBkZXZfZXJy X3Byb2JlPwo+ID4gCj4gPiBCVFcsIGFueSBzdWdnZXN0aW9ucyBmb3IgbmFtZXMgaGVyZSwga2Vl cCB1c2luZwo+ID4gZGV2bV9yZXF1ZXN0X3RocmVhZGVkX2lycV9lbXNnIG9yIGNoYW5nZSB0byBh IG5ldyBuYW1lPyAgCj4gCj4gSSB3b3VsZCBoYXZlIGNhbGxlZCBpdCBkZXZtX3JlcXVlc3RfdGhy ZWFkZWRfaXJxX3ZlcmJvc2UoKSB3aGljaCBJCj4gY29uc2lkZXIgZWFzaWVyIHRvIHVuZGVyc3Rh bmQuIEJ1dCBtYXliZSAgaXMganVzdCBteSAoZ3JlZW4pCj4gYmlrZXNoZWQuCgpJZiBnb2luZyB0 byB1c2UgZGV2X2Vycl9wcm9iZSgpIGludGVybmFsbHkgbWF5YmUgY2FuIGp1c3QgdXNlCmRldm1f cmVxdWVzdF90aHJlYWRlZF9pcnFfcHJvYmUoKSB0aHVzIHJlZmxlY3RpbmcgdGhhdCBhbmQgbWFr aW5nCml0IGRpZmZlcmVudCB0byB0aGUgZGV2bV9yZXF1ZXN0X3RocmVhZGVkX2lycSgpPwoKSSdt IG5vdCBzdXJlIHdlIG5lZWQgdG8gY2FsbCBvdXQgdGhlIGZhY3QgaXQgcHJpbnRzIGFuIGVycm9y IG1lc3NhZ2UgaW4KdGhlIG5hbWluZy4gIE1heWJlIHRoZSBmYWN0IGl0IHNob3VsZCBwcm9iYWJs eSBvbmx5IGJlIHVzZWQgaW4gcHJvYmUoKQppcyB0aGUgbW9yZSByZWxldmFudCBpbmZvcm1hdGlv bj8KCkJpa2VzaGVkcyBzaG91bGQgYWxsIGJlIHJlZCEKCkpvbmF0aGFuCgo+IAo+IEJlc3QgcmVn YXJkcwo+IFV3ZQo+IAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK