From: Florian Westphal <fw@strlen.de>
To: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
Pablo Neira Ayuso <pablo@netfilter.org>,
Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH v2] netfilter: nf_tables: prevent OOB access in nft_byteorder_eval
Date: Wed, 5 Jul 2023 23:29:29 +0200 [thread overview]
Message-ID: <20230705212929.GI3751@breakpoint.cc> (raw)
In-Reply-To: <20230705210535.943194-1-cascardo@canonical.com>
Thadeu Lima de Souza Cascardo <cascardo@canonical.com> wrote:
> When evaluating byteorder expressions with size 2, a union with 32-bit and
> 16-bit members is used. Since the 16-bit members are aligned to 32-bit,
> the array accesses will be out-of-bounds.
>
> It may lead to a stack-out-of-bounds access like the one below:
Reviewed-by: Florian Westphal <fw@strlen.de>
next prev parent reply other threads:[~2023-07-05 21:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 12:15 [PATCH] netfilter: nf_tables: prevent OOB access in nft_byteorder_eval Thadeu Lima de Souza Cascardo
2023-07-05 13:03 ` Florian Westphal
2023-07-05 13:50 ` Pablo Neira Ayuso
2023-07-05 18:17 ` Thadeu Lima de Souza Cascardo
2023-07-05 20:12 ` Florian Westphal
2023-07-05 21:05 ` [PATCH v2] " Thadeu Lima de Souza Cascardo
2023-07-05 21:29 ` Florian Westphal [this message]
2023-07-05 22:56 ` Pablo Neira Ayuso
2023-11-02 10:16 ` Dan Carpenter
2023-11-02 10:28 ` Florian Westphal
2023-11-02 12:27 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230705212929.GI3751@breakpoint.cc \
--to=fw@strlen.de \
--cc=cascardo@canonical.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.