From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C976EB64D9 for ; Thu, 6 Jul 2023 06:07:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 4427D81423; Thu, 6 Jul 2023 06:07:38 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 4427D81423 Authentication-Results: smtp1.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=M79slbfz X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rYz7iq2BK4DF; Thu, 6 Jul 2023 06:07:37 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id 4146581414; Thu, 6 Jul 2023 06:07:36 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 4146581414 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 15813C0072; Thu, 6 Jul 2023 06:07:36 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id E01D6C0032 for ; Thu, 6 Jul 2023 06:07:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id AD55E60AD5 for ; Thu, 6 Jul 2023 06:07:34 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org AD55E60AD5 Authentication-Results: smtp3.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=M79slbfz X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rZg8h2UlVjLY for ; Thu, 6 Jul 2023 06:07:32 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 493AA60AAA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp3.osuosl.org (Postfix) with ESMTPS id 493AA60AAA for ; Thu, 6 Jul 2023 06:07:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688623651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QO+V26UGI/WBMUGqFJ+p6LZkGHrVbYJRVlupGwNTzEQ=; b=M79slbfzMXV71sVGSmMkNc3ahm3eteV+Si+hgeZXkHD9Y0kFioDMPdIU52S8K01L+TyQ+V Mj1zrLDkXO0yDyRbK6Hhlt73O8RZcIF70lBQXUVIVOLkzgz99lQMMMszwI2MxVMtEIQW+Y 2mwLw4TpCfZVTUXnRRf8vcICiE2W5UE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-522-1LzyGobxM-WIlYUsKKfAKA-1; Thu, 06 Jul 2023 02:07:27 -0400 X-MC-Unique: 1LzyGobxM-WIlYUsKKfAKA-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-30e3ee8a42eso148262f8f.1 for ; Wed, 05 Jul 2023 23:07:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688623646; x=1691215646; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QO+V26UGI/WBMUGqFJ+p6LZkGHrVbYJRVlupGwNTzEQ=; b=ZboFV7Si10QKT/V0NrDzNYMnX5MvOJoTbuT+vJoUIwmpkKSCzxH8XD4u8FyTVIKwCl Z3X8DaImdWeVqOg//gWFozQxoVhuibSefvDc1UoZP2fEqy8DSwYEehsknCGohWeQ3UtT 8SO4mfplJJk9htCCpdnUPVyX98iQxnel9yykShpOvmhMBhdngqdi5i/uYVOwJqXRTIIh zxlqLDHTBibuvgOo+KsoHoMIoXTck2Tu4X7DEVs2gljDENnCMbjM85sqhWTrHWaKnn69 xGjEshTeguOGR5AI8G2R5jku62eY36lmFgliPkQ7ZJ43UdlzTgpJ4TOHqkKfhz9iWFSq DQ3w== X-Gm-Message-State: ABy/qLaqFZLfISO6n7g62wcdDjFzKZkhawvQmXWO37OZyGJp2MaUB5Tq LkpcR1aTEaNZGYjZbtXU1SpOaHjPuwZ+rpprAWwt7ABjHBlOiQJikvyprkB/4UR7q74VTLekqUs C8H4x8r+w1igtUimGoCqMRBbMsga7n55V4GiD+9dcAg== X-Received: by 2002:a5d:4a92:0:b0:314:1230:29b0 with SMTP id o18-20020a5d4a92000000b00314123029b0mr590417wrq.52.1688623646690; Wed, 05 Jul 2023 23:07:26 -0700 (PDT) X-Google-Smtp-Source: APBJJlHrDUg7w0Am2K8eApMnGUTNaSK+AtEqMa/Nhk+0S8Dvv6TeSL3nnknCHe+T2JWv5yai8Yzccg== X-Received: by 2002:a5d:4a92:0:b0:314:1230:29b0 with SMTP id o18-20020a5d4a92000000b00314123029b0mr590400wrq.52.1688623646344; Wed, 05 Jul 2023 23:07:26 -0700 (PDT) Received: from redhat.com ([2a06:c701:73e5:9a00:6cb0:ad0c:4846:6126]) by smtp.gmail.com with ESMTPSA id q9-20020adff789000000b00313e2abfb8dsm873455wrp.92.2023.07.05.23.07.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jul 2023 23:07:25 -0700 (PDT) Date: Thu, 6 Jul 2023 02:07:23 -0400 From: "Michael S. Tsirkin" To: Shannon Nelson Subject: Re: [PATCH] vdpa: reject F_ENABLE_AFTER_DRIVER_OK if backend does not support it Message-ID: <20230706020603-mutt-send-email-mst@kernel.org> References: <20230703142218.362549-1-eperezma@redhat.com> <20230703105022-mutt-send-email-mst@kernel.org> <20230704063646-mutt-send-email-mst@kernel.org> <20230704114159-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: kvm@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Eugenio Perez Martin X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" T24gV2VkLCBKdWwgMDUsIDIwMjMgYXQgMDU6MDc6MTFQTSAtMDcwMCwgU2hhbm5vbiBOZWxzb24g d3JvdGU6Cj4gT24gNy81LzIzIDExOjI3IEFNLCBFdWdlbmlvIFBlcmV6IE1hcnRpbiB3cm90ZToK PiA+Cj4gPiBPbiBXZWQsIEp1bCA1LCAyMDIzIGF0IDk6NTDigK9BTSBKYXNvbiBXYW5nIDxqYXNv d2FuZ0ByZWRoYXQuY29tPiB3cm90ZToKPiA+ID4gCj4gPiA+IE9uIFR1ZSwgSnVsIDQsIDIwMjMg YXQgMTE6NDXigK9QTSBNaWNoYWVsIFMuIFRzaXJraW4gPG1zdEByZWRoYXQuY29tPiB3cm90ZToK PiA+ID4gPiAKPiA+ID4gPiBPbiBUdWUsIEp1bCAwNCwgMjAyMyBhdCAwMTozNjoxMVBNICswMjAw LCBFdWdlbmlvIFBlcmV6IE1hcnRpbiB3cm90ZToKPiA+ID4gPiA+IE9uIFR1ZSwgSnVsIDQsIDIw MjMgYXQgMTI6MzjigK9QTSBNaWNoYWVsIFMuIFRzaXJraW4gPG1zdEByZWRoYXQuY29tPiB3cm90 ZToKPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+IE9uIFR1ZSwgSnVsIDA0LCAyMDIzIGF0IDEyOjI1 OjMyUE0gKzAyMDAsIEV1Z2VuaW8gUGVyZXogTWFydGluIHdyb3RlOgo+ID4gPiA+ID4gPiA+IE9u IE1vbiwgSnVsIDMsIDIwMjMgYXQgNDo1MuKAr1BNIE1pY2hhZWwgUy4gVHNpcmtpbiA8bXN0QHJl ZGhhdC5jb20+IHdyb3RlOgo+ID4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gPiBPbiBNb24s IEp1bCAwMywgMjAyMyBhdCAwNDoyMjoxOFBNICswMjAwLCBFdWdlbmlvIFDDqXJleiB3cm90ZToK PiA+ID4gPiA+ID4gPiA+ID4gV2l0aCB0aGUgY3VycmVudCBjb2RlIGl0IGlzIGFjY2VwdGVkIGFz IGxvbmcgYXMgdXNlcmxhbmQgc2VuZCBpdC4KPiA+ID4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ ID4gPiA+IEFsdGhvdWdoIHVzZXJsYW5kIHNob3VsZCBub3Qgc2V0IGEgZmVhdHVyZSBmbGFnIHRo YXQgaGFzIG5vdCBiZWVuCj4gPiA+ID4gPiA+ID4gPiA+IG9mZmVyZWQgdG8gaXQgd2l0aCBWSE9T VF9HRVRfQkFDS0VORF9GRUFUVVJFUywgdGhlIGN1cnJlbnQgY29kZSB3aWxsIG5vdAo+ID4gPiA+ ID4gPiA+ID4gPiBjb21wbGFpbiBmb3IgaXQuCj4gPiA+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4g PiA+ID4gPiBTaW5jZSB0aGVyZSBpcyBubyBzcGVjaWZpYyByZWFzb24gZm9yIGFueSBwYXJlbnQg dG8gcmVqZWN0IHRoYXQgYmFja2VuZAo+ID4gPiA+ID4gPiA+ID4gPiBmZWF0dXJlIGJpdCB3aGVu IGl0IGhhcyBiZWVuIHByb3Bvc2VkLCBsZXQncyBjb250cm9sIGl0IGF0IHZkcGEgZnJvbnRlbmQK PiA+ID4gPiA+ID4gPiA+ID4gbGV2ZWwuIEZ1dHVyZSBwYXRjaGVzIG1heSBtb3ZlIHRoaXMgY29u dHJvbCB0byB0aGUgcGFyZW50IGRyaXZlci4KPiA+ID4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ ID4gPiA+IEZpeGVzOiA5Njc4MDBkMmQ1MmUgKCJ2ZHBhOiBhY2NlcHQgVkhPU1RfQkFDS0VORF9G X0VOQUJMRV9BRlRFUl9EUklWRVJfT0sgYmFja2VuZCBmZWF0dXJlIikKPiA+ID4gPiA+ID4gPiA+ ID4gU2lnbmVkLW9mZi1ieTogRXVnZW5pbyBQw6lyZXogPGVwZXJlem1hQHJlZGhhdC5jb20+Cj4g PiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiA+IFBsZWFzZSBkbyBzZW5kIHYzLiBBbmQgYWdh aW4sIEkgZG9uJ3Qgd2FudCB0byBzZW5kICJhZnRlciBkcml2ZXIgb2siIGhhY2sKPiA+ID4gPiA+ ID4gPiA+IHVwc3RyZWFtIGF0IGFsbCwgSSBtZXJnZWQgaXQgaW4gbmV4dCBqdXN0IHRvIGdpdmUg aXQgc29tZSB0ZXN0aW5nLgo+ID4gPiA+ID4gPiA+ID4gV2Ugd2FudCBSSU5HX0FDQ0VTU19BRlRF Ul9LSUNLIG9yIHNvbWUgc3VjaC4KPiA+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+IAo+ID4g PiA+ID4gPiA+IEN1cnJlbnQgZGV2aWNlcyBkbyBub3Qgc3VwcG9ydCB0aGF0IHNlbWFudGljLgo+ ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gV2hpY2ggZGV2aWNlcyBzcGVjaWZpY2FsbHkgYWNjZXNz IHRoZSByaW5nIGFmdGVyIERSSVZFUl9PSyBidXQgYmVmb3JlCj4gPiA+ID4gPiA+IGEga2ljaz8K PiAKPiBUaGUgUERTIHZkcGEgZGV2aWNlIGNhbiBkZWFsIHdpdGggYSBjYWxsIHRvIC5zZXRfdnFf cmVhZHkgYWZ0ZXIgRFJJVkVSX09LIGlzCj4gc2V0LiAgQW5kIEknbSB0b2xkIHRoYXQgb3VyIFZR IGFjdGl2aXR5IHNob3VsZCBzdGFydCB3aXRob3V0IGEga2ljay4KPiAKPiBPdXIgdmRwYSBkZXZp Y2UgRlcgZG9lc24ndCBjdXJyZW50bHkgaGF2ZSBzdXBwb3J0IGZvciBWSVJUSU9fRl9SSU5HX1JF U0VULAo+IGJ1dCBJIGJlbGlldmUgaXQgY291bGQgYmUgYWRkZWQgd2l0aG91dCB0b28gbXVjaCB0 cm91YmxlLgo+IAo+IHNsbgo+IAoKT0sgaXQgc2VlbXMgY2xlYXIgYXQgbGVhc3QgaW4gdGhlIGN1 cnJlbnQgdmVyc2lvbiBwZHMgbmVlZHMKVkhPU1RfQkFDS0VORF9GX0VOQUJMRV9BRlRFUl9EUklW RVJfT0suCkhvd2V2ZXIgY2FuIHdlIGFsc28gY29kZSB1cCB0aGUgUklOR19SRVNFVCBwYXRoIGFz IHRoZSBkZWZhdWx0PwpUaGVuIGRvd24gdGhlIHJvYWQgdmVuZG9ycyBjYW4gY2hvb3NlIHdoYXQg dG8gZG8uCgoKCgoKPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiAKPiA+ID4gPiA+IFByZXZpb3VzIHZl cnNpb25zIG9mIHRoZSBRRU1VIExNIHNlcmllcyBkaWQgYSBzcHVyaW91cyBraWNrIHRvIHN0YXJ0 Cj4gPiA+ID4gPiB0cmFmZmljIGF0IHRoZSBMTSBkZXN0aW5hdGlvbiBbMV0uIFdoZW4gaXQgd2Fz IHByb3Bvc2VkLCB0aGF0IHNwdXJpb3VzCj4gPiA+ID4gPiBraWNrIHdhcyByZW1vdmVkIGZyb20g dGhlIHNlcmllcyBiZWNhdXNlIHRvIGNoZWNrIGZvciBkZXNjcmlwdG9ycwo+ID4gPiA+ID4gYWZ0 ZXIgZHJpdmVyX29rLCBldmVuIHdpdGhvdXQgYSBraWNrLCB3YXMgY29uc2lkZXJlZCB3b3JrIG9m IHRoZQo+ID4gPiA+ID4gcGFyZW50IGRyaXZlci4KPiA+ID4gPiA+IAo+ID4gPiA+ID4gSSdtIG9r IHRvIGdvIGJhY2sgdG8gdGhpcyBzcHVyaW91cyBraWNrLCBidXQgSSdtIG5vdCBzdXJlIGlmIHRo ZSBodwo+ID4gPiA+ID4gd2lsbCByZWFkIHRoZSByaW5nIGJlZm9yZSB0aGUga2ljayBhY3R1YWxs eS4gSSBjYW4gYXNrLgo+ID4gPiA+ID4gCj4gPiA+ID4gPiBUaGFua3MhCj4gPiA+ID4gPiAKPiA+ ID4gPiA+IFsxXSBodHRwczovL2xpc3RzLm5vbmdudS5vcmcvYXJjaGl2ZS9odG1sL3FlbXUtZGV2 ZWwvMjAyMy0wMS9tc2cwMjc3NS5odG1sCj4gPiA+ID4gCj4gPiA+ID4gTGV0J3MgZmluZCBvdXQu IFdlIG5lZWQgdG8gY2hlY2sgZm9yIEVOQUJMRV9BRlRFUl9EUklWRVJfT0sgdG9vLCBubz8KPiA+ ID4gCj4gPiA+IE15IHVuZGVyc3RhbmRpbmcgaXMgWzFdIGFzc3VtaW5nIEFDQ0VTU19BRlRFUl9L SUNLLiBUaGlzIHNlZW1zCj4gPiA+IHN1Yi1vcHRpbWFsIHRoYW4gYXNzdW1pbmcgRU5BQkxFX0FG VEVSX0RSSVZFUl9PSy4KPiA+ID4gCj4gPiA+IEJ1dCB0aGlzIHJlbWluZHMgbWUgb25lIHRoaW5n LCBhcyB0aGUgdGhyZWFkIGlzIGdvaW5nIHRvbyBsb25nLCBJCj4gPiA+IHdvbmRlciBpZiB3ZSBz aW1wbHkgYXNzdW1lIEVOQUJMRV9BRlRFUl9EUklWRVJfT0sgaWYgUklOR19SRVNFVCBpcwo+ID4g PiBzdXBwb3J0ZWQ/Cj4gPiA+IAo+ID4gCj4gPiBUaGUgcHJvYmxlbSB3aXRoIHRoYXQgaXMgdGhh dCB0aGUgZGV2aWNlIG5lZWRzIHRvIHN1cHBvcnQgYWxsCj4gPiBSSU5HX1JFU0VULCBsaWtlIHRv IGJlIGFibGUgdG8gY2hhbmdlIHZxIGFkZHJlc3MgZXRjIGFmdGVyIERSSVZFUl9PSy4KPiA+IE5v dCBhbGwgSFcgc3VwcG9ydCBpdC4KPiA+IAo+ID4gV2UganVzdCBuZWVkIHRoZSBzdWJzZXQgb2Yg aGF2aW5nIHRoZSBkYXRhcGxhbmUgZnJlZXplZCB1bnRpbCBhbGwgQ1ZRCj4gPiBjb21tYW5kcyBo YXZlIGJlZW4gY29uc3VtZWQuIEknbSBzdXJlIGN1cnJlbnQgdkRQQSBjb2RlIGFscmVhZHkKPiA+ IHN1cHBvcnRzIGl0IGluIHNvbWUgZGV2aWNlcywgbGlrZSBNTFggYW5kIFBTRC4KPiA+IAo+ID4g VGhhbmtzIQo+ID4gCj4gPiA+IFRoYW5rcwo+ID4gPiAKPiA+ID4gPiAKPiA+ID4gPiAKPiA+ID4g PiAKPiA+ID4gPiA+ID4gPiBNeSBwbGFuIHdhcyB0byBjb252ZXJ0Cj4gPiA+ID4gPiA+ID4gaXQg aW4gdnBfdmRwYSBpZiBuZWVkZWQsIGFuZCByZXVzZSB0aGUgY3VycmVudCB2ZHBhIG9wcy4gU29y cnkgaWYgSQo+ID4gPiA+ID4gPiA+IHdhcyBub3QgZXhwbGljaXQgZW5vdWdoLgo+ID4gPiA+ID4g PiA+IAo+ID4gPiA+ID4gPiA+IFRoZSBvbmx5IHNvbHV0aW9uIEkgY2FuIHNlZSB0byB0aGF0IGlz IHRvIHRyYXAgJiBlbXVsYXRlIGluIHRoZSB2ZHBhCj4gPiA+ID4gPiA+ID4gKHBhcmVudD8pIGRy aXZlciwgYXMgdGFsa2VkIGluIHZpcnRpby1jb21tZW50LiBCdXQgdGhhdCBjb21wbGljYXRlcwo+ ID4gPiA+ID4gPiA+IHRoZSBhcmNoaXRlY3R1cmU6Cj4gPiA+ID4gPiA+ID4gKiBPZmZlciBWSE9T VF9CQUNLRU5EX0ZfUklOR19BQ0NFU1NfQUZURVJfS0lDSwo+ID4gPiA+ID4gPiA+ICogU3RvcmUg dnEgZW5hYmxlIHN0YXRlIHNlcGFyYXRlbHksIGF0Cj4gPiA+ID4gPiA+ID4gdmRwYS0+Y29uZmln LT5zZXRfdnFfcmVhZHkodHJ1ZSksIGJ1dCBub3QgdHJhbnNtaXQgdGhhdCBlbmFibGUgdG8gaHcK PiA+ID4gPiA+ID4gPiAqIFN0b3JlIHRoZSBkb29yYmVsbCBzdGF0ZSBzZXBhcmF0ZWx5LCBidXQg ZG8gbm90IGNvbmZpZ3VyZSBpdCB0byB0aGUKPiA+ID4gPiA+ID4gPiBkZXZpY2UgZGlyZWN0bHku Cj4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gQnV0IGhvdyB0byByZWNvdmVyIGlmIHRoZSBk ZXZpY2UgY2Fubm90IGNvbmZpZ3VyZSB0aGVtIGF0IGtpY2sgdGltZSwKPiA+ID4gPiA+ID4gPiBm b3IgZXhhbXBsZT8KPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiBNYXliZSB3ZSBjYW4ganVz dCBmYWlsIGlmIHRoZSBwYXJlbnQgZHJpdmVyIGRvZXMgbm90IHN1cHBvcnQgZW5hYmxpbmcKPiA+ ID4gPiA+ID4gPiB0aGUgdnEgYWZ0ZXIgRFJJVkVSX09LPyBUaGF0IHdheSBubyBuZXcgZmVhdHVy ZSBmbGFnIGlzIG5lZWRlZC4KPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiBUaGFua3MhCj4g PiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiA+ID4gLS0tCj4gPiA+ ID4gPiA+ID4gPiA+IFNlbnQgd2l0aCBGaXhlczogdGFnIHBvaW50aW5nIHRvIGdpdC5rZXJuZWwu b3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC9tc3QKPiA+ID4gPiA+ID4gPiA+ID4gY29tbWl0 LiBQbGVhc2UgbGV0IG1lIGtub3cgaWYgSSBzaG91bGQgc2VuZCBhIHYzIG9mIFsxXSBpbnN0ZWFk Lgo+ID4gPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiA+ID4gWzFdIGh0dHBzOi8vbG9yZS5r ZXJuZWwub3JnL2xrbWwvMjAyMzA2MDkxMjEyNDQtbXV0dC1zZW5kLWVtYWlsLW1zdEBrZXJuZWwu b3JnL1QvCj4gPiA+ID4gPiA+ID4gPiA+IC0tLQo+ID4gPiA+ID4gPiA+ID4gPiAgIGRyaXZlcnMv dmhvc3QvdmRwYS5jIHwgNyArKysrKy0tCj4gPiA+ID4gPiA+ID4gPiA+ICAgMSBmaWxlIGNoYW5n ZWQsIDUgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiA+ID4gPiA+ID4gPiA+ID4gCj4g PiA+ID4gPiA+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3Zob3N0L3ZkcGEuYyBiL2RyaXZl cnMvdmhvc3QvdmRwYS5jCj4gPiA+ID4gPiA+ID4gPiA+IGluZGV4IGUxYWJmMjlmZWQ1Yi4uYTdl NTU0MzUyMzUxIDEwMDY0NAo+ID4gPiA+ID4gPiA+ID4gPiAtLS0gYS9kcml2ZXJzL3Zob3N0L3Zk cGEuYwo+ID4gPiA+ID4gPiA+ID4gPiArKysgYi9kcml2ZXJzL3Zob3N0L3ZkcGEuYwo+ID4gPiA+ ID4gPiA+ID4gPiBAQCAtNjgxLDE4ICs2ODEsMjEgQEAgc3RhdGljIGxvbmcgdmhvc3RfdmRwYV91 bmxvY2tlZF9pb2N0bChzdHJ1Y3QgZmlsZSAqZmlsZXAsCj4gPiA+ID4gPiA+ID4gPiA+ICAgewo+ ID4gPiA+ID4gPiA+ID4gPiAgICAgICAgc3RydWN0IHZob3N0X3ZkcGEgKnYgPSBmaWxlcC0+cHJp dmF0ZV9kYXRhOwo+ID4gPiA+ID4gPiA+ID4gPiAgICAgICAgc3RydWN0IHZob3N0X2RldiAqZCA9 ICZ2LT52ZGV2Owo+ID4gPiA+ID4gPiA+ID4gPiArICAgICBjb25zdCBzdHJ1Y3QgdmRwYV9jb25m aWdfb3BzICpvcHMgPSB2LT52ZHBhLT5jb25maWc7Cj4gPiA+ID4gPiA+ID4gPiA+ICAgICAgICB2 b2lkIF9fdXNlciAqYXJncCA9ICh2b2lkIF9fdXNlciAqKWFyZzsKPiA+ID4gPiA+ID4gPiA+ID4g ICAgICAgIHU2NCBfX3VzZXIgKmZlYXR1cmVwID0gYXJncDsKPiA+ID4gPiA+ID4gPiA+ID4gLSAg ICAgdTY0IGZlYXR1cmVzOwo+ID4gPiA+ID4gPiA+ID4gPiArICAgICB1NjQgZmVhdHVyZXMsIHBh cmVudF9mZWF0dXJlcyA9IDA7Cj4gPiA+ID4gPiA+ID4gPiA+ICAgICAgICBsb25nIHIgPSAwOwo+ ID4gPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiA+ID4gICAgICAgIGlmIChjbWQgPT0gVkhP U1RfU0VUX0JBQ0tFTkRfRkVBVFVSRVMpIHsKPiA+ID4gPiA+ID4gPiA+ID4gICAgICAgICAgICAg ICAgaWYgKGNvcHlfZnJvbV91c2VyKCZmZWF0dXJlcywgZmVhdHVyZXAsIHNpemVvZihmZWF0dXJl cykpKQo+ID4gPiA+ID4gPiA+ID4gPiAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiAtRUZB VUxUOwo+ID4gPiA+ID4gPiA+ID4gPiArICAgICAgICAgICAgIGlmIChvcHMtPmdldF9iYWNrZW5k X2ZlYXR1cmVzKQo+ID4gPiA+ID4gPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgcGFyZW50 X2ZlYXR1cmVzID0gb3BzLT5nZXRfYmFja2VuZF9mZWF0dXJlcyh2LT52ZHBhKTsKPiA+ID4gPiA+ ID4gPiA+ID4gICAgICAgICAgICAgICAgaWYgKGZlYXR1cmVzICYgfihWSE9TVF9WRFBBX0JBQ0tF TkRfRkVBVFVSRVMgfAo+ID4gPiA+ID4gPiA+ID4gPiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIEJJVF9VTEwoVkhPU1RfQkFDS0VORF9GX1NVU1BFTkQpIHwKPiA+ID4gPiA+ID4gPiA+ ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBCSVRfVUxMKFZIT1NUX0JBQ0tFTkRf Rl9SRVNVTUUpIHwKPiA+ID4gPiA+ID4gPiA+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIEJJVF9VTEwoVkhPU1RfQkFDS0VORF9GX0VOQUJMRV9BRlRFUl9EUklWRVJfT0spKSkKPiA+ ID4gPiA+ID4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBhcmVudF9mZWF0 dXJlcykpCj4gPiA+ID4gPiA+ID4gPiA+ICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIC1F T1BOT1RTVVBQOwo+ID4gPiA+ID4gPiA+ID4gPiAgICAgICAgICAgICAgICBpZiAoKGZlYXR1cmVz ICYgQklUX1VMTChWSE9TVF9CQUNLRU5EX0ZfU1VTUEVORCkpICYmCj4gPiA+ID4gPiA+ID4gPiA+ ICAgICAgICAgICAgICAgICAgICAgIXZob3N0X3ZkcGFfY2FuX3N1c3BlbmQodikpCj4gPiA+ID4g PiA+ID4gPiA+IC0tCj4gPiA+ID4gPiA+ID4gPiA+IDIuMzkuMwo+ID4gPiA+ID4gPiA+ID4gCj4g PiA+ID4gPiA+IAo+ID4gPiA+IAo+ID4gPiAKPiA+IAoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KVmlydHVhbGl6YXRpb24gbWFpbGluZyBsaXN0ClZpcnR1 YWxpemF0aW9uQGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhm b3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL3ZpcnR1YWxpemF0aW9u From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62122EB64DD for ; Thu, 6 Jul 2023 06:10:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233493AbjGFGKB (ORCPT ); Thu, 6 Jul 2023 02:10:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233483AbjGFGJ7 (ORCPT ); Thu, 6 Jul 2023 02:09:59 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E31AE1FFD for ; Wed, 5 Jul 2023 23:08:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688623648; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QO+V26UGI/WBMUGqFJ+p6LZkGHrVbYJRVlupGwNTzEQ=; b=Te1rbunQ2rLtn5S0NZAJ1xKzw/4zzgMXGAPgqbfKm86hg54gSYJZZP/OTckAIvToBKgFkd MyfTo5RkKQhpLLaT0PKkNMVx42CcsP8GBhVIfuhgOlpBkmI0oGU9r4bGkqinjbI+fH4vYZ 5clyPOy8qKmiFmbu8I8YLNWdm1jxVBU= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-615-LU2o3VuWNMi4vG4BUJPZOg-1; Thu, 06 Jul 2023 02:07:27 -0400 X-MC-Unique: LU2o3VuWNMi4vG4BUJPZOg-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3143ac4a562so145720f8f.2 for ; Wed, 05 Jul 2023 23:07:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688623646; x=1691215646; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QO+V26UGI/WBMUGqFJ+p6LZkGHrVbYJRVlupGwNTzEQ=; b=FYU7S5MpuQnoovIdrk/lMHSwGoHyTFkDBvJYXh1+EzFdGIqtobz+ktKQ6zKM9lojl/ 2ZXYJ9OiWkdXpo/lwkrS+cJaVLVqDGIo42vm+oc118r+7MBqJssP8+6X7ssDuTd2/T6B ZanJGf9iSp3XTpRmucq9OixKmdI/6y40AyY/ECX7SaCSJdc77w8+auBCZ9Ven2VXEcbn EqaLe9bpYcj3GGOazZYUOl5f4FgyNeRP7E5yUK7jCJmVGu66mJJ2VkpLzmIITg0RYlUd TFZ6evqJnsnJ7ktAWc/peL6nKxijKAUsMB57XQjQ31DGt5l6CksPjT2Mo+bwBiibrPR5 SAkA== X-Gm-Message-State: ABy/qLYlyQQpM17Mp5y9Sw6vd/8yyVC184cZw7EJec3lkQOP2rnQHojN 0bVdejmHGHnoj14iPRc5GpX5MvXiq1W8acv80ObqV7ATjIcagTIk/CIQ8qf+wqy7alOxCg4PIO/ VxeCyWv9LL85m X-Received: by 2002:a5d:4a92:0:b0:314:1230:29b0 with SMTP id o18-20020a5d4a92000000b00314123029b0mr590413wrq.52.1688623646690; Wed, 05 Jul 2023 23:07:26 -0700 (PDT) X-Google-Smtp-Source: APBJJlHrDUg7w0Am2K8eApMnGUTNaSK+AtEqMa/Nhk+0S8Dvv6TeSL3nnknCHe+T2JWv5yai8Yzccg== X-Received: by 2002:a5d:4a92:0:b0:314:1230:29b0 with SMTP id o18-20020a5d4a92000000b00314123029b0mr590400wrq.52.1688623646344; Wed, 05 Jul 2023 23:07:26 -0700 (PDT) Received: from redhat.com ([2a06:c701:73e5:9a00:6cb0:ad0c:4846:6126]) by smtp.gmail.com with ESMTPSA id q9-20020adff789000000b00313e2abfb8dsm873455wrp.92.2023.07.05.23.07.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jul 2023 23:07:25 -0700 (PDT) Date: Thu, 6 Jul 2023 02:07:23 -0400 From: "Michael S. Tsirkin" To: Shannon Nelson Cc: Eugenio Perez Martin , Jason Wang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org Subject: Re: [PATCH] vdpa: reject F_ENABLE_AFTER_DRIVER_OK if backend does not support it Message-ID: <20230706020603-mutt-send-email-mst@kernel.org> References: <20230703142218.362549-1-eperezma@redhat.com> <20230703105022-mutt-send-email-mst@kernel.org> <20230704063646-mutt-send-email-mst@kernel.org> <20230704114159-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Jul 05, 2023 at 05:07:11PM -0700, Shannon Nelson wrote: > On 7/5/23 11:27 AM, Eugenio Perez Martin wrote: > > > > On Wed, Jul 5, 2023 at 9:50 AM Jason Wang wrote: > > > > > > On Tue, Jul 4, 2023 at 11:45 PM Michael S. Tsirkin wrote: > > > > > > > > On Tue, Jul 04, 2023 at 01:36:11PM +0200, Eugenio Perez Martin wrote: > > > > > On Tue, Jul 4, 2023 at 12:38 PM Michael S. Tsirkin wrote: > > > > > > > > > > > > On Tue, Jul 04, 2023 at 12:25:32PM +0200, Eugenio Perez Martin wrote: > > > > > > > On Mon, Jul 3, 2023 at 4:52 PM Michael S. Tsirkin wrote: > > > > > > > > > > > > > > > > On Mon, Jul 03, 2023 at 04:22:18PM +0200, Eugenio Pérez wrote: > > > > > > > > > With the current code it is accepted as long as userland send it. > > > > > > > > > > > > > > > > > > Although userland should not set a feature flag that has not been > > > > > > > > > offered to it with VHOST_GET_BACKEND_FEATURES, the current code will not > > > > > > > > > complain for it. > > > > > > > > > > > > > > > > > > Since there is no specific reason for any parent to reject that backend > > > > > > > > > feature bit when it has been proposed, let's control it at vdpa frontend > > > > > > > > > level. Future patches may move this control to the parent driver. > > > > > > > > > > > > > > > > > > Fixes: 967800d2d52e ("vdpa: accept VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK backend feature") > > > > > > > > > Signed-off-by: Eugenio Pérez > > > > > > > > > > > > > > > > Please do send v3. And again, I don't want to send "after driver ok" hack > > > > > > > > upstream at all, I merged it in next just to give it some testing. > > > > > > > > We want RING_ACCESS_AFTER_KICK or some such. > > > > > > > > > > > > > > > > > > > > > > Current devices do not support that semantic. > > > > > > > > > > > > Which devices specifically access the ring after DRIVER_OK but before > > > > > > a kick? > > The PDS vdpa device can deal with a call to .set_vq_ready after DRIVER_OK is > set. And I'm told that our VQ activity should start without a kick. > > Our vdpa device FW doesn't currently have support for VIRTIO_F_RING_RESET, > but I believe it could be added without too much trouble. > > sln > OK it seems clear at least in the current version pds needs VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK. However can we also code up the RING_RESET path as the default? Then down the road vendors can choose what to do. > > > > > > > > > > > > > > > > Previous versions of the QEMU LM series did a spurious kick to start > > > > > traffic at the LM destination [1]. When it was proposed, that spurious > > > > > kick was removed from the series because to check for descriptors > > > > > after driver_ok, even without a kick, was considered work of the > > > > > parent driver. > > > > > > > > > > I'm ok to go back to this spurious kick, but I'm not sure if the hw > > > > > will read the ring before the kick actually. I can ask. > > > > > > > > > > Thanks! > > > > > > > > > > [1] https://lists.nongnu.org/archive/html/qemu-devel/2023-01/msg02775.html > > > > > > > > Let's find out. We need to check for ENABLE_AFTER_DRIVER_OK too, no? > > > > > > My understanding is [1] assuming ACCESS_AFTER_KICK. This seems > > > sub-optimal than assuming ENABLE_AFTER_DRIVER_OK. > > > > > > But this reminds me one thing, as the thread is going too long, I > > > wonder if we simply assume ENABLE_AFTER_DRIVER_OK if RING_RESET is > > > supported? > > > > > > > The problem with that is that the device needs to support all > > RING_RESET, like to be able to change vq address etc after DRIVER_OK. > > Not all HW support it. > > > > We just need the subset of having the dataplane freezed until all CVQ > > commands have been consumed. I'm sure current vDPA code already > > supports it in some devices, like MLX and PSD. > > > > Thanks! > > > > > Thanks > > > > > > > > > > > > > > > > > > > > > > My plan was to convert > > > > > > > it in vp_vdpa if needed, and reuse the current vdpa ops. Sorry if I > > > > > > > was not explicit enough. > > > > > > > > > > > > > > The only solution I can see to that is to trap & emulate in the vdpa > > > > > > > (parent?) driver, as talked in virtio-comment. But that complicates > > > > > > > the architecture: > > > > > > > * Offer VHOST_BACKEND_F_RING_ACCESS_AFTER_KICK > > > > > > > * Store vq enable state separately, at > > > > > > > vdpa->config->set_vq_ready(true), but not transmit that enable to hw > > > > > > > * Store the doorbell state separately, but do not configure it to the > > > > > > > device directly. > > > > > > > > > > > > > > But how to recover if the device cannot configure them at kick time, > > > > > > > for example? > > > > > > > > > > > > > > Maybe we can just fail if the parent driver does not support enabling > > > > > > > the vq after DRIVER_OK? That way no new feature flag is needed. > > > > > > > > > > > > > > Thanks! > > > > > > > > > > > > > > > > > > > > > > > > --- > > > > > > > > > Sent with Fixes: tag pointing to git.kernel.org/pub/scm/linux/kernel/git/mst > > > > > > > > > commit. Please let me know if I should send a v3 of [1] instead. > > > > > > > > > > > > > > > > > > [1] https://lore.kernel.org/lkml/20230609121244-mutt-send-email-mst@kernel.org/T/ > > > > > > > > > --- > > > > > > > > > drivers/vhost/vdpa.c | 7 +++++-- > > > > > > > > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > > > > > > > > > > > > > > > diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c > > > > > > > > > index e1abf29fed5b..a7e554352351 100644 > > > > > > > > > --- a/drivers/vhost/vdpa.c > > > > > > > > > +++ b/drivers/vhost/vdpa.c > > > > > > > > > @@ -681,18 +681,21 @@ static long vhost_vdpa_unlocked_ioctl(struct file *filep, > > > > > > > > > { > > > > > > > > > struct vhost_vdpa *v = filep->private_data; > > > > > > > > > struct vhost_dev *d = &v->vdev; > > > > > > > > > + const struct vdpa_config_ops *ops = v->vdpa->config; > > > > > > > > > void __user *argp = (void __user *)arg; > > > > > > > > > u64 __user *featurep = argp; > > > > > > > > > - u64 features; > > > > > > > > > + u64 features, parent_features = 0; > > > > > > > > > long r = 0; > > > > > > > > > > > > > > > > > > if (cmd == VHOST_SET_BACKEND_FEATURES) { > > > > > > > > > if (copy_from_user(&features, featurep, sizeof(features))) > > > > > > > > > return -EFAULT; > > > > > > > > > + if (ops->get_backend_features) > > > > > > > > > + parent_features = ops->get_backend_features(v->vdpa); > > > > > > > > > if (features & ~(VHOST_VDPA_BACKEND_FEATURES | > > > > > > > > > BIT_ULL(VHOST_BACKEND_F_SUSPEND) | > > > > > > > > > BIT_ULL(VHOST_BACKEND_F_RESUME) | > > > > > > > > > - BIT_ULL(VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK))) > > > > > > > > > + parent_features)) > > > > > > > > > return -EOPNOTSUPP; > > > > > > > > > if ((features & BIT_ULL(VHOST_BACKEND_F_SUSPEND)) && > > > > > > > > > !vhost_vdpa_can_suspend(v)) > > > > > > > > > -- > > > > > > > > > 2.39.3 > > > > > > > > > > > > > > > > > > > > > > >