From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1B7BEB64D9 for ; Thu, 6 Jul 2023 03:53:15 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2DA48861EB; Thu, 6 Jul 2023 05:53:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 15A3486202; Thu, 6 Jul 2023 05:53:12 +0200 (CEST) Received: from muru.com (muru.com [72.249.23.125]) by phobos.denx.de (Postfix) with ESMTP id D2362861C2 for ; Thu, 6 Jul 2023 05:53:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=tony@atomide.com Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id B3E12807E; Thu, 6 Jul 2023 03:53:07 +0000 (UTC) Date: Thu, 6 Jul 2023 06:53:06 +0300 From: Tony Lindgren To: Tom Rini Cc: Roger Quadros , Nishanth Menon , Julien Panis , u-boot@lists.denx.de, vigneshr@ti.com Subject: Re: [PATCH v2 0/2] Fix 'no USB device found' error. Message-ID: <20230706035306.GA5086@atomide.com> References: <20230621-fix_usb_ether_init-v2-0-ff121f0e8d7a@baylibre.com> <20230622154915.GO3931582@bill-the-cat> <8bcf4961-12ea-33c6-de2b-b9f2d1b6c6c1@baylibre.com> <20230623175938.GR3931582@bill-the-cat> <20230626073258.7y2j4ygk7eapgbql@kobold> <20230703162219.GW3931582@bill-the-cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230703162219.GW3931582@bill-the-cat> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean * Tom Rini [230703 16:22]: > On Mon, Jul 03, 2023 at 07:12:47PM +0300, Roger Quadros wrote: > > Linux DT files are correct. USB0 is a dual-role port so it sets it to 'otg'. > > u-boot doesn't support 'otg' so we need to override it to 'peripheral' in -u-boot.dtsi > > Ah, thanks, that was the missing bit of background information. It would be best to parse dual-role feature in the driver to handle it as peripheral only and keep the dts the same. Regards, Tony