From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1A5CEB64D9 for ; Thu, 6 Jul 2023 14:06:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2380710E404; Thu, 6 Jul 2023 14:06:37 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5C75010E403 for ; Thu, 6 Jul 2023 14:02:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688652143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0GE7k8I9982HVE9TTWbDiwrZOKfvdOMPK3S9DyegjXE=; b=bHuAjGdMeb5UM7luqOYiBeR/SBM0Uv+jAqXatTXJi/062i/HA8yoilJE8rurBOGAcNj6PJ 6QkXfiyWmZ8I1+XwOC/2hHjGv2710/4PkQjn1WHxlCz9xzt178m6/jQdOQJkITqOcseSee rOrFxSlRIx5fxO95bWgnL4effoiLkVs= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-179-j2jn559mPj-HKLiI7yRfSQ-1; Thu, 06 Jul 2023 10:02:21 -0400 X-MC-Unique: j2jn559mPj-HKLiI7yRfSQ-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3141a98a29aso417737f8f.1 for ; Thu, 06 Jul 2023 07:02:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688652140; x=1691244140; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0GE7k8I9982HVE9TTWbDiwrZOKfvdOMPK3S9DyegjXE=; b=MC65W4Y/EM0ExlYyvdUxGQ6HxXndVfGY7Qtn65wxgwcMz1dpDtwwFMHyJe70EskEzD tYKkhu8JAguMK8eyzCqVyMfR2X3UUycaMvh/fwf4SES4ZCVojOwLhwXdw8TrWvd73RZY XUtYFXs2UgM7pDVlxH+TzQzAu4YnKx07JXagLqsvqYTWdyMDIgBs/EuvNWuSvy3ANNhC PFs1CuIzoapG3xzNpoIyfXZSApWDRW3rH85GLIJ4onHodMizSi/RaH/85dhJTiPW/c6N 7HhGc8r3T7aYQh6MXGWlgPjc1rnppfCOwrGZcD1sA1DZNF83u945p51MooZpGwjpQo+I cVNQ== X-Gm-Message-State: ABy/qLaA48M3YMyFlaR1/pUH8jLJeyKI/4Vb5lAK7tnvRZUXAFoDynoY BZycMYDKfwV4GZmYhz+V3UkaYP/TcNiaJE2vIc/PAx9sQiHpTDjnHTU2U4fFz2EoMc+iZRC0Tip 39ua3FzzbCatT0pyL0LWlD2qBEw== X-Received: by 2002:a5d:4e12:0:b0:313:e2c8:bed1 with SMTP id p18-20020a5d4e12000000b00313e2c8bed1mr2235658wrt.34.1688652140610; Thu, 06 Jul 2023 07:02:20 -0700 (PDT) X-Google-Smtp-Source: APBJJlHcrZAK048UNMfdOsb+IYlPvPsKZoDto6N+0HK8CkttE8tg+x61xjZ/Drujf9ZKOumGT2ngEg== X-Received: by 2002:a5d:4e12:0:b0:313:e2c8:bed1 with SMTP id p18-20020a5d4e12000000b00313e2c8bed1mr2235624wrt.34.1688652140228; Thu, 06 Jul 2023 07:02:20 -0700 (PDT) Received: from redhat.com ([2.52.13.33]) by smtp.gmail.com with ESMTPSA id o2-20020a5d4742000000b0031434936f0dsm1960350wrs.68.2023.07.06.07.02.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jul 2023 07:02:19 -0700 (PDT) Date: Thu, 6 Jul 2023 10:02:13 -0400 From: "Michael S. Tsirkin" To: Yang Rong Subject: Re: [PATCH] Fix max/min warnings in virtio_net, amd/display, and io_uring Message-ID: <20230706100133-mutt-send-email-mst@kernel.org> References: <20230706021102.2066-1-yangrong@vivo.com> MIME-Version: 1.0 In-Reply-To: <20230706021102.2066-1-yangrong@vivo.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Thu, 06 Jul 2023 14:06:34 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Max Tseng , Christian =?iso-8859-1?Q?K=F6nig?= , Jason Wang , "open list:DRM DRIVERS" , "open list:VIRTIO CORE AND NET DRIVERS" , Eric Dumazet , Jun Lei , Josip Pavic , Xuan Zhuo , David Airlie , Rodrigo Siqueira , "open list:AMD DISPLAY CORE" , "open list:IO_URING" , Alvin Lee , Jakub Kicinski , Paolo Abeni , Harry Wentland , opensource.kernel@vivo.com, Leo Li , Cruise Hung , Jens Axboe , "open list:NETWORKING DRIVERS" , Qingqing Zhuo , "Pan, Xinhui" , open list , luhongfei@vivo.com, "David S. Miller" , Daniel Vetter , Alex Deucher , Pavel Begunkov Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Thu, Jul 06, 2023 at 10:06:16AM +0800, Yang Rong wrote: > The files drivers/net/virtio_net.c, drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c, and io_uring/io_uring.c were modified to fix warnings. what warnings? the point of the warning is to analyze it not "fix" it blindly. > Specifically, the opportunities for max() and min() were utilized to address the warnings. > > Signed-off-by: Yang Rong > --- > drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 6 +++--- > drivers/net/virtio_net.c | 3 ++- > io_uring/io_uring.c | 3 ++- > 3 files changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c > index c753c6f30dd7..df79aea49a3c 100644 > --- a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c > +++ b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c > @@ -22,7 +22,7 @@ > * Authors: AMD > * > */ > - > +#include > #include "dc.h" > #include "dc_dmub_srv.h" > #include "../dmub/dmub_srv.h" > @@ -481,7 +481,7 @@ static void populate_subvp_cmd_drr_info(struct dc *dc, > max_drr_vblank_us = div64_u64((subvp_active_us - prefetch_us - > dc->caps.subvp_fw_processing_delay_us - drr_active_us), 2) + drr_active_us; > max_drr_mallregion_us = subvp_active_us - prefetch_us - mall_region_us - dc->caps.subvp_fw_processing_delay_us; > - max_drr_supported_us = max_drr_vblank_us > max_drr_mallregion_us ? max_drr_vblank_us : max_drr_mallregion_us; > + max_drr_supported_us = max(max_drr_vblank_us, max_drr_mallregion_us); > max_vtotal_supported = div64_u64(((uint64_t)drr_timing->pix_clk_100hz * 100 * max_drr_supported_us), > (((uint64_t)drr_timing->h_total * 1000000))); > > @@ -771,7 +771,7 @@ void dc_dmub_setup_subvp_dmub_command(struct dc *dc, > wm_val_refclk = context->bw_ctx.bw.dcn.watermarks.a.cstate_pstate.pstate_change_ns * > (dc->res_pool->ref_clocks.dchub_ref_clock_inKhz / 1000) / 1000; > > - cmd.fw_assisted_mclk_switch_v2.config_data.watermark_a_cache = wm_val_refclk < 0xFFFF ? wm_val_refclk : 0xFFFF; > + cmd.fw_assisted_mclk_switch_v2.config_data.watermark_a_cache = min(wm_val_refclk, 0xFFFF); > } > > dm_execute_dmub_cmd(dc->ctx, &cmd, DM_DMUB_WAIT_TYPE_WAIT); > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index 9b3721424e71..5bb7da885f00 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -22,6 +22,7 @@ > #include > #include > #include > +#include > > static int napi_weight = NAPI_POLL_WEIGHT; > module_param(napi_weight, int, 0444); > @@ -1291,7 +1292,7 @@ static struct sk_buff *build_skb_from_xdp_buff(struct net_device *dev, > __skb_put(skb, data_len); > > metasize = xdp->data - xdp->data_meta; > - metasize = metasize > 0 ? metasize : 0; > + metasize = max(metasize, 0); > if (metasize) > skb_metadata_set(skb, metasize); > > diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c > index e8096d502a7c..875ca657227d 100644 > --- a/io_uring/io_uring.c > +++ b/io_uring/io_uring.c > @@ -47,6 +47,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -2660,7 +2661,7 @@ static void *__io_uaddr_map(struct page ***pages, unsigned short *npages, > page_array); > if (ret != nr_pages) { > err: > - io_pages_free(&page_array, ret > 0 ? ret : 0); > + io_pages_free(&page_array, max(ret, 0)); > return ret < 0 ? ERR_PTR(ret) : ERR_PTR(-EFAULT); > } > /* > -- > 2.35.3 > > > ________________________________ > 本邮件及其附件内容可能含有机密和/或隐私信息，仅供指定个人或机构使用。若您非发件人指定收件人或其代理人，请勿使用、传播、复制或存储此邮件之任何内容或其附件。如您误收本邮件，请即以回复或电话方式通知发件人，并将原始邮件、附件及其所有复本删除。谢谢。 > The contents of this message and any attachments may contain confidential and/or privileged information and are intended exclusively for the addressee(s). If you are not the intended recipient of this message or their agent, please note that any use, dissemination, copying, or storage of this message or its attachments is not allowed. If you receive this message in error, please notify the sender by reply the message or phone and delete this message, any attachments and any copies immediately. > Thank you From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3D31EB64D9 for ; Thu, 6 Jul 2023 14:03:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231859AbjGFODM (ORCPT ); Thu, 6 Jul 2023 10:03:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231721AbjGFODL (ORCPT ); Thu, 6 Jul 2023 10:03:11 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D4511BD9 for ; Thu, 6 Jul 2023 07:02:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688652144; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0GE7k8I9982HVE9TTWbDiwrZOKfvdOMPK3S9DyegjXE=; b=cbxyYykZzhc3Q3Il8Z5x2aNt/bgOIqcWWKFZFguc1L7aDjTfgT+oXs9aDJdgzGXckGnQZp WW6oYUYxftDEXGE334E9fISscDyjX1epE8MeJ287EisttCFJXgYGQd5VQULZhHV2jREJjf jZqPuix2CddrEqT0aXFhLc7k8ZAcXDE= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-103-zWK4KsFyPdOdNgLtvJKYFA-1; Thu, 06 Jul 2023 10:02:22 -0400 X-MC-Unique: zWK4KsFyPdOdNgLtvJKYFA-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-314394a798dso423161f8f.0 for ; Thu, 06 Jul 2023 07:02:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688652140; x=1691244140; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0GE7k8I9982HVE9TTWbDiwrZOKfvdOMPK3S9DyegjXE=; b=j2Z7o/7jJ7ysOwxr8TCeA1CCIIWxoFbvn+2gxdwjuVpSo+WRfZfRc+nY6TavYq9YGI Cg6HAk/J1Q1+F0DM/AtXXpEndHi7NNWA7CKC3vTFENMuU8xC4OB3wII4Wh9m8XC2aWYb rPKqn3pMWKcM4D/9S38I1Q8O8OalIbw6nc5ma5LCpKFbS9Dz1TzKv9Ysn+/rjVDNsQp6 ujxkB9nt8MUHbkyi5OMajjKV7D8y261Cc6c4UQ8jXQhtzBsDIdPfpmMJY7bWmmbnut5F dbSHrj3yWOK1Qa7SZTz1LsmzNjhewJWIMvFJpLRtfybqFcQD1tl4VZIYxcr9MuS1PSLn CaiQ== X-Gm-Message-State: ABy/qLZ9heWul4Y3udYC/+96+Qgacz6BBTGjSrMxQeP4SXdMAuFGT6qf TBpq/tFjxSxvMtBAaDUv2gK5XXeCFd8Lksx+6Zjgy2OW598OU48ad4zQTf+vOumLvuKjBqbYDqV I4QxR0xgEblUnhR16qbg= X-Received: by 2002:a5d:4e12:0:b0:313:e2c8:bed1 with SMTP id p18-20020a5d4e12000000b00313e2c8bed1mr2235677wrt.34.1688652140612; Thu, 06 Jul 2023 07:02:20 -0700 (PDT) X-Google-Smtp-Source: APBJJlHcrZAK048UNMfdOsb+IYlPvPsKZoDto6N+0HK8CkttE8tg+x61xjZ/Drujf9ZKOumGT2ngEg== X-Received: by 2002:a5d:4e12:0:b0:313:e2c8:bed1 with SMTP id p18-20020a5d4e12000000b00313e2c8bed1mr2235624wrt.34.1688652140228; Thu, 06 Jul 2023 07:02:20 -0700 (PDT) Received: from redhat.com ([2.52.13.33]) by smtp.gmail.com with ESMTPSA id o2-20020a5d4742000000b0031434936f0dsm1960350wrs.68.2023.07.06.07.02.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jul 2023 07:02:19 -0700 (PDT) Date: Thu, 6 Jul 2023 10:02:13 -0400 From: "Michael S. Tsirkin" To: Yang Rong Cc: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , Jason Wang , Xuan Zhuo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jens Axboe , Pavel Begunkov , Alvin Lee , Jun Lei , Qingqing Zhuo , Max Tseng , Josip Pavic , Cruise Hung , "open list:AMD DISPLAY CORE" , "open list:DRM DRIVERS" , open list , "open list:VIRTIO CORE AND NET DRIVERS" , "open list:NETWORKING DRIVERS" , "open list:IO_URING" , opensource.kernel@vivo.com, luhongfei@vivo.com Subject: Re: [PATCH] Fix max/min warnings in virtio_net, amd/display, and io_uring Message-ID: <20230706100133-mutt-send-email-mst@kernel.org> References: <20230706021102.2066-1-yangrong@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230706021102.2066-1-yangrong@vivo.com> Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Thu, Jul 06, 2023 at 10:06:16AM +0800, Yang Rong wrote: > The files drivers/net/virtio_net.c, drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c, and io_uring/io_uring.c were modified to fix warnings. what warnings? the point of the warning is to analyze it not "fix" it blindly. > Specifically, the opportunities for max() and min() were utilized to address the warnings. > > Signed-off-by: Yang Rong > --- > drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 6 +++--- > drivers/net/virtio_net.c | 3 ++- > io_uring/io_uring.c | 3 ++- > 3 files changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c > index c753c6f30dd7..df79aea49a3c 100644 > --- a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c > +++ b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c > @@ -22,7 +22,7 @@ > * Authors: AMD > * > */ > - > +#include > #include "dc.h" > #include "dc_dmub_srv.h" > #include "../dmub/dmub_srv.h" > @@ -481,7 +481,7 @@ static void populate_subvp_cmd_drr_info(struct dc *dc, > max_drr_vblank_us = div64_u64((subvp_active_us - prefetch_us - > dc->caps.subvp_fw_processing_delay_us - drr_active_us), 2) + drr_active_us; > max_drr_mallregion_us = subvp_active_us - prefetch_us - mall_region_us - dc->caps.subvp_fw_processing_delay_us; > - max_drr_supported_us = max_drr_vblank_us > max_drr_mallregion_us ? max_drr_vblank_us : max_drr_mallregion_us; > + max_drr_supported_us = max(max_drr_vblank_us, max_drr_mallregion_us); > max_vtotal_supported = div64_u64(((uint64_t)drr_timing->pix_clk_100hz * 100 * max_drr_supported_us), > (((uint64_t)drr_timing->h_total * 1000000))); > > @@ -771,7 +771,7 @@ void dc_dmub_setup_subvp_dmub_command(struct dc *dc, > wm_val_refclk = context->bw_ctx.bw.dcn.watermarks.a.cstate_pstate.pstate_change_ns * > (dc->res_pool->ref_clocks.dchub_ref_clock_inKhz / 1000) / 1000; > > - cmd.fw_assisted_mclk_switch_v2.config_data.watermark_a_cache = wm_val_refclk < 0xFFFF ? wm_val_refclk : 0xFFFF; > + cmd.fw_assisted_mclk_switch_v2.config_data.watermark_a_cache = min(wm_val_refclk, 0xFFFF); > } > > dm_execute_dmub_cmd(dc->ctx, &cmd, DM_DMUB_WAIT_TYPE_WAIT); > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index 9b3721424e71..5bb7da885f00 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -22,6 +22,7 @@ > #include > #include > #include > +#include > > static int napi_weight = NAPI_POLL_WEIGHT; > module_param(napi_weight, int, 0444); > @@ -1291,7 +1292,7 @@ static struct sk_buff *build_skb_from_xdp_buff(struct net_device *dev, > __skb_put(skb, data_len); > > metasize = xdp->data - xdp->data_meta; > - metasize = metasize > 0 ? metasize : 0; > + metasize = max(metasize, 0); > if (metasize) > skb_metadata_set(skb, metasize); > > diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c > index e8096d502a7c..875ca657227d 100644 > --- a/io_uring/io_uring.c > +++ b/io_uring/io_uring.c > @@ -47,6 +47,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -2660,7 +2661,7 @@ static void *__io_uaddr_map(struct page ***pages, unsigned short *npages, > page_array); > if (ret != nr_pages) { > err: > - io_pages_free(&page_array, ret > 0 ? ret : 0); > + io_pages_free(&page_array, max(ret, 0)); > return ret < 0 ? ERR_PTR(ret) : ERR_PTR(-EFAULT); > } > /* > -- > 2.35.3 > > > ________________________________ > 本邮件及其附件内容可能含有机密和/或隐私信息，仅供指定个人或机构使用。若您非发件人指定收件人或其代理人，请勿使用、传播、复制或存储此邮件之任何内容或其附件。如您误收本邮件，请即以回复或电话方式通知发件人，并将原始邮件、附件及其所有复本删除。谢谢。 > The contents of this message and any attachments may contain confidential and/or privileged information and are intended exclusively for the addressee(s). If you are not the intended recipient of this message or their agent, please note that any use, dissemination, copying, or storage of this message or its attachments is not allowed. If you receive this message in error, please notify the sender by reply the message or phone and delete this message, any attachments and any copies immediately. > Thank you From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC163EB64DD for ; Thu, 6 Jul 2023 14:02:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 6FC8160B5A; Thu, 6 Jul 2023 14:02:28 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 6FC8160B5A Authentication-Results: smtp3.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bHuAjGdM X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8wMrhAXleBkW; Thu, 6 Jul 2023 14:02:27 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id DFC0B600B6; Thu, 6 Jul 2023 14:02:26 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org DFC0B600B6 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id B7466C0072; Thu, 6 Jul 2023 14:02:26 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id E8B47C0032 for ; Thu, 6 Jul 2023 14:02:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id B3A284189F for ; Thu, 6 Jul 2023 14:02:25 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org B3A284189F Authentication-Results: smtp4.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bHuAjGdM X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I0IGY9FeIQI3 for ; Thu, 6 Jul 2023 14:02:24 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 88B8E41889 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id 88B8E41889 for ; Thu, 6 Jul 2023 14:02:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688652143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0GE7k8I9982HVE9TTWbDiwrZOKfvdOMPK3S9DyegjXE=; b=bHuAjGdMeb5UM7luqOYiBeR/SBM0Uv+jAqXatTXJi/062i/HA8yoilJE8rurBOGAcNj6PJ 6QkXfiyWmZ8I1+XwOC/2hHjGv2710/4PkQjn1WHxlCz9xzt178m6/jQdOQJkITqOcseSee rOrFxSlRIx5fxO95bWgnL4effoiLkVs= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-101-hYpK7pa8NJutrJkJO-cXJg-1; Thu, 06 Jul 2023 10:02:21 -0400 X-MC-Unique: hYpK7pa8NJutrJkJO-cXJg-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3141a98a29aso417740f8f.1 for ; Thu, 06 Jul 2023 07:02:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688652140; x=1691244140; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0GE7k8I9982HVE9TTWbDiwrZOKfvdOMPK3S9DyegjXE=; b=O4kfWZiX4ePp7hiB5pnk4pjItWp8dKxCRKhzeybCLbgCvKqOJqO26mqigrHZKxXHmz gLA2ycZewIV/malXlPiMXC9yJNRD922JhQW5EaoWi48SWXnBhKtNc1GbI04raV2CfhTW QrCnaCTqKBSmFp/lJErcqrwmrQNmvf+rkKuIq9Zxm+rLrzbKPa8K/DSjv0YJL/PiSFhJ JiOwP/RxWp+pSeP14OsOGcuezf728f2MOqC2YKmPEjeB1ZRJdJO54/fbNxHzzLo3ddQ5 R8I+Xa/SYGih6D7wrfGogsbXzcwPTex4YqtL62qBcRGQX6toGGv2uNxwZYlQt3EKArWk YBtQ== X-Gm-Message-State: ABy/qLZAsZ1g4GIfvexthrj3oreOhv+7BYRtsLJP2ZSkXpsgZaq7a2UR GOWKdBBtAYv1/raTvdafyHMotKr56/l307de5VpHvT+/k3Pa880aquDGfX52QVA9EB8CnQ5WDw1 3oelm3bqAJNR0qwDawKb2eikYIVx6EF2cisg5OCnwPQ== X-Received: by 2002:a5d:4e12:0:b0:313:e2c8:bed1 with SMTP id p18-20020a5d4e12000000b00313e2c8bed1mr2235680wrt.34.1688652140615; Thu, 06 Jul 2023 07:02:20 -0700 (PDT) X-Google-Smtp-Source: APBJJlHcrZAK048UNMfdOsb+IYlPvPsKZoDto6N+0HK8CkttE8tg+x61xjZ/Drujf9ZKOumGT2ngEg== X-Received: by 2002:a5d:4e12:0:b0:313:e2c8:bed1 with SMTP id p18-20020a5d4e12000000b00313e2c8bed1mr2235624wrt.34.1688652140228; Thu, 06 Jul 2023 07:02:20 -0700 (PDT) Received: from redhat.com ([2.52.13.33]) by smtp.gmail.com with ESMTPSA id o2-20020a5d4742000000b0031434936f0dsm1960350wrs.68.2023.07.06.07.02.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jul 2023 07:02:19 -0700 (PDT) Date: Thu, 6 Jul 2023 10:02:13 -0400 From: "Michael S. Tsirkin" To: Yang Rong Subject: Re: [PATCH] Fix max/min warnings in virtio_net, amd/display, and io_uring Message-ID: <20230706100133-mutt-send-email-mst@kernel.org> References: <20230706021102.2066-1-yangrong@vivo.com> MIME-Version: 1.0 In-Reply-To: <20230706021102.2066-1-yangrong@vivo.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: Max Tseng , Christian =?iso-8859-1?Q?K=F6nig?= , "open list:DRM DRIVERS" , "open list:VIRTIO CORE AND NET DRIVERS" , Eric Dumazet , Jun Lei , Josip Pavic , Xuan Zhuo , David Airlie , Rodrigo Siqueira , "open list:AMD DISPLAY CORE" , "open list:IO_URING" , Alvin Lee , Jakub Kicinski , Paolo Abeni , Harry Wentland , opensource.kernel@vivo.com, Leo Li , Cruise Hung , Jens Axboe , "open list:NETWORKING DRIVERS" , Qingqing Zhuo , "Pan, Xinhui" , open list , luhongfei@vivo.com, "David S. Miller" , Daniel Vetter , Alex Deucher , Pavel Begunkov X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" T24gVGh1LCBKdWwgMDYsIDIwMjMgYXQgMTA6MDY6MTZBTSArMDgwMCwgWWFuZyBSb25nIHdyb3Rl Ogo+IFRoZSBmaWxlcyBkcml2ZXJzL25ldC92aXJ0aW9fbmV0LmMsIGRyaXZlcnMvZ3B1L2RybS9h bWQvZGlzcGxheS9kYy9kY19kbXViX3Nydi5jLCBhbmQgaW9fdXJpbmcvaW9fdXJpbmcuYyB3ZXJl IG1vZGlmaWVkIHRvIGZpeCB3YXJuaW5ncy4KCndoYXQgd2FybmluZ3M/IHRoZSBwb2ludCBvZiB0 aGUgd2FybmluZyBpcyB0byBhbmFseXplIGl0IG5vdCAiZml4IiBpdApibGluZGx5LgoKPiBTcGVj aWZpY2FsbHksIHRoZSBvcHBvcnR1bml0aWVzIGZvciBtYXgoKSBhbmQgbWluKCkgd2VyZSB1dGls aXplZCB0byBhZGRyZXNzIHRoZSB3YXJuaW5ncy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBZYW5nIFJv bmcgPHlhbmdyb25nQHZpdm8uY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3Bs YXkvZGMvZGNfZG11Yl9zcnYuYyB8IDYgKysrLS0tCj4gIGRyaXZlcnMvbmV0L3ZpcnRpb19uZXQu YyAgICAgICAgICAgICAgICAgICAgIHwgMyArKy0KPiAgaW9fdXJpbmcvaW9fdXJpbmcuYyAgICAg ICAgICAgICAgICAgICAgICAgICAgfCAzICsrLQo+ICAzIGZpbGVzIGNoYW5nZWQsIDcgaW5zZXJ0 aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2FtZC9kaXNwbGF5L2RjL2RjX2RtdWJfc3J2LmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3Bs YXkvZGMvZGNfZG11Yl9zcnYuYwo+IGluZGV4IGM3NTNjNmYzMGRkNy4uZGY3OWFlYTQ5YTNjIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9kYy9kY19kbXViX3Nydi5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2RjL2RjX2RtdWJfc3J2LmMKPiBA QCAtMjIsNyArMjIsNyBAQAo+ICAgKiBBdXRob3JzOiBBTUQKPiAgICoKPiAgICovCj4gLQo+ICsj aW5jbHVkZSA8bGludXgvbWlubWF4Lmg+Cj4gICNpbmNsdWRlICJkYy5oIgo+ICAjaW5jbHVkZSAi ZGNfZG11Yl9zcnYuaCIKPiAgI2luY2x1ZGUgIi4uL2RtdWIvZG11Yl9zcnYuaCIKPiBAQCAtNDgx LDcgKzQ4MSw3IEBAIHN0YXRpYyB2b2lkIHBvcHVsYXRlX3N1YnZwX2NtZF9kcnJfaW5mbyhzdHJ1 Y3QgZGMgKmRjLAo+ICAgICAgICAgbWF4X2Rycl92YmxhbmtfdXMgPSBkaXY2NF91NjQoKHN1YnZw X2FjdGl2ZV91cyAtIHByZWZldGNoX3VzIC0KPiAgICAgICAgICAgICAgICAgICAgICAgICBkYy0+ Y2Fwcy5zdWJ2cF9md19wcm9jZXNzaW5nX2RlbGF5X3VzIC0gZHJyX2FjdGl2ZV91cyksIDIpICsg ZHJyX2FjdGl2ZV91czsKPiAgICAgICAgIG1heF9kcnJfbWFsbHJlZ2lvbl91cyA9IHN1YnZwX2Fj dGl2ZV91cyAtIHByZWZldGNoX3VzIC0gbWFsbF9yZWdpb25fdXMgLSBkYy0+Y2Fwcy5zdWJ2cF9m d19wcm9jZXNzaW5nX2RlbGF5X3VzOwo+IC0gICAgICAgbWF4X2Rycl9zdXBwb3J0ZWRfdXMgPSBt YXhfZHJyX3ZibGFua191cyA+IG1heF9kcnJfbWFsbHJlZ2lvbl91cyA/IG1heF9kcnJfdmJsYW5r X3VzIDogbWF4X2Rycl9tYWxscmVnaW9uX3VzOwo+ICsgICAgICAgbWF4X2Rycl9zdXBwb3J0ZWRf dXMgPSBtYXgobWF4X2Rycl92YmxhbmtfdXMsIG1heF9kcnJfbWFsbHJlZ2lvbl91cyk7Cj4gICAg ICAgICBtYXhfdnRvdGFsX3N1cHBvcnRlZCA9IGRpdjY0X3U2NCgoKHVpbnQ2NF90KWRycl90aW1p bmctPnBpeF9jbGtfMTAwaHogKiAxMDAgKiBtYXhfZHJyX3N1cHBvcnRlZF91cyksCj4gICAgICAg ICAgICAgICAgICAgICAgICAgKCgodWludDY0X3QpZHJyX3RpbWluZy0+aF90b3RhbCAqIDEwMDAw MDApKSk7Cj4gCj4gQEAgLTc3MSw3ICs3NzEsNyBAQCB2b2lkIGRjX2RtdWJfc2V0dXBfc3VidnBf ZG11Yl9jb21tYW5kKHN0cnVjdCBkYyAqZGMsCj4gICAgICAgICAgICAgICAgIHdtX3ZhbF9yZWZj bGsgPSBjb250ZXh0LT5id19jdHguYncuZGNuLndhdGVybWFya3MuYS5jc3RhdGVfcHN0YXRlLnBz dGF0ZV9jaGFuZ2VfbnMgKgo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGRjLT5y ZXNfcG9vbC0+cmVmX2Nsb2Nrcy5kY2h1Yl9yZWZfY2xvY2tfaW5LaHogLyAxMDAwKSAvIDEwMDA7 Cj4gCj4gLSAgICAgICAgICAgICAgIGNtZC5md19hc3Npc3RlZF9tY2xrX3N3aXRjaF92Mi5jb25m aWdfZGF0YS53YXRlcm1hcmtfYV9jYWNoZSA9IHdtX3ZhbF9yZWZjbGsgPCAweEZGRkYgPyB3bV92 YWxfcmVmY2xrIDogMHhGRkZGOwo+ICsgICAgICAgICAgICAgICBjbWQuZndfYXNzaXN0ZWRfbWNs a19zd2l0Y2hfdjIuY29uZmlnX2RhdGEud2F0ZXJtYXJrX2FfY2FjaGUgPSBtaW4od21fdmFsX3Jl ZmNsaywgMHhGRkZGKTsKPiAgICAgICAgIH0KPiAKPiAgICAgICAgIGRtX2V4ZWN1dGVfZG11Yl9j bWQoZGMtPmN0eCwgJmNtZCwgRE1fRE1VQl9XQUlUX1RZUEVfV0FJVCk7Cj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvbmV0L3ZpcnRpb19uZXQuYyBiL2RyaXZlcnMvbmV0L3ZpcnRpb19uZXQuYwo+IGlu ZGV4IDliMzcyMTQyNGU3MS4uNWJiN2RhODg1ZjAwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbmV0 L3ZpcnRpb19uZXQuYwo+ICsrKyBiL2RyaXZlcnMvbmV0L3ZpcnRpb19uZXQuYwo+IEBAIC0yMiw2 ICsyMiw3IEBACj4gICNpbmNsdWRlIDxuZXQvcm91dGUuaD4KPiAgI2luY2x1ZGUgPG5ldC94ZHAu aD4KPiAgI2luY2x1ZGUgPG5ldC9uZXRfZmFpbG92ZXIuaD4KPiArI2luY2x1ZGUgPGxpbnV4L21p bm1heC5oPgo+IAo+ICBzdGF0aWMgaW50IG5hcGlfd2VpZ2h0ID0gTkFQSV9QT0xMX1dFSUdIVDsK PiAgbW9kdWxlX3BhcmFtKG5hcGlfd2VpZ2h0LCBpbnQsIDA0NDQpOwo+IEBAIC0xMjkxLDcgKzEy OTIsNyBAQCBzdGF0aWMgc3RydWN0IHNrX2J1ZmYgKmJ1aWxkX3NrYl9mcm9tX3hkcF9idWZmKHN0 cnVjdCBuZXRfZGV2aWNlICpkZXYsCj4gICAgICAgICBfX3NrYl9wdXQoc2tiLCBkYXRhX2xlbik7 Cj4gCj4gICAgICAgICBtZXRhc2l6ZSA9IHhkcC0+ZGF0YSAtIHhkcC0+ZGF0YV9tZXRhOwo+IC0g ICAgICAgbWV0YXNpemUgPSBtZXRhc2l6ZSA+IDAgPyBtZXRhc2l6ZSA6IDA7Cj4gKyAgICAgICBt ZXRhc2l6ZSA9IG1heChtZXRhc2l6ZSwgMCk7Cj4gICAgICAgICBpZiAobWV0YXNpemUpCj4gICAg ICAgICAgICAgICAgIHNrYl9tZXRhZGF0YV9zZXQoc2tiLCBtZXRhc2l6ZSk7Cj4gCj4gZGlmZiAt LWdpdCBhL2lvX3VyaW5nL2lvX3VyaW5nLmMgYi9pb191cmluZy9pb191cmluZy5jCj4gaW5kZXgg ZTgwOTZkNTAyYTdjLi44NzVjYTY1NzIyN2QgMTAwNjQ0Cj4gLS0tIGEvaW9fdXJpbmcvaW9fdXJp bmcuYwo+ICsrKyBiL2lvX3VyaW5nL2lvX3VyaW5nLmMKPiBAQCAtNDcsNiArNDcsNyBAQAo+ICAj aW5jbHVkZSA8bGludXgvcmVmY291bnQuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L3Vpby5oPgo+ICAj aW5jbHVkZSA8bGludXgvYml0cy5oPgo+ICsjaW5jbHVkZSA8bGludXgvbWlubWF4Lmg+Cj4gCj4g ICNpbmNsdWRlIDxsaW51eC9zY2hlZC9zaWduYWwuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L2ZzLmg+ Cj4gQEAgLTI2NjAsNyArMjY2MSw3IEBAIHN0YXRpYyB2b2lkICpfX2lvX3VhZGRyX21hcChzdHJ1 Y3QgcGFnZSAqKipwYWdlcywgdW5zaWduZWQgc2hvcnQgKm5wYWdlcywKPiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgcGFnZV9hcnJheSk7Cj4gICAgICAgICBpZiAocmV0 ICE9IG5yX3BhZ2VzKSB7Cj4gIGVycjoKPiAtICAgICAgICAgICAgICAgaW9fcGFnZXNfZnJlZSgm cGFnZV9hcnJheSwgcmV0ID4gMCA/IHJldCA6IDApOwo+ICsgICAgICAgICAgICAgICBpb19wYWdl c19mcmVlKCZwYWdlX2FycmF5LCBtYXgocmV0LCAwKSk7Cj4gICAgICAgICAgICAgICAgIHJldHVy biByZXQgPCAwID8gRVJSX1BUUihyZXQpIDogRVJSX1BUUigtRUZBVUxUKTsKPiAgICAgICAgIH0K PiAgICAgICAgIC8qCj4gLS0KPiAyLjM1LjMKPiAKPiAKPiBfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwo+IOacrOmCruS7tuWPiuWFtumZhOS7tuWGheWuueWPr+iDveWQq+acieacuuWv huWSjC/miJbpmpDnp4Hkv6Hmga/vvIzku4XkvpvmjIflrprkuKrkurrmiJbmnLrmnoTkvb/nlKjj gILoi6XmgqjpnZ7lj5Hku7bkurrmjIflrprmlLbku7bkurrmiJblhbbku6PnkIbkurrvvIzor7fl i7/kvb/nlKjjgIHkvKDmkq3jgIHlpI3liLbmiJblrZjlgqjmraTpgq7ku7bkuYvku7vkvZXlhoXl rrnmiJblhbbpmYTku7bjgILlpoLmgqjor6/mlLbmnKzpgq7ku7bvvIzor7fljbPku6Xlm57lpI3m iJbnlLXor53mlrnlvI/pgJrnn6Xlj5Hku7bkurrvvIzlubblsIbljp/lp4vpgq7ku7bjgIHpmYTk u7blj4rlhbbmiYDmnInlpI3mnKzliKDpmaTjgILosKLosKLjgIIKPiBUaGUgY29udGVudHMgb2Yg dGhpcyBtZXNzYWdlIGFuZCBhbnkgYXR0YWNobWVudHMgbWF5IGNvbnRhaW4gY29uZmlkZW50aWFs IGFuZC9vciBwcml2aWxlZ2VkIGluZm9ybWF0aW9uIGFuZCBhcmUgaW50ZW5kZWQgZXhjbHVzaXZl bHkgZm9yIHRoZSBhZGRyZXNzZWUocykuIElmIHlvdSBhcmUgbm90IHRoZSBpbnRlbmRlZCByZWNp cGllbnQgb2YgdGhpcyBtZXNzYWdlIG9yIHRoZWlyIGFnZW50LCBwbGVhc2Ugbm90ZSB0aGF0IGFu eSB1c2UsIGRpc3NlbWluYXRpb24sIGNvcHlpbmcsIG9yIHN0b3JhZ2Ugb2YgdGhpcyBtZXNzYWdl IG9yIGl0cyBhdHRhY2htZW50cyBpcyBub3QgYWxsb3dlZC4gSWYgeW91IHJlY2VpdmUgdGhpcyBt ZXNzYWdlIGluIGVycm9yLCBwbGVhc2Ugbm90aWZ5IHRoZSBzZW5kZXIgYnkgcmVwbHkgdGhlIG1l c3NhZ2Ugb3IgcGhvbmUgYW5kIGRlbGV0ZSB0aGlzIG1lc3NhZ2UsIGFueSBhdHRhY2htZW50cyBh bmQgYW55IGNvcGllcyBpbW1lZGlhdGVseS4KPiBUaGFuayB5b3UKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlz dApWaXJ0dWFsaXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3Rz LmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby92aXJ0dWFsaXphdGlvbg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 638D8EB64D9 for ; Thu, 6 Jul 2023 14:02:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B643E10E403; Thu, 6 Jul 2023 14:02:27 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5EE9E10E403 for ; Thu, 6 Jul 2023 14:02:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688652145; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0GE7k8I9982HVE9TTWbDiwrZOKfvdOMPK3S9DyegjXE=; b=CpbtB4+gwIGB1fUzkCd2UaWdhpkrtKRmrAUboqXPxRhT8GCH/4P5ao1+wb+ttIZqlsd8aB y6JZ9ILVqgFPEK5RTBRDeGDmeHoBt4y7g87tAhuPUClI+9u4mL81exRCKuIetRp2RNFWeK rkLm2+R2cIRZL55D3lwGTfmUwHRkKq0= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-275-TTmN27ewNielD9XA5RHhTw-1; Thu, 06 Jul 2023 10:02:23 -0400 X-MC-Unique: TTmN27ewNielD9XA5RHhTw-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-314394a798dso423162f8f.0 for ; Thu, 06 Jul 2023 07:02:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688652141; x=1691244141; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0GE7k8I9982HVE9TTWbDiwrZOKfvdOMPK3S9DyegjXE=; b=JZ1PJGftcDXKFmwG5Bzcbu9zYCl0yOvaQefI6RTrwFoMtPv/2LJbfBDRiTx/q96Ajb MPOV0gpsZA5WFixZTGROqKPHFbpMMDehoK4cjEFAjcKvPDnyRB27Rd4dH7W+1Q9tOWGg J96ahOluQXUME0RyWcsHJpyujBrMLzoSBliAXNzfR4qa+LGFdhH1cvqPo+awrOa8Ig/o yZ4Y7j9RiM1WBdA4OdGh1AM6qAufbCbmn7/i+SanU7YgMNo+/2PSPmJV4+Jn7XE0Scl+ 7t5/Dzi1oXjFAzKV+/h7NM/npEHNA/IuISFvea0y45ucUperY2l4cV6kEE+RcdDubR1E funA== X-Gm-Message-State: ABy/qLZh1WuFlO4B47j9CZlKqL4/rrgLkGqKf6xDV/00NR8cy4GqE6lc X/wSYLm7uoNniIVuPDIfww69lk7fxV8ItI8O0MbON+NYCQBR30nTb9vXeKzWjKRmIXk711t427f IrU6PnrLFlBAGwj2BOrWm9Avn1URw X-Received: by 2002:a5d:4e12:0:b0:313:e2c8:bed1 with SMTP id p18-20020a5d4e12000000b00313e2c8bed1mr2235674wrt.34.1688652140611; Thu, 06 Jul 2023 07:02:20 -0700 (PDT) X-Google-Smtp-Source: APBJJlHcrZAK048UNMfdOsb+IYlPvPsKZoDto6N+0HK8CkttE8tg+x61xjZ/Drujf9ZKOumGT2ngEg== X-Received: by 2002:a5d:4e12:0:b0:313:e2c8:bed1 with SMTP id p18-20020a5d4e12000000b00313e2c8bed1mr2235624wrt.34.1688652140228; Thu, 06 Jul 2023 07:02:20 -0700 (PDT) Received: from redhat.com ([2.52.13.33]) by smtp.gmail.com with ESMTPSA id o2-20020a5d4742000000b0031434936f0dsm1960350wrs.68.2023.07.06.07.02.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jul 2023 07:02:19 -0700 (PDT) Date: Thu, 6 Jul 2023 10:02:13 -0400 From: "Michael S. Tsirkin" To: Yang Rong Subject: Re: [PATCH] Fix max/min warnings in virtio_net, amd/display, and io_uring Message-ID: <20230706100133-mutt-send-email-mst@kernel.org> References: <20230706021102.2066-1-yangrong@vivo.com> MIME-Version: 1.0 In-Reply-To: <20230706021102.2066-1-yangrong@vivo.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Max Tseng , Christian =?iso-8859-1?Q?K=F6nig?= , Jason Wang , "open list:DRM DRIVERS" , "open list:VIRTIO CORE AND NET DRIVERS" , Eric Dumazet , Jun Lei , Josip Pavic , Xuan Zhuo , Rodrigo Siqueira , "open list:AMD DISPLAY CORE" , "open list:IO_URING" , Alvin Lee , Jakub Kicinski , Paolo Abeni , opensource.kernel@vivo.com, Leo Li , Cruise Hung , Jens Axboe , "open list:NETWORKING DRIVERS" , Qingqing Zhuo , "Pan, Xinhui" , open list , luhongfei@vivo.com, "David S. Miller" , Alex Deucher , Pavel Begunkov Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Jul 06, 2023 at 10:06:16AM +0800, Yang Rong wrote: > The files drivers/net/virtio_net.c, drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c, and io_uring/io_uring.c were modified to fix warnings. what warnings? the point of the warning is to analyze it not "fix" it blindly. > Specifically, the opportunities for max() and min() were utilized to address the warnings. > > Signed-off-by: Yang Rong > --- > drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 6 +++--- > drivers/net/virtio_net.c | 3 ++- > io_uring/io_uring.c | 3 ++- > 3 files changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c > index c753c6f30dd7..df79aea49a3c 100644 > --- a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c > +++ b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c > @@ -22,7 +22,7 @@ > * Authors: AMD > * > */ > - > +#include > #include "dc.h" > #include "dc_dmub_srv.h" > #include "../dmub/dmub_srv.h" > @@ -481,7 +481,7 @@ static void populate_subvp_cmd_drr_info(struct dc *dc, > max_drr_vblank_us = div64_u64((subvp_active_us - prefetch_us - > dc->caps.subvp_fw_processing_delay_us - drr_active_us), 2) + drr_active_us; > max_drr_mallregion_us = subvp_active_us - prefetch_us - mall_region_us - dc->caps.subvp_fw_processing_delay_us; > - max_drr_supported_us = max_drr_vblank_us > max_drr_mallregion_us ? max_drr_vblank_us : max_drr_mallregion_us; > + max_drr_supported_us = max(max_drr_vblank_us, max_drr_mallregion_us); > max_vtotal_supported = div64_u64(((uint64_t)drr_timing->pix_clk_100hz * 100 * max_drr_supported_us), > (((uint64_t)drr_timing->h_total * 1000000))); > > @@ -771,7 +771,7 @@ void dc_dmub_setup_subvp_dmub_command(struct dc *dc, > wm_val_refclk = context->bw_ctx.bw.dcn.watermarks.a.cstate_pstate.pstate_change_ns * > (dc->res_pool->ref_clocks.dchub_ref_clock_inKhz / 1000) / 1000; > > - cmd.fw_assisted_mclk_switch_v2.config_data.watermark_a_cache = wm_val_refclk < 0xFFFF ? wm_val_refclk : 0xFFFF; > + cmd.fw_assisted_mclk_switch_v2.config_data.watermark_a_cache = min(wm_val_refclk, 0xFFFF); > } > > dm_execute_dmub_cmd(dc->ctx, &cmd, DM_DMUB_WAIT_TYPE_WAIT); > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index 9b3721424e71..5bb7da885f00 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -22,6 +22,7 @@ > #include > #include > #include > +#include > > static int napi_weight = NAPI_POLL_WEIGHT; > module_param(napi_weight, int, 0444); > @@ -1291,7 +1292,7 @@ static struct sk_buff *build_skb_from_xdp_buff(struct net_device *dev, > __skb_put(skb, data_len); > > metasize = xdp->data - xdp->data_meta; > - metasize = metasize > 0 ? metasize : 0; > + metasize = max(metasize, 0); > if (metasize) > skb_metadata_set(skb, metasize); > > diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c > index e8096d502a7c..875ca657227d 100644 > --- a/io_uring/io_uring.c > +++ b/io_uring/io_uring.c > @@ -47,6 +47,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -2660,7 +2661,7 @@ static void *__io_uaddr_map(struct page ***pages, unsigned short *npages, > page_array); > if (ret != nr_pages) { > err: > - io_pages_free(&page_array, ret > 0 ? ret : 0); > + io_pages_free(&page_array, max(ret, 0)); > return ret < 0 ? ERR_PTR(ret) : ERR_PTR(-EFAULT); > } > /* > -- > 2.35.3 > > > ________________________________ > 本邮件及其附件内容可能含有机密和/或隐私信息，仅供指定个人或机构使用。若您非发件人指定收件人或其代理人，请勿使用、传播、复制或存储此邮件之任何内容或其附件。如您误收本邮件，请即以回复或电话方式通知发件人，并将原始邮件、附件及其所有复本删除。谢谢。 > The contents of this message and any attachments may contain confidential and/or privileged information and are intended exclusively for the addressee(s). If you are not the intended recipient of this message or their agent, please note that any use, dissemination, copying, or storage of this message or its attachments is not allowed. If you receive this message in error, please notify the sender by reply the message or phone and delete this message, any attachments and any copies immediately. > Thank you