From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C05CEB64D9 for ; Thu, 6 Jul 2023 11:16:37 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F2E148621A; Thu, 6 Jul 2023 13:16:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 053BB86261; Thu, 6 Jul 2023 13:16:33 +0200 (CEST) Received: from muru.com (muru.com [72.249.23.125]) by phobos.denx.de (Postfix) with ESMTP id AD0988621A for ; Thu, 6 Jul 2023 13:16:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=tony@atomide.com Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 08D7880B5; Thu, 6 Jul 2023 11:16:29 +0000 (UTC) Date: Thu, 6 Jul 2023 14:16:27 +0300 From: Tony Lindgren To: Julien Panis Cc: u-boot@lists.denx.de, Marek Vasut , trini@konsulko.com, rogerq@kernel.org, vigneshr@ti.com, nm@ti.com Subject: Re: [PATCH v4 1/2] musb-new: ti-musb: Handle usb dual-role feature as peripheral Message-ID: <20230706111627.GA5094@atomide.com> References: <20230621-fix_usb_ether_init-v4-0-5f4977bb7678@baylibre.com> <20230621-fix_usb_ether_init-v4-1-5f4977bb7678@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230621-fix_usb_ether_init-v4-1-5f4977bb7678@baylibre.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean * Julien Panis [230706 10:41]: > This prevents from getting some 'No USB device found' error, > in usb_ether_init() function for instance. Looks good to me: Reviewed-by: Tony Lindgren