From: Stephen Hemminger <stephen@networkplumber.org>
To: <eagostini@nvidia.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH v2 1/1] app/test-gpudev: introduce ethdev to rx/tx packets using GPU memory
Date: Thu, 6 Jul 2023 11:58:15 -0700 [thread overview]
Message-ID: <20230706115815.50ea5cc7@hermes.local> (raw)
In-Reply-To: <20211118185613.3246-2-eagostini@nvidia.com>
On Thu, 18 Nov 2021 18:56:13 +0000
<eagostini@nvidia.com> wrote:
More tests is always good, this seemed to have gotten stalled.
Probably because most people don't have Nvidia GPU and DPDK.
> +static void
> +signal_handler(int signum)
> +{
> + if (signum == SIGINT || signum == SIGTERM) {
> + printf("\n\nSignal %d received, preparing to exit...\n",
> + signum);
Printf in signal handler is unsafe, don't do it.
We just removed this in other tests.
> +exit:
> /* clean up the EAL */
> rte_eal_cleanup();
>
> + printf("Bye...\n");
You don't need this. Just noise, why add it.
prev parent reply other threads:[~2023-07-06 18:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 1:52 [PATCH v1 0/1] app/test-gpudev: introduce ethdev to rx/tx packets using GPU memory eagostini
2021-11-18 1:52 ` [PATCH v1 1/1] " eagostini
2021-11-18 6:17 ` Jerin Jacob
2021-11-18 10:16 ` Elena Agostini
2021-11-18 18:56 ` [PATCH v2 0/1] " eagostini
2021-11-18 18:56 ` [PATCH v2 1/1] " eagostini
2023-07-06 18:58 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230706115815.50ea5cc7@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=eagostini@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.