From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5399FEB64D9 for ; Thu, 6 Jul 2023 15:04:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229782AbjGFPET (ORCPT ); Thu, 6 Jul 2023 11:04:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233731AbjGFPEQ (ORCPT ); Thu, 6 Jul 2023 11:04:16 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B2E1199F for ; Thu, 6 Jul 2023 08:04:08 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1qHQWb-0005eJ-GO; Thu, 06 Jul 2023 17:04:05 +0200 Date: Thu, 6 Jul 2023 17:04:05 +0200 From: Florian Westphal To: Pablo Neira Ayuso Cc: netfilter-devel@vger.kernel.org, fw@strlen.de Subject: Re: [PATCH nft] netlink_linearize: use div_round_up in byteorder length Message-ID: <20230706150405.GJ3751@breakpoint.cc> References: <20230706150237.47694-1-pablo@netfilter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230706150237.47694-1-pablo@netfilter.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Pablo Neira Ayuso wrote: > Use div_round_up() to calculate the byteorder length, otherwise fields > that take % BITS_PER_BYTE != 0 are not considered by the byteorder > expression. Thanks for fixing this! Patch LGTM.