All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Eugenio Pérez" <eperezma@redhat.com>
Cc: qemu-devel@nongnu.org, Laurent Vivier <lvivier@redhat.com>,
	Cindy Lu <lulu@redhat.com>,
	si-wei.liu@oracle.com, Stefano Garzarella <sgarzare@redhat.com>,
	Shannon Nelson <snelson@pensando.io>,
	Gautam Dawar <gdawar@xilinx.com>,
	Jason Wang <jasowang@redhat.com>,
	Harpreet Singh Anand <hanand@xilinx.com>,
	Parav Pandit <parav@mellanox.com>,
	Dragos Tatulea <dtatulea@nvidia.com>,
	Zhu Lingshan <lingshan.zhu@intel.com>,
	Lei Yang <leiyang@redhat.com>
Subject: Re: [RFC PATCH 0/6] Enable vdpa net migration with features depending on CVQ
Date: Thu, 6 Jul 2023 16:02:08 -0400	[thread overview]
Message-ID: <20230706160139-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230706191227.835526-1-eperezma@redhat.com>

On Thu, Jul 06, 2023 at 09:12:21PM +0200, Eugenio Pérez wrote:
> At this moment the migration of net features that depends on CVQ is not
> possible, as there is no reliable way to restore the device state like mac
> address, number of enabled queues, etc to the destination.  This is mainly
> caused because the device must only read CVQ, and process all the commands
> before resuming the dataplane.
> 
> This RFC lift that requirement, sending the VHOST_VDPA_SET_VRING_ENABLE ioctl
> for dataplane vqs only after the device has processed all commands.  If this
> method is valid or not, or if it must be signalled by the parent driver
> somehow, is still under discussion.  In case it is valid, this code allows
> testing the vDPA device for it.

And you plan to add the reset trick too in a future version?

> Eugenio Pérez (6):
>   vdpa: export vhost_vdpa_set_vring_ready
>   vdpa: add should_enable op
>   vdpa: use virtio_ops->should_enable at vhost_vdpa_set_vrings_ready
>   vdpa: add stub vhost_vdpa_should_enable
>   vdpa: delay enable of data vqs
>   vdpa: remove net cvq migration blocker
> 
>  include/hw/virtio/vhost-vdpa.h |  9 +++++++
>  hw/virtio/vhost-vdpa.c         | 33 +++++++++++++++++++------
>  net/vhost-vdpa.c               | 45 +++++++++++++++++++++++++---------
>  hw/virtio/trace-events         |  2 +-
>  4 files changed, 68 insertions(+), 21 deletions(-)
> 
> -- 
> 2.39.3
> 



  parent reply	other threads:[~2023-07-06 20:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-06 19:12 [RFC PATCH 0/6] Enable vdpa net migration with features depending on CVQ Eugenio Pérez
2023-07-06 19:12 ` [RFC PATCH 1/6] vdpa: export vhost_vdpa_set_vring_ready Eugenio Pérez
2023-07-10  3:19   ` Jason Wang
2023-07-10  8:43     ` Eugenio Perez Martin
2023-07-06 19:12 ` [RFC PATCH 2/6] vdpa: add should_enable op Eugenio Pérez
2023-07-10  3:46   ` Jason Wang
2023-07-06 19:12 ` [RFC PATCH 3/6] vdpa: use virtio_ops->should_enable at vhost_vdpa_set_vrings_ready Eugenio Pérez
2023-07-06 19:12 ` [RFC PATCH 4/6] vdpa: add stub vhost_vdpa_should_enable Eugenio Pérez
2023-07-06 19:12 ` [RFC PATCH 5/6] vdpa: delay enable of data vqs Eugenio Pérez
2023-07-06 19:12 ` [RFC PATCH 6/6] vdpa: remove net cvq migration blocker Eugenio Pérez
2023-07-10  3:53   ` Jason Wang
2023-07-10  7:37     ` Eugenio Perez Martin
2023-07-20  8:17       ` Eugenio Perez Martin
2023-07-20  8:23         ` Jason Wang
2023-07-06 20:02 ` Michael S. Tsirkin [this message]
2023-07-07  6:21   ` [RFC PATCH 0/6] Enable vdpa net migration with features depending on CVQ Eugenio Perez Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230706160139-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=dtatulea@nvidia.com \
    --cc=eperezma@redhat.com \
    --cc=gdawar@xilinx.com \
    --cc=hanand@xilinx.com \
    --cc=jasowang@redhat.com \
    --cc=leiyang@redhat.com \
    --cc=lingshan.zhu@intel.com \
    --cc=lulu@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=parav@mellanox.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sgarzare@redhat.com \
    --cc=si-wei.liu@oracle.com \
    --cc=snelson@pensando.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.