From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E77B4EB64DC for ; Thu, 6 Jul 2023 17:39:33 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C35AA86308; Thu, 6 Jul 2023 19:39:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="Qk/O3rKT"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E96DF8634D; Thu, 6 Jul 2023 19:39:29 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7EFEA86139 for ; Thu, 6 Jul 2023 19:39:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DC24A60B9E; Thu, 6 Jul 2023 17:39:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A8C8C433C8; Thu, 6 Jul 2023 17:39:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688665165; bh=ddbIQGbnoZcDNS3aEEDmUpdXqZnQj0g7CEhAebGMYFw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Qk/O3rKT+iQCKoyzy9qsz3pygAGYkL5C8qhIeg7Lqe2Ytslm0S5muU98+R9jmzwis L4ks5DFa662kR3X4ytpSLDWURbWRpu6JLrhgK5h42bVG7TGxmo748AwR7pNVEfN7iP Dtq85flBKpuB0V/BGBnSyryVCRz12k85JjsMMebXgqu6VGgOVn0yawY2/X3FIvjt43 V/aaanpr32GDCFSt0ToQRzhMCzqSDYnxeBv5tkwZ3pJ14SbWTmKITj/aJgZwCTUTls 475qgA884hfBQ2RMQjJMB+5eW8lvmSO6jpJAFa8JGMJUAMWrjub6Hm1T88rFhClMHK 3AwxtZdVwRwEQ== Received: by pali.im (Postfix) id 7B451970; Thu, 6 Jul 2023 19:39:22 +0200 (CEST) Date: Thu, 6 Jul 2023 19:39:22 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Jaehoon Chung , Tom Rini Cc: Peng Fan , Stefan Roese , u-boot@lists.denx.de Subject: Re: [PATCH u-boot 0/4] mmc: Explain and cleanup partition selection Message-ID: <20230706173922.3nixe6ruolis6s25@pali> References: <20230413211057.10975-1-pali@kernel.org> <38d6a7fe-7a85-750f-5609-51a902494a63@samsung.com> <20230706105034.fj243i473ks3t3sn@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230706105034.fj243i473ks3t3sn@pali> User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Thursday 06 July 2023 12:50:34 Pali Rohár wrote: > On Monday 03 July 2023 21:16:37 Jaehoon Chung wrote: > > Hi, > > > > On 4/14/23 06:10, Pali Rohár wrote: > > > Some people do not want to read review comments in emails. So put > > > comments and explanation into the source code itself; make emmc > > > partition selection code more explicit and validate configuration in > > > bubt command. > > > > Sorry for too late. > > After applied this patch-set, some board are failed with spl's size overflowed > > > > The below is one of failed log. > > > > +arm-linux-gnueabi-ld.bfd: region `.sram' overflowed by 352 bytes > > +make[2]: *** [scripts/Makefile.spl:527: spl/u-boot-spl] Error 1 > > +make[1]: *** [Makefile:2049: spl/u-boot-spl] Error 2 > > Crap, and again we have there same issue. Patch after months does not > apply anymore. And resending the patch would again result in the same > problem that it would not apply anymore after half of the year... Here is v2 patch with simple fix for that platform: https://patchwork.ozlabs.org/project/uboot/patch/20230706173502.2796-1-pali@kernel.org/ And it passed _now_ CI pipeline: https://github.com/u-boot/u-boot/pull/340 > > Anyway, only first patch is SPL specific, other should apply without any > problem. > > > > > Best Regards, > > Jaehoon Chung > > > > > > > > Pali Rohár (4): > > > mmc: spl: Make partition choice in > > > default_spl_mmc_emmc_boot_partition() more explicit > > > cmd: mvebu/bubt: Validate EXT_CSD[179] eMMC register in > > > mmc_burn_image() > > > sunxi: eMMC: Add comments explaining mapping between bootpart and > > > mmc_switch_part() > > > board: purism: Use U-Boot mmc function for converting boot part to > > > part access > > > > > > arch/arm/mach-sunxi/board.c | 12 ++++++++++- > > > board/purism/librem5/librem5.c | 6 +----- > > > cmd/mvebu/bubt.c | 24 +++++++++++++++++++-- > > > common/spl/spl_mmc.c | 38 +++++++++++++++++++++++++++------- > > > 4 files changed, 64 insertions(+), 16 deletions(-) > >