From: Rob Herring <robh@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Xu Yang <xu.yang_2@nxp.com>,
Peng Fan <peng.fan@nxp.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/1] dt-bindings: usb: ci-hdrc-usb2: Fix number of clocks
Date: Thu, 6 Jul 2023 13:18:25 -0600 [thread overview]
Message-ID: <20230706191825.GA170669-robh@kernel.org> (raw)
In-Reply-To: <20230706093928.3580544-1-alexander.stein@ew.tq-group.com>
On Thu, Jul 06, 2023 at 11:39:28AM +0200, Alexander Stein wrote:
> Some (older) IP cores require 3 clocks, named 'ipg', 'ahb' and 'per' while
> more recent IP cores just require one. Fix the number and explicitly
> state the clock-names.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> >From I can tell, is that imx25, imx27, imx35 have specified 3 clocks in
> their DT.
> IMHO minItems for 'clock-names' can be removed as I presume that this
> property is not set when only one clock is used.
Rather than presume, did you test that? Well, I did[1] and can confirm.
Reviewed-by: Rob Herring <robh@kernel.org>
[1] https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230706093928.3580544-1-alexander.stein@ew.tq-group.com/
next prev parent reply other threads:[~2023-07-06 19:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 9:39 [PATCH 1/1] dt-bindings: usb: ci-hdrc-usb2: Fix number of clocks Alexander Stein
2023-07-06 19:18 ` Rob Herring [this message]
2023-07-07 5:59 ` Alexander Stein
2023-07-07 7:06 ` [EXT] " Xu Yang
2023-07-07 8:34 ` Alexander Stein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230706191825.GA170669-robh@kernel.org \
--to=robh@kernel.org \
--cc=alexander.stein@ew.tq-group.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-usb@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.