From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F36AC0015E for ; Fri, 7 Jul 2023 23:43:44 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D1633863EC; Sat, 8 Jul 2023 01:43:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Kl927DFM"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B63BF863ED; Sat, 8 Jul 2023 01:43:40 +0200 (CEST) Received: from mail-yw1-x1136.google.com (mail-yw1-x1136.google.com [IPv6:2607:f8b0:4864:20::1136]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6708486307 for ; Sat, 8 Jul 2023 01:43:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x1136.google.com with SMTP id 00721157ae682-5701810884aso31605867b3.0 for ; Fri, 07 Jul 2023 16:43:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1688773417; x=1691365417; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=kFERl8so8Zj7tqkMnBQ2fNDmqtoRmK9Nb7b1+dwtW9Y=; b=Kl927DFMgVwVy6JCmtbDd9FYIvNYsxrba2woD1XFHd3cW2iSMxxvHqFyJfwcIDTK1t I3Y+gn1XD5YM6an+BHp8f9q//dqqk/T7TkwiTNO95jZlJl55ttkrTE/j5vYlYN2H41/l gDMtrqvlM5DPo3p6o5yOfNCI/fQEk4cYo0zls= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688773417; x=1691365417; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kFERl8so8Zj7tqkMnBQ2fNDmqtoRmK9Nb7b1+dwtW9Y=; b=Dkna/oAklyIi20YZWKUp752oAfaXpiain+gpuWjXB00KtvbUlNxYC5x8nI+Hn84l6i qV7HWVEOoBEuGqNFVugS/xpDJdnTOPVaoW14nlWrRCwOar/qXAfPK3y2lT/mH0mJbkV/ VD9VK2VmmjNbGVlSJJyA3JAI61ZyrcWBI3JDHI1ZicSkVqLOAGwNHXrgJNgA8ERjH7W9 BXfYKQrvR5tJOuc7A/6jpSzzfHVJYuMcjySwZzoHvBUIzom/HfTiwuaSQTopo6clR4hG 9ciDv1IqLKFuxA/fClYOKWClTvl5LLK30EENE8ixtdwsvpLqBrftSelcQSpXvA7KUlmC HVeQ== X-Gm-Message-State: ABy/qLbZqhNYYTymLnCqmpdurIAB4zhaD5o6gu8emFhBNvcdHCYpI9d7 +b42yWleiga9GNpi1W1/8OR0Ig== X-Google-Smtp-Source: APBJJlG1UaP3iWDf2S19YuchJ/uGkX25TMqI7upEnEy+t2OQXJlPzzzgyP+71NmQ5YGgf2WzudFJEg== X-Received: by 2002:a81:8481:0:b0:576:a1d4:b57c with SMTP id u123-20020a818481000000b00576a1d4b57cmr7283767ywf.47.1688773416987; Fri, 07 Jul 2023 16:43:36 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-21ea-8e86-6208-34bf.res6.spectrum.com. [2603:6081:7b00:6400:21ea:8e86:6208:34bf]) by smtp.gmail.com with ESMTPSA id i128-20020a816d86000000b005773ca61111sm1374752ywc.42.2023.07.07.16.43.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jul 2023 16:43:36 -0700 (PDT) Date: Fri, 7 Jul 2023 19:43:34 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Jaehoon Chung , u-boot@lists.denx.de Subject: Re: [PATCH v3 u-boot] mmc: spl: Make partition choice in default_spl_mmc_emmc_boot_partition() more explicit Message-ID: <20230707234334.GL148062@bill-the-cat> References: <20230413211057.10975-2-pali@kernel.org> <20230707225438.32334-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="INd0R29F3gn3u8tK" Content-Disposition: inline In-Reply-To: <20230707225438.32334-1-pali@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --INd0R29F3gn3u8tK Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jul 08, 2023 at 12:54:38AM +0200, Pali Roh=E1r wrote: > To make eMMC partition choosing in default_spl_mmc_emmc_boot_partition() > function better understandable, rewrite it via explicit switch-case code > pattern. >=20 > Also indicate an error when eMMC EXT_CSD[179] register is configured by > user to value which is not suitable for eMMC booting and SPL do not know > how to interpret it. >=20 > Signed-off-by: Pali Roh=E1r I did some quick local testing to check on the size impact and this is indeed quite manageable, thanks for reworking things! Reviewed-by: Tom Rini --=20 Tom --INd0R29F3gn3u8tK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmSooxwACgkQFHw5/5Y0 tyxYxwv/UV+u2nCnAcdh8Zjp3TMQyvcPVah7YcA0BtEvgJDjRvbALQXqHnyq8Wma jX8TAphAi4NIC4/CfQ+ntTp9FQMVHTMrG+kRNPHitpIfgXRumGbf1gWYf7Q0+KJz 87HRFArq9vbKw5kZyrUlsa+DJADkh1kJudYthyWwSo/miR0Az91w/MbqXq8AuJoy fEBFyK2Z3msoGHg8qHoJzAlLuq19bZmH4HmqsHF5Plu49cSMOWd/6yDjLVOpIsY0 umxrQ4DkxK7lqpH8lvUD0YJDf6XAENuIXxdvqlZZUcOZgu8YsuFhaCEPmwG9A8yF d4JfDbaBP1s/7Lsxwtdom0oZIXPujXAL79o43embO+bhm+s0s45p3nz7LlOpAd4c f1XVesXBdZEJuqcOf0tS5EaCu+jnEwf840ZpqO+Lnj2rDWbFpbFYIZZfmnC4IIDS 2DEuoaOhzwismroPcxD7W2nLC34UjKDbFYC0p0acE/XK4DoVMJB9Ykvzao0eygmB K8vEOII7 =qoss -----END PGP SIGNATURE----- --INd0R29F3gn3u8tK--