From: Greg KH <gregkh@linuxfoundation.org>
To: "Liam R. Howlett" <Liam.Howlett@oracle.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
John Hsu <John.Hsu@mediatek.com>,
stable@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH stable v6.1] mm/mmap: Fix extra maple tree write
Date: Fri, 7 Jul 2023 17:55:26 +0200 [thread overview]
Message-ID: <2023070748-confiding-abnormal-b7e3@gregkh> (raw)
In-Reply-To: <20230706185135.2235532-1-Liam.Howlett@oracle.com>
On Thu, Jul 06, 2023 at 02:51:35PM -0400, Liam R. Howlett wrote:
> commit 0503ea8f5ba73eb3ab13a81c1eefbaf51405385a upstream.
>
> This was inadvertently fixed during the removal of __vma_adjust().
>
> When __vma_adjust() is adjusting next with a negative value (pushing
> vma->vm_end lower), there would be two writes to the maple tree. The
> first write is unnecessary and uses all allocated nodes in the maple
> state. The second write is necessary but will need to allocate nodes
> since the first write has used the allocated nodes. This may be a
> problem as it may not be safe to allocate at this time, such as a low
> memory situation. Fix the issue by avoiding the first write and only
> write the adjusted "next" VMA.
Are you sure this is the same git id? The one you reference above is
_VERY_ different from your 2 line change below.
And the changelog text is not the same.
confused,
greg k-h
next prev parent reply other threads:[~2023-07-07 15:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 18:51 [PATCH stable v6.1] mm/mmap: Fix extra maple tree write Liam R. Howlett
2023-07-07 15:55 ` Greg KH [this message]
2023-07-07 16:45 ` Liam R. Howlett
2023-07-12 0:54 ` Liam R. Howlett
2023-07-14 14:44 ` Vlastimil Babka
2023-07-14 15:00 ` Liam R. Howlett
2023-07-16 15:05 ` Greg KH
2023-07-16 15:05 ` Patch "mm/mmap: Fix extra maple tree write" has been added to the 6.1-stable tree gregkh
2023-07-16 15:08 ` Patch "mm/mmap: Fix extra maple tree write" has been added to the 5.4-stable tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023070748-confiding-abnormal-b7e3@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=John.Hsu@mediatek.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.