From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A11FEB64D9 for ; Mon, 10 Jul 2023 15:34:19 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 804AB201; Mon, 10 Jul 2023 17:33:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 804AB201 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1689003257; bh=5CM62BWHL8zOH1qrcSFyvnkmKB8XTQfKgi5NKFnPmeg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=sRFJvFuJeNc7inzhNOyffqFhQGZMr5J3TCWc3HHBLh8UXIxO3G0k354/lP9bdOjsB 3ndKOVU8rfbcQJ5oOKxdMp5OozDGslocr+ciQx7pnRscew0noutH77T70i+VMJidsV k1+tEiVetScKXxsQdXNnFj4E3hBz4+cWC/cdQ9Z4= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 96052F80578; Mon, 10 Jul 2023 17:32:15 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 01F55F8056F; Mon, 10 Jul 2023 17:32:15 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3E01CF80125; Sat, 8 Jul 2023 15:03:42 +0200 (CEST) Received: from mail.andi.de1.cc (mail.andi.de1.cc [IPv6:2a02:c205:3004:2154::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E3CE9F800E4 for ; Sat, 8 Jul 2023 15:03:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E3CE9F800E4 Received: from p5dc58ef9.dip0.t-ipconnect.de ([93.197.142.249] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qI7ar-001Dj3-76; Sat, 08 Jul 2023 15:03:21 +0200 Date: Sat, 8 Jul 2023 15:03:19 +0200 From: Andreas Kemnade To: Mark Brown Cc: bcousson@baylibre.com, tony@atomide.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, peter.ujfalusi@gmail.com, jarkko.nikula@bitmer.com, dmitry.torokhov@gmail.com, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 2/3] ASoC: tlv320aic3x: use BCLK instead of MCLK if not in master mode Message-ID: <20230708150319.202789c1@aktux> In-Reply-To: References: <20230705190324.355282-1-andreas@kemnade.info> <20230705190324.355282-3-andreas@kemnade.info> <15d3fc6e-d294-4968-bc7d-66307efc92db@sirena.org.uk> <20230705215611.5f96584e@aktux> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-MailFrom: andreas@kemnade.info X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1 Message-ID-Hash: D5C3B2IUDXOEROV2DXEHKLJHKMVL5YXU X-Message-ID-Hash: D5C3B2IUDXOEROV2DXEHKLJHKMVL5YXU X-Mailman-Approved-At: Mon, 10 Jul 2023 15:32:11 +0000 X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi, On Thu, 6 Jul 2023 13:02:36 +0100 Mark Brown wrote: > On Wed, Jul 05, 2023 at 09:56:11PM +0200, Andreas Kemnade wrote: > > Mark Brown wrote: > > > > It would be nicer to set the clock via the DT bindings, ideally with the > > > clock bindings... > > > I found no path from these simple-audio-card things to provide a clk_id > > to set_dai_sysclk. I would of course prefer such a thing. Do I have overlooked > > something? > > Since we already have clock bindings we should use those to configure > the clocks, there's several drivers that have added this support already > - look for clock providers. ok, looking around: Just to make sure I am not running in a bad direction: Do you think tlv320aic32x4{,-clk}.c is a good example? It is ignoring clk_id. I was mentally bound to have to use clk_id there, so I did not found a good solution. So I guess I have to configure the chip as a master and using mclk and compare register dumps with the state we have now and the state after the changes, additionally to check bclk functionality directly. Regards, Andreas