All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: chengming.zhou@linux.dev
Cc: axboe@kernel.dk, hch@lst.de, tj@kernel.org, ming.lei@redhat.com,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	zhouchengming@bytedance.com
Subject: Re: [PATCH v5] blk-mq: fix start_time_ns and alloc_time_ns for pre-allocated rq
Date: Mon, 10 Jul 2023 14:11:36 +0200	[thread overview]
Message-ID: <20230710121136.GA17422@lst.de> (raw)
In-Reply-To: <20230710105516.2053478-1-chengming.zhou@linux.dev>

As a personal preference I kinda hate the empty ?:, but otherwise this
looks good;

Reviewed-by: Christoph Hellwig <hch@lst.de>

  reply	other threads:[~2023-07-10 12:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-10 10:55 [PATCH v5] blk-mq: fix start_time_ns and alloc_time_ns for pre-allocated rq chengming.zhou
2023-07-10 12:11 ` Christoph Hellwig [this message]
2023-07-10 19:42 ` Tejun Heo
2023-07-10 19:47 ` Jens Axboe
2023-07-13 12:25   ` Chengming Zhou
2023-07-13 17:58     ` Tejun Heo
2023-07-13 18:13       ` Jens Axboe
2023-07-14 11:31       ` Chengming Zhou
2023-07-14 14:43         ` Jens Axboe
2023-07-14 14:49           ` Chengming Zhou
2023-07-13 18:31 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230710121136.GA17422@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=chengming.zhou@linux.dev \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=tj@kernel.org \
    --cc=zhouchengming@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.