All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Gobert <richardbgobert@gmail.com>
To: Eric Dumazet <edumazet@google.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
	willemdebruijn.kernel@gmail.com, dsahern@kernel.org,
	tom@herbertland.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, gal@nvidia.com
Subject: Re: [PATCH 1/1] net: gro: fix misuse of CB in udp socket lookup
Date: Mon, 10 Jul 2023 16:54:05 +0200	[thread overview]
Message-ID: <20230710145403.GA22009@debian> (raw)
In-Reply-To: <CANn89i+gm=0J3aR_9ikhroQmAvuQ+-dPMH1em9WrmE1o1pfi7w@mail.gmail.com>

Thanks, I will send a v2 with the fixes.

> ipv6_rcv() inits
> 
> IP6CB(skb)->iif = skb_dst(skb) ?
> ip6_dst_idev(skb_dst(skb))->dev->ifindex : dev->ifindex;
> 
> You chose to always use skb->dev->ifindex instead ?
> 
> You might add a comment why it is okay.

It looks like this assignment ("ip6_dst_idev(skb_dst(skb))->dev->ifindex")
is relevant only in case of sending traffic on loopback.
It does not seem relevant in GRO stack.
That is why I chose to use only the `skb->dev->ifindex` part.
Do you think that's correct?

  reply	other threads:[~2023-07-10 14:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-07 12:16 [PATCH 0/1] net: gro: fix misuse of CB in udp socket lookup Richard Gobert
2023-07-07 12:26 ` [PATCH 1/1] " Richard Gobert
2023-07-07 13:44   ` Eric Dumazet
2023-07-10 14:54     ` Richard Gobert [this message]
2023-07-07 18:42   ` Kuniyuki Iwashima
2023-07-07 21:40   ` David Ahern
2023-07-10 14:58     ` Richard Gobert
2023-07-10 15:50       ` David Ahern
2023-07-17 10:41   ` Gal Pressman
2023-07-19  7:27     ` Richard Gobert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230710145403.GA22009@debian \
    --to=richardbgobert@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=gal@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=tom@herbertland.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.