From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9459BEB64D9 for ; Mon, 10 Jul 2023 15:09:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231349AbjGJPJs (ORCPT ); Mon, 10 Jul 2023 11:09:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233533AbjGJPJr (ORCPT ); Mon, 10 Jul 2023 11:09:47 -0400 Received: from mail-il1-f181.google.com (mail-il1-f181.google.com [209.85.166.181]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AAF56A0; Mon, 10 Jul 2023 08:09:45 -0700 (PDT) Received: by mail-il1-f181.google.com with SMTP id e9e14a558f8ab-345ff33d286so24397755ab.3; Mon, 10 Jul 2023 08:09:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689001785; x=1691593785; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jKvprmbQggu3W5jTI7/RYtuI14SvwmXAeaCnRhx/8Eg=; b=IOp9JgM9HfYcgWeDU+dXqH3tw0yGM6TtJeIsduTEnJi/zpSX9GM6ahF5ai3J/0JO4a SPiIqXQf0QCMRIqo+IfBV0iBmHuiCdU6go7a75ubBfgRBU8Hrn1yCh+11IKwOINeqWfV 2zTyO7oStBp78+clg/9W+0/+KHB4s1+uhK37aRKeqGnZqkQAyM3G5frdz4TQLf6C1LbK Pta1S84MoNDW57sZkADSdVv+Ahts2lfZYJc1YGPB4ZHa6Nb/rJ9KcFmxL0B2gw/UtfmZ B5cwRqSD0rMmxBJZkQn1WiF3OKd50Biz1LiXgH81yql/LjMj2NaouOaQazyiFd/Mabaq inFA== X-Gm-Message-State: ABy/qLbP4vBeL+epN7fCMjMMyeKb9VD+0+iZg4Gl9DQrwxDjUbkUx8pv qLKyvxfsX55b31mR8BQi+Q== X-Google-Smtp-Source: APBJJlHBaTGeZWqsJNGHTw9YfpFhBk2BMRsd8PWrFG782s4SFRcoePJT+h6xwMH7fWTh51JVq7Dj8Q== X-Received: by 2002:a92:d585:0:b0:331:773f:e67a with SMTP id a5-20020a92d585000000b00331773fe67amr11073262iln.31.1689001784902; Mon, 10 Jul 2023 08:09:44 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id t7-20020a92c0c7000000b00345cce526cdsm3584666ilf.54.2023.07.10.08.09.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jul 2023 08:09:44 -0700 (PDT) Received: (nullmailer pid 1983048 invoked by uid 1000); Mon, 10 Jul 2023 15:09:42 -0000 Date: Mon, 10 Jul 2023 09:09:42 -0600 From: Rob Herring To: Marek Vasut Cc: Krzysztof Kozlowski , linux-remoteproc@vger.kernel.org, Bjorn Andersson , Conor Dooley , Fabio Estevam , Krzysztof Kozlowski , Mathieu Poirier , NXP Linux Team , Peng Fan , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: imx_rproc: Support i.MX8MN/P MMIO Message-ID: <20230710150942.GA1979021-robh@kernel.org> References: <20230707232626.374475-1-marex@denx.de> <566cacd8-7110-850c-8d30-e1aba1591e92@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <566cacd8-7110-850c-8d30-e1aba1591e92@denx.de> Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Mon, Jul 10, 2023 at 11:10:48AM +0200, Marek Vasut wrote: > On 7/10/23 10:13, Krzysztof Kozlowski wrote: > > On 08/07/2023 01:26, Marek Vasut wrote: > > > The MX8M CM7 boot via SMC call is problematic, since not all versions > > > of ATF support this interface. Document MMIO support used to boot the > > > CM7 on MX8MN/MP instead and discern MMIO interface using DT compatible > > > string. Document GPR register syscon phandle which is required by the > > > MMIO interface too. > > > > > > Signed-off-by: Marek Vasut > > > --- > > > Note that the MMIO being discerned using compatible string is similar > > > approach to "st,stm32mp1-rcc" vs "st,stm32mp1-rcc-secure". > > > --- > > > > Same hardware should not have two compatibles, depending on the bus it is. > > Yes, I know, but for whatever reason the ST does, so I picked the same > approach here. What else would you suggest, boolean properly like Peng wrote > ? > > The compatible is also easier to handle on driver level, at least in Linux, > see 2/2 . IIRC, in the ST case, the programming model presented to the OS is different, so different compatibles. Seems like this case is similar. However, can't you try and SMC call and if it fails, use MMIO? Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA218EB64D9 for ; Mon, 10 Jul 2023 15:10:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MHcLaLVruz7k79QeMJAkDHf3uGWqr+/RPVaHkrq2/XQ=; b=yMyjnFUADvjoJA 3NQqG0R0fpmb7m55Mkmg9V8jmNcRoinC/H21AGMZY+w+5z3A2/o13nYIAd7FTdh2RXpvEpfpuSCQ/ Jmtc9snb/Gao6aQSsmAP0Eyw7P3MxtiAtefVfWwfONNAHA+ayQpTT2Ihvpd4V6KALoJLNd1+Hfxe5 TlAxBhv28mm4RHQJsc1vEuSBzdUNAsx1TdDCxi1xqOWS+3hAH1HdXQxe4GgOKI+qjlXOYPwe7gbM8 2xu0pzZ+gJscZkf0Uf26Lk81zKe6u/OXRbvxQKEKGRMBFFnR1zp/lwEt/VaFFDeW5WyGPuaW7U/HA +ERTaBALphFLRX98zynA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qIsWK-00ByF7-2h; Mon, 10 Jul 2023 15:09:48 +0000 Received: from mail-il1-f171.google.com ([209.85.166.171]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qIsWI-00ByEZ-1h for linux-arm-kernel@lists.infradead.org; Mon, 10 Jul 2023 15:09:47 +0000 Received: by mail-il1-f171.google.com with SMTP id e9e14a558f8ab-3457a3ada84so24376035ab.1 for ; Mon, 10 Jul 2023 08:09:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689001785; x=1691593785; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jKvprmbQggu3W5jTI7/RYtuI14SvwmXAeaCnRhx/8Eg=; b=fZQaIsyoEwqXkeaONb2b+R6322Sbl/h4OcRLAS5twvp4iQIy93CFlhDb7Wwb7WuWDw 4iuFEm6U5+LbzE0Vb7arSEJ34Z53FNKvUYn5Td0Hfhg22YhL4t6MlFa7KWwqIRiNagr+ FJ6wNpWwBGz9MhDJsI/zf2a8LVUwym+a10vE78xBk9orBHMZ6hR/o4Ibu4e4OWhMqCoY Kg/u9XG/2/TQThIlwRnKACF8B9RvB09Lysp9QlDTRJTJTKjFrOokRkvIWG8QnfpI52gI LUHlbziyoE62V47tEIvb9s6PpTbELeq71kNUVByWd0ZL17YahoraHqTTxShknwNfP3ky c5Ig== X-Gm-Message-State: ABy/qLYBWOzgJ4TVZuKN2ELLdszbazBRFM1jLgOucp+aVs4CUNPhhn5U kgpXX13Y8XD/j+Ffv3II5w== X-Google-Smtp-Source: APBJJlHBaTGeZWqsJNGHTw9YfpFhBk2BMRsd8PWrFG782s4SFRcoePJT+h6xwMH7fWTh51JVq7Dj8Q== X-Received: by 2002:a92:d585:0:b0:331:773f:e67a with SMTP id a5-20020a92d585000000b00331773fe67amr11073262iln.31.1689001784902; Mon, 10 Jul 2023 08:09:44 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id t7-20020a92c0c7000000b00345cce526cdsm3584666ilf.54.2023.07.10.08.09.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jul 2023 08:09:44 -0700 (PDT) Received: (nullmailer pid 1983048 invoked by uid 1000); Mon, 10 Jul 2023 15:09:42 -0000 Date: Mon, 10 Jul 2023 09:09:42 -0600 From: Rob Herring To: Marek Vasut Cc: Krzysztof Kozlowski , linux-remoteproc@vger.kernel.org, Bjorn Andersson , Conor Dooley , Fabio Estevam , Krzysztof Kozlowski , Mathieu Poirier , NXP Linux Team , Peng Fan , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: imx_rproc: Support i.MX8MN/P MMIO Message-ID: <20230710150942.GA1979021-robh@kernel.org> References: <20230707232626.374475-1-marex@denx.de> <566cacd8-7110-850c-8d30-e1aba1591e92@denx.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <566cacd8-7110-850c-8d30-e1aba1591e92@denx.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230710_080946_563272_25BB403E X-CRM114-Status: GOOD ( 20.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 10, 2023 at 11:10:48AM +0200, Marek Vasut wrote: > On 7/10/23 10:13, Krzysztof Kozlowski wrote: > > On 08/07/2023 01:26, Marek Vasut wrote: > > > The MX8M CM7 boot via SMC call is problematic, since not all versions > > > of ATF support this interface. Document MMIO support used to boot the > > > CM7 on MX8MN/MP instead and discern MMIO interface using DT compatible > > > string. Document GPR register syscon phandle which is required by the > > > MMIO interface too. > > > > > > Signed-off-by: Marek Vasut > > > --- > > > Note that the MMIO being discerned using compatible string is similar > > > approach to "st,stm32mp1-rcc" vs "st,stm32mp1-rcc-secure". > > > --- > > > > Same hardware should not have two compatibles, depending on the bus it is. > > Yes, I know, but for whatever reason the ST does, so I picked the same > approach here. What else would you suggest, boolean properly like Peng wrote > ? > > The compatible is also easier to handle on driver level, at least in Linux, > see 2/2 . IIRC, in the ST case, the programming model presented to the OS is different, so different compatibles. Seems like this case is similar. However, can't you try and SMC call and if it fails, use MMIO? Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel