From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Ignacy Gawędzki" <ignacy.gawedzki@green-communications.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2] package/iproute2: add optional dependency on libbpf
Date: Mon, 10 Jul 2023 19:32:11 +0200 [thread overview]
Message-ID: <20230710193211.77b635f0@windsurf> (raw)
In-Reply-To: <20230703211559.qpoachdrbjt43btk@zenon.in.qult.net>
On Mon, 3 Jul 2023 23:15:59 +0200
Ignacy Gawędzki <ignacy.gawedzki@green-communications.fr> wrote:
> The configure script will automatically detect used pkg-config if
> libbpf is available.
This sentence in the commit log did not really make sense anymore now
that you have added explicit usage of the --libbpf_force option.
> +IPROUTE2_CONFIGURE_OPTS =
This is not needed, and we rarely do this in Buildroot. Non-existing
variables are by default empty, so doing a += to a non-existing
variable is perfectly correct.
Applied with those two small nits addressed. Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-07-10 17:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 10:58 [Buildroot] [PATCH] package/iproute2: add optional dependency on libbpf Ignacy Gawędzki
2023-07-03 19:09 ` Thomas Petazzoni via buildroot
2023-07-03 21:15 ` [Buildroot] [PATCH v2] " Ignacy Gawędzki
2023-07-10 17:32 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230710193211.77b635f0@windsurf \
--to=buildroot@buildroot.org \
--cc=ignacy.gawedzki@green-communications.fr \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.