From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org, Yi Zhang <yi.zhang@redhat.com>,
Chunguang Xu <brookxu.cn@gmail.com>
Subject: Re: [PATCH 1/6] nvme: unquiesce io queues when removing namespaces
Date: Tue, 11 Jul 2023 10:27:19 +0200 [thread overview]
Message-ID: <20230711082719.GA23019@lst.de> (raw)
In-Reply-To: <20230710153555.1766438-2-ming.lei@redhat.com>
On Mon, Jul 10, 2023 at 11:35:50PM +0800, Ming Lei wrote:
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 47d7ba2827ff..98fa8315bc65 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -3903,6 +3903,12 @@ void nvme_remove_namespaces(struct nvme_ctrl *ctrl)
> */
> nvme_mpath_clear_ctrl_paths(ctrl);
>
> + /*
> + * Unquiesce io queues so any pending IO won't hang, especially
> + * those submitted from scan work
> + */
> + nvme_unquiesce_io_queues(ctrl);
What quiesce does this pair with?
next prev parent reply other threads:[~2023-07-11 8:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 15:35 [PATCH 0/6] nvme fabircs: move start freeze into reconnection work Ming Lei
2023-07-10 15:35 ` [PATCH 1/6] nvme: unquiesce io queues when removing namespaces Ming Lei
2023-07-10 15:37 ` Keith Busch
2023-07-11 7:32 ` Sagi Grimberg
2023-07-11 8:27 ` Christoph Hellwig [this message]
2023-07-11 8:31 ` Ming Lei
2023-07-11 9:12 ` Sagi Grimberg
2023-07-10 15:35 ` [PATCH 2/6] nvme: tcp: remove 'shutdown' parameters from two teardown helpers Ming Lei
2023-07-11 7:38 ` Sagi Grimberg
2023-07-11 7:39 ` Sagi Grimberg
2023-07-10 15:35 ` [PATCH 3/6] nvme: tcp: unquiesce queues after ctrl state is changed Ming Lei
2023-07-11 7:41 ` Sagi Grimberg
2023-07-11 7:53 ` Ming Lei
2023-07-11 9:05 ` Sagi Grimberg
2023-07-10 15:35 ` [PATCH 4/6] nvme: rdma: unquiesce queues until " Ming Lei
2023-07-11 7:42 ` Sagi Grimberg
2023-07-10 15:35 ` [PATCH 5/6] nvem: tcp: move start freeze into nvme_tcp_configure_io_queues Ming Lei
2023-07-11 7:36 ` Sagi Grimberg
2023-07-10 15:35 ` [PATCH 6/6] nvem: rdma: move start freeze into nvme_rdma_configure_io_queues Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230711082719.GA23019@lst.de \
--to=hch@lst.de \
--cc=brookxu.cn@gmail.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.