From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Asaf Kahlon <asafka7@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] package/python-terminaltables: fix build backend
Date: Tue, 11 Jul 2023 09:32:49 +0200 [thread overview]
Message-ID: <20230711093249.73674060@windsurf> (raw)
In-Reply-To: <CADvTj4ruzjfhJ-Ns9rPYhrW4oGWGqCkf66gUjTT+DR+DB8C3Xw@mail.gmail.com>
On Mon, 10 Jul 2023 13:58:38 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:
> > > We need to migrate python-terminaltables to the pep517 poetry-core
> > > backend as setuptools is not supported.
> > >
> > > Upstream has merged a patch replacing poetry with poetry-core, however
> > > we can not backport this using a patch file due to CRLF line ending
> > > issues so we will have to apply the change in the patch using sed
> > > instead.
> > >
> > > See upstream commit:
> > > https://github.com/matthewdeanmartin/terminaltables/commit/9e3dda0efb54fee6934c744a13a7336d24c6e9e9
> > >
> > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> >
> > What is the motivation to do this, if the current version of
> > python-terminaltables builds fine with setuptools?
>
> It doesn't build in combination with pep517 setuptools since the pyproject.toml
> specifies poetry as the build backend and not setuptools.
So is this patch series modifying python-terminaltables a prerequisite
to applying the patch at
https://patchwork.ozlabs.org/project/buildroot/patch/20230626181531.2312002-5-james.hilliard1@gmail.com/ ?
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-07-11 7:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 7:26 [Buildroot] [PATCH 1/2] package/python-poetry-core: new host package James Hilliard
2023-06-27 7:26 ` [Buildroot] [PATCH 2/2] package/python-terminaltables: fix build backend James Hilliard
2023-07-10 18:01 ` Thomas Petazzoni via buildroot
2023-07-10 19:58 ` James Hilliard
2023-07-11 7:32 ` Thomas Petazzoni via buildroot [this message]
2023-07-11 7:35 ` James Hilliard
2023-07-11 8:00 ` Thomas Petazzoni via buildroot
2023-07-11 9:43 ` James Hilliard
2023-07-11 9:54 ` Thomas Petazzoni via buildroot
2023-07-11 9:57 ` Thomas Petazzoni via buildroot
2023-07-11 10:50 ` James Hilliard
2023-07-11 12:29 ` Thomas Petazzoni via buildroot
2023-07-11 14:42 ` James Hilliard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230711093249.73674060@windsurf \
--to=buildroot@buildroot.org \
--cc=asafka7@gmail.com \
--cc=james.hilliard1@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.