From: kernel test robot <lkp@intel.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [amir73il:start-write-safe 4/6] fs/nfsd/vfs.c:1031:13: error: call to undeclared function 'file_access_permission'; ISO C99 and later do not support implicit function declarations
Date: Tue, 11 Jul 2023 14:47:36 +0800 [thread overview]
Message-ID: <202307111413.ILAEIXd9-lkp@intel.com> (raw)
tree: https://github.com/amir73il/linux start-write-safe
head: dee92d97ca4a2052cddcf1875441bdbe30e50b13
commit: 28373848f0ca3bbfb2c00e4b210d8b498d145d98 [4/6] splice: move permission hook out of splice_direct_to_actor()
config: arm-versatile_defconfig (https://download.01.org/0day-ci/archive/20230711/202307111413.ILAEIXd9-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce: (https://download.01.org/0day-ci/archive/20230711/202307111413.ILAEIXd9-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307111413.ILAEIXd9-lkp@intel.com/
All errors (new ones prefixed by >>):
>> fs/nfsd/vfs.c:1031:13: error: call to undeclared function 'file_access_permission'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
1031 | host_err = file_access_permission(file, MAY_READ);
| ^
fs/nfsd/vfs.c:1031:13: note: did you mean 'file_permission'?
include/linux/fs.h:2519:19: note: 'file_permission' declared here
2519 | static inline int file_permission(struct file *file, int mask)
| ^
1 error generated.
vim +/file_access_permission +1031 fs/nfsd/vfs.c
1005
1006 /**
1007 * nfsd_splice_read - Perform a VFS read using a splice pipe
1008 * @rqstp: RPC transaction context
1009 * @fhp: file handle of file to be read
1010 * @file: opened struct file of file to be read
1011 * @offset: starting byte offset
1012 * @count: IN: requested number of bytes; OUT: number of bytes read
1013 * @eof: OUT: set non-zero if operation reached the end of the file
1014 *
1015 * Returns nfs_ok on success, otherwise an nfserr stat value is
1016 * returned.
1017 */
1018 __be32 nfsd_splice_read(struct svc_rqst *rqstp, struct svc_fh *fhp,
1019 struct file *file, loff_t offset, unsigned long *count,
1020 u32 *eof)
1021 {
1022 struct splice_desc sd = {
1023 .len = 0,
1024 .total_len = *count,
1025 .pos = offset,
1026 .u.data = rqstp,
1027 };
1028 ssize_t host_err;
1029
1030 trace_nfsd_read_splice(rqstp, fhp, offset, *count);
> 1031 host_err = file_access_permission(file, MAY_READ);
1032 if (!host_err)
1033 host_err = splice_direct_to_actor(file, &sd,
1034 nfsd_direct_splice_actor);
1035 return nfsd_finish_read(rqstp, fhp, file, offset, count, eof, host_err);
1036 }
1037
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2023-07-11 6:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202307111413.ILAEIXd9-lkp@intel.com \
--to=lkp@intel.com \
--cc=amir73il@gmail.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.