From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: John Ogness <john.ogness@linutronix.de>
Cc: Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH printk v2 3/5] printk: Consolidate console deferred printing
Date: Wed, 12 Jul 2023 00:17:38 +0900 [thread overview]
Message-ID: <20230711151738.GD12154@google.com> (raw)
In-Reply-To: <20230710134524.25232-4-john.ogness@linutronix.de>
On (23/07/10 15:51), John Ogness wrote:
> Printing to consoles can be deferred for several reasons:
>
> - explicitly with printk_deferred()
> - printk() in NMI context
> - recursive printk() calls
>
> The current implementation is not consistent. For printk_deferred(),
> irq work is scheduled twice. For NMI und recursive, panic CPU
> suppression and caller delays are not properly enforced.
>
> Correct these inconsistencies by consolidating the deferred printing
> code so that vprintk_deferred() is the top-level function for
> deferred printing and vprintk_emit() will perform whichever irq_work
> queueing is appropriate.
>
> Also add kerneldoc for wake_up_klogd() and defer_console_output() to
> clarify their differences and appropriate usage.
>
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
Looks good to me
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
next prev parent reply other threads:[~2023-07-11 15:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 13:45 [PATCH printk v2 0/5] various cleanups John Ogness
2023-07-10 13:45 ` [PATCH printk v2 1/5] kdb: do not assume write() callback available John Ogness
2023-07-11 0:25 ` Sergey Senozhatsky
2023-07-11 8:23 ` Daniel Thompson
2023-07-11 8:58 ` John Ogness
2023-07-11 9:01 ` Daniel Thompson
2023-07-10 13:45 ` [PATCH printk v2 2/5] printk: Add NMI safety to console_flush_on_panic() and console_unblank() John Ogness
2023-07-11 15:43 ` Petr Mladek
2023-07-11 16:07 ` Sergey Senozhatsky
2023-07-12 21:11 ` John Ogness
2023-07-13 14:43 ` Petr Mladek
2023-07-14 4:00 ` Sergey Senozhatsky
2023-07-14 9:41 ` Petr Mladek
2023-07-10 13:45 ` [PATCH printk v2 3/5] printk: Consolidate console deferred printing John Ogness
2023-07-11 15:17 ` Sergey Senozhatsky [this message]
2023-07-13 14:51 ` Petr Mladek
2023-07-10 13:45 ` [PATCH printk v2 4/5] printk: Add per-console suspended state John Ogness
2023-07-11 15:08 ` Sergey Senozhatsky
2023-07-11 15:23 ` John Ogness
2023-07-11 15:26 ` Sergey Senozhatsky
2023-07-11 15:30 ` Sergey Senozhatsky
2023-07-13 15:53 ` Petr Mladek
2023-07-10 13:45 ` [PATCH printk v2 5/5] printk: Rename abandon_console_lock_in_panic() to other_cpu_in_panic() John Ogness
2023-07-11 0:22 ` Sergey Senozhatsky
2023-07-13 15:55 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230711151738.GD12154@google.com \
--to=senozhatsky@chromium.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.