From: Jakub Kicinski <kuba@kernel.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
netdev@vger.kernel.org, Ivan Vecera <ivecera@redhat.com>,
Ma Yuying <yuma@redhat.com>,
Simon Horman <simon.horman@corigine.com>,
Rafal Romanowski <rafal.romanowski@intel.com>
Subject: Re: [PATCH net-next 1/2] i40e: Add helper for VF inited state check with timeout
Date: Tue, 11 Jul 2023 17:37:31 -0700 [thread overview]
Message-ID: <20230711173731.54b9fa80@kernel.org> (raw)
In-Reply-To: <20230711120904.GP41919@unreal>
On Tue, 11 Jul 2023 15:09:04 +0300 Leon Romanovsky wrote:
> > + for (i = 0; i < 15; i++) {
> > + if (test_bit(I40E_VF_STATE_INIT, &vf->vf_states))
> > + return true;
> > +
> > + msleep(20);
> > + }
> > +
> > + dev_err(&vf->pf->pdev->dev, "VF %d still in reset. Try again.\n",
> > + vf->vf_id);
>
> This error is not accurate in the edge case, when VF state changed to
> be INIT during msleep() while i was 14.
Right, it's a change in behavior from existing code,
old code re-checked if INIT is set after the last sleep.
--
pw-bot: cr
next prev parent reply other threads:[~2023-07-12 0:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 16:40 [PATCH net-next 0/2][pull request] Intel Wired LAN Driver Updates 2023-07-10 (i40e) Tony Nguyen
2023-07-10 16:40 ` [PATCH net-next 1/2] i40e: Add helper for VF inited state check with timeout Tony Nguyen
2023-07-11 12:09 ` Leon Romanovsky
2023-07-12 0:37 ` Jakub Kicinski [this message]
2023-07-12 13:28 ` Ivan Vecera
2023-07-12 13:18 ` Ivan Vecera
2023-07-12 17:31 ` Jakub Kicinski
2023-07-10 16:40 ` [PATCH net-next 2/2] i40e: Wait for pending VF reset in VF set callbacks Tony Nguyen
2023-07-11 12:10 ` Leon Romanovsky
-- strict thread matches above, loose matches on Subject: below --
2023-06-13 12:16 [PATCH net-next 1/2] i40e: Add helper for VF inited state check with timeout Ivan Vecera
2023-06-14 8:26 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230711173731.54b9fa80@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ivecera@redhat.com \
--cc=leon@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafal.romanowski@intel.com \
--cc=simon.horman@corigine.com \
--cc=yuma@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.