From: Jakub Kicinski <kuba@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next][resend v1 1/1] netlink: Don't use int as bool in netlink_update_socket_mc()
Date: Tue, 11 Jul 2023 17:43:10 -0700 [thread overview]
Message-ID: <20230711174310.081a2574@kernel.org> (raw)
In-Reply-To: <20230710100624.87836-1-andriy.shevchenko@linux.intel.com>
On Mon, 10 Jul 2023 13:06:24 +0300 Andy Shevchenko wrote:
> The bit operations take boolean parameter and return also boolean
> (in test_bit()-like cases). Don't threat booleans as integers when
> it's not needed.
I don't have a strong opinion on the merit.
But I feel like the discussion is a waste of everyone's time,
so to discourage such ambivalent patches I'm going to drop this.
--
pw-bot: reject
prev parent reply other threads:[~2023-07-12 0:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 10:06 [PATCH net-next][resend v1 1/1] netlink: Don't use int as bool in netlink_update_socket_mc() Andy Shevchenko
2023-07-11 6:33 ` Leon Romanovsky
2023-07-11 10:21 ` Paolo Abeni
2023-07-11 10:54 ` Andy Shevchenko
2023-07-11 12:20 ` Leon Romanovsky
2023-07-11 12:45 ` Andy Shevchenko
2023-07-11 13:32 ` Leon Romanovsky
2023-07-11 13:44 ` Andy Shevchenko
2023-07-11 17:10 ` Leon Romanovsky
2023-07-11 17:19 ` Andy Shevchenko
2023-07-12 0:43 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230711174310.081a2574@kernel.org \
--to=kuba@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.