From: Jakub Kicinski <kuba@kernel.org>
To: Florian Kauer <florian.kauer@linutronix.de>
Cc: Leon Romanovsky <leon@kernel.org>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
netdev@vger.kernel.org, kurt@linutronix.de,
vinicius.gomes@intel.com, muhammad.husaini.zulkifli@intel.com,
tee.min.tan@linux.intel.com, aravindhan.gunasekaran@intel.com,
sasha.neftin@intel.com, Naama Meir <naamax.meir@linux.intel.com>
Subject: Re: [PATCH net 1/6] igc: Rename qbv_enable to taprio_offload_enable
Date: Tue, 11 Jul 2023 17:58:25 -0700 [thread overview]
Message-ID: <20230711175825.0b6dbbcd@kernel.org> (raw)
In-Reply-To: <275f1916-3f23-45e5-ae4d-a5d47e75e452@linutronix.de>
On Tue, 11 Jul 2023 09:51:34 +0200 Florian Kauer wrote:
> > I understand the intention, but your second patch showed that rename was
> > premature.
I think it's fine. It's a rename, it can't regress anything.
And the separate commit message clearly describing reasoning
is good to have.
> The second patch does not touch the rename in igc.h and igc_tsn.c...
> (and the latter is from the context probably the most relevant one)
> But I see what you mean. I am fine with both squashing and keeping it separate,
> but I have no idea how the preferred process is since this
> is already so far through the pipeline...
"This is so far through the pipeline" is an argument which may elicit
a very negative reaction upstream :)
next prev parent reply other threads:[~2023-07-12 0:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 16:34 [PATCH net 0/6][pull request] igc: Fix corner cases for TSN offload Tony Nguyen
2023-07-10 16:34 ` [PATCH net 1/6] igc: Rename qbv_enable to taprio_offload_enable Tony Nguyen
2023-07-11 7:01 ` Leon Romanovsky
2023-07-11 7:18 ` Florian Kauer
2023-07-11 7:32 ` Leon Romanovsky
2023-07-11 7:51 ` Florian Kauer
2023-07-12 0:58 ` Jakub Kicinski [this message]
2023-07-12 6:53 ` Florian Kauer
2023-07-12 20:37 ` Tony Nguyen
2023-07-10 16:34 ` [PATCH net 2/6] igc: Do not enable taprio offload for invalid arguments Tony Nguyen
2023-07-11 7:03 ` Leon Romanovsky
2023-07-10 16:35 ` [PATCH net 3/6] igc: Handle already enabled taprio offload for basetime 0 Tony Nguyen
2023-07-11 7:03 ` Leon Romanovsky
2023-07-10 16:35 ` [PATCH net 4/6] igc: No strict mode in pure launchtime/CBS offload Tony Nguyen
2023-07-11 7:09 ` Leon Romanovsky
2023-07-10 16:35 ` [PATCH net 5/6] igc: Fix launchtime before start of cycle Tony Nguyen
2023-07-11 7:09 ` Leon Romanovsky
2023-07-11 8:37 ` Florian Kauer
2023-07-11 10:12 ` Leon Romanovsky
2023-07-12 0:54 ` Jakub Kicinski
2023-07-12 6:11 ` Leon Romanovsky
2023-07-10 16:35 ` [PATCH net 6/6] igc: Fix inserting of empty frame for launchtime Tony Nguyen
2023-07-11 7:11 ` Leon Romanovsky
2023-07-12 9:10 ` [PATCH net 0/6][pull request] igc: Fix corner cases for TSN offload patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230711175825.0b6dbbcd@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=aravindhan.gunasekaran@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.kauer@linutronix.de \
--cc=kurt@linutronix.de \
--cc=leon@kernel.org \
--cc=muhammad.husaini.zulkifli@intel.com \
--cc=naamax.meir@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sasha.neftin@intel.com \
--cc=tee.min.tan@linux.intel.com \
--cc=vinicius.gomes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.