From: Jakub Kicinski <kuba@kernel.org>
To: Yang Rong <yangrong@vivo.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
virtualization@lists.linux-foundation.org (open list:VIRTIO CORE
AND NET DRIVERS),
netdev@vger.kernel.org (open list:NETWORKING DRIVERS),
linux-kernel@vger.kernel.org (open list),
opensource.kernel@vivo.com, luhongfei@vivo.com
Subject: Re: [PATCH] virtio_net: Use max() function for better coding conventions
Date: Tue, 11 Jul 2023 19:29:43 -0700 [thread overview]
Message-ID: <20230711192943.7a541984@kernel.org> (raw)
In-Reply-To: <20230710012508.2119-1-yangrong@vivo.com>
On Mon, 10 Jul 2023 09:20:51 +0800 Yang Rong wrote:
> It is advisable to utilize the max() function in the virtio_net.c file,
> as it conforms better to programming conventions.
>
> Signed-off-by: Yang Rong <yangrong@vivo.com>
Unnecessary churn, please don't send max() conversions to networking.
--
pw-bot: reject
prev parent reply other threads:[~2023-07-12 2:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 1:20 [PATCH] virtio_net: Use max() function for better coding conventions Yang Rong
2023-07-12 2:29 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230711192943.7a541984@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luhongfei@vivo.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
--cc=yangrong@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.