From: Jakub Kicinski <kuba@kernel.org>
To: Michael Chan <michael.chan@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com
Subject: Re: [PATCH net-next 3/3] eth: bnxt: handle invalid Tx completions more gracefully
Date: Wed, 12 Jul 2023 09:35:06 -0700 [thread overview]
Message-ID: <20230712093506.6a1f229a@kernel.org> (raw)
In-Reply-To: <CACKFLimyipgG41BoGb52HAFbxRdmU2HwfNw-GZr6WZ0c1v2LqQ@mail.gmail.com>
On Tue, 11 Jul 2023 21:50:16 -0700 Michael Chan wrote:
> > Are you saying that in ethtool -S in addition to per-ring counts
> > we'd report a "total" which is sum(current per ring) + saved?
> > If so - that makes sense, yup.
>
> Yes, for example, we have "rx_resets" which is per ring. We'll add a
> "rx_total_resets" which is the sum of all current "rx_resets" + the
> saved snapshot. The per ring "rx_resets" will reset to 0 during each
> reset (including ifdown). But "rx_total_resets" will be saved across
> reset.
>
> > You mention reset but the errors counters should survive close() /
> > open() cycles as well.
>
> Yes. It's the same reset whether it is ifdown/ifup or reset.
Makes sense, and sounds good!
next prev parent reply other threads:[~2023-07-12 16:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 20:56 [PATCH net-next 0/3] eth: bnxt: handle invalid Tx completions more gracefully Jakub Kicinski
2023-07-10 20:56 ` [PATCH net-next 1/3] eth: bnxt: move and rename reset helpers Jakub Kicinski
2023-07-10 20:56 ` [PATCH net-next 2/3] eth: bnxt: take the bit to set as argument of bnxt_queue_sp_work() Jakub Kicinski
2023-07-10 20:56 ` [PATCH net-next 3/3] eth: bnxt: handle invalid Tx completions more gracefully Jakub Kicinski
2023-07-11 8:00 ` Michael Chan
2023-07-12 0:01 ` Michael Chan
2023-07-12 1:09 ` Jakub Kicinski
2023-07-12 4:11 ` Michael Chan
2023-07-12 4:24 ` Jakub Kicinski
2023-07-12 4:50 ` Michael Chan
2023-07-12 16:35 ` Jakub Kicinski [this message]
2023-07-11 10:10 ` Paolo Abeni
2023-07-12 1:19 ` Jakub Kicinski
2023-07-12 6:50 ` Paolo Abeni
2023-07-12 16:34 ` Jakub Kicinski
2023-07-12 20:31 ` Paolo Abeni
2023-07-12 20:50 ` Jakub Kicinski
2023-07-10 21:44 ` [PATCH net-next 0/3] " Michael Chan
2023-07-11 0:38 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230712093506.6a1f229a@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.