From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4D39EB64DD for ; Wed, 12 Jul 2023 12:05:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9250310E50E; Wed, 12 Jul 2023 12:04:58 +0000 (UTC) X-Greylist: delayed 381 seconds by postgrey-1.36 at gabe; Wed, 12 Jul 2023 09:50:11 UTC Received: from hygieia.sysophe.eu (hygieia.sysophe.eu [138.201.91.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id C3A3410E4BA; Wed, 12 Jul 2023 09:50:11 +0000 (UTC) Received: from hemera.lan.sysophe.eu (unknown [IPv6:2001:a18:2c5:a501:fa75:a4ff:fe28:fe3a]) by smtp.sysophe.eu (Postfix) with ESMTPSA id 1A675260A610; Wed, 12 Jul 2023 11:43:42 +0200 (CEST) Date: Wed, 12 Jul 2023 11:43:35 +0200 From: Bruno =?UTF-8?B?UHLDqW1vbnQ=?= To: Thomas Zimmermann Subject: Re: [PATCH 10/17] hid/picolcd: Remove flag FBINFO_FLAG_DEFAULT from fbdev driver Message-ID: <20230712114335.42644eab@hemera.lan.sysophe.eu> In-Reply-To: <20230710130113.14563-11-tzimmermann@suse.de> References: <20230710130113.14563-1-tzimmermann@suse.de> <20230710130113.14563-11-tzimmermann@suse.de> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Wed, 12 Jul 2023 12:04:52 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Jiri Kosina , kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-sh@vger.kernel.org, deller@gmx.de, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, javierm@redhat.com, Benjamin Tissoires , dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-nvidia@lists.surfsouth.com, linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-geode@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Mon, 10 Jul 2023 14:50:14 +0200 Thomas Zimmermann wrote: > The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct > fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do > not set it. >=20 > Flags should signal differences from the default values. After cleaning > up all occurences of FBINFO_FLAG_DEFAULT, the token can be removed. >=20 > Signed-off-by: Thomas Zimmermann > Cc: "Bruno Pr=C3=A9mont" > Cc: Jiri Kosina > Cc: Benjamin Tissoires Acked-by: Bruno Pr=C3=A9mont Cheers, Bruno > --- > drivers/hid/hid-picolcd_fb.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/drivers/hid/hid-picolcd_fb.c b/drivers/hid/hid-picolcd_fb.c > index dabcd054dad9..d726aaafb146 100644 > --- a/drivers/hid/hid-picolcd_fb.c > +++ b/drivers/hid/hid-picolcd_fb.c > @@ -527,7 +527,6 @@ int picolcd_init_framebuffer(struct picolcd_data *dat= a) > info->var =3D picolcdfb_var; > info->fix =3D picolcdfb_fix; > info->fix.smem_len =3D PICOLCDFB_SIZE*8; > - info->flags =3D FBINFO_FLAG_DEFAULT; > =20 > fbdata =3D info->par; > spin_lock_init(&fbdata->lock); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86234EB64DD for ; Wed, 12 Jul 2023 10:01:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232170AbjGLKAu convert rfc822-to-8bit (ORCPT ); Wed, 12 Jul 2023 06:00:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231944AbjGLKAT (ORCPT ); Wed, 12 Jul 2023 06:00:19 -0400 X-Greylist: delayed 601 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 12 Jul 2023 03:00:12 PDT Received: from hygieia.sysophe.eu (hygieia.sysophe.eu [138.201.91.14]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 011841720; Wed, 12 Jul 2023 03:00:11 -0700 (PDT) Received: from hemera.lan.sysophe.eu (unknown [IPv6:2001:a18:2c5:a501:fa75:a4ff:fe28:fe3a]) by smtp.sysophe.eu (Postfix) with ESMTPSA id 1A675260A610; Wed, 12 Jul 2023 11:43:42 +0200 (CEST) Date: Wed, 12 Jul 2023 11:43:35 +0200 From: Bruno =?UTF-8?B?UHLDqW1vbnQ=?= To: Thomas Zimmermann Cc: deller@gmx.de, javierm@redhat.com, linux-sh@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-geode@lists.infradead.org, linux-nvidia@lists.surfsouth.com, linux-hyperv@vger.kernel.org, linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, Jiri Kosina , Benjamin Tissoires Subject: Re: [PATCH 10/17] hid/picolcd: Remove flag FBINFO_FLAG_DEFAULT from fbdev driver Message-ID: <20230712114335.42644eab@hemera.lan.sysophe.eu> In-Reply-To: <20230710130113.14563-11-tzimmermann@suse.de> References: <20230710130113.14563-1-tzimmermann@suse.de> <20230710130113.14563-11-tzimmermann@suse.de> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Mon, 10 Jul 2023 14:50:14 +0200 Thomas Zimmermann wrote: > The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct > fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do > not set it. > > Flags should signal differences from the default values. After cleaning > up all occurences of FBINFO_FLAG_DEFAULT, the token can be removed. > > Signed-off-by: Thomas Zimmermann > Cc: "Bruno Prémont" > Cc: Jiri Kosina > Cc: Benjamin Tissoires Acked-by: Bruno Prémont Cheers, Bruno > --- > drivers/hid/hid-picolcd_fb.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/hid/hid-picolcd_fb.c b/drivers/hid/hid-picolcd_fb.c > index dabcd054dad9..d726aaafb146 100644 > --- a/drivers/hid/hid-picolcd_fb.c > +++ b/drivers/hid/hid-picolcd_fb.c > @@ -527,7 +527,6 @@ int picolcd_init_framebuffer(struct picolcd_data *data) > info->var = picolcdfb_var; > info->fix = picolcdfb_fix; > info->fix.smem_len = PICOLCDFB_SIZE*8; > - info->flags = FBINFO_FLAG_DEFAULT; > > fbdata = info->par; > spin_lock_init(&fbdata->lock); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB488EB64D9 for ; Wed, 12 Jul 2023 09:50:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lFm+Ne3gw2sJBxPF2KgkIWs1qrixp+R4XPJRN/syklU=; b=Qi9py8aL8+G6GA 4KI/PPrcDiqE2vnHDU9P6cKxHOG1OsxcZktXs76xu5Jc9QfMgkDBOtOixROeTt+9VTe9/+PiI82lZ 81IWt97XqRb44Gw/78bO/3/FlaY3F5AYLnOrNti8UHFcU4KZW8uTD5h/CntnO+cP9IWbojIRdLDKC ogL3LAjtX8FP81ZM3eXwBmGVlYjbkA9HwfuhnrbEFeuQ7jAHG7xDUoA4BxPRSxN5O97g6jPvV3aA5 Xb0fLG4EDmFslKpxdRSlGVW/Lb++qfHK1ht6bGyajIVT2qCGCbJQkeYF6YVBEvSjsmK9nosOVPK43 zaUTNaJg0bJwywwo2eaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJWUB-00H6dn-0e; Wed, 12 Jul 2023 09:50:15 +0000 Received: from hygieia.sysophe.eu ([138.201.91.14]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qJWU7-00H6cp-2e; Wed, 12 Jul 2023 09:50:14 +0000 Received: from hemera.lan.sysophe.eu (unknown [IPv6:2001:a18:2c5:a501:fa75:a4ff:fe28:fe3a]) by smtp.sysophe.eu (Postfix) with ESMTPSA id 1A675260A610; Wed, 12 Jul 2023 11:43:42 +0200 (CEST) Date: Wed, 12 Jul 2023 11:43:35 +0200 From: Bruno =?UTF-8?B?UHLDqW1vbnQ=?= To: Thomas Zimmermann Cc: deller@gmx.de, javierm@redhat.com, linux-sh@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-geode@lists.infradead.org, linux-nvidia@lists.surfsouth.com, linux-hyperv@vger.kernel.org, linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, Jiri Kosina , Benjamin Tissoires Subject: Re: [PATCH 10/17] hid/picolcd: Remove flag FBINFO_FLAG_DEFAULT from fbdev driver Message-ID: <20230712114335.42644eab@hemera.lan.sysophe.eu> In-Reply-To: <20230710130113.14563-11-tzimmermann@suse.de> References: <20230710130113.14563-1-tzimmermann@suse.de> <20230710130113.14563-11-tzimmermann@suse.de> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230712_025012_019573_EE1FAF16 X-CRM114-Status: GOOD ( 14.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAxMCBKdWwgMjAyMyAxNDo1MDoxNCArMDIwMCBUaG9tYXMgWmltbWVybWFubiB3cm90 ZToKPiBUaGUgZmxhZyBGQklORk9fRkxBR19ERUZBVUxUIGlzIDAgYW5kIGhhcyBubyBlZmZlY3Qs IGFzIHN0cnVjdAo+IGZiaW5mby5mbGFncyBoYXMgYmVlbiBhbGxvY2F0ZWQgdG8gemVybyBieSBm cmFtZWJ1ZmZlcl9hbGxvYygpLiBTbyBkbwo+IG5vdCBzZXQgaXQuCj4gCj4gRmxhZ3Mgc2hvdWxk IHNpZ25hbCBkaWZmZXJlbmNlcyBmcm9tIHRoZSBkZWZhdWx0IHZhbHVlcy4gQWZ0ZXIgY2xlYW5p bmcKPiB1cCBhbGwgb2NjdXJlbmNlcyBvZiBGQklORk9fRkxBR19ERUZBVUxULCB0aGUgdG9rZW4g Y2FuIGJlIHJlbW92ZWQuCj4gCj4gU2lnbmVkLW9mZi1ieTogVGhvbWFzIFppbW1lcm1hbm4gPHR6 aW1tZXJtYW5uQHN1c2UuZGU+Cj4gQ2M6ICJCcnVubyBQcsOpbW9udCIgPGJvbmJvbnNAbGludXgt dnNlcnZlci5vcmc+Cj4gQ2M6IEppcmkgS29zaW5hIDxqaWtvc0BrZXJuZWwub3JnPgo+IENjOiBC ZW5qYW1pbiBUaXNzb2lyZXMgPGJlbmphbWluLnRpc3NvaXJlc0ByZWRoYXQuY29tPgoKQWNrZWQt Ynk6IEJydW5vIFByw6ltb250IDxib25ib25zQGxpbnV4LXZzZXJ2ZXIub3JnPgoKQ2hlZXJzLApC cnVubwoKCj4gLS0tCj4gIGRyaXZlcnMvaGlkL2hpZC1waWNvbGNkX2ZiLmMgfCAxIC0KPiAgMSBm aWxlIGNoYW5nZWQsIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9oaWQv aGlkLXBpY29sY2RfZmIuYyBiL2RyaXZlcnMvaGlkL2hpZC1waWNvbGNkX2ZiLmMKPiBpbmRleCBk YWJjZDA1NGRhZDkuLmQ3MjZhYWFmYjE0NiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2hpZC9oaWQt cGljb2xjZF9mYi5jCj4gKysrIGIvZHJpdmVycy9oaWQvaGlkLXBpY29sY2RfZmIuYwo+IEBAIC01 MjcsNyArNTI3LDYgQEAgaW50IHBpY29sY2RfaW5pdF9mcmFtZWJ1ZmZlcihzdHJ1Y3QgcGljb2xj ZF9kYXRhICpkYXRhKQo+ICAJaW5mby0+dmFyID0gcGljb2xjZGZiX3ZhcjsKPiAgCWluZm8tPmZp eCA9IHBpY29sY2RmYl9maXg7Cj4gIAlpbmZvLT5maXguc21lbV9sZW4gICA9IFBJQ09MQ0RGQl9T SVpFKjg7Cj4gLQlpbmZvLT5mbGFncyA9IEZCSU5GT19GTEFHX0RFRkFVTFQ7Cj4gIAo+ICAJZmJk YXRhID0gaW5mby0+cGFyOwo+ICAJc3Bpbl9sb2NrX2luaXQoJmZiZGF0YS0+bG9jayk7CgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo=