From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D62AEB64DD for ; Wed, 12 Jul 2023 12:07:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LdHBBXYysffhqlfAWuFjXs2i56DjCEBdAC9UpxcIPUA=; b=ZHENm4pSPNANQR l3jbjhBYnpO5rzmG+ePpa92js7IrhsfWicec2IspxKpnpl3bmu5jNfvU8+eXy8K1B6VnseR4Bqgke tS10Uwm6LAPmW1EhR0d7Dm56x8kHsyxPknpmqpM8VGte8Wy5jVtG6Jk9UJLwAqZxigM9x/sELv1TV tOcVmLINpiLA2pfetUySAZTO72AOTlIUBdzMryAEXEqB+mQrSPo/Rzq6f5cC5l50zYcFNGfhCmvAL RBfC5yxVN9BW5P6GXnTy8XxvaKn2gryyWSy1DIk9tEjEo6bGZOw8QTdVb4vXtTCm82GUjA0Xgen4c L3OwgzpIhcmEJ4iB6pxg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJYcf-00HUBU-1l; Wed, 12 Jul 2023 12:07:09 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qJYcc-00HUAP-1b; Wed, 12 Jul 2023 12:07:08 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 5BAFC40007; Wed, 12 Jul 2023 12:06:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1689163620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E7ByKZ6oXF6klWgs2IJLwIobDTVTZio3/GXOfUphAec=; b=o4PPeJa6zgRt3UiGPCief6r+PAxy2XWT8DlOmuoUwwpF8ch48sJUaMbjT/suvREM7Hcq37 8z+/KLv7GUBt6TZtsK79jHsq826uZHC9U7z+/HbNlVpZ+PFFaENxM7b5luXr1XWo2PCgnx HsnUVGr7rk9iUmsK0aeibehjZXFeOw/yXIgEt5a9NVFNM+M23L0P3ZV3Ie3XsbsiyMxvpP siKtD56rxyksEnM7A8EQBLHK7TDOiyJkkfIbzWJ/vXVwKj7owExNXALh3xU25ZqiOfe7Tn mDGkOuKqGvp7Qw7ZGLgfxB+Z9RVBCkygIap408+nQNilsXfZbowSbThkpQ4jgQ== Date: Wed, 12 Jul 2023 14:06:55 +0200 From: Miquel Raynal To: Yangtao Li Cc: Richard Weinberger , Vignesh Raghavendra , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/18] mtd: rawnand: sunxi: Use devm_platform_get_and_ioremap_resource() Message-ID: <20230712140655.72fc2a3d@xps-13> In-Reply-To: <20230712135455.71fbeb5f@xps-13> References: <20230707040622.78174-1-frank.li@vivo.com> <20230712135455.71fbeb5f@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230712_050706_667476_CD4294E6 X-CRM114-Status: GOOD ( 21.82 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Cm1pcXVlbC5yYXluYWxAYm9vdGxpbi5jb20gd3JvdGUgb24gV2VkLCAxMiBKdWwgMjAyMyAxMzo1 NDo1NSArMDIwMDoKCj4gSGkgWWFuZ3RhbywKPiAKPiBmcmFuay5saUB2aXZvLmNvbSB3cm90ZSBv biBGcmksICA3IEp1bCAyMDIzIDEyOjA2OjA1ICswODAwOgo+IAo+ID4gQ29udmVydCBwbGF0Zm9y bV9nZXRfcmVzb3VyY2UoKSwgZGV2bV9pb3JlbWFwX3Jlc291cmNlKCkgdG8gYSBzaW5nbGUKPiA+ IGNhbGwgdG8gZGV2bV9wbGF0Zm9ybV9nZXRfYW5kX2lvcmVtYXBfcmVzb3VyY2UoKSwgYXMgdGhp cyBpcyBleGFjdGx5Cj4gPiB3aGF0IHRoaXMgZnVuY3Rpb24gZG9lcy4KPiA+IAo+ID4gU2lnbmVk LW9mZi1ieTogWWFuZ3RhbyBMaSA8ZnJhbmsubGlAdml2by5jb20+Cj4gPiAtLS0KPiA+ICBkcml2 ZXJzL210ZC9uYW5kL3Jhdy9zdW54aV9uYW5kLmMgfCAzICstLQo+ID4gIDEgZmlsZSBjaGFuZ2Vk LCAxIGluc2VydGlvbigrKSwgMiBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvbXRkL25hbmQvcmF3L3N1bnhpX25hbmQuYyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L3N1 bnhpX25hbmQuYwo+ID4gaW5kZXggOTg4NDMwNDYzNGY2Li5kYjM2YmQ3NTViOGQgMTAwNjQ0Cj4g PiAtLS0gYS9kcml2ZXJzL210ZC9uYW5kL3Jhdy9zdW54aV9uYW5kLmMKPiA+ICsrKyBiL2RyaXZl cnMvbXRkL25hbmQvcmF3L3N1bnhpX25hbmQuYwo+ID4gQEAgLTIwODcsOCArMjA4Nyw3IEBAIHN0 YXRpYyBpbnQgc3VueGlfbmZjX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4g PiAgCW5hbmRfY29udHJvbGxlcl9pbml0KCZuZmMtPmNvbnRyb2xsZXIpOwo+ID4gIAlJTklUX0xJ U1RfSEVBRCgmbmZjLT5jaGlwcyk7Cj4gPiAgCj4gPiAtCXIgPSBwbGF0Zm9ybV9nZXRfcmVzb3Vy Y2UocGRldiwgSU9SRVNPVVJDRV9NRU0sIDApOwo+ID4gLQluZmMtPnJlZ3MgPSBkZXZtX2lvcmVt YXBfcmVzb3VyY2UoZGV2LCByKTsKPiA+ICsJbmZjLT5yZWdzID0gZGV2bV9wbGF0Zm9ybV9nZXRf YW5kX2lvcmVtYXBfcmVzb3VyY2UocGRldiwgMCwgJnIpOwo+IAo+IFdoeSBkbyB5b3Uga2VlcCBh IHJlZmVyZW5jZSBvdmVyIHRoZSByZXNvdXJjZT8gV2h5IG5vdCBqdXN0Cj4gZGV2bV9wbGF0Zm9y bV9pb3JlbWFwX3Jlc291cmNlKHBkZXYsIDApID8KPiAKPiBUaGlzIGNvbW1lbnQgaXMgdmFsaWQg Zm9yIGFsbW9zdCBhbGwgdGhlIGNhc2VzIGluIHRoaXMgc2VyaWVzLgoKQWN0dWFsbHkgJ3InIGlz IHVzZWQgYXQgdGhlIGJvdHRvbSwgc28gdGhlIHBhdGNoIGlzIGdvb2QuIEkgcmV2aWV3ZWQKYWxs IHRoZSBwYXRjaGVzLCAxNyBsb29rIHJpZ2h0LCBJIGhhdmUgYSBtaW5vciBjb21tZW50IG9uIG9u ZSBvZiB0aGVtLgpJbiBvcmRlciB0byBhdm9pZCByZXNlbmRpbmcgYWxsIHRoZSBwYXRjaGVzLCBJ J2xsIGZpcnN0IGFwcGx5IHRoZSAxNwpnb29kIG9uZXMgYW5kIGFzayB5b3UgdG8gcmVzZW5kIGp1 c3QgdGhlIGxhc3Qgb25lLgoKPiBXaGVuIHRoZSByZXNvdXJjZSBpcyBvbmx5IG5lZWRlZCBpbiBh biBlcnJvciBwcmludGssIEkgYW0gYWxzbyBpbiBmYXZvcgo+IG9mIG1vZGlmeWluZyB0aGUgZXJy b3IgbWVzc2FnZSB0byBhdm9pZCBoYXZpbmcgdG8gZ3JhYiB0aGUgcmVzb3VyY2UuCj4gCj4gPiAg CWlmIChJU19FUlIobmZjLT5yZWdzKSkKPiA+ICAJCXJldHVybiBQVFJfRVJSKG5mYy0+cmVncyk7 Cj4gPiAgCj4gCj4gVGhlc2UgY29tbWVudHMgYXBwbHkgdG8gdGhlIDE4IHBhdGNoZXMuCj4gCj4g VGhhbmtzLAo+IE1pcXXDqGwKCgpUaGFua3MsCk1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eCBNVEQgZGlzY3Vzc2lvbiBt YWlsaW5nIGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mslow1.mail.gandi.net (mslow1.mail.gandi.net [217.70.178.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBB6C2AB20 for ; Wed, 12 Jul 2023 12:20:29 +0000 (UTC) Received: from relay2-d.mail.gandi.net (unknown [IPv6:2001:4b98:dc4:8::222]) by mslow1.mail.gandi.net (Postfix) with ESMTP id 2519CC69B8 for ; Wed, 12 Jul 2023 12:07:09 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id 5BAFC40007; Wed, 12 Jul 2023 12:06:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1689163620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E7ByKZ6oXF6klWgs2IJLwIobDTVTZio3/GXOfUphAec=; b=o4PPeJa6zgRt3UiGPCief6r+PAxy2XWT8DlOmuoUwwpF8ch48sJUaMbjT/suvREM7Hcq37 8z+/KLv7GUBt6TZtsK79jHsq826uZHC9U7z+/HbNlVpZ+PFFaENxM7b5luXr1XWo2PCgnx HsnUVGr7rk9iUmsK0aeibehjZXFeOw/yXIgEt5a9NVFNM+M23L0P3ZV3Ie3XsbsiyMxvpP siKtD56rxyksEnM7A8EQBLHK7TDOiyJkkfIbzWJ/vXVwKj7owExNXALh3xU25ZqiOfe7Tn mDGkOuKqGvp7Qw7ZGLgfxB+Z9RVBCkygIap408+nQNilsXfZbowSbThkpQ4jgQ== Date: Wed, 12 Jul 2023 14:06:55 +0200 From: Miquel Raynal To: Yangtao Li Cc: Richard Weinberger , Vignesh Raghavendra , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/18] mtd: rawnand: sunxi: Use devm_platform_get_and_ioremap_resource() Message-ID: <20230712140655.72fc2a3d@xps-13> In-Reply-To: <20230712135455.71fbeb5f@xps-13> References: <20230707040622.78174-1-frank.li@vivo.com> <20230712135455.71fbeb5f@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com miquel.raynal@bootlin.com wrote on Wed, 12 Jul 2023 13:54:55 +0200: > Hi Yangtao, >=20 > frank.li@vivo.com wrote on Fri, 7 Jul 2023 12:06:05 +0800: >=20 > > Convert platform_get_resource(), devm_ioremap_resource() to a single > > call to devm_platform_get_and_ioremap_resource(), as this is exactly > > what this function does. > >=20 > > Signed-off-by: Yangtao Li > > --- > > drivers/mtd/nand/raw/sunxi_nand.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > >=20 > > diff --git a/drivers/mtd/nand/raw/sunxi_nand.c b/drivers/mtd/nand/raw/s= unxi_nand.c > > index 9884304634f6..db36bd755b8d 100644 > > --- a/drivers/mtd/nand/raw/sunxi_nand.c > > +++ b/drivers/mtd/nand/raw/sunxi_nand.c > > @@ -2087,8 +2087,7 @@ static int sunxi_nfc_probe(struct platform_device= *pdev) > > nand_controller_init(&nfc->controller); > > INIT_LIST_HEAD(&nfc->chips); > > =20 > > - r =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); > > - nfc->regs =3D devm_ioremap_resource(dev, r); > > + nfc->regs =3D devm_platform_get_and_ioremap_resource(pdev, 0, &r); >=20 > Why do you keep a reference over the resource? Why not just > devm_platform_ioremap_resource(pdev, 0) ? >=20 > This comment is valid for almost all the cases in this series. Actually 'r' is used at the bottom, so the patch is good. I reviewed all the patches, 17 look right, I have a minor comment on one of them. In order to avoid resending all the patches, I'll first apply the 17 good ones and ask you to resend just the last one. > When the resource is only needed in an error printk, I am also in favor > of modifying the error message to avoid having to grab the resource. >=20 > > if (IS_ERR(nfc->regs)) > > return PTR_ERR(nfc->regs); > > =20 >=20 > These comments apply to the 18 patches. >=20 > Thanks, > Miqu=C3=A8l Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AAFA4EB64D9 for ; Wed, 12 Jul 2023 12:07:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZE36cy7SphrGIbYf2MhmJsPNs6FKvZUmWt9f13jjQTY=; b=RhVEr/9LzrMdTX dekYFxIaz446pUrEi84ebZgOO+gIzD+zVKihMT308ubOX5B3b/8mmWFjpP0iWpsYye58BFV/oU2ef xDZQ1HpG1GuEh12PfPoFllvqwoodSB2qRWGuCF3+pVK27p8CuONOxp7JxStqYrgPIyLembhDA1MlP GoNcTX6sVUnu75CF04W9IXcHiVwEiMBWqewFcbc5yElX3F35ORmhw4gzed80wxQu2C7I/w0WOStCK epFXG+NZ/E5cc5rlmdT90vR3TxyhpSGQYpEpKYo2ARWyS1FhOdLlo7ZO1zxphUKOthXLZf6S5tqdQ b8H3QdPjRfCPpQxQNFVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJYce-00HUBD-33; Wed, 12 Jul 2023 12:07:08 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qJYcc-00HUAP-1b; Wed, 12 Jul 2023 12:07:08 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 5BAFC40007; Wed, 12 Jul 2023 12:06:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1689163620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E7ByKZ6oXF6klWgs2IJLwIobDTVTZio3/GXOfUphAec=; b=o4PPeJa6zgRt3UiGPCief6r+PAxy2XWT8DlOmuoUwwpF8ch48sJUaMbjT/suvREM7Hcq37 8z+/KLv7GUBt6TZtsK79jHsq826uZHC9U7z+/HbNlVpZ+PFFaENxM7b5luXr1XWo2PCgnx HsnUVGr7rk9iUmsK0aeibehjZXFeOw/yXIgEt5a9NVFNM+M23L0P3ZV3Ie3XsbsiyMxvpP siKtD56rxyksEnM7A8EQBLHK7TDOiyJkkfIbzWJ/vXVwKj7owExNXALh3xU25ZqiOfe7Tn mDGkOuKqGvp7Qw7ZGLgfxB+Z9RVBCkygIap408+nQNilsXfZbowSbThkpQ4jgQ== Date: Wed, 12 Jul 2023 14:06:55 +0200 From: Miquel Raynal To: Yangtao Li Cc: Richard Weinberger , Vignesh Raghavendra , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/18] mtd: rawnand: sunxi: Use devm_platform_get_and_ioremap_resource() Message-ID: <20230712140655.72fc2a3d@xps-13> In-Reply-To: <20230712135455.71fbeb5f@xps-13> References: <20230707040622.78174-1-frank.li@vivo.com> <20230712135455.71fbeb5f@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230712_050706_667476_CD4294E6 X-CRM114-Status: GOOD ( 21.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Cm1pcXVlbC5yYXluYWxAYm9vdGxpbi5jb20gd3JvdGUgb24gV2VkLCAxMiBKdWwgMjAyMyAxMzo1 NDo1NSArMDIwMDoKCj4gSGkgWWFuZ3RhbywKPiAKPiBmcmFuay5saUB2aXZvLmNvbSB3cm90ZSBv biBGcmksICA3IEp1bCAyMDIzIDEyOjA2OjA1ICswODAwOgo+IAo+ID4gQ29udmVydCBwbGF0Zm9y bV9nZXRfcmVzb3VyY2UoKSwgZGV2bV9pb3JlbWFwX3Jlc291cmNlKCkgdG8gYSBzaW5nbGUKPiA+ IGNhbGwgdG8gZGV2bV9wbGF0Zm9ybV9nZXRfYW5kX2lvcmVtYXBfcmVzb3VyY2UoKSwgYXMgdGhp cyBpcyBleGFjdGx5Cj4gPiB3aGF0IHRoaXMgZnVuY3Rpb24gZG9lcy4KPiA+IAo+ID4gU2lnbmVk LW9mZi1ieTogWWFuZ3RhbyBMaSA8ZnJhbmsubGlAdml2by5jb20+Cj4gPiAtLS0KPiA+ICBkcml2 ZXJzL210ZC9uYW5kL3Jhdy9zdW54aV9uYW5kLmMgfCAzICstLQo+ID4gIDEgZmlsZSBjaGFuZ2Vk LCAxIGluc2VydGlvbigrKSwgMiBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvbXRkL25hbmQvcmF3L3N1bnhpX25hbmQuYyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L3N1 bnhpX25hbmQuYwo+ID4gaW5kZXggOTg4NDMwNDYzNGY2Li5kYjM2YmQ3NTViOGQgMTAwNjQ0Cj4g PiAtLS0gYS9kcml2ZXJzL210ZC9uYW5kL3Jhdy9zdW54aV9uYW5kLmMKPiA+ICsrKyBiL2RyaXZl cnMvbXRkL25hbmQvcmF3L3N1bnhpX25hbmQuYwo+ID4gQEAgLTIwODcsOCArMjA4Nyw3IEBAIHN0 YXRpYyBpbnQgc3VueGlfbmZjX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4g PiAgCW5hbmRfY29udHJvbGxlcl9pbml0KCZuZmMtPmNvbnRyb2xsZXIpOwo+ID4gIAlJTklUX0xJ U1RfSEVBRCgmbmZjLT5jaGlwcyk7Cj4gPiAgCj4gPiAtCXIgPSBwbGF0Zm9ybV9nZXRfcmVzb3Vy Y2UocGRldiwgSU9SRVNPVVJDRV9NRU0sIDApOwo+ID4gLQluZmMtPnJlZ3MgPSBkZXZtX2lvcmVt YXBfcmVzb3VyY2UoZGV2LCByKTsKPiA+ICsJbmZjLT5yZWdzID0gZGV2bV9wbGF0Zm9ybV9nZXRf YW5kX2lvcmVtYXBfcmVzb3VyY2UocGRldiwgMCwgJnIpOwo+IAo+IFdoeSBkbyB5b3Uga2VlcCBh IHJlZmVyZW5jZSBvdmVyIHRoZSByZXNvdXJjZT8gV2h5IG5vdCBqdXN0Cj4gZGV2bV9wbGF0Zm9y bV9pb3JlbWFwX3Jlc291cmNlKHBkZXYsIDApID8KPiAKPiBUaGlzIGNvbW1lbnQgaXMgdmFsaWQg Zm9yIGFsbW9zdCBhbGwgdGhlIGNhc2VzIGluIHRoaXMgc2VyaWVzLgoKQWN0dWFsbHkgJ3InIGlz IHVzZWQgYXQgdGhlIGJvdHRvbSwgc28gdGhlIHBhdGNoIGlzIGdvb2QuIEkgcmV2aWV3ZWQKYWxs IHRoZSBwYXRjaGVzLCAxNyBsb29rIHJpZ2h0LCBJIGhhdmUgYSBtaW5vciBjb21tZW50IG9uIG9u ZSBvZiB0aGVtLgpJbiBvcmRlciB0byBhdm9pZCByZXNlbmRpbmcgYWxsIHRoZSBwYXRjaGVzLCBJ J2xsIGZpcnN0IGFwcGx5IHRoZSAxNwpnb29kIG9uZXMgYW5kIGFzayB5b3UgdG8gcmVzZW5kIGp1 c3QgdGhlIGxhc3Qgb25lLgoKPiBXaGVuIHRoZSByZXNvdXJjZSBpcyBvbmx5IG5lZWRlZCBpbiBh biBlcnJvciBwcmludGssIEkgYW0gYWxzbyBpbiBmYXZvcgo+IG9mIG1vZGlmeWluZyB0aGUgZXJy b3IgbWVzc2FnZSB0byBhdm9pZCBoYXZpbmcgdG8gZ3JhYiB0aGUgcmVzb3VyY2UuCj4gCj4gPiAg CWlmIChJU19FUlIobmZjLT5yZWdzKSkKPiA+ICAJCXJldHVybiBQVFJfRVJSKG5mYy0+cmVncyk7 Cj4gPiAgCj4gCj4gVGhlc2UgY29tbWVudHMgYXBwbHkgdG8gdGhlIDE4IHBhdGNoZXMuCj4gCj4g VGhhbmtzLAo+IE1pcXXDqGwKCgpUaGFua3MsCk1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK