From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CFA27EB64D9 for ; Wed, 12 Jul 2023 14:22:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TUsD58Foa9UBWHkuHEtQFJLQUCM4yJzi9Sz/iiyVJd0=; b=tSr2bwuJgkS/p1 jQdbCAAffA2qjszO3YRNFSRzKwBsh8scy0WAd/8YHFU1MQQChnUe2TIO3uh/2I5XEfZomBrlYhM6Y Snr0308dbZxR51LiWTDMQC54021bzyO8xCB4MmwDjzHwN+fmruUjiYYI72gRIHwQGEdEA02mpBA7R vvtdFo+FLP9IE5aWKDXHipkvcqByrLSsDQtTXEZcg0tcUJaT+2WRffsdT9fPi/IMA8owXbWr0IBY6 CA1yOBFDlcQBGak8WT/mHiB9cwg95k88TNOfxKWMqtwntuj7pDe8cnZT1C9ZNG4tviTcBXz/M7tEr Lkcy/YPVBnQb/tbsN/mg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJajX-000Bn7-1M; Wed, 12 Jul 2023 14:22:23 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qJajT-000Blj-2w for linux-mtd@lists.infradead.org; Wed, 12 Jul 2023 14:22:21 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 4370EC0004; Wed, 12 Jul 2023 14:22:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1689171736; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S9jnw+toN9EeY6OX+EqtUPKBA1qAOSWPjY0T6FQGzUo=; b=Sml7oRqc9FZlkoUmkEJGPnsbtSld3wIs8bdyNwNO3A/p6Zm7gkJBa7lHYIzKDTXSzcAARU ezXwOKvNUdJ2OsegmyMWUq5uQJp/8JNcPfa2C0a6EWyLPOgAqRZcoHLifgKaQKmP1kPTiR A8TcFoz8RlLmzNWYSZdy2odLYy3wOU9WAFZli+wv9NpuZlXnVQjg0Xtgn+Xc1gheECOSwq 4lytmkfg1bNObDxe0OmV7z2koGH5cgQlQu+wvmetH5o9t8Gl7mTi2Zdug3fdTPVUGfheTq Om2IKD9N1Q2cyqygFCsCeQtmnVXY4SnXgF7nWDxctmesF5T+Lh/maatPyz5j8g== Date: Wed, 12 Jul 2023 16:22:13 +0200 From: Miquel Raynal To: Pintu Agarwal Cc: open list , linux-fsdevel , linux-mtd , linux-fsdevel@kvack.org, ezequiel@collabora.com, bjorn@mork.no Subject: Re: MTD: Lots of mtdblock warnings on bootup logs Message-ID: <20230712162213.79bc889c@xps-13> In-Reply-To: References: Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230712_072220_212131_BFAFAB3E X-CRM114-Status: GOOD ( 20.57 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgUGludHUsCgpwaW50dS5waW5nQGdtYWlsLmNvbSB3cm90ZSBvbiBXZWQsIDEyIEp1bCAyMDIz IDE5OjI5OjM5ICswNTMwOgoKPiBIaSwKPiAKPiBXZSBhcmUgZ2V0dGluZyBiZWxvdyB3YXJuaW5n IG1lc3NhZ2VzIGluIGRtZXNnIGxvZ3Mgb24gYSBOQU5EIGRldmljZQo+IGZvciBldmVyeSByYXcg cGFydGl0aW9uLgo+IEtlcm5lbDogNS4xNSA7IGFybTY0IDsgTkFORCArIHViaSArIHNxdWFzaGZz Cj4gV2UgaGF2ZSBzb21lIFJBVyBwYXJ0aXRpb25zIGFuZCBvbmUgVUJJIHBhcnRpdGlvbiAod2l0 aCB1Ymlmcy9zcXVhc2hmcyB2b2x1bWVzKS4KPiAKPiBXZSBhcmUgc2VlaW5nIGxhcmdlIG51bWJl cnMgb2YgdGhlc2UgbG9ncyBvbiB0aGUgc2VyaWFsIGNvbnNvbGUgdGhhdAo+IGltcGFjdCB0aGUg Ym9vdCB0aW1lLgo+IFsuLi4uXQo+IFsgICAgOS42NjcyNDBdWyAgICBUOV0gQ3JlYXRpbmcgNTgg TVREIHBhcnRpdGlvbnMgb24gIjFjOTgwMDAubmFuZCI6Cj4gWy4uLi5dCj4gWyAgIDM5Ljk3NTcw N11bICBUNTE5XSBtdGRibG9jazogTVREIGRldmljZSAndWVmaV9hJyBpcyBOQU5ELCBwbGVhc2UK PiBjb25zaWRlciB1c2luZyBVQkkgYmxvY2sgZGV2aWNlcyBpbnN0ZWFkLgo+IFsgICAzOS45NzU3 MDddWyAgVDUxOV0gbXRkYmxvY2s6IE1URCBkZXZpY2UgJ3VlZmlfYicgaXMgTkFORCwgcGxlYXNl Cj4gY29uc2lkZXIgdXNpbmcgVUJJIGJsb2NrIGRldmljZXMgaW5zdGVhZC4KPiBbLi4uLl0KPiAK PiBUaGlzIHdhcyBhZGRlZCBhcyBwYXJ0IG9mIHRoaXMgY29tbWl0Ogo+IGh0dHBzOi8vZ2l0Lmtl cm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3N0YWJsZS9saW51eC5naXQvY29tbWl0 L2RyaXZlcnMvbXRkL210ZGJsb2NrLmM/aD12NS4xNS4xMjAmaWQ9ZjQxYzk0MThjNTg5OGMwMTYz NDY3NTE1MDY5NmRhMjkwZmI4Njc5Ngo+IGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9s aW51eC9rZXJuZWwvZ2l0L3N0YWJsZS9saW51eC5naXQvY29tbWl0L2RyaXZlcnMvbXRkL210ZGJs b2NrLmM/aD12NS4xNS4xMjAmaWQ9ZTA3NDAzYThjNmJlMDE4NTdmZjc1MDYwYjJkZjlhMWFhODMy MGZlNQo+IAo+IEkgdGhpbmsgdGhpcyB3YXJuaW5nIHdhcyBkZWNpZGVkIGFmdGVyIG15IGxhc3Qg eWVhcidzIGRpc2N1c3Npb24gYWJvdXQKPiBtdGRibG9jayB2cyB1YmlibG9jayBmb3Igc3F1YXNo ZnMuCj4gCj4gQnV0IHRoZXNlIGFyZSByYXcgTkFORCBwYXJ0aXRpb25zIGFuZCBub3QgbW91bnRl ZCBieSB1cy4KPiAKPiBXaGF0IGlzIHRoZSBleGFjdCBtZWFuaW5nIG9mIHRoZXNlIHdhcm5pbmdz ID8KCm10ZGJsb2NrIGlzIGxlZ2FjeSwgdWJpYmxvY2sgaXMgYmV0dGVyIChvbiBOQU5EIGRldmlj ZXMpLgoKPiBXZSBoYXZlIGJvdGggdGhlc2UgY29uZmlncyBlbmFibGVkOgo+IENPTkZJR19NVERf QkxPQ0s9eQo+IENPTkZJR19NVERfVUJJX0JMT0NLPXkKPiAKPiBUaHJvdWdoIHRoaXMgd2Fybmlu ZywgYXJlIHdlIHRlbGxpbmcgdGhhdCBvbmx5IG9uZSBvZiB0aGUgYWJvdmUgY29uZmlnCj4gc2hv dWxkIGJlIGVuYWJsZWQgPwoKSWYgeW91IGRvbid0IG5lZWQgYm90aCwgdGhlbiB5ZXMuCgo+IEFu ZCB0aGUgcmVjb21tZW5kYXRpb24gaXMgdG8gdXNlIHViaV9ibG9jayBhbmQgZGlzYWJsZSBtdGRf YmxvY2sgPwoKWWVzLgoKPiBXZSBhcmUgYWxyZWFkeSB1c2luZyB1YmlibG9jayBmb3IgbW91bnRp bmcgc3F1YXNoZnMgdm9sdW1lcy4KPiBCdXQgaG93IHRvIGdldCByaWQgb2YgdGhlc2Ugd2Fybmlu Z3MgZm9yIHJhdyBOQU5EIHBhcnRpdGlvbnMgPwo+IAo+IElzIHRoZXJlIGEgd2F5IHRvIGF2b2lk IG9yIHdlIGFyZSBtaXNzaW5nIHNvbWV0aGluZyB3aGljaCB3ZSBhcmUgbm90IGF3YXJlIG9mPwo+ IAoKSW4gdGhlb3J5IHRoZSB3YXJuaW5nIHNob3VsZCBvbmx5IGFwcGVhciBpZiB5b3Ugb3BlbiB0 aGUgZGV2aWNlIChJT1csCm9ubHkgaWYgeW91IHVzZSBpdCkuIEZvciB0aGlzIHRvIGhhcHBlbiwg eW91IG5lZWQ6Cjk2YTMyOTVjMzUxZCAoIm10ZGJsb2NrOiB3YXJuIGlmIG9wZW5lZCBvbiBOQU5E IikKVGhpcyBjb21taXQgd2FzIG1heWJlIG5vdCBiYWNrcG9ydGVkIHRvIHN0YWJsZSBrZXJuZWxz LCB5b3UgY2FuIHNlbmQgaXQKdG8gc3RhYmxlQHZnZXIua2VybmVsLm9yZyBpbiBvcmRlciB0byBh c2sgZm9yIHRoYXQuIEkgYWxzbyBzZWUgdGhhdCB0aGUKbXRkYmxvY2tfcm8gcGF0aCB3YXMgbm90 IGNvcnJlY3RlZCwgbWF5YmUgdGhhdCdzIGFsc28gYSBwcm9ibGVtIGluIHlvdXIKY2FzZT8gU2Ft ZSwgeW91IGNhbiBhZGFwdCB0aGUgYWJvdmUgcGF0Y2ggYW5kIHNlbmQgaXQgdXBzdHJlYW0uCgpU aGFua3MsCk1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpMaW51eCBNVEQgZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 748EBEB64DD for ; Wed, 12 Jul 2023 14:22:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230155AbjGLOWV (ORCPT ); Wed, 12 Jul 2023 10:22:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229993AbjGLOWU (ORCPT ); Wed, 12 Jul 2023 10:22:20 -0400 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD615E70; Wed, 12 Jul 2023 07:22:17 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 4370EC0004; Wed, 12 Jul 2023 14:22:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1689171736; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S9jnw+toN9EeY6OX+EqtUPKBA1qAOSWPjY0T6FQGzUo=; b=Sml7oRqc9FZlkoUmkEJGPnsbtSld3wIs8bdyNwNO3A/p6Zm7gkJBa7lHYIzKDTXSzcAARU ezXwOKvNUdJ2OsegmyMWUq5uQJp/8JNcPfa2C0a6EWyLPOgAqRZcoHLifgKaQKmP1kPTiR A8TcFoz8RlLmzNWYSZdy2odLYy3wOU9WAFZli+wv9NpuZlXnVQjg0Xtgn+Xc1gheECOSwq 4lytmkfg1bNObDxe0OmV7z2koGH5cgQlQu+wvmetH5o9t8Gl7mTi2Zdug3fdTPVUGfheTq Om2IKD9N1Q2cyqygFCsCeQtmnVXY4SnXgF7nWDxctmesF5T+Lh/maatPyz5j8g== Date: Wed, 12 Jul 2023 16:22:13 +0200 From: Miquel Raynal To: Pintu Agarwal Cc: open list , linux-fsdevel , linux-mtd , linux-fsdevel@kvack.org, ezequiel@collabora.com, bjorn@mork.no Subject: Re: MTD: Lots of mtdblock warnings on bootup logs Message-ID: <20230712162213.79bc889c@xps-13> In-Reply-To: References: Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Hi Pintu, pintu.ping@gmail.com wrote on Wed, 12 Jul 2023 19:29:39 +0530: > Hi, >=20 > We are getting below warning messages in dmesg logs on a NAND device > for every raw partition. > Kernel: 5.15 ; arm64 ; NAND + ubi + squashfs > We have some RAW partitions and one UBI partition (with ubifs/squashfs vo= lumes). >=20 > We are seeing large numbers of these logs on the serial console that > impact the boot time. > [....] > [ 9.667240][ T9] Creating 58 MTD partitions on "1c98000.nand": > [....] > [ 39.975707][ T519] mtdblock: MTD device 'uefi_a' is NAND, please > consider using UBI block devices instead. > [ 39.975707][ T519] mtdblock: MTD device 'uefi_b' is NAND, please > consider using UBI block devices instead. > [....] >=20 > This was added as part of this commit: > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/d= rivers/mtd/mtdblock.c?h=3Dv5.15.120&id=3Df41c9418c5898c01634675150696da290f= b86796 > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/d= rivers/mtd/mtdblock.c?h=3Dv5.15.120&id=3De07403a8c6be01857ff75060b2df9a1aa8= 320fe5 >=20 > I think this warning was decided after my last year's discussion about > mtdblock vs ubiblock for squashfs. >=20 > But these are raw NAND partitions and not mounted by us. >=20 > What is the exact meaning of these warnings ? mtdblock is legacy, ubiblock is better (on NAND devices). > We have both these configs enabled: > CONFIG_MTD_BLOCK=3Dy > CONFIG_MTD_UBI_BLOCK=3Dy >=20 > Through this warning, are we telling that only one of the above config > should be enabled ? If you don't need both, then yes. > And the recommendation is to use ubi_block and disable mtd_block ? Yes. > We are already using ubiblock for mounting squashfs volumes. > But how to get rid of these warnings for raw NAND partitions ? >=20 > Is there a way to avoid or we are missing something which we are not awar= e of? >=20 In theory the warning should only appear if you open the device (IOW, only if you use it). For this to happen, you need: 96a3295c351d ("mtdblock: warn if opened on NAND") This commit was maybe not backported to stable kernels, you can send it to stable@vger.kernel.org in order to ask for that. I also see that the mtdblock_ro path was not corrected, maybe that's also a problem in your case? Same, you can adapt the above patch and send it upstream. Thanks, Miqu=C3=A8l