Re: Please pull u-boot-dm

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 3276 bytes --]

On Wed, Jul 12, 2023 at 02:09:19PM -0600, Simon Glass wrote:
> Hi Tom,
> 
> On Wed, 12 Jul 2023 at 13:36, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Wed, Jul 12, 2023 at 03:29:39PM -0400, Tom Rini wrote:
> > > On Wed, Jul 12, 2023 at 09:51:13AM -0600, Simon Glass wrote:
> > >
> > > > Hi Tom.
> > > >
> > > > https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/16872
> > > >
> > > >
> > > > The following changes since commit 8e21064cb3452950b09301baec06d86e37342471:
> > > >
> > > >   Merge tag 'efi-2023-07-rc7' of
> > > > https://source.denx.de/u-boot/custodians/u-boot-efi (2023-07-11
> > > > 13:27:32 -0400)
> > > >
> > > > are available in the Git repository at:
> > > >
> > > >   git://git.denx.de/u-boot-dm.git tags/dm-pull-12jul23a
> > > >
> > > > for you to fetch changes up to 45aa7ac492d90ddc2977ea6c9d161e7cc3333487:
> > > >
> > > >   tools: Fix package discovery in pyproject.toml of u_boot_pylib.
> > > > (2023-07-12 09:48:19 -0600)
> > >
> > > NAK,
> > > commit 5a801ad450303f028213c5da12017db5d3668cbc
> > > Author: Simon Glass <sjg@chromium.org>
> > > Date:   Thu Jun 22 12:44:24 2023 +0100
> > >
> > >     buildman: Provide an argument to the -R option
> > >
> > >     Allow writing the file to a selected location, since otherwise this is
> > >     controlled by the buildman configuration, so cannot be determined by the
> > >     caller.
> > >
> > >     Fixes: https://source.denx.de/u-boot/u-boot/-/issues/17
> > >     Signed-off-by: Simon Glass <sjg@chromium.org>
> > >
> > > Breaks buildman -R as it now requires a location to be specified instead
> > > of creating one where it's normally needed / used by default.
> > >
> > > And I believe this matters in that I use "buildman -R" for "Did someone
> > > add a new defconfig and not update a MAINATINERS file?".
> 
> From the docs:
> 
> This file is no-longer needed by buildman but it is still generated in the
> working directory. This helps avoid a delay on every build, since scanning all
> the Kconfig files takes a few seconds. Use the `-R <filename>` flag to force
> regeneration of the file - in that case buildman exits after writing the file
> with exit code 2 if there was an error in the maintainer files. To use the
> default filename, use a hyphen, i.e. `-R -`.

The old name needs to be the default if none is specified, to not break
existing setups.

> > And even harder NAK, this
> > commit 075c6a5eb53f8fb8d375373293c92396f3b4a448
> > Author: Simon Glass <sjg@chromium.org>
> > Date:   Wed Jul 5 13:18:38 2023 +0100
> >
> >     buildman: Move board-selection code into a function
> >
> >     Create a new determine_boards() function to hold the code which selects
> >     which boards to build.
> >
> >     Signed-off-by: Simon Glass <sjg@chromium.org>
> >
> > Breaks "buildman foo -x bar" and so all of the Azure jobs that exclude
> > things don't exclude things at all anymore.  For example:
> > ./tools/buildman/buildman --dry-run -v freescale -x powerpc,m68k,aarch64,ls101,ls102,ls104,ls108,ls20,lx21
> > gives 229 boards and not 28.
> 
> I'll take a look. One of the reasons this series adds test-coverage
> measurement is to see where there are gaps in testing.

OK.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]