From: kernel test robot <lkp@intel.com>
To: Pavel Begunkov <asml.silence@gmail.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [isilence:net/defer-free 1/2] include/linux/atomic/atomic-arch-fallback.h:326:14: error: void value not ignored as it ought to be
Date: Thu, 13 Jul 2023 02:05:07 +0800 [thread overview]
Message-ID: <202307130107.GnUXIFII-lkp@intel.com> (raw)
tree: https://github.com/isilence/linux net/defer-free
head: bc14c0e28995a8d2a7c5c481a90973553861cbe2
commit: c3205b3c22a6b7d0147dd98c1c0a4888436efe73 [1/2] net/core: lockless defer free
config: csky-randconfig-r032-20230712 (https://download.01.org/0day-ci/archive/20230713/202307130107.GnUXIFII-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230713/202307130107.GnUXIFII-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307130107.GnUXIFII-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from net/core/dev.c:90:
include/linux/netdevice.h:3196:9: error: unknown type name 'u128'
3196 | u128 full;
| ^~~~
In file included from include/linux/atomic.h:80,
from include/asm-generic/bitops/lock.h:5,
from arch/csky/include/asm/bitops.h:69,
from include/linux/bitops.h:68,
from include/linux/log2.h:12,
from include/asm-generic/div64.h:55,
from ./arch/csky/include/generated/asm/div64.h:1,
from include/linux/math.h:6,
from include/linux/math64.h:6,
from include/linux/time64.h:5,
from include/linux/restart_block.h:10,
from include/linux/thread_info.h:14,
from include/asm-generic/current.h:5,
from ./arch/csky/include/generated/asm/current.h:1,
from include/linux/sched.h:12,
from include/linux/uaccess.h:8,
from net/core/dev.c:71:
net/core/dev.c: In function 'skb_defer_free_flush':
>> include/linux/atomic/atomic-arch-fallback.h:326:14: error: void value not ignored as it ought to be
326 | ___r = raw_cmpxchg128((_ptr), ___o, (_new)); \
| ^
include/linux/atomic/atomic-instrumented.h:4914:9: note: in expansion of macro 'raw_try_cmpxchg128'
4914 | raw_try_cmpxchg128(__ai_ptr, __ai_oldp, __VA_ARGS__); \
| ^~~~~~~~~~~~~~~~~~
net/core/dev.c:6574:17: note: in expansion of macro 'try_cmpxchg128'
6574 | while (!try_cmpxchg128(&sd->defer.full, &old.full, new.full)) {}
| ^~~~~~~~~~~~~~
net/core/dev.c:6567:35: warning: unused variable 'new' [-Wunused-variable]
6567 | softnet_defer_list_t old, new = {};
| ^~~
--
In file included from include/net/sock.h:46,
from include/linux/tcp.h:19,
from net/core/skbuff.c:45:
include/linux/netdevice.h:3196:9: error: unknown type name 'u128'
3196 | u128 full;
| ^~~~
In file included from include/linux/atomic.h:80,
from include/asm-generic/bitops/lock.h:5,
from arch/csky/include/asm/bitops.h:69,
from include/linux/bitops.h:68,
from include/linux/log2.h:12,
from include/asm-generic/div64.h:55,
from ./arch/csky/include/generated/asm/div64.h:1,
from include/linux/math.h:6,
from include/linux/math64.h:6,
from include/linux/time.h:6,
from include/linux/stat.h:19,
from include/linux/module.h:13,
from net/core/skbuff.c:37:
net/core/skbuff.c: In function 'skb_attempt_defer_free':
>> include/linux/atomic/atomic-arch-fallback.h:326:14: error: void value not ignored as it ought to be
326 | ___r = raw_cmpxchg128((_ptr), ___o, (_new)); \
| ^
include/linux/atomic/atomic-instrumented.h:4914:9: note: in expansion of macro 'raw_try_cmpxchg128'
4914 | raw_try_cmpxchg128(__ai_ptr, __ai_oldp, __VA_ARGS__); \
| ^~~~~~~~~~~~~~~~~~
net/core/skbuff.c:6752:19: note: in expansion of macro 'try_cmpxchg128'
6752 | } while (!try_cmpxchg128(&sd->defer.full, &old.full, new.full));
| ^~~~~~~~~~~~~~
net/core/skbuff.c:6726:35: warning: variable 'new' set but not used [-Wunused-but-set-variable]
6726 | softnet_defer_list_t old, new = {};
| ^~~
vim +326 include/linux/atomic/atomic-arch-fallback.h
0aa7be05d83cc5 Uros Bizjak 2022-05-15 316
9257959a6e5b4f Mark Rutland 2023-06-05 317 #if defined(arch_try_cmpxchg128)
9257959a6e5b4f Mark Rutland 2023-06-05 318 #define raw_try_cmpxchg128 arch_try_cmpxchg128
9257959a6e5b4f Mark Rutland 2023-06-05 319 #elif defined(arch_try_cmpxchg128_relaxed)
9257959a6e5b4f Mark Rutland 2023-06-05 320 #define raw_try_cmpxchg128(...) \
9257959a6e5b4f Mark Rutland 2023-06-05 321 __atomic_op_fence(arch_try_cmpxchg128, __VA_ARGS__)
9257959a6e5b4f Mark Rutland 2023-06-05 322 #else
9257959a6e5b4f Mark Rutland 2023-06-05 323 #define raw_try_cmpxchg128(_ptr, _oldp, _new) \
8c8b096a23d12f Peter Zijlstra 2023-05-31 324 ({ \
8c8b096a23d12f Peter Zijlstra 2023-05-31 325 typeof(*(_ptr)) *___op = (_oldp), ___o = *___op, ___r; \
9257959a6e5b4f Mark Rutland 2023-06-05 @326 ___r = raw_cmpxchg128((_ptr), ___o, (_new)); \
8c8b096a23d12f Peter Zijlstra 2023-05-31 327 if (unlikely(___r != ___o)) \
8c8b096a23d12f Peter Zijlstra 2023-05-31 328 *___op = ___r; \
8c8b096a23d12f Peter Zijlstra 2023-05-31 329 likely(___r == ___o); \
8c8b096a23d12f Peter Zijlstra 2023-05-31 330 })
9257959a6e5b4f Mark Rutland 2023-06-05 331 #endif
8c8b096a23d12f Peter Zijlstra 2023-05-31 332
:::::: The code at line 326 was first introduced by commit
:::::: 9257959a6e5b4fca6fc8e985790bff62c2046f20 locking/atomic: scripts: restructure fallback ifdeffery
:::::: TO: Mark Rutland <mark.rutland@arm.com>
:::::: CC: Peter Zijlstra <peterz@infradead.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2023-07-12 18:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202307130107.GnUXIFII-lkp@intel.com \
--to=lkp@intel.com \
--cc=asml.silence@gmail.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.