From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E170C0015E for ; Thu, 13 Jul 2023 14:50:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231745AbjGMOuT (ORCPT ); Thu, 13 Jul 2023 10:50:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229682AbjGMOuT (ORCPT ); Thu, 13 Jul 2023 10:50:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5042273A; Thu, 13 Jul 2023 07:49:58 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3887561545; Thu, 13 Jul 2023 14:49:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03A37C433C8; Thu, 13 Jul 2023 14:49:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689259797; bh=oUeQBue4D+P5RKuXyNTqDYmkvCRh4FYVyWtbLqAKhmA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XxKgmn1xsOU2pbWpxRsCyKp99xUi09w4uLO1jBoSotyiJJfgPbzmlDjlmVpBsS5Yx ncIKrzKTaCItf5d2aokcdPa8m4ykTT8eLxOfOfaM0s0kk5LsbIPsp4OOzWcSmSj2I2 m2upGxLV5F+Dl4eoKKngsmTR1oinJHxiDWLERc+pK3cC2L/SLbYzEJBh6l+VzgNXy1 gv2T5CpLDQ/tDZKe3UfKnti5V1QizPVI3MCNRkrb5pmPRMSoOdFjbwbF5nhNvdPrzl oOuAQTXH5PDOIdTy7qHbEezRIFzaPM5g7QeOP4kQaOO0fS76lgohHqzxEzRVcl5iWQ /HxBJ7XGKXF9Q== Date: Thu, 13 Jul 2023 15:49:50 +0100 From: Lee Jones To: Linus Walleij Cc: Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Maxime Coquelin , Alexandre Torgue , Dmitry Torokhov , Philippe Schenker , Stefan Agner , Marek Vasut , Steffen Trumtrar , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Rob Herring Subject: Re: [PATCH v5] dt-bindings: MFD: Convert STMPE to YAML schema Message-ID: <20230713144950.GE10768@google.com> References: <20230709-stmpe-dt-bindings-v5-1-34a3d6ee1e57@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230709-stmpe-dt-bindings-v5-1-34a3d6ee1e57@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Sun, 09 Jul 2023, Linus Walleij wrote: > This converts the STMPE MFD device tree bindings to the YAML > schema. > > Reference the existing schema for the ADC, just define the > other subnode schemas directly in the MFD schema. > > Add two examples so we have examples covering both the simple > GPIO expander and the more complex with ADC and touchscreen. > > Some in-tree users do not follow the naming conventions for nodes > so these DTS files need to be augmented to use proper node names > like "adc", "pwm", "gpio", "keyboard-controller" etc before the > bindings take effect on them. > > Acked-by: Dmitry Torokhov > Reviewed-by: Rob Herring > Signed-off-by: Linus Walleij > --- > This adds the missing GPIO bindings for the STMPE port expander > and converts the existing MFD binding to YAML. > > I suppose Lee can merge this when he's happy with it. > --- > Changes in v5: > - Rebase on v6.5-rc1 meaning GPIO binding is merged > upstream and can be dropped. > - Link to v4: https://lore.kernel.org/r/20230426-stmpe-dt-bindings-v4-0-36fdd53d9919@linaro.org > > Changes in v4: > - Make the GPIO bindings a conversion: there were some old > text bindings for the STMPE GPIO, we now delete them as > part of the patch. > - I expect Lee or the DT binding tree to pick both patches. > - Link to v3: https://lore.kernel.org/r/20230426-stmpe-dt-bindings-v3-0-eac1d736e488@linaro.org > > Changes in v3: > - Update to review feedback > - Collected some ack/review tags > - Link to v2: https://lore.kernel.org/r/20230426-stmpe-dt-bindings-v2-0-2f85a1fffcda@linaro.org > > Changes in v2: > - Split off a separate GPIO binding > - Updated the MFD binding according to feedback > --- > ChangeLog v4->v5: > - Rebase on v6.5-rc1 > ChangeLog v3->v4: > - No changes. > ChangeLog v2->v3: > - Drop the required pwm properties already required by the > template pwm schema. > - Add the number of PWM cells as const. > ChangeLog v1->v2: > - Split off the GPIO bindings to their own schema, as the old > bindings didn't even have any GPIO bindings. Put the GPIO > schema before this schema so we can use GPIO in the examples. > - Drop nodename and pattern as STMPE is not a generic name. > - Add maxItems to the resets. > - Make wakeup-source just :true, as it is a generic property. > - Move unevaluatedProperties for subnodes right before properties > as requested. > - Name devices "port-expander" in the examples. > - Use lowercase hex in line init. > --- > .../devicetree/bindings/input/stmpe-keypad.txt | 41 --- > .../bindings/input/touchscreen/stmpe.txt | 108 -------- > .../devicetree/bindings/mfd/st,stmpe.yaml | 297 +++++++++++++++++++++ > Documentation/devicetree/bindings/mfd/stmpe.txt | 42 --- > 4 files changed, 297 insertions(+), 191 deletions(-) Applied, thanks -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D396BC0015E for ; Thu, 13 Jul 2023 14:50:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yHVaG2edd8Mx2bXnguKj1Wi/KcnOMvmtvxVlexs622w=; b=pGbC8P06SdcBW6 hUX/wwIyilkfotHkUH8IA8x4vx0pGHHwh+W9gFNcLkjLNdM1emhfsJRGXxGPwVB5rB63V6qNSl4Fm lutstLz8m1XcAeQ3lcsbaQybeEQ6FBphtcdNKC0qfKYmU4I0M8MPX8hdT9HCYMY0j36/oaxHY3niZ lm6eBpc81etUyHXoGlk6iK9ptgl1nUPHpmRfyyJWpNrvr/RS58HXR9tA/1rmreb5mY3mEeDoiwbor wSWFOeWooCGtjvgsClpaFGnh7q3FMEufErr0AVccUd7cRxqAoh0QkFG4L/VGsrf3UydzUBQSVjKyy eltq1A0f1ukj6lXOSXuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJxdp-003cOD-1y; Thu, 13 Jul 2023 14:50:01 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qJxdm-003cNP-2e for linux-arm-kernel@lists.infradead.org; Thu, 13 Jul 2023 14:50:00 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 31AC06153B; Thu, 13 Jul 2023 14:49:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03A37C433C8; Thu, 13 Jul 2023 14:49:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689259797; bh=oUeQBue4D+P5RKuXyNTqDYmkvCRh4FYVyWtbLqAKhmA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XxKgmn1xsOU2pbWpxRsCyKp99xUi09w4uLO1jBoSotyiJJfgPbzmlDjlmVpBsS5Yx ncIKrzKTaCItf5d2aokcdPa8m4ykTT8eLxOfOfaM0s0kk5LsbIPsp4OOzWcSmSj2I2 m2upGxLV5F+Dl4eoKKngsmTR1oinJHxiDWLERc+pK3cC2L/SLbYzEJBh6l+VzgNXy1 gv2T5CpLDQ/tDZKe3UfKnti5V1QizPVI3MCNRkrb5pmPRMSoOdFjbwbF5nhNvdPrzl oOuAQTXH5PDOIdTy7qHbEezRIFzaPM5g7QeOP4kQaOO0fS76lgohHqzxEzRVcl5iWQ /HxBJ7XGKXF9Q== Date: Thu, 13 Jul 2023 15:49:50 +0100 From: Lee Jones To: Linus Walleij Cc: Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Maxime Coquelin , Alexandre Torgue , Dmitry Torokhov , Philippe Schenker , Stefan Agner , Marek Vasut , Steffen Trumtrar , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Rob Herring Subject: Re: [PATCH v5] dt-bindings: MFD: Convert STMPE to YAML schema Message-ID: <20230713144950.GE10768@google.com> References: <20230709-stmpe-dt-bindings-v5-1-34a3d6ee1e57@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230709-stmpe-dt-bindings-v5-1-34a3d6ee1e57@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230713_074958_962903_C0830BE4 X-CRM114-Status: GOOD ( 26.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU3VuLCAwOSBKdWwgMjAyMywgTGludXMgV2FsbGVpaiB3cm90ZToKCj4gVGhpcyBjb252ZXJ0 cyB0aGUgU1RNUEUgTUZEIGRldmljZSB0cmVlIGJpbmRpbmdzIHRvIHRoZSBZQU1MCj4gc2NoZW1h Lgo+IAo+IFJlZmVyZW5jZSB0aGUgZXhpc3Rpbmcgc2NoZW1hIGZvciB0aGUgQURDLCBqdXN0IGRl ZmluZSB0aGUKPiBvdGhlciBzdWJub2RlIHNjaGVtYXMgZGlyZWN0bHkgaW4gdGhlIE1GRCBzY2hl bWEuCj4gCj4gQWRkIHR3byBleGFtcGxlcyBzbyB3ZSBoYXZlIGV4YW1wbGVzIGNvdmVyaW5nIGJv dGggdGhlIHNpbXBsZQo+IEdQSU8gZXhwYW5kZXIgYW5kIHRoZSBtb3JlIGNvbXBsZXggd2l0aCBB REMgYW5kIHRvdWNoc2NyZWVuLgo+IAo+IFNvbWUgaW4tdHJlZSB1c2VycyBkbyBub3QgZm9sbG93 IHRoZSBuYW1pbmcgY29udmVudGlvbnMgZm9yIG5vZGVzCj4gc28gdGhlc2UgRFRTIGZpbGVzIG5l ZWQgdG8gYmUgYXVnbWVudGVkIHRvIHVzZSBwcm9wZXIgbm9kZSBuYW1lcwo+IGxpa2UgImFkYyIs ICJwd20iLCAiZ3BpbyIsICJrZXlib2FyZC1jb250cm9sbGVyIiBldGMgYmVmb3JlIHRoZQo+IGJp bmRpbmdzIHRha2UgZWZmZWN0IG9uIHRoZW0uCj4gCj4gQWNrZWQtYnk6IERtaXRyeSBUb3Jva2hv diA8ZG1pdHJ5LnRvcm9raG92QGdtYWlsLmNvbT4KPiBSZXZpZXdlZC1ieTogUm9iIEhlcnJpbmcg PHJvYmhAa2VybmVsLm9yZz4KPiBTaWduZWQtb2ZmLWJ5OiBMaW51cyBXYWxsZWlqIDxsaW51cy53 YWxsZWlqQGxpbmFyby5vcmc+Cj4gLS0tCj4gVGhpcyBhZGRzIHRoZSBtaXNzaW5nIEdQSU8gYmlu ZGluZ3MgZm9yIHRoZSBTVE1QRSBwb3J0IGV4cGFuZGVyCj4gYW5kIGNvbnZlcnRzIHRoZSBleGlz dGluZyBNRkQgYmluZGluZyB0byBZQU1MLgo+IAo+IEkgc3VwcG9zZSBMZWUgY2FuIG1lcmdlIHRo aXMgd2hlbiBoZSdzIGhhcHB5IHdpdGggaXQuCj4gLS0tCj4gQ2hhbmdlcyBpbiB2NToKPiAtIFJl YmFzZSBvbiB2Ni41LXJjMSBtZWFuaW5nIEdQSU8gYmluZGluZyBpcyBtZXJnZWQKPiAgIHVwc3Ry ZWFtIGFuZCBjYW4gYmUgZHJvcHBlZC4KPiAtIExpbmsgdG8gdjQ6IGh0dHBzOi8vbG9yZS5rZXJu ZWwub3JnL3IvMjAyMzA0MjYtc3RtcGUtZHQtYmluZGluZ3MtdjQtMC0zNmZkZDUzZDk5MTlAbGlu YXJvLm9yZwo+IAo+IENoYW5nZXMgaW4gdjQ6Cj4gLSBNYWtlIHRoZSBHUElPIGJpbmRpbmdzIGEg Y29udmVyc2lvbjogdGhlcmUgd2VyZSBzb21lIG9sZAo+ICAgdGV4dCBiaW5kaW5ncyBmb3IgdGhl IFNUTVBFIEdQSU8sIHdlIG5vdyBkZWxldGUgdGhlbSBhcwo+ICAgcGFydCBvZiB0aGUgcGF0Y2gu Cj4gLSBJIGV4cGVjdCBMZWUgb3IgdGhlIERUIGJpbmRpbmcgdHJlZSB0byBwaWNrIGJvdGggcGF0 Y2hlcy4KPiAtIExpbmsgdG8gdjM6IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3IvMjAyMzA0MjYt c3RtcGUtZHQtYmluZGluZ3MtdjMtMC1lYWMxZDczNmU0ODhAbGluYXJvLm9yZwo+IAo+IENoYW5n ZXMgaW4gdjM6Cj4gLSBVcGRhdGUgdG8gcmV2aWV3IGZlZWRiYWNrCj4gLSBDb2xsZWN0ZWQgc29t ZSBhY2svcmV2aWV3IHRhZ3MKPiAtIExpbmsgdG8gdjI6IGh0dHBzOi8vbG9yZS5rZXJuZWwub3Jn L3IvMjAyMzA0MjYtc3RtcGUtZHQtYmluZGluZ3MtdjItMC0yZjg1YTFmZmZjZGFAbGluYXJvLm9y Zwo+IAo+IENoYW5nZXMgaW4gdjI6Cj4gLSBTcGxpdCBvZmYgYSBzZXBhcmF0ZSBHUElPIGJpbmRp bmcKPiAtIFVwZGF0ZWQgdGhlIE1GRCBiaW5kaW5nIGFjY29yZGluZyB0byBmZWVkYmFjawo+IC0t LQo+IENoYW5nZUxvZyB2NC0+djU6Cj4gLSBSZWJhc2Ugb24gdjYuNS1yYzEKPiBDaGFuZ2VMb2cg djMtPnY0Ogo+IC0gTm8gY2hhbmdlcy4KPiBDaGFuZ2VMb2cgdjItPnYzOgo+IC0gRHJvcCB0aGUg cmVxdWlyZWQgcHdtIHByb3BlcnRpZXMgYWxyZWFkeSByZXF1aXJlZCBieSB0aGUKPiAgIHRlbXBs YXRlIHB3bSBzY2hlbWEuCj4gLSBBZGQgdGhlIG51bWJlciBvZiBQV00gY2VsbHMgYXMgY29uc3Qu Cj4gQ2hhbmdlTG9nIHYxLT52MjoKPiAtIFNwbGl0IG9mZiB0aGUgR1BJTyBiaW5kaW5ncyB0byB0 aGVpciBvd24gc2NoZW1hLCBhcyB0aGUgb2xkCj4gICBiaW5kaW5ncyBkaWRuJ3QgZXZlbiBoYXZl IGFueSBHUElPIGJpbmRpbmdzLiBQdXQgdGhlIEdQSU8KPiAgIHNjaGVtYSBiZWZvcmUgdGhpcyBz Y2hlbWEgc28gd2UgY2FuIHVzZSBHUElPIGluIHRoZSBleGFtcGxlcy4KPiAtIERyb3Agbm9kZW5h bWUgYW5kIHBhdHRlcm4gYXMgU1RNUEUgaXMgbm90IGEgZ2VuZXJpYyBuYW1lLgo+IC0gQWRkIG1h eEl0ZW1zIHRvIHRoZSByZXNldHMuCj4gLSBNYWtlIHdha2V1cC1zb3VyY2UganVzdCA6dHJ1ZSwg YXMgaXQgaXMgYSBnZW5lcmljIHByb3BlcnR5Lgo+IC0gTW92ZSB1bmV2YWx1YXRlZFByb3BlcnRp ZXMgZm9yIHN1Ym5vZGVzIHJpZ2h0IGJlZm9yZSBwcm9wZXJ0aWVzCj4gICBhcyByZXF1ZXN0ZWQu Cj4gLSBOYW1lIGRldmljZXMgInBvcnQtZXhwYW5kZXIiIGluIHRoZSBleGFtcGxlcy4KPiAtIFVz ZSBsb3dlcmNhc2UgaGV4IGluIGxpbmUgaW5pdC4KPiAtLS0KPiAgLi4uL2RldmljZXRyZWUvYmlu ZGluZ3MvaW5wdXQvc3RtcGUta2V5cGFkLnR4dCAgICAgfCAgNDEgLS0tCj4gIC4uLi9iaW5kaW5n cy9pbnB1dC90b3VjaHNjcmVlbi9zdG1wZS50eHQgICAgICAgICAgIHwgMTA4IC0tLS0tLS0tCj4g IC4uLi9kZXZpY2V0cmVlL2JpbmRpbmdzL21mZC9zdCxzdG1wZS55YW1sICAgICAgICAgIHwgMjk3 ICsrKysrKysrKysrKysrKysrKysrKwo+ICBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGlu Z3MvbWZkL3N0bXBlLnR4dCAgICB8ICA0MiAtLS0KPiAgNCBmaWxlcyBjaGFuZ2VkLCAyOTcgaW5z ZXJ0aW9ucygrKSwgMTkxIGRlbGV0aW9ucygtKQoKQXBwbGllZCwgdGhhbmtzCgotLSAKTGVlIEpv bmVzIFvmnY7nkLzmlq9dCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1hcm0ta2VybmVsCg==