All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Md Sadre Alam <quic_mdalam@quicinc.com>
Cc: oe-kbuild-all@lists.linux.dev,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Sricharan Ramabadhran <quic_srichara@quicinc.com>
Subject: [mtd:nand/next 24/28] drivers/mtd/nand/raw/qcom_nandc.c:2957:38: warning: variable 'naddrs' set but not used
Date: Thu, 13 Jul 2023 19:22:03 +0800	[thread overview]
Message-ID: <202307131959.PdPSC86K-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next
head:   2b42d718c7d7f4269d45fb58b4f74d7b2bfb08bd
commit: 5c6a9518447ebc72606b390ab5cb3eab9dc1d867 [24/28] mtd: rawnand: qcom: Implement exec_op()
config: arm-allmodconfig (https://download.01.org/0day-ci/archive/20230713/202307131959.PdPSC86K-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230713/202307131959.PdPSC86K-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307131959.PdPSC86K-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/mtd/nand/raw/qcom_nandc.c: In function 'qcom_parse_instructions':
>> drivers/mtd/nand/raw/qcom_nandc.c:2957:38: warning: variable 'naddrs' set but not used [-Wunused-but-set-variable]
    2957 |                 unsigned int offset, naddrs;
         |                                      ^~~~~~

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for SM_GCC_8350
   Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=m] && (ARM64 || COMPILE_TEST [=n])
   Selected by [m]:
   - SM_VIDEOCC_8350 [=m] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=m]
   WARNING: unmet direct dependencies detected for SM_GCC_8450
   Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=m] && (ARM64 || COMPILE_TEST [=n])
   Selected by [m]:
   - SM_GPUCC_8450 [=m] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=m]
   - SM_VIDEOCC_8450 [=m] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=m]
   WARNING: unmet direct dependencies detected for SM_GCC_8550
   Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=m] && (ARM64 || COMPILE_TEST [=n])
   Selected by [m]:
   - SM_GPUCC_8550 [=m] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=m]
   - SM_VIDEOCC_8550 [=m] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=m]


vim +/naddrs +2957 drivers/mtd/nand/raw/qcom_nandc.c

  2943	
  2944	/* NAND framework ->exec_op() hooks and related helpers */
  2945	static void qcom_parse_instructions(struct nand_chip *chip,
  2946					    const struct nand_subop *subop,
  2947						struct qcom_op *q_op)
  2948	{
  2949		struct qcom_nand_controller *nandc = get_qcom_nand_controller(chip);
  2950		const struct nand_op_instr *instr = NULL;
  2951		unsigned int op_id;
  2952		int i;
  2953	
  2954		memset(q_op, 0, sizeof(*q_op));
  2955	
  2956		for (op_id = 0; op_id < subop->ninstrs; op_id++) {
> 2957			unsigned int offset, naddrs;
  2958			const u8 *addrs;
  2959	
  2960			instr = &subop->instrs[op_id];
  2961	
  2962			switch (instr->type) {
  2963			case NAND_OP_CMD_INSTR:
  2964				q_op->cmd_reg = qcom_op_cmd_mapping(nandc, instr->ctx.cmd.opcode, q_op);
  2965				q_op->rdy_delay_ns = instr->delay_ns;
  2966				break;
  2967	
  2968			case NAND_OP_ADDR_INSTR:
  2969				offset = nand_subop_get_addr_start_off(subop, op_id);
  2970				naddrs = nand_subop_get_num_addr_cyc(subop, op_id);
  2971				addrs = &instr->ctx.addr.addrs[offset];
  2972				for (i = 0; i < MAX_ADDRESS_CYCLE; i++) {
  2973					if (i < 4)
  2974						q_op->addr1_reg |= (u32)addrs[i] << i * 8;
  2975					else
  2976						q_op->addr2_reg |= addrs[i];
  2977				}
  2978				q_op->rdy_delay_ns = instr->delay_ns;
  2979				break;
  2980	
  2981			case NAND_OP_DATA_IN_INSTR:
  2982				q_op->data_instr = instr;
  2983				q_op->data_instr_idx = op_id;
  2984				q_op->rdy_delay_ns = instr->delay_ns;
  2985				fallthrough;
  2986			case NAND_OP_DATA_OUT_INSTR:
  2987				q_op->rdy_delay_ns = instr->delay_ns;
  2988				break;
  2989	
  2990			case NAND_OP_WAITRDY_INSTR:
  2991				q_op->rdy_timeout_ms = instr->ctx.waitrdy.timeout_ms;
  2992				q_op->rdy_delay_ns = instr->delay_ns;
  2993				break;
  2994			}
  2995		}
  2996	}
  2997	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2023-07-13 11:22 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202307131959.PdPSC86K-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=quic_mdalam@quicinc.com \
    --cc=quic_srichara@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.